[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131317729 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -134,6 +135,16 @@ private[hive]

[GitHub] spark issue #18842: [SPARK-21636] Several configurations which only are used...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18842 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131318739 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -157,12 +168,8 @@ private[hive]

[GitHub] spark issue #18839: [SPARK-21634][SQL] Change OneRowRelation from a case obj...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18839 **[Test build #80231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80231/testReport)** for PR 18839 at commit

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18779 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80232/ Test PASSed. ---

[GitHub] spark issue #18742: [Spark-21542][ML][Python]Python persistence helper funct...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18742 **[Test build #80234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80234/testReport)** for PR 18742 at commit

[GitHub] spark issue #18742: [Spark-21542][ML][Python]Python persistence helper funct...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80234/ Test PASSed. ---

[GitHub] spark issue #18742: [Spark-21542][ML][Python]Python persistence helper funct...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18742 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18779 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18843 **[Test build #80236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80236/testReport)** for PR 18843 at commit

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131320806 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -134,6 +135,16 @@ private[hive]

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131322107 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -50,6 +50,7 @@ private[hive]

[GitHub] spark issue #18842: [SPARK-21636] Several configurations which only are used...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18842 No, these may be set by callers. It's not clear it's not on purpose. I would close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18841 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18829 I also don't see value in exposing these machine-readable endpoints in a user interface? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18839: [SPARK-21634][SQL] Change OneRowRelation from a case obj...

2017-08-04 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18839 cc @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18783: [SPARK-21254] [WebUI] History UI performance fixes

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18783 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131328048 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by-ordinal.sql --- @@ -52,8 +52,18 @@ select count(a), a from (select 1 as a) tmp group by 2

[GitHub] spark issue #18413: [SPARK-21205][SQL] pmod(number, 0) should be null.

2017-08-04 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/18413 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18838: [SPARK-21632] There is no need to make attempts f...

2017-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18838#discussion_r131326239 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -294,9 +294,14 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131328405 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -557,4 +557,22 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131329214 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -134,6 +135,16 @@ private[hive]

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131329942 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -557,4 +557,22 @@ class DataFrameAggregateSuite extends

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18838 This changes the logic and I'm not clear why it's an improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #18800: [SPARK-21330][SQL] Bad partitioning does not allo...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be ...

2017-08-04 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/18841 [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null ## What changes were proposed in this pull request? This PR makes ACOS(2) and ASIN(2) to null, same MySQL. I have submit a

[GitHub] spark pull request #18783: [SPARK-21254] [WebUI] History UI performance fixe...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18668 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80239/ Test FAILed. ---

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18668 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18668 **[Test build #80239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80239/testReport)** for PR 18668 at commit

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131329917 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by-ordinal.sql --- @@ -52,8 +52,18 @@ select count(a), a from (select 1 as a) tmp group by 2

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-04 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131331807 --- Diff: python/pyspark/ml/util.py --- @@ -156,28 +218,23 @@ def write(self): @inherit_doc -class MLReader(object): +class

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-04 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131332345 --- Diff: python/pyspark/ml/util.py --- @@ -283,3 +341,198 @@ def numFeatures(self): Returns the number of features the model was trained on.

[GitHub] spark issue #18746: [SPARK-21633][ML][Python] UnaryTransformer in Python

2017-08-04 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18746 LGTM Merging with master Thanks @ajaysaini725 ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18789: SPARK-20433 Bump jackson from 2.6.5 to 2.6.7.1

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18789 Ping @ash211 or should I take this over? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18779 **[Test build #80232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80232/testReport)** for PR 18779 at commit

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/18843 @hvanhovell : let me know what you think about this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #18843: [SPARK-21595] Separate thresholds for buffering a...

2017-08-04 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/18843 [SPARK-21595] Separate thresholds for buffering and spilling in ExternalAppendOnlyUnsafeRowArray ## What changes were proposed in this pull request?

[GitHub] spark issue #18840: [SPARK-21565] Propagate metadata in attribute replacemen...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18840 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80233/ Test FAILed. ---

[GitHub] spark issue #18840: [SPARK-21565] Propagate metadata in attribute replacemen...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18840 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131320143 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -157,12 +168,8 @@ private[hive]

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131320120 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -157,12 +168,8 @@ private[hive]

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18779 **[Test build #80237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80237/testReport)** for PR 18779 at commit

[GitHub] spark issue #18710: [SPARK][Docs] Added note on meaning of position to subst...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18710 Ping @maclockard let's get this one finished --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18668 **[Test build #80241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80241/testReport)** for PR 18668 at commit

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131330713 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by-ordinal.sql --- @@ -52,8 +52,18 @@ select count(a), a from (select 1 as a) tmp group by 2

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131334204 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by-ordinal.sql --- @@ -52,8 +52,18 @@ select count(a), a from (select 1 as a) tmp group by 2

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18841 **[Test build #80235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80235/testReport)** for PR 18841 at commit

[GitHub] spark pull request #18842: [SPARK-21636] Several configurations which only a...

2017-08-04 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/spark/pull/18842 [SPARK-21636] Several configurations which only are used in unit tests should be removed [https://issues.apache.org/jira/browse/SPARK-21636](https://issues.apache.org/jira/browse/SPARK-21636)

[GitHub] spark issue #18839: [SPARK-21634][SQL] Change OneRowRelation from a case obj...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18839 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80231/ Test PASSed. ---

[GitHub] spark issue #18839: [SPARK-21634][SQL] Change OneRowRelation from a case obj...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18839 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18840: [SPARK-21565] Propagate metadata in attribute replacemen...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18840 **[Test build #80233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80233/testReport)** for PR 18840 at commit

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131320240 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -404,6 +404,13 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18668 Please open another JIRA for the issue of https://github.com/apache/spark/pull/18668#issuecomment-319002379. Also put the JIRA number in this PR. It can help us track the issues. Thanks! ---

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131321807 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -134,6 +135,16 @@ private[hive]

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131323098 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -404,6 +404,13 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties...

2017-08-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131322795 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -134,6 +135,16 @@ private[hive]

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131323389 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by-ordinal.sql --- @@ -52,8 +52,19 @@ select count(a), a from (select 1 as a) tmp group by 2

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18843 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18843 **[Test build #80236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80236/testReport)** for PR 18843 at commit

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18841 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80235/ Test FAILed. ---

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18841 **[Test build #80235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80235/testReport)** for PR 18841 at commit

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80236/ Test FAILed. ---

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18841 **[Test build #80238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80238/testReport)** for PR 18841 at commit

[GitHub] spark pull request #18838: [SPARK-21632] There is no need to make attempts f...

2017-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18838#discussion_r131326197 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -294,9 +294,14 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request #18838: [SPARK-21632] There is no need to make attempts f...

2017-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18838#discussion_r131328303 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -294,9 +294,14 @@ private[spark] object Utils extends Logging { }

[GitHub] spark issue #18413: [SPARK-21205][SQL] pmod(number, 0) should be null.

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18413 **[Test build #80240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80240/testReport)** for PR 18413 at commit

[GitHub] spark issue #18668: [SPARK-21451][SQL]get `spark.hadoop.*` properties from s...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18668 **[Test build #80239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80239/testReport)** for PR 18668 at commit

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-08-04 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18841 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18800: [SPARK-21330][SQL] Bad partitioning does not allow to re...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18800 Merged to master/2.2/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-04 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131331793 --- Diff: python/pyspark/ml/util.py --- @@ -61,32 +66,89 @@ def _randomUID(cls): @inherit_doc -class MLWriter(object): +class

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-04 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131332176 --- Diff: python/pyspark/ml/util.py --- @@ -283,3 +341,198 @@ def numFeatures(self): Returns the number of features the model was trained on.

[GitHub] spark pull request #18746: [SPARK-21633][ML][Python] UnaryTransformer in Pyt...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18837: [Spark-20812][Mesos] Add secrets support to the d...

2017-08-04 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/18837#discussion_r131354746 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -529,18 +560,54 @@

[GitHub] spark issue #18668: [SPARK-21637][SPARK-21451][SQL]get `spark.hadoop.*` prop...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18668 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18843 **[Test build #80247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80247/testReport)** for PR 18843 at commit

[GitHub] spark issue #18668: [SPARK-21637][SPARK-21451][SQL]get `spark.hadoop.*` prop...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18668 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80241/ Test FAILed. ---

[GitHub] spark issue #18622: [SPARK-21340] Bring pyspark BinaryClassificationMetrics ...

2017-08-04 Thread jakecharland
Github user jakecharland commented on the issue: https://github.com/apache/spark/pull/18622 +1 on getting this verified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #18810: [SPARK-21603][sql]The wholestage codegen will be ...

2017-08-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18810#discussion_r131359039 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -356,6 +356,16 @@ class CodegenContext {

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131361398 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -557,4 +557,22 @@ class DataFrameAggregateSuite extends

[GitHub] spark issue #18749: [SPARK-21485][FOLLOWUP][SQL][DOCS] Describes examples an...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18749 **[Test build #80248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80248/testReport)** for PR 18749 at commit

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18779 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80244/ Test FAILed. ---

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18779 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18779 **[Test build #80244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80244/testReport)** for PR 18779 at commit

[GitHub] spark issue #18413: [SPARK-21205][SQL] pmod(number, 0) should be null.

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18413 **[Test build #80240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80240/testReport)** for PR 18413 at commit

[GitHub] spark issue #18413: [SPARK-21205][SQL] pmod(number, 0) should be null.

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18413 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18413: [SPARK-21205][SQL] pmod(number, 0) should be null.

2017-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18413 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80240/ Test PASSed. ---

[GitHub] spark pull request #18413: [SPARK-21205][SQL] pmod(number, 0) should be null...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18413 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18668: [SPARK-21637][SPARK-21451][SQL]get `spark.hadoop.*` prop...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18668 **[Test build #80241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80241/testReport)** for PR 18668 at commit

[GitHub] spark issue #18843: [SPARK-21595] Separate thresholds for buffering and spil...

2017-08-04 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/18843 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18622: [SPARK-21340] Bring pyspark BinaryClassificationMetrics ...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18622 @jakecharland that's just an automated message asking if it's OK to test. I'll kick it off --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18622: [SPARK-21340] Bring pyspark BinaryClassificationMetrics ...

2017-08-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18622 **[Test build #3879 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3879/testReport)** for PR 18622 at commit

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131360533 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2023,4 +2023,11 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #18779: [SPARK-21580][SQL]Integers in aggregation express...

2017-08-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18779#discussion_r131360956 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2023,4 +2023,11 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18779 LGTM. cc @gatorsmile for final check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar...

2017-08-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18779 @10110346 Thanks for working this! Sorry I've confused you in previous comments. Current changes looks good to me. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18838 Let's close this PR, since the original behavior was by design. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #18648: [SPARK-21428] Turn IsolatedClientLoader off while using ...

2017-08-04 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/18648 ping @gatorsmile could you help to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18764: [SPARK-21306][ML] For branch 2.0, OneVsRest should suppo...

2017-08-04 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/18764 @yanboliang Thanks, yanbo. I am not familar with python 2.6, which is too outdated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18838 @srowen Yes,I change the logic because I think it's no mean to attempt to create a dir while there was a same name dir. --- If your project is set up for it, you can reply to this email

  1   2   3   4   >