[GitHub] [spark] cloud-fan commented on a change in pull request #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
cloud-fan commented on a change in pull request #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#discussion_r343609900 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551047714 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-550994518 **[Test build #113374 has

[GitHub] [spark] cloud-fan commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
cloud-fan commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551052606 LGTM, can you fix the conflicts?

[GitHub] [spark] SparkQA commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
SparkQA commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551057458 **[Test build #113376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113376/testReport)** for

[GitHub] [spark] SparkQA commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
SparkQA commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551057867 **[Test build #113377 has

[GitHub] [spark] AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551057685 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551057665 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551057665 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551000790 **[Test build #113376 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551057685 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551006871 **[Test build #113377 has

[GitHub] [spark] AmplabJenkins commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551063582 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551063568 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils

2019-11-07 Thread GitBox
SparkQA commented on issue #26423: [SPARK-29787][SQL] Move methods add/subtract/negate from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26423#issuecomment-551063166 **[Test build #113382 has

[GitHub] [spark] AmplabJenkins commented on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's URL: https://github.com/apache/spark/pull/24898#issuecomment-551068563 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's URL: https://github.com/apache/spark/pull/24898#issuecomment-551068573 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's URL: https://github.com/apache/spark/pull/24898#issuecomment-551068563 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's URL: https://github.com/apache/spark/pull/24898#issuecomment-551068573 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type

2019-11-07 Thread GitBox
SparkQA commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-551068287 **[Test build #113383 has

[GitHub] [spark] SparkQA commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
SparkQA commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551068294 **[Test build #113384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113384/testReport)**

[GitHub] [spark] jobitmathew opened a new pull request #26424: [SPARK-29788][DOC] Fix the typos in the SQL reference documents

2019-11-07 Thread GitBox
jobitmathew opened a new pull request #26424: [SPARK-29788][DOC] Fix the typos in the SQL reference documents URL: https://github.com/apache/spark/pull/26424 ### What changes were proposed in this pull request? Fixing the typos in SQL reference document. ### Why

[GitHub] [spark] AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551077301 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551077291 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551077283 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551077310 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551077291 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551077283 Merged build finished. Test PASSed. This is

[GitHub] [spark] cloud-fan commented on a change in pull request #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
cloud-fan commented on a change in pull request #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#discussion_r343656079 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ##

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r343659893 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r343659756 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r343659955 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r343660015 ## File path:

[GitHub] [spark] SparkQA commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
SparkQA commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551103426 **[Test build #113391 has

[GitHub] [spark] AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551104038 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551104055 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-07 Thread GitBox
SparkQA commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551132834 **[Test build #113392 has

[GitHub] [spark] SparkQA removed a comment on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551103426 **[Test build #113391 has

[GitHub] [spark] SparkQA commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
SparkQA commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551141451 **[Test build #113391 has

[GitHub] [spark] LucaCanali commented on issue #26332: [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+

2019-11-07 Thread GitBox
LucaCanali commented on issue #26332: [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+ URL: https://github.com/apache/spark/pull/26332#issuecomment-551141633 Most of the PRs for the metrics system targeting 3.0 so far have been about adding new metrics. It's good to

[GitHub] [spark] AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551141900 Merged build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551141912 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551146186 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] LantaoJin commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-07 Thread GitBox
LantaoJin commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551146116 Maybe but I didn’t check all failure handing of all types of event. What’s I can confirm is

[GitHub] [spark] AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551146157 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551076672 **[Test build #113386 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551146157 Merged build finished. Test FAILed. This is

[GitHub] [spark] SparkQA commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values

2019-11-07 Thread GitBox
SparkQA commented on issue #26347: [SPARK-29688][SQL] Support average for interval type values URL: https://github.com/apache/spark/pull/26347#issuecomment-551145858 **[Test build #113386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113386/testReport)**

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343722265 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343726691 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343725514 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343736772 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343722044 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-551161740 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-551161724 Merged build finished. Test PASSed.

[GitHub] [spark] vanzin commented on issue #26170: [SPARK-29397][core] Extend plugin interface to include the driver.

2019-11-07 Thread GitBox
vanzin commented on issue #26170: [SPARK-29397][core] Extend plugin interface to include the driver. URL: https://github.com/apache/spark/pull/26170#issuecomment-551166075 See #26390 This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #26390: [SPARK-29399][core] Remove old ExecutorPlugin interface.

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26390: [SPARK-29399][core] Remove old ExecutorPlugin interface. URL: https://github.com/apache/spark/pull/26390#issuecomment-551170690 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26390: [SPARK-29399][core] Remove old ExecutorPlugin interface.

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26390: [SPARK-29399][core] Remove old ExecutorPlugin interface. URL: https://github.com/apache/spark/pull/26390#issuecomment-551170680 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
SparkQA commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-551181096 **[Test build #113388 has

[GitHub] [spark] srowen commented on a change in pull request #26427: [SPARK-29795][CORE] Explicitly clear registered metrics on MetricSystem shutdown

2019-11-07 Thread GitBox
srowen commented on a change in pull request #26427: [SPARK-29795][CORE] Explicitly clear registered metrics on MetricSystem shutdown URL: https://github.com/apache/spark/pull/26427#discussion_r343777361 ## File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala

[GitHub] [spark] squito commented on a change in pull request #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

2019-11-07 Thread GitBox
squito commented on a change in pull request #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's URL: https://github.com/apache/spark/pull/24898#discussion_r343781041 ## File path: python/pyspark/tests/test_pin_thread.py ## @@ -0,0 +1,156 @@ +# +#

[GitHub] [spark] SparkQA commented on issue #26427: [SPARK-29795][CORE] Explicitly clear registered metrics on MetricSystem shutdown

2019-11-07 Thread GitBox
SparkQA commented on issue #26427: [SPARK-29795][CORE] Explicitly clear registered metrics on MetricSystem shutdown URL: https://github.com/apache/spark/pull/26427#issuecomment-551183886 **[Test build #113395 has

[GitHub] [spark] planga82 commented on a change in pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-07 Thread GitBox
planga82 commented on a change in pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176#discussion_r343785491 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #26419: [SPARK-29680][SQL][Followup] Replace qualifiedName with multipartIdentifier

2019-11-07 Thread GitBox
viirya commented on a change in pull request #26419: [SPARK-29680][SQL][Followup] Replace qualifiedName with multipartIdentifier URL: https://github.com/apache/spark/pull/26419#discussion_r343787101 ## File path:

[GitHub] [spark] dongjoon-hyun opened a new pull request #26428: [HOTFIX][TESTS] `HiveExternalCatalogVersionsSuite` should ignore preview release

2019-11-07 Thread GitBox
dongjoon-hyun opened a new pull request #26428: [HOTFIX][TESTS] `HiveExternalCatalogVersionsSuite` should ignore preview release URL: https://github.com/apache/spark/pull/26428 … ### What changes were proposed in this pull request? ### Why are the changes

[GitHub] [spark] dvogelbacher commented on issue #25602: [SPARK-28613][SQL] Add config option for limiting uncompressed result size in SQL

2019-11-07 Thread GitBox
dvogelbacher commented on issue #25602: [SPARK-28613][SQL] Add config option for limiting uncompressed result size in SQL URL: https://github.com/apache/spark/pull/25602#issuecomment-551204293 @HyukjinKwon @maropu would you prefer @mccheah 's suggestion to just use

[GitHub] [spark] LantaoJin removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-07 Thread GitBox
LantaoJin removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551147342 > Maybe but I didn’t check all failure handing of all types of event. What’s I can confirm

[GitHub] [spark] LantaoJin commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-07 Thread GitBox
LantaoJin commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551147342 > Maybe but I didn’t check all failure handing of all types of event. What’s I can confirm is

[GitHub] [spark] LantaoJin edited a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-07 Thread GitBox
LantaoJin edited a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551150480 In deed many handling of other events are synchronized. Heartbeat could be asynchronous

[GitHub] [spark] cloud-fan commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-07 Thread GitBox
cloud-fan commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-551155548 now both the driver endpoint and the new heartbeat endpoint track the list of block managers. What

[GitHub] [spark] cloud-fan commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-07 Thread GitBox
cloud-fan commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551156015 let's go option 1 then This is an automated message

[GitHub] [spark] SparkQA commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
SparkQA commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551160130 **[Test build #113384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113384/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551068294 **[Test build #113384 has

[GitHub] [spark] SparkQA removed a comment on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-551068287 **[Test build #113383 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551160883 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551160896 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-551161740 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-551161724 Merged build finished. Test PASSed. This

[GitHub] [spark] rdblue commented on a change in pull request #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
rdblue commented on a change in pull request #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#discussion_r343771374 ## File path:

[GitHub] [spark] rdblue commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
rdblue commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-551177714 @cloud-fan, I think this misunderstands the purpose of the API. That API is for end users, where

[GitHub] [spark] imback82 commented on a change in pull request #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
imback82 commented on a change in pull request #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#discussion_r343784310 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ##

[GitHub] [spark] SparkQA commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
SparkQA commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551192516 **[Test build #113390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113390/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551099794 **[Test build #113390 has

[GitHub] [spark] SparkQA commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven

2019-11-07 Thread GitBox
SparkQA commented on issue #26417: [SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven URL: https://github.com/apache/spark/pull/26417#issuecomment-551206589 **[Test build #113398 has

[GitHub] [spark] AmplabJenkins commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176#issuecomment-551216729 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176#issuecomment-551216714 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-07 Thread GitBox
SparkQA commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176#issuecomment-551216091 **[Test build #113400 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-551144979 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343739726 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-07 Thread GitBox
gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#discussion_r343739726 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-07 Thread GitBox
cloud-fan commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551148995 so it's mostly about years. 1) 1 year = 12 month = 360 days, or 2) 1 year = 362.25 days I think option 1 is

[GitHub] [spark] yaooqinn commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-07 Thread GitBox
yaooqinn commented on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551152792 Postgres use option 1 that a year is 360 days and a month is 30 day in interval binary comparison. As the test case I

[GitHub] [spark] SparkQA commented on issue #26390: [SPARK-29399][core] Remove old ExecutorPlugin interface.

2019-11-07 Thread GitBox
SparkQA commented on issue #26390: [SPARK-29399][core] Remove old ExecutorPlugin interface. URL: https://github.com/apache/spark/pull/26390#issuecomment-551169990 **[Test build #113393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113393/testReport)**

[GitHub] [spark] SparkQA commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched

2019-11-07 Thread GitBox
SparkQA commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-551170034 **[Test build #113394 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-551182168 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-551182156 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-551182168 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-551182156 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable

2019-11-07 Thread GitBox
SparkQA removed a comment on issue #26337: [SPARK-29679][SQL] Make interval type comparable and orderable URL: https://github.com/apache/spark/pull/26337#issuecomment-551132834 **[Test build #113392 has

[GitHub] [spark] AmplabJenkins commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils

2019-11-07 Thread GitBox
AmplabJenkins commented on issue #26411: [SPARK-29772][TESTS][SQL] Add withNamespace in SQLTestUtils URL: https://github.com/apache/spark/pull/26411#issuecomment-551193268 Test PASSed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   6   7   8   9   10   >