[GitHub] [spark] venkata91 commented on pull request #28287: [SPARK-31418][SCHEDULER] Request more executors in case of dynamic allocation is enabled and a task becomes unschedulable due to spark's bl

2020-06-23 Thread GitBox
venkata91 commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-647940759 @tgravescs After thinking about the problem and also after discussing with @mridulm, I have handled this problem now by just keeping track of unschedulable task sets in order

[GitHub] [spark] HyukjinKwon commented on pull request #28894: [SPARK-32052][SQL] Extract common code from date-time field expressions

2020-06-23 Thread GitBox
HyukjinKwon commented on pull request #28894: URL: https://github.com/apache/spark/pull/28894#issuecomment-647941360 late LGTM too This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647945906 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
SparkQA commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647945350 **[Test build #124395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124395/testReport)** for PR 27366 at commit

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647945315 **[Test build #124394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124394/testReport)** for PR 28901 at commit

[GitHub] [spark] cloud-fan commented on pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-23 Thread GitBox
cloud-fan commented on pull request #28780: URL: https://github.com/apache/spark/pull/28780#issuecomment-647945904 shall we set `sorter.totalSpillBytes`, then we can update the metrics correctly in `sort.spill`. This is an

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647945936 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan edited a comment on pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-23 Thread GitBox
cloud-fan edited a comment on pull request #28780: URL: https://github.com/apache/spark/pull/28780#issuecomment-647945904 shall we set `sorter.totalSpillBytes`? then we can update the metrics correctly in `sort.spill`. This

[GitHub] [spark] xianyinxin commented on a change in pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
xianyinxin commented on a change in pull request #28875: URL: https://github.com/apache/spark/pull/28875#discussion_r444002874 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -468,13 +458,25 @@ class AstBuilder(conf:

[GitHub] [spark] dongjoon-hyun commented on pull request #28897: [SPARK-32058][BUILD] Use Apache Hadoop 3.2.0 dependency by default

2020-06-23 Thread GitBox
dongjoon-hyun commented on pull request #28897: URL: https://github.com/apache/spark/pull/28897#issuecomment-647949881 BTW, if you want to have `Hadoop 2.7` variant in `Hadoop 3.2 (default)` environment, we had better revise the JIRA issue.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-647948835 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28897: [SPARK-32058][BUILD] Use Apache Hadoop 3.2.0 dependency by default

2020-06-23 Thread GitBox
dongjoon-hyun commented on pull request #28897: URL: https://github.com/apache/spark/pull/28897#issuecomment-647949279 @gatorsmile . Why that blocks this? Technically, this supersedes it, doesn't it? > We should avoid making this change until we can resolve

[GitHub] [spark] maropu commented on a change in pull request #28893: [SPARK-32049][SQL][TESTS] Upgrade Oracle JDBC Driver 8

2020-06-23 Thread GitBox
maropu commented on a change in pull request #28893: URL: https://github.com/apache/spark/pull/28893#discussion_r444013421 ## File path: pom.xml ## @@ -984,6 +984,12 @@ 8.2.2.jre8 test + +com.oracle.database.jdbc +ojdbc8 +

[GitHub] [spark] SparkQA commented on pull request #28884: [SPARK-20249][ML][PYSPARK] Add training summary for LinearSVCModel

2020-06-23 Thread GitBox
SparkQA commented on pull request #28884: URL: https://github.com/apache/spark/pull/28884#issuecomment-647927281 **[Test build #124386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124386/testReport)** for PR 28884 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28899: URL: https://github.com/apache/spark/pull/28899#discussion_r443980530 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala ## @@ -240,4 +240,20 @@ class SparkSessionBuilderSuite

[GitHub] [spark] AmplabJenkins commented on pull request #28884: [SPARK-20249][ML][PYSPARK] Add training summary for LinearSVCModel

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28884: URL: https://github.com/apache/spark/pull/28884#issuecomment-647927719 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647937012 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647937012 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-23 Thread GitBox
SparkQA removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647896228 **[Test build #124383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124383/testReport)** for PR 27246 at commit

[GitHub] [spark] SparkQA commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
SparkQA commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647937053 **[Test build #124392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124392/testReport)** for PR 28903 at commit

[GitHub] [spark] SparkQA commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-23 Thread GitBox
SparkQA commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647936567 **[Test build #124383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124383/testReport)** for PR 27246 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647940129 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647940129 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
SparkQA commented on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647939695 **[Test build #124393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124393/testReport)** for PR 28895 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r444000693 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -800,35 +770,20 @@ private[spark] class MapOutputTrackerWorker(conf:

[GitHub] [spark] SparkQA commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
SparkQA commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-647948382 **[Test build #124396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124396/testReport)** for PR 28875 at commit

[GitHub] [spark] LantaoJin commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
LantaoJin commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647950482 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] MaxGekk commented on a change in pull request #28886: [SPARK-32043][SQL] Replace Decimal by Int op in `make_interval` and `make_timestamp`

2020-06-23 Thread GitBox
MaxGekk commented on a change in pull request #28886: URL: https://github.com/apache/spark/pull/28886#discussion_r444003827 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ## @@ -751,7 +751,8 @@ object IntervalUtils {

[GitHub] [spark] HyukjinKwon commented on pull request #27331: [SPARK-29157][SQL][PYSPARK] Add DataFrameWriterV2 to Python API

2020-06-23 Thread GitBox
HyukjinKwon commented on pull request #27331: URL: https://github.com/apache/spark/pull/27331#issuecomment-647950548 Sorry, there's no policy to block but I don't also think practically it's a good idea to merge if it's expected to change. Once you have PySpark and SparkR APIs, you

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647955215 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is l

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-647953071 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647952180 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647952205 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gatorsmile commented on pull request #28897: [SPARK-32058][BUILD] Use Apache Hadoop 3.2.0 dependency by default

2020-06-23 Thread GitBox
gatorsmile commented on pull request #28897: URL: https://github.com/apache/spark/pull/28897#issuecomment-647955466 Will the PySpark users hit the migration issue if they upgrade from Spark 3.0 to 3.1 due to this PR? For example, some incompatibility issues introduced by Hadoop 3.x.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647955215 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647955238 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-23 Thread GitBox
maropu commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r444016135 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1885,11 +1885,16 @@ class Analyzer( } /**

[GitHub] [spark] beliefer commented on pull request #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-06-23 Thread GitBox
beliefer commented on pull request #26875: URL: https://github.com/apache/spark/pull/26875#issuecomment-647931974 test1 looks the same as test3. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
SparkQA commented on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647931949 **[Test build #124390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124390/testReport)** for PR 28899 at commit

[GitHub] [spark] viirya commented on a change in pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
viirya commented on a change in pull request #28900: URL: https://github.com/apache/spark/pull/28900#discussion_r443984508 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -1026,15 +1026,48 @@ class

[GitHub] [spark] cloud-fan closed pull request #28894: [SPARK-32052][SQL] Extract common code from date-time field expressions

2020-06-23 Thread GitBox
cloud-fan closed pull request #28894: URL: https://github.com/apache/spark/pull/28894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28884: [SPARK-20249][ML][PYSPARK] Add training summary for LinearSVCModel

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28884: URL: https://github.com/apache/spark/pull/28884#issuecomment-647927719 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28884: [SPARK-20249][ML][PYSPARK] Add training summary for LinearSVCModel

2020-06-23 Thread GitBox
SparkQA removed a comment on pull request #28884: URL: https://github.com/apache/spark/pull/28884#issuecomment-647905327 **[Test build #124386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124386/testReport)** for PR 28884 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647932324 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647937510 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-647937018 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] Ngone51 commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-23 Thread GitBox
Ngone51 commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-647943905 LGTM, also cc @jiangxb1987 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647951434 **[Test build #124397 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124397/testReport)** for PR 28901 at commit

[GitHub] [spark] SparkQA commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
SparkQA commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647957820 **[Test build #124399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124399/testReport)** for PR 28903 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647932324 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] huaxingao opened a new pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
huaxingao opened a new pull request #28903: URL: https://github.com/apache/spark/pull/28903 ### What changes were proposed in this pull request? Adding support to Association Rules in Spark ml.fpm. ### Why are the changes needed? Support is an indication of how frequently

[GitHub] [spark] cloud-fan commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r44333 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -737,35 +721,21 @@ private[spark] class MapOutputTrackerMaster( //

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647946391 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r444000320 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -737,35 +721,21 @@ private[spark] class MapOutputTrackerMaster( //

[GitHub] [spark] xianyinxin commented on a change in pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
xianyinxin commented on a change in pull request #28875: URL: https://github.com/apache/spark/pull/28875#discussion_r444000449 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -468,13 +458,25 @@ class AstBuilder(conf:

[GitHub] [spark] cloud-fan commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r444000561 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -737,35 +721,21 @@ private[spark] class MapOutputTrackerMaster( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r443999839 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -737,35 +721,21 @@ private[spark] class MapOutputTrackerMaster( //

[GitHub] [spark] gatorsmile edited a comment on pull request #28897: [SPARK-32058][BUILD] Use Apache Hadoop 3.2.0 dependency by default

2020-06-23 Thread GitBox
gatorsmile edited a comment on pull request #28897: URL: https://github.com/apache/spark/pull/28897#issuecomment-647946667 Yes. As you said, the default version is very important for PySpark users. I am afraid there are breaking changes in Hadoop 3.x releases. We should avoid

[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
SparkQA commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647954681 **[Test build #124398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124398/testReport)** for PR 27366 at commit

[GitHub] [spark] huaxingao commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
huaxingao commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647954701 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r443981984 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2589,6 +2589,8 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28900: URL: https://github.com/apache/spark/pull/28900#issuecomment-647935005 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28900: URL: https://github.com/apache/spark/pull/28900#issuecomment-647935005 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on a change in pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
MaxGekk commented on a change in pull request #27366: URL: https://github.com/apache/spark/pull/27366#discussion_r443994932 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmark.scala ## @@ -508,6 +548,7 @@ object JsonBenchmark

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647942226 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647942226 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
SparkQA commented on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647942120 **[Test build #124389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124389/testReport)** for PR 28899 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
SparkQA removed a comment on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647909279 **[Test build #124389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124389/testReport)** for PR 28899 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-647948835 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647952219 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
SparkQA removed a comment on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647939695 **[Test build #124393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124393/testReport)** for PR 28895 at commit

[GitHub] [spark] SparkQA commented on pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
SparkQA commented on pull request #28900: URL: https://github.com/apache/spark/pull/28900#issuecomment-647952064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647952177 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647952204 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647952061 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-647952098 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28903: [SPARK-19939] [ML] Add support for association rules in ML

2020-06-23 Thread GitBox
SparkQA commented on pull request #28903: URL: https://github.com/apache/spark/pull/28903#issuecomment-647952076 **[Test build #124392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124392/testReport)** for PR 28903 at commit

[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
SparkQA commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647952078 **[Test build #124395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124395/testReport)** for PR 27366 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28900: URL: https://github.com/apache/spark/pull/28900#issuecomment-647952284 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
SparkQA commented on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-647952066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins commented on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins commented on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647952197 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
HyukjinKwon commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647952395 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] gatorsmile commented on pull request #28897: [SPARK-32058][BUILD] Use Apache Hadoop 3.2.0 dependency by default

2020-06-23 Thread GitBox
gatorsmile commented on pull request #28897: URL: https://github.com/apache/spark/pull/28897#issuecomment-647952007 We should avoid forcing the current PySpark users to upgrade their Hadoop versions. If we change the default, will it impact them? If YES, I think we should not do it until

[GitHub] [spark] SparkQA commented on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
SparkQA commented on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647952073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-06-23 Thread GitBox
SparkQA commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-647952077 **[Test build #124388 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124388/testReport)** for PR 28848 at commit

[GitHub] [spark] SparkQA commented on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
SparkQA commented on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647952072 **[Test build #124393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124393/testReport)** for PR 28895 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
cloud-fan commented on a change in pull request #28895: URL: https://github.com/apache/spark/pull/28895#discussion_r444004873 ## File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala ## @@ -43,23 +44,15 @@ private[spark] trait ShuffleManager {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28900: URL: https://github.com/apache/spark/pull/28900#issuecomment-647952730 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is l

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-647953078 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647952602 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28875: [SPARK-32030][SQL] Support unlimited MATCHED and NOT MATCHED clauses in MERGE INTO

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28875: URL: https://github.com/apache/spark/pull/28875#issuecomment-647952604 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28895: URL: https://github.com/apache/spark/pull/28895#issuecomment-647952230 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28899: [SPARK-32062][SQL] Reset listenerRegistered in SparkSession

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28899: URL: https://github.com/apache/spark/pull/28899#issuecomment-647952999 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28900: [SPARK-32056][SQL] Coalesce partitions for repartition by expressions when AQE is enabled

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28900: URL: https://github.com/apache/spark/pull/28900#issuecomment-647952289 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-647945936 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan edited a comment on pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-23 Thread GitBox
cloud-fan edited a comment on pull request #28780: URL: https://github.com/apache/spark/pull/28780#issuecomment-647945904 shall we set `sorter.totalSpillBytes`? then we can update the metrics correctly in `sorter.spill`.

[GitHub] [spark] gatorsmile commented on pull request #28897: [SPARK-32058][BUILD] Use Apache Hadoop 3.2.0 dependency by default

2020-06-23 Thread GitBox
gatorsmile commented on pull request #28897: URL: https://github.com/apache/spark/pull/28897#issuecomment-647946667 Yes. As you said, the default version is very important for PySpark users. We should avoid making this change until we can resolve

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647946372 **[Test build #124394 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124394/testReport)** for PR 28901 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
SparkQA removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647945315 **[Test build #124394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124394/testReport)** for PR 28901 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-06-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-647946382 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

  1   2   3   4   5   6   7   8   9   >