[GitHub] spark pull request #20167: Allow providing Mesos principal & secret via file...

2018-01-05 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/20167 Allow providing Mesos principal & secret via files (SPARK-16501) ## What changes were proposed in this pull request? This commit modifies the Mesos submission client to allow the princ

[GitHub] spark issue #20167: Allow providing Mesos principal & secret via files (SPAR...

2018-01-08 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/20167 @felixcheung Well currently you are required to provide them in clear text either via `--conf` arguments or in your `spark-defaults.conf` which was unacceptable to our security conscious users. The

[GitHub] spark issue #20167: Allow providing Mesos principal & secret via files (SPAR...

2018-01-09 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/20167 CC @ArtRand @vanzin I would appreciate your reviews as and when you have time --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #20167: [SPARK-16501] [MESOS] Allow providing Mesos princ...

2018-01-15 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/20167#discussion_r161484346 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -80,10 +80,27 @@ trait

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-01-15 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/20167 @vanzin @ArtRand Thanks for the initial reviews, I have refactored the patch based on comments so should hopefully be in a better state now. I was able to also add some unit test coverage for this

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-01-19 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/20167 @vanzin Thanks for the detailed review. I have now added the ability to also specify the credentials directly via environment variables. I have added additional unit test coverage and a new section

[GitHub] spark pull request #20167: [SPARK-16501] [MESOS] Allow providing Mesos princ...

2018-01-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/20167#discussion_r164123285 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -71,40 +74,64 @@ trait

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-06 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/20167 I've fixed up the Scala style issues so think this is ready to merge --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark issue #20167: [SPARK-16501] [MESOS] Allow providing Mesos principal & ...

2018-02-09 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/20167 @vanzin Ok I should hopefully have all those addressed and the documentation clarified appropriately --- - To unsubscribe, e

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-08-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r207299324 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -107,7 +109,14

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-08-08 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r208531808 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -164,7 +164,15 @@ private[spark] class SparkSubmit extends Logging

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-08-08 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r208530663 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -212,6 +212,60 @@ private[spark] object Config

[GitHub] spark pull request #22215: [SPARK-25222][K8S][WIP] Improve container status ...

2018-08-24 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/22215 [SPARK-25222][K8S][WIP] Improve container status logging ## What changes were proposed in this pull request? Currently when running Spark on Kubernetes a logger is run by the client that

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2018-07-17 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/13599 @holdenk What we're doing in some of our products currently is that we require that users create their Python environments up front and that they be stored on a file system that is accessible t

[GitHub] spark pull request #21796: [SPARK-24833][K8S][WIP] Add host name aliases fea...

2018-07-17 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/21796 [SPARK-24833][K8S][WIP] Add host name aliases feature ## What changes were proposed in this pull request? This adds a new feature to the driver and executor builders for K8S that allows

[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature

2018-07-19 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/21796 @liyinan926 Ok, I will keep an eye on that issue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature

2018-07-23 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/21796 @felixcheung No problem, have already made a couple of comments on the design doc --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #21796: [SPARK-24833][K8S][WIP] Add host name aliases fea...

2018-07-23 Thread rvesse
Github user rvesse closed the pull request at: https://github.com/apache/spark/pull/21796 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-07-31 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r204403925 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -107,7 +109,14

[GitHub] spark pull request: [SPARK 5280] RDF Loader added + documentation

2015-07-14 Thread rvesse
Github user rvesse commented on the pull request: https://github.com/apache/spark/pull/4650#issuecomment-121210915 A Spark plugin seems like a much better approach, I've done some experimentation on a plugin for this which seems like a much cleaner and lightweight approach tho

[GitHub] spark pull request #22584: [SPARK-25262][DOC][FOLLOWUP] Fix missing markup t...

2018-10-01 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22584#discussion_r221538327 --- Diff: docs/running-on-kubernetes.md --- @@ -799,7 +799,7 @@ specific to Spark on Kubernetes. spark.kubernetes.local.dirs.tmpfs

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-01 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r221539921 --- Diff: docs/security.md --- @@ -729,6 +729,15 @@ so that non-local processes can authenticate. These delegation tokens in Kuberne shared by the

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22146 @mccheah I was taking that as a given --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-10-09 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r223620758 --- Diff: docs/running-on-kubernetes.md --- @@ -799,4 +815,168 @@ specific to Spark on Kubernetes. This sets the major Python version of the docker

[GitHub] spark issue #18519: [SPARK-16742] Mesos Kerberos Support

2017-08-31 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/18519 @ArtRand Any plans to add delegation token renewal under Mesos in the future? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #22215: [SPARK-25222][K8S] Improve container status logging

2018-08-28 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22215 @liyinan926 @nrchakradhar Addressed all your comments, thanks for the reviews. Is someone able to kick off the Jenkins testing on this PR

[GitHub] spark pull request #22256: [SPARK-25262][K8S][WIP] Better support configurab...

2018-08-28 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/22256 [SPARK-25262][K8S][WIP] Better support configurability of Spark scratch space when using Kubernetes ## What changes were proposed in this pull request? This change improves how Spark on

[GitHub] spark issue #22256: [SPARK-25262][K8S] Better support configurability of Spa...

2018-08-29 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22256 @skonto Here is the PR for the `SPARK_LOCAL_DIRS` behaviour customisation we were discussing in the context of SPARK-24434. I have minimised config to adding a single new setting for the

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-08-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22256#discussion_r213954156 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -37,41 +40,99 @@ private

[GitHub] spark issue #22256: [SPARK-25262][K8S] Better support configurability of Spa...

2018-08-30 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22256 @skonto I haven't done anything specific for the size limit ATM. From the K8S docs `tmpfs` backed `emptyDir` usage counts towards your containers memory limits so you can jus

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-08-31 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22256#discussion_r214277672 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -37,41 +40,99 @@ private

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-08-31 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22256#discussion_r214416634 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -37,41 +40,99 @@ private

[GitHub] spark pull request #22215: [SPARK-25222][K8S] Improve container status loggi...

2018-09-03 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22215#discussion_r214612510 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala --- @@ -60,4 +64,81 @@ private[spark] object

[GitHub] spark issue #22215: [SPARK-25222][K8S] Improve container status logging

2018-09-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22215 @mccheah Thanks for the review, have made the change you suggested to use N/A instead of empty string. I have left indentation as tabs for now, as I said in a previous comment this was just

[GitHub] spark pull request #22215: [SPARK-25222][K8S] Improve container status loggi...

2018-09-03 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22215#discussion_r214614277 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala --- @@ -151,13 +152,15

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-03 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/22323 [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be tmpfs backed on K8S ## What changes were proposed in this pull request? The default behaviour of Spark on K8S currently is to create

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-09-03 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22256#discussion_r214623272 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -37,41 +40,99 @@ private

[GitHub] spark issue #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spark on K8...

2018-09-03 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/21669 @ifilonenko I think the issue with the `UnixUsername` might possibly be avoided by exporting `HADOOP_USER_NAME` as an environment variable in the pod spec set to the same value as `SPARK_USER

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-05 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215187426 --- Diff: docs/running-on-kubernetes.md --- @@ -215,6 +215,19 @@ spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.clai

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-05 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215338145 --- Diff: docs/running-on-kubernetes.md --- @@ -215,6 +215,19 @@ spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.clai

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215625362 --- Diff: docs/running-on-kubernetes.md --- @@ -215,6 +215,19 @@ spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.clai

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215625299 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -45,6 +47,10 @@ private

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215625636 --- Diff: docs/running-on-kubernetes.md --- @@ -215,6 +215,19 @@ spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.clai

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215625448 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -225,6 +225,15 @@ private[spark] object Config

[GitHub] spark pull request #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be t...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22323#discussion_r215625508 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -22,6 +22,7 @@ import

[GitHub] spark issue #22323: [SPARK-25262][K8S] Allow SPARK_LOCAL_DIRS to be tmpfs ba...

2018-09-06 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22323 All comments so far addressed, can we kick off the PR builder on this now? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22215: [SPARK-25222][K8S] Improve container status logging

2018-09-06 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22215 Think this is pretty much ready to merge, can folks take another look when they get chance --- - To unsubscribe, e-mail: reviews

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215692843 --- Diff: docs/security.md --- @@ -722,6 +722,62 @@ with encryption, at least. The Kerberos login will be periodically renewed using the provided

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215695909 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -212,6 +212,60 @@ private[spark] object Config

[GitHub] spark issue #22256: [SPARK-25262][K8S] Better support configurability of Spa...

2018-09-07 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22256 Closed in favour of #22323 which has been merged --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-09-07 Thread rvesse
Github user rvesse closed the pull request at: https://github.com/apache/spark/pull/22256 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-10 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/21669 @vanzin I think in the current implementation of this PR the Kerberos login is happening inside the driver pod which is running inside the K8S cluster. The old design from the Spark on K8S

[GitHub] spark issue #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh script

2018-10-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22748 Suggested reviewers: @mccheah @liyinan926 @skonto --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh s...

2018-10-16 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/22748 [SPARK-25745][K8S] Improve docker-image-tool.sh script ## What changes were proposed in this pull request? Adds error checking and handling to `docker` invocations ensuring the script

[GitHub] spark pull request #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integr...

2018-10-16 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r225614226 --- Diff: bin/docker-image-tool.sh --- @@ -71,18 +71,29 @@ function build { --build-arg base_img=$(image_ref spark) ) - local

[GitHub] spark issue #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh script

2018-10-17 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22748 > There seems to be overlapping logic between this PR and #22681 Yes sorry, I was having issues with the script while working on something unrelated and hadn't realised your int

[GitHub] spark pull request #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh s...

2018-10-17 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22748#discussion_r225867566 --- Diff: bin/docker-image-tool.sh --- @@ -44,28 +44,41 @@ function image_ref { function build { local BUILD_ARGS local IMG_PATH

[GitHub] spark pull request #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh s...

2018-10-17 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22748#discussion_r225867655 --- Diff: bin/docker-image-tool.sh --- @@ -78,20 +91,38 @@ function build { docker build $NOCACHEARG "${BUILD_ARGS[@]}" \ -t $

[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...

2018-10-18 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22681#discussion_r226289881 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -18,6 +18,7 @@ FROM openjdk:8-alpine ARG

[GitHub] spark issue #22681: [SPARK-25682][k8s] Package example jars in same target f...

2018-10-18 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22681 I actually just got bit by this today while trying to run K8S integration tests with custom images. The integration tests assume the runnable distribution layout for `/opt/spark/examples` in the

[GitHub] spark issue #22748: [SPARK-25745][K8S] Improve docker-image-tool.sh script

2018-10-19 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22748 Rebased onto master, should be ready for merging --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22782: [HOTFIX] Fix PySpark pip packaging tests by non-a...

2018-10-22 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22782#discussion_r226983785 --- Diff: bin/docker-image-tool.sh --- @@ -79,7 +79,7 @@ function build { fi # Verify that Spark has actually been built/is a runnable

[GitHub] spark pull request #22782: [HOTFIX] Fix PySpark pip packaging tests by non-a...

2018-10-23 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22782#discussion_r227274978 --- Diff: bin/docker-image-tool.sh --- @@ -79,7 +79,7 @@ function build { fi # Verify that Spark has actually been built/is a runnable

[GitHub] spark pull request #22782: [HOTFIX] Fix PySpark pip packaging tests by non-a...

2018-10-23 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22782#discussion_r227373891 --- Diff: bin/docker-image-tool.sh --- @@ -79,7 +79,7 @@ function build { fi # Verify that Spark has actually been built/is a runnable

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-23 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/22805 [WIP][SPARK-25809][K8S][TEST] New K8S integration testing backends ## What changes were proposed in this pull request? Currently K8S integration tests are hardcoded to use a `minikube

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-23 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r227400699 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/docker/DockerForDesktopBackend.scala

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-23 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 @srowen Yes there are a lot of assumptions made by the integration tests that are not documented anywhere and I figured out by digging in the code and POMs. Broadly speaking right now to

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-23 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 @skonto Yep, I plan to do that tomorrow At least for my `minikube` instance I found 4g insufficient and a couple of tests would fail because their pods didn't get scheduled. 8g is pro

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-24 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r227833846 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/docker/DockerForDesktopBackend.scala

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-24 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r227835021 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/docker/DockerForDesktopBackend.scala

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-24 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 @ifilonenko I have done the generalisation today since it was fairly trivial and it actually resolves a number of concerns about the first pass implementation @skonto I have restored the

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-25 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 Ran successfully against one of our dev K8S clusters today: ![screen shot 2018-10-25 at 17 39 40](https://user-images.githubusercontent.com/2104864/47516269-fd2e1480-d87c-11e8-80f9

[GitHub] spark pull request #22820: [SPARK-25828][K8S] Bumping Kubernetes-Client vers...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22820#discussion_r228458281 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala --- @@ -157,7 +157,9 @@ private[spark] object

[GitHub] spark pull request #22820: [SPARK-25828][K8S] Bumping Kubernetes-Client vers...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22820#discussion_r228458947 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala --- @@ -157,7 +157,9 @@ private[spark] object

[GitHub] spark issue #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration testin...

2018-10-26 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 @liyinan926 I will rebase and squash appropriately once PR #22820 is merged --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228467766 --- Diff: resource-managers/kubernetes/integration-tests/README.md --- @@ -13,15 +13,45 @@ The simplest way to run the integration tests is to install and

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228467591 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/cloud/KubeConfigBackend.scala

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228467650 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/cloud/KubeConfigBackend.scala

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228467937 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228467705 --- Diff: resource-managers/kubernetes/integration-tests/README.md --- @@ -41,12 +71,127 @@ The Spark code to test is handed to the integration test system

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228469510 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/Utils.scala --- @@ -27,4 +27,36

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228470004 --- Diff: resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh --- @@ -71,19 +71,36 @@ if [[ $IMAGE_TAG == &quo

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-26 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r228470066 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/Utils.scala --- @@ -27,4 +27,36

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229395036 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229400780 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -42,6 +42,9 @@ private

[GitHub] spark issue #22805: [SPARK-25809][K8S][TEST] New K8S integration testing bac...

2018-10-30 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 Did a bunch more testing on our internal K8S clusters today after rebasing this onto master. I am now happy that this is ready for final review and merging so I have removed the `[WIP]` tag

[GitHub] spark pull request #22805: [SPARK-25809][K8S][TEST] New K8S integration test...

2018-10-31 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229630011 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -63,6 +66,8 @@ private

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-10-31 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/22904 [SPARK-25887][K8S] Configurable K8S context support ## What changes were proposed in this pull request? This enhancement allows for specifying the desired context to use for the initial

[GitHub] spark issue #22805: [SPARK-25809][K8S][TEST] New K8S integration testing bac...

2018-11-01 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 @mccheah I have updated the comment to reference the follow up issue and opened a PR for that as #22904. Can we go ahead and merge now

[GitHub] spark pull request #22904: [SPARK-25887][K8S] Configurable K8S context suppo...

2018-11-02 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22904#discussion_r230318413 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -23,6 +23,18 @@ import

[GitHub] spark issue #22904: [SPARK-25887][K8S] Configurable K8S context support

2018-11-06 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22904 @mccheah I have made the requested changes, can I get another review please? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #22911: [SPARK-25815][k8s] Support kerberos in client mod...

2018-11-06 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22911#discussion_r231195413 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala --- @@ -126,20 +134,53

[GitHub] spark issue #22959: [SPARK-25876][k8s] Simplify kubernetes configuration typ...

2018-11-07 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22959 First glance this looks like a lot of nice simplification, will take a proper look over this tomorrow --- - To unsubscribe, e

[GitHub] spark pull request #22959: [SPARK-25876][k8s] Simplify kubernetes configurat...

2018-11-08 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22959#discussion_r231838596 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala --- @@ -112,125 +72,139 @@ private[spark] case

[GitHub] spark pull request #23013: [SPARK-25023] More detailed security guidance for...

2018-11-12 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/23013 [SPARK-25023] More detailed security guidance for K8S ## What changes were proposed in this pull request? Highlights specific security issues to be aware of with Spark on K8S and

[GitHub] spark pull request #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spa...

2018-11-12 Thread rvesse
GitHub user rvesse opened a pull request: https://github.com/apache/spark/pull/23017 [WIP][SPARK-26015][K8S] Set a default UID for Spark on K8S Images ## What changes were proposed in this pull request? Adds USER directives to the Dockerfiles which is configurable via build

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-12 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/23017 For those with more knowledge of client mode here is the specific error seen in the integration tests: ``` Exception in thread "main" java.lang.IllegalArgumentException: basedi

[GitHub] spark issue #23013: [SPARK-25023] More detailed security guidance for K8S

2018-11-13 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/23013 @mccheah I have tried to keep it minimal and just point to the official K8S docs. Obviously there is a balance to be had between high level warnings and detailed advice. K8S is still a relatively

[GitHub] spark issue #23013: [SPARK-25023] More detailed security guidance for K8S

2018-11-13 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/23013 @tgravescs Re: Point 1 I have a separate PR #22904 which makes some improvements to the docs around that point --- - To

[GitHub] spark pull request #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spa...

2018-11-14 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/23017#discussion_r233385383 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh --- @@ -30,6 +30,10 @@ set -e # If there is no passwd entry for

  1   2   >