Peng-Lei commented on pull request #35204:
URL: https://github.com/apache/spark/pull/35204#issuecomment-1015060395
> @Peng-Lei We should update `AstBuilder.cleanTableProperties`, to make
`EXTERNAL` a truly reserved property. Let's open a new PR for it as it's a
breaking change.
The
Peng-Lei commented on pull request #35204:
URL: https://github.com/apache/spark/pull/35204#issuecomment-1014747343
> @Peng-Lei can you be more specific? What's the expectation of the tests
and how do we break it?
>
> I see that we exclude `COMMENT` there, as we do want to allow
Peng-Lei commented on pull request #35204:
URL: https://github.com/apache/spark/pull/35204#issuecomment-1014664463
> do you know why the test failed?
without ·filterNot(_ == PROP_EXTERNAL)·
--
This is an automated message from the Apache Git Service.
To respond to the message,
Peng-Lei commented on pull request #35204:
URL: https://github.com/apache/spark/pull/35204#issuecomment-1014424632
@cloud-fan Update the PR. As the testcase failed
Peng-Lei commented on pull request #35204:
URL: https://github.com/apache/spark/pull/35204#issuecomment-1012732429
@cloud-fan @imback82 Could you take a look? Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
