Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1478924572
@mridulm
yep，it`s me
Username: StoveM
Full name: Fencheng Mei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1478924279
>
yep，it`s me
Username:StoveM
Full name: Fencheng Mei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1478849048
> I could not cherry pick this into 3.4 and 3.3 - we should fix for those
branches as well IMO. Can you create a PR against those two branches as well
@Stove-hust ? Thanks
No
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1475695975
> Technically, 3 :-) The UT that I added will generate 2 tests - one for
push based shuffle and one without. And we have the initial test you added.
>
> You dont need to mark it
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1475528785
> @Stove-hust To clarify - I meant add this as well (after you had a chance
to look at it and clean it up if required - this was from my test setup). We
should keep the UT you had
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1474918516
> Instead of only testing specifically for the flag - which is subject to
change as the implementation evolves, we should also test for behavior here.
>
> This is the
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1474162354
> So this is an interesting coincidence, I literally encountered a
production job which seems to be hitting this exact same issue :-) I was in the
process of creating a test case, but
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1473303194
> So this is an interesting coincidence, I literally encountered a
production job which seems to be hitting this exact same issue :-) I was in the
process of creating a test case, but
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1469402096
> @Stove-hust Haven't had a chance to look at it yet. I'll take a look at it
this week.
tks
--
This is an automated message from the Apache Git Service.
To respond to the
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-146938
@otterc Hello, is there anything else I should add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1467340408
> @Stove-hust Thank you for reporting and the patch. Would you be able to
share driver logs?
Sure（Add some comments）
--- stage 10 faield
22/10/15 10:55:58 WARN
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1467339828
> @Stove-hust Thank you for reporting and the patch. Would you be able to
share driver logs?
**
--- stage 10 faield
22/10/15 10:55:58 WARN task-result-getter-1
Stove-hust commented on PR #40393:
URL: https://github.com/apache/spark/pull/40393#issuecomment-1467339346
> @Stove-hust Thank you for reporting and the patch. Would you be able to
share driver logs?
sure.
`# stage 10 faield
22/10/15 10:55:58 WARN task-result-getter-1
13 matches
Mail list logo
