[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1219760457 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -123,6 +127,77 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils {

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1219759816 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -123,6 +127,77 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils {

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1219758844 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala: ## @@ -165,19 +165,25 @@ case class QualifiedColType( *

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217474065 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala: ## @@ -145,7 +145,7 @@ class DetermineTableStats(session: SparkSession) extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217473411 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -46,21 +47,24 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils { }

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217473051 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala: ## @@ -506,7 +507,8 @@ object PreWriteCheck extends (LogicalPlan => Unit) {

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217472863 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala: ## @@ -425,7 +426,7 @@ object PreprocessTableInsertion extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217472430 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala: ## @@ -397,7 +397,8 @@ object PreprocessTableInsertion extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217472203 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala: ## @@ -397,7 +397,8 @@ object PreprocessTableInsertion extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217471748 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ## @@ -274,15 +274,16 @@ class FindDataSourceTable(sparkSession:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217471514 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ## @@ -274,15 +274,16 @@ class FindDataSourceTable(sparkSession:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217471285 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ## @@ -274,15 +274,16 @@ class FindDataSourceTable(sparkSession:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217470812 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ## @@ -151,8 +151,8 @@ object DataSourceAnalysis extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217470419 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ## @@ -151,8 +151,8 @@ object DataSourceAnalysis extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1217470181 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala: ## @@ -165,19 +165,25 @@ case class QualifiedColType( *

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1213790789 ## sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -318,7 +318,7 @@ query insertInto : INSERT OVERWRITE TABLE?

[GitHub] [spark] cloud-fan commented on a diff in pull request #40908: [SPARK-42750][SQL] Support Insert By Name statement

cloud-fan commented on code in PR #40908: URL: https://github.com/apache/spark/pull/40908#discussion_r1213789191 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -1289,6 +1291,12 @@ class Analyzer(override val catalogManager: