Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-187313458
Thanks everybody for the review and help! Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-187119717
@srowen thanks for merging it.
@ygcao thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-187098446
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-186546462
At long last I think ready to go. @mengxr any more comments? or @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-185685961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-185685958
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-185685501
**[Test build #51483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51483/consoleFull)**
for PR 10152 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-185669428
**[Test build #51483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51483/consoleFull)**
for PR 10152 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-185659555
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-185036851
Done! sorry for missing the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r53122840
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52975344
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,19 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-184528879
addressed the 'final' comment, and checked lint and test cases. shall we do
the merge then? Thanks!
---
If your project is set up for it, you can reply to this email
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52867732
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52867596
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52843218
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52835896
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52722338
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52722467
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52773573
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52773740
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52823895
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52576421
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -272,15 +285,14 @@ class Word2Vec extends Serializable with Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52575653
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -272,15 +285,14 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52574236
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -272,15 +285,14 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52574384
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -551,12 +551,17 @@ class Word2VecModel private[spark] (
}
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52573698
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52575825
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-183197942
addressed new comments. still kept the if statement as I explained by
sample codes.
reran test and lint test. Jenkins should still be happy :fireworks:
---
If your
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52708705
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52590418
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -76,6 +76,18 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52638919
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -76,6 +76,18 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-182591988
@srowen Thanks! I will make a quick pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-182595810
made one pass and only minor comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52530851
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -76,6 +76,18 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52530869
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52530874
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -551,12 +551,17 @@ class Word2VecModel private[spark] (
}
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52530860
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -272,15 +285,14 @@ class Word2Vec extends Serializable with Logging {
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-182317367
Agree, I'm ready to merge this. I'll CC @mengxr or @jkbradley in case they
want a final comment today
---
If your project is set up for it, you can reply to this email
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-182237525
It's getting to personal tastes now~~, still adopted suggestion though.
Personally, I would like always to let machine to do the formatting and length
limits(even adding
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-181271212
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52141782
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,26 +301,24 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52141876
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -551,12 +553,17 @@ class Word2VecModel private[spark] (
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52142152
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -551,12 +553,17 @@ class Word2VecModel private[spark] (
}
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-181253115
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-181257924
**[Test build #50915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50915/consoleFull)**
for PR 10152 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r52142120
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,26 +301,24 @@ class Word2Vec extends Serializable with Logging {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-181270729
**[Test build #50915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50915/consoleFull)**
for PR 10152 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-181271217
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-181240271
added braces to make lint happy. Jenkins should happy now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-180820174
**[Test build #50873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50873/consoleFull)**
for PR 10152 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-180820176
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-180817180
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-180820036
**[Test build #50873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50873/consoleFull)**
for PR 10152 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-180820177
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-179858977
@ygcao sorry for the delay. I'm trying to run a few `spark-perf` tests and
try larger scale if possible. Will revert ASAP.
---
If your project is set up for it, you
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-180188955
coolï¼Thanks. It will be helpful to see the large scale test result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r51391185
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-177855098
FYI: did a small scale perf-test and also checked logic correctness. please
check my comment for the review text for details of my experiment done.
---
If your project
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-177429666
Adopted all Sean's suggestions with minor editing to address missed edge
case and make compiler happy, I think these suggestions are good ones, thanks!.
please try to
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r51361374
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r51356725
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r51088952
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r51088866
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -556,6 +571,7 @@ class Word2VecModel private[spark] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r50961556
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-174446659
@ygcao this has not been merged. You can see the PR is open and there is no
message about merging into master.
---
If your project is set up for it, you can reply to
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r50671686
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -556,6 +571,7 @@ class Word2VecModel private[spark] (
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-174452391
As Sean says this hasn't been merged yet, I was waiting for the latest test
build to pass before making a final pass over this.
Ideally I'd like to just get
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r50676720
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -556,6 +571,7 @@ class Word2VecModel private[spark] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r50675972
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r50683565
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -289,17 +301,28 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r50684006
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -556,6 +571,7 @@ class Word2VecModel private[spark] (
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-174413771
Thanks for the merge! It looks successful, but it seems like the change is
still not appearing in the master.
What's the rest of the workflow for it to be appearing
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-173607998
**[Test build #2431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2431/consoleFull)**
for PR 10152 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-173621659
**[Test build #2431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2431/consoleFull)**
for PR 10152 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172787971
**[Test build #2407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2407/consoleFull)**
for PR 10152 at commit
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172777566
PySpark's test case fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172778827
**[Test build #2407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2407/consoleFull)**
for PR 10152 at commit
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-173094302
adjusted python doctest format. Did the heavy job of running pyspark test
locally. Now should be OK.
Finished test(python): pyspark.ml.feature (35s)
---
If your
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172468729
ouch, we finally decided to make backward incompatible changes for
synonyms~~. That caused test case failure.
I adjusted the expected value according our new logic:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172480884
**[Test build #2394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2394/consoleFull)**
for PR 10152 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172489168
**[Test build #2394 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2394/consoleFull)**
for PR 10152 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-170854032
@ygcao sorry for the delay, I was on vacation and not checking email
regularly. I'm pretty much happy with this, but I'd like to just get one of
@srowen @jkbradley
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-170927597
@ygcao the changes have impacted the tests - could you take a look at the
failure? I think we may need to update the test suite.
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-170885940
**[Test build #2372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2372/consoleFull)**
for PR 10152 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-170878810
**[Test build #2372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2372/consoleFull)**
for PR 10152 at commit
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-168907161
@MLnick Happy new year. I think I've addressed all you comments last year,
could you help to do the merge this year? If anyone still have other concerns,
please let me
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r48229609
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -77,6 +77,18 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r48324725
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -77,6 +77,18 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r48324747
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -77,6 +77,18 @@ class Word2Vec extends Serializable with Logging {
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-166544099
modified comment accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-166215753
Pinging @jkbradley @mengxr @MechCoder again for a final review - could you
give this a look and confirm you're in agreement with my comments above.
Also
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r48119953
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -77,6 +77,20 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-166215472
@ygcao just one final comment on the `setMaxSentenceLength` setter comment
to address, thanks!
---
If your project is set up for it, you can reply to this email and
Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-165959134
Thanks @MLnick! Added the @Since annotation in the code accordingly and
updated issue to make type as bug and consistent with what we finalized for
changing.
---
If
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r47875988
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -281,17 +295,28 @@ class Word2Vec extends Serializable with Logging {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r47876214
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -77,6 +77,20 @@ class Word2Vec extends Serializable with Logging {
98 matches
Mail list logo
