Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220602808
Merged to master/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220260517
@srowen
Modified as you expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220205291
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220205292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220205168
**[Test build #58827 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58827/consoleFull)**
for PR 13172 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220190063
**[Test build #58827 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58827/consoleFull)**
for PR 13172 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13172#discussion_r63744491
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,16 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ #here add this loop to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220072583
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220072220
**[Test build #58780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58780/consoleFull)**
for PR 13172 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220072586
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/12978
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r63708450
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,15 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ for i in {1..10}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13172#issuecomment-220037041
**[Test build #58780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58780/consoleFull)**
for PR 13172 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r63701914
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,15 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ for i in {1..10}
+
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r63700865
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,15 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ for i in {1..10}
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-220021986
OK maybe, though here you show it took 0.5s.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-220021066
In order to check this potential problem more carefully, We can add the
following test code like this:
`
echo "$newpid" > "$pid"
**for i in
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r63696847
--- Diff: sbin/spark-daemon.sh ---
@@ -162,6 +162,15 @@ run_command() {
esac
echo "$newpid" > "$pid"
+
+ for i in {1..10}
+
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-220016724
@srowen According to your suggestion, I add a loop to check whether it pass
STAGE-1 and launch java daemon. And I recover the check statement `! $(ps -p
"$newpid"
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-219290733
I think the way forward is to make a different change, if you're still
pretty sure this is an issue: try this a small number of times in a loop until
it succeeds or the
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-218097327
@srowen Er...I am also a little strange while stage 1 may took a long time
but it really happen several times... If there is time I will do a more
detailed test.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-218090853
At that point the Java process is already running though. I want to make
sure we are solving the problem you think.
---
If your project is set up for it, you can
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-218089784
@srowen At my virtual machine, After OS started and start spark daemon, the
stage 1 describe above will took a long time,often exceeding 2s, I think the
java
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-218071565
Hm, how would stage 1 take any significant time though? I'm missing what
could take that much time.
The problem with this change is that it fails to check whether
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-218040874
@srowen
because spark-daemon.sh using exec command to start the java daemon process.
when run script, the spark-daemon.sh process will exists for a little
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12978#discussion_r62428386
--- Diff: sbin/spark-daemon.sh ---
@@ -164,7 +164,7 @@ run_command() {
echo "$newpid" > "$pid"
sleep 2
# Check if the process has died;
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12978#issuecomment-217647731
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/12978
[SPARK-15203][Deploy]The spark daemon shell script error, daemon process
start successfully but script output fail message.
This bug is because, sbin/spark-daemon.sh script use
29 matches
Mail list logo
