Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r77177492
--- Diff: .gitignore ---
@@ -28,6 +28,7 @@ build/*.jar
build/apache-maven*
build/scala*
build/zinc*
+build/venv
--- End diff --
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76968414
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76967915
--- Diff: python/.editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agre
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76967736
--- Diff: dev/py-validate.sh ---
@@ -0,0 +1,110 @@
+#!/usr/bin/env bash
--- End diff --
My point of view:
- don't enforce it right away,
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76967333
--- Diff: dev/isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76961681
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. S
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76961521
--- Diff: python/.editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreem
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76961377
--- Diff: dev/py-validate.sh ---
@@ -0,0 +1,110 @@
+#!/usr/bin/env bash
--- End diff --
@davies what do you think about including this vs just
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76961264
--- Diff: dev/isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. S
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76582188
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76580634
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. S
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76577358
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76577137
--- Diff: dev/isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76574930
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. S
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76574875
--- Diff: dev/isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. S
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76574749
--- Diff: dev/isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. S
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76400303
--- Diff: python/pyspark/heapq3.py ---
@@ -408,10 +408,12 @@
__all__ = ['heappush', 'heappop', 'heapify', 'heapreplace', 'merge',
'nlarg
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76394998
--- Diff: .editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
Meaning, do
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76394439
--- Diff: .editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
yes of co
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76393422
--- Diff: python/pyspark/cloudpickle.py ---
@@ -280,7 +279,7 @@ def extract_code_globals(co):
# see if nested function have any global refs
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76393105
--- Diff: .editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
Would this
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76392662
--- Diff: .isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. Se
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76391648
--- Diff: .editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
Should be
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76391001
--- Diff: python/run-tests.py ---
@@ -37,9 +37,9 @@
sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)),
"../dev/"))
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76388621
--- Diff: .editorconfig ---
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
Same, would
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76388567
--- Diff: .isort.cfg ---
@@ -1,9 +1,9 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76388360
--- Diff: python/pyspark/cloudpickle.py ---
@@ -280,7 +279,7 @@ def extract_code_globals(co):
# see if nested function have any global refs
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r76388158
--- Diff: python/run-tests.py ---
@@ -37,9 +37,9 @@
sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)),
"../dev/"))
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75642520
--- Diff: python/pyspark/cloudpickle.py ---
@@ -280,7 +279,7 @@ def extract_code_globals(co):
# see if nested function have any global refs
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75561821
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -25,7 +25,8 @@ class HasMaxIter(Params):
Mixin for param maxIter: max number of iterations (>= 0)
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75561735
--- Diff: dev/py-validate.sh ---
@@ -0,0 +1,110 @@
+#!/usr/bin/env bash
--- End diff --
it is the script that format all python code automat
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75553470
--- Diff: dev/py-validate.sh ---
@@ -0,0 +1,110 @@
+#!/usr/bin/env bash
--- End diff --
Where is this file used?
---
If your project is set
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75553298
--- Diff: python/pyspark/cloudpickle.py ---
@@ -42,17 +42,17 @@
"""
--- End diff --
This file is copied, please ignore it
---
If your proje
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75553255
--- Diff: python/pyspark/heapq3.py ---
@@ -408,10 +408,12 @@
__all__ = ['heappush', 'heappop', 'heapify', 'heapreplace', 'merge',
'nlarges
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75553180
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -25,7 +25,8 @@ class HasMaxIter(Params):
Mixin for param maxIter: max number of iterations (>= 0).
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r74615638
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -25,7 +25,8 @@ class HasMaxIter(Params):
Mixin for param maxIter: max number of iterations (>= 0)
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r74615609
--- Diff: python/pyspark/cloudpickle.py ---
@@ -42,17 +42,17 @@
"""
--- End diff --
isort/pep8 executed on this file to make jenkins happy
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r74590863
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r74590160
--- Diff: python/pyspark/cloudpickle.py ---
@@ -194,7 +194,7 @@ def save_function(self, obj, name=None):
# we'll pickle the actual function obje
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r74362668
--- Diff: python/pyspark/cloudpickle.py ---
@@ -194,7 +194,7 @@ def save_function(self, obj, name=None):
# we'll pickle the actual function objec
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r74362636
--- Diff: python/pep8rc ---
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
42 matches
Mail list logo
