Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16089
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90575547
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -245,24 +230,12 @@ private[csv] class CsvOutputWriter
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90566162
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -147,6 +147,17 @@ public void writeTo(ByteBuffer buffer) {
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90521381
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -245,24 +230,12 @@ private[csv] class CsvOutp
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90509459
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -194,4 +194,8 @@ private[sql] class JacksonGener
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90503024
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Ap
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90502669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -194,4 +194,8 @@ private[sql] class JacksonGene
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90502343
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -147,6 +147,17 @@ public void writeTo(ByteBuffer buffer) {
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90501927
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -194,4 +194,8 @@ private[sql] class JacksonGener
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90499765
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -147,6 +147,17 @@ public void writeTo(ByteBuffer buffer) {
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90497882
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -194,4 +194,8 @@ private[sql] class JacksonGene
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90488454
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -132,39 +128,17 @@ class TextOutputWriter
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90468858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -132,39 +128,17 @@ class TextOutputWriter
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90468563
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Ap
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90409731
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -245,24 +230,12 @@ private[csv] class CsvOutputWriter
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90409064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Sof
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90409094
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Sof
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90408942
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Sof
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90385252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Ap
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90380594
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -132,39 +128,17 @@ class TextOutputWriter
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90380316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -132,39 +128,17 @@ class TextOutputWriter(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16089#discussion_r90380266
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -194,4 +194,8 @@ private[sql] class JacksonGenera
GitHub user NathanHowell opened a pull request:
https://github.com/apache/spark/pull/16089
[SPARK-18658][SQL] Write text records directly to a FileOutputStream
## What changes were proposed in this pull request?
This replaces uses of `TextOutputFormat` with an `OutputStream`
23 matches
Mail list logo