[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150692098 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150687775 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150682875 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150665699 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150664593 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150660671 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150659762 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150568042 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150528361 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150528207 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150443594 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-11-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r150426911 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -468,14 +460,16 @@ object PartitioningUtils

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r14268 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -1067,4 +1098,24 @@

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r141999696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -149,7 +149,7 @@ object TypeCoercion {

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r141999620 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -249,6 +249,11 @@

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r141947058 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -249,6 +249,11 @@ class

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r141948681 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -1067,4 +1098,24 @@ class

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19389#discussion_r141949009 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -149,7 +149,7 @@ object TypeCoercion { })

[GitHub] spark pull request #19389: [SPARK-22165][SQL] Resolve type conflicts between...

2017-09-28 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/19389 [SPARK-22165][SQL] Resolve type conflicts between decimals, dates and timestamps in partition column ## What changes were proposed in this pull request? This PR proposes to re-use