Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19390
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151862273
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -228,24 +254,15 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151821865
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -228,24 +254,15 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151679164
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151674490
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151674372
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -228,24 +254,15 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151673131
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151673115
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -349,13 +349,22
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151672855
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +444,10 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151672564
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,17 +176,39 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151521406
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151520818
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,17 +176,39 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151521750
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151521101
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -228,24 +254,15 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151520336
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -349,13 +349,22
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151521265
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +444,10 @@ trait
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151521542
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +468,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r149367812
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +465,20 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r148786663
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147463877
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +441,10 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147461660
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147429031
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147370701
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147370285
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +441,10 @@ trait
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147261741
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147087721
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,17 +176,36 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147087477
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +465,20 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147087405
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -349,13 +349,22
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147069130
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +441,10 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147067951
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -349,13 +349,22
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147067641
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +465,20 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147066762
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,17 +176,36 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145645133
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145643615
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -446,6 +456,9 @@
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145530482
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -446,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145397272
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145298003
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145237956
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145010250
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -469,6 +474,12 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145009696
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144835209
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -469,6 +474,12 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144835101
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,14 +175,22 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144835048
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -28,6 +28,8 @@ import
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144834956
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682189
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -28,6 +28,8 @@ import
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682211
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,14 +175,22 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682163
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682379
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -469,6 +474,12 @@ trait
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/19390
[SPARK-18935][MESOS] Fix dynamic reservations
## What changes were proposed in this pull request?
- Solves the issue described in the ticket by preserving reservation and
allocation info.
49 matches
Mail list logo
