[GitHub] spark pull request #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20991


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint ...

[ueshin]

Github user ueshin commented on a diff in the pull request:

https://github.com/apache/spark/pull/20991#discussion_r179669069
  
--- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java 
---
@@ -54,7 +54,7 @@ public static int roundNumberOfBytesToNearestWord(int 
numBytes) {
* @return true if the arrays are equal, false otherwise
*/
   public static boolean arrayEqualsBlock(
-  MemoryBlock leftBase, long leftOffset, MemoryBlock rightBase, long 
rightOffset, final long length) {
+  MemoryBlock leftBase, long leftOffset, MemoryBlock rightBase, long 
rightOffset, long length) {
--- End diff --

Maybe we can remove `final` from L67 as well?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20991: [SPARK-10399][SPARK-23879][HotFix] Fix Java lint ...

[kiszk]

GitHub user kiszk opened a pull request:

https://github.com/apache/spark/pull/20991

[SPARK-10399][SPARK-23879][HotFix] Fix Java lint errors

## What changes were proposed in this pull request?

This PR fixes the following errors in [Java 
lint](https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-lint/7717/console)
 after #19222 has been merged.

```
[ERROR] 
src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java:[57] (sizes) 
LineLength: Line is longer than 100 characters (found 106).
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java:[26,8] 
(imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OffHeapMemoryBlock.java:[23,10] 
(modifier) ModifierOrder: 'public' modifier out of order with the JLS 
suggestions.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[64,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[69,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[74,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[79,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[84,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[89,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[94,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[99,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[104,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[109,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[114,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[119,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[124,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java:[129,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[60,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[65,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[70,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[75,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[80,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[85,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[90,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[95,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[100,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[105,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[110,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[115,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR] 
src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java:[120,10] 
(modifier) RedundantModifier: Redundant 'final' modifier.
[ERROR]