Re: [ros-dev] Merging our x86 HALs

2017-12-14 Thread Colin Finck
Thanks for the numerous replies! Let's stop at this point and not talk this topic to death ;) Even if we don't know yet how many HALs are to be kept, we agree on reducing the number of HALs from the current 6. There is also no point in a final decision on this until we have code to back it. I

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread James Tabor
Two HALs for both old and new hardware is good. I've tried XP on new hardware and it did not boot up at all. ReactOS same or better. On Tue, Dec 12, 2017 at 10:51 AM, Alex Ionescu wrote: > I would move to the Win8+ HAL Model -- a single HAL for APIC, ACPI with > runtime

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread Hermès BÉLUSCA-MAÏTO
jet : Re: [ros-dev] Merging our x86 HALs > > Hi, > > I think that at least merging most of the versions shouldn't be a big problem. > We could go Win8's way. Is there a rough estimation, how much is the > distribution of common code, code for new HW only and code für old HW only? >

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread Michael Fritscher
Hi, I think that at least merging most of the versions shouldn't be a big problem. We could go Win8's way. Is there a rough estimation, how much is the distribution of common code, code for new HW only and code für old HW only? To be honest, I don't think that much space will be wasted in the

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread Riccardo Paolo Bestetti
for the time you took to read this. BR, Riccardo P. Bestetti From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Javier Agustìn Fernàndez Arroyo Sent: mercoledì 13 dicembre 2017 12:49 To: ReactOS Development List <ros-dev@reactos.org> Subject: Re: [ros-dev] Merging our x8

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread Magnus Johnsson
nstalling ReactOS instead of Windows [2000|XP|2003] on it). Of course I >>> leave the (very) technical discussion about how to implement HALs to you. >>> >>> >>> >>> BR. >>> >>> *Riccardo P. Bestetti* >>> >>> >>> >

Re: [ros-dev] Merging our x86 HALs

2017-12-13 Thread Javier Agustìn Fernàndez Arroyo
Quintana (gigaherz) > *Sent:* martedì 12 dicembre 2017 22:45 > > *To:* ReactOS Development List <ros-dev@reactos.org> > *Subject:* Re: [ros-dev] Merging our x86 HALs > > > > I think yes, on the fact that duplicate code is already causing bugs. Now > wether we want

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Riccardo Paolo Bestetti
2017 22:45 To: ReactOS Development List <ros-dev@reactos.org> Subject: Re: [ros-dev] Merging our x86 HALs I think yes, on the fact that duplicate code is already causing bugs. Now wether we want to unify everything into one megaHAL, or compile multiple HALs fom the same codebase, or merge in

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread David Quintana (gigaherz)
f Of *Javier > Agustìn Fernàndez Arroyo > *Sent:* martedì 12 dicembre 2017 18:13 > *To:* ReactOS Development List <ros-dev@reactos.org> > *Subject:* Re: [ros-dev] Merging our x86 HALs > > > > Win8 does not support old hardware as ReactOS do! > > > > El 12 dic.

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Hermès BÉLUSCA-MAÏTO
Objet : Re: [ros-dev] Merging our x86 HALs My bi-annual IT guy peak: Is there a real need to? I think not. B.R. Riccardo P. Bestetti From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Javier Agustìn Fernàndez Arroyo Sent: martedì 12 dicembre 2017 18:13 To: ReactOS

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Riccardo Paolo Bestetti
: [ros-dev] Merging our x86 HALs Win8 does not support old hardware as ReactOS do! El 12 dic. 2017 17:52, "Alex Ionescu" <ion...@videotron.ca<mailto:ion...@videotron.ca>> escribió: I would move to the Win8+ HAL Model -- a single HAL for APIC, ACPI with runtime support

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Javier Agustìn Fernàndez Arroyo
i know you probably can't answer, but where is the ninja group? xD On Tue, Dec 12, 2017 at 7:06 PM, Thomas Faber wrote: > Now the only problem is that neither our APIC nor MP HAL actually > work... > > > > On 2017-12-12 18:31, David Quintana (gigaherz) wrote: > >>

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Thomas Faber
Now the only problem is that neither our APIC nor MP HAL actually work... On 2017-12-12 18:31, David Quintana (gigaherz) wrote: I have to agree that reducing it to 2 HALs (one ACPI with multiprocessor and such, that maybe is also used for single-cpu systems with ACPI), and a legacy one for

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread David Quintana (gigaherz)
I have to agree that reducing it to 2 HALs (one ACPI with multiprocessor and such, that maybe is also used for single-cpu systems with ACPI), and a legacy one for systems unable to handle ACPI+MP, sounds like a great idea. On 12 December 2017 at 18:13, Javier Agustìn Fernàndez Arroyo <

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Javier Agustìn Fernàndez Arroyo
Win8 does not support old hardware as ReactOS do! El 12 dic. 2017 17:52, "Alex Ionescu" escribió: > I would move to the Win8+ HAL Model -- a single HAL for APIC, ACPI with > runtime support for UEFI (if present) and MP (if present). > > If people still want to run on a PIC

Re: [ros-dev] Merging our x86 HALs

2017-12-12 Thread Alex Ionescu
I would move to the Win8+ HAL Model -- a single HAL for APIC, ACPI with runtime support for UEFI (if present) and MP (if present). If people still want to run on a PIC VM (why???) or old computer, then we can also maintain the HAL PIC x86 for UP. Hence there would only be 2 HALs. Best regards,

Re: [ros-dev] Merging our x86 HALs

2017-12-11 Thread Colin Finck
Am 11.12.2017 um 01:18 schrieb Hermès BÉLUSCA-MAÏTO:> If you basically put all the HALs into one, then you obtain bloated stuff (which remains in memory for the whole life of the OS). Example: standard HAL is 1MB vs. ACPI HAL which is few kBHave you actually checked what makes up this difference?

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Hermès BÉLUSCA-MAÏTO
os-dev-boun...@reactos.org] De la part de Hermès > BÉLUSCA-MAÏTO > Envoyé : lundi 11 décembre 2017 02:03 > À : 'ReactOS Development List' > Objet : Re: [ros-dev] Merging our x86 HALs > > Also, there is (at least parts of) HKLM\HARDWARE tree that is built at > installation t

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Hermès BÉLUSCA-MAÏTO
-MAÏTO > Envoyé : lundi 11 décembre 2017 01:18 > À : 'ReactOS Development List' > Objet : Re: [ros-dev] Merging our x86 HALs > > I personally think it's a bit "against" the philosophy of HALs, namely having > a > lightweight hardware abstraction layer code for different plat

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Hermès BÉLUSCA-MAÏTO
ery clear and maintainable. H. > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Colin Finck > Envoyé : dimanche 10 décembre 2017 19:55 > À : ros-dev@reactos.org > Objet : Re: [ros-dev] Merging our x86 HALs > > Am 10.12.2017 um 19:38 s

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Colin Finck
Am 10.12.2017 um 19:38 schrieb David Quintana (gigaherz): > Colin: Are we talking merge and decide which method to use at runtime Exactly! We don't even need boot flags: Just like the setup currently detects an ACPI-compliant computer, the HAL could do this at boot-up. It's also not too hard to

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread David Quintana (gigaherz)
Colin: Are we talking merge and decide which method to use at runtime (boot flags or something), or compile-time merging of the source code but generating multiple final hals based on each possible configuration? I'm assuming the former. elhoir: Given the fact that some of the HAL

Re: [ros-dev] Merging our x86 HALs

2017-12-10 Thread Javier Agustìn Fernàndez Arroyo
But this breaks modularity, isnt It? And HAL might become huge El 10/12/2017 19:11, "Colin Finck" escribió: > Hi all, > > I have been looking into our HALs recently on the promise that it is a > huge mess that needs fixing. Well, as a start I could imagine merging > our 6