Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-10 Thread lgtm-com[bot]
This pull request **introduces 1 alert** when merging ce5514692e86b1f556e96494882189405f8a5581 into 16d9074e1a3020f8844ed4a213fb92e844d8f9ad - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-c82bc2501b0f2dd9d33aa330ec1e1449275633a3) **new alerts:** * 1 for

Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-10 Thread KOLANICH
@KOLANICH pushed 1 commit. ce5514692e86b1f556e96494882189405f8a5581 Improved python support: enums are now enums with all additional goodies. Can usually be available using CamelCased prefix, class members have the prefix stripped. -- You are receiving this because you are subscribed to

[Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-10 Thread KOLANICH
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1311 -- Commit Summary -- * Added a high-level wrapper. -- File Changes -- A python/rpm/highLevel.py (38) -- Patch Links --

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-10 Thread Igor Raits
@ignatenkobrain commented on this pull request. >AS_IF([test "$enable_zstd" = "yes"], [ if test "$have_zstd" = "no"; then AC_MSG_ERROR([--enable-zstd specified, but not available]) fi ]) + PKG_CHECK_MODULES([ZSTD], [libzstd], [have_zstd=yes], [have_zstd=no]) I think it

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-10 Thread Michael Schroeder
I guess it can't deal with the ECDSA and EdDSA signatures. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Size check is too strict (#1232)

2020-07-10 Thread Florian Festi
Double checking the code the unchanged files should not be counted when `%_minimize_writes` is enabled. So it obviously isn't in this test case. The question here is why the installation with `--ignoresize` passes without an error. I wonder if there is some trickery going on on the FS level to

Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-10 Thread Pavel Raiskup
> My guess is you want that rpmbuild man page is more clear Yes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread KOLANICH
Thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1310#issuecomment-656726988___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread Florian Festi
The ticket system is not a help forum. Please ask questions like this on #rpm.org @freenode or on the mailing lists. See http://rpm.org/community.html for details. To the question at hand: There is an rpm.archive class. An instances can be obtained from an rpm.files object with the .archive()

Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread Florian Festi
Closed #1310. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1310#event-3534208073___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Question: multi-threaded zstd compression (#1300)

2020-07-10 Thread Florian Festi
As there now is a pull request (#1303) I am closing this ticket here. No need to distribute the discussion to multiple places. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Question: multi-threaded zstd compression (#1300)

2020-07-10 Thread Florian Festi
Closed #1300. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1300#event-3534156801___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-10 Thread KOLANICH
Supporting signatures (being able to read and process them) and non breaking in their presence, by just ignoring them, are very different things. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-10 Thread Florian Festi
Sorry, I am not quite understanding what you are suggesting here. My guess is you want that rpmbuild man page is more clear? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread KOLANICH
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1310___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-07-10 Thread Florian Festi
Looking at the code I understand why this may go wrong but I have not yet found why it worked before and what changed. `rpm --specfile` is translated to `rpmspec -q`with popt aliases. By default rpmspec queries all generated sub packages. So I am kinda confused by you only get one line. Can

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-10 Thread Florian Festi
Yes, this is a known - or not so well known - limitation. As the signature check is basically done by hand it lack a lot of feature one would expect of GPG proper. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-10 Thread marxin
> This change looks good and straight forward. Thanks! > > I am missing some information on what version of zstd supports the new API - > and if necessary a check in configure.ac. Updated `configure.ac` (one needs at least release `1.3.8`). -- You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Treat /usr/share/gnome/help as docs (#1295)

2020-07-10 Thread Florian Festi
Merged #1295 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1295#event-3534052702___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Treat /usr/share/gnome/help as docs (#1295)

2020-07-10 Thread Florian Festi
Let's hope that rpmlint is right... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1295#issuecomment-656695500___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
I don't see any need for further discussion here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-656689650___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
Merged #1272 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#event-3534004891___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Doxygen comments (#1302)

2020-07-10 Thread Florian Festi
Thanks for the fix! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1302#issuecomment-656686843___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Doxygen comments (#1302)

2020-07-10 Thread Florian Festi
Merged #1302 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1302#event-3533981732___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Florian Festi
Looks straight forward to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1308#issuecomment-656685900___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Florian Festi
Merged #1308 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1308#event-3533973211___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-10 Thread Florian Festi
This change looks good and straight forward. I am missing some information on what version of zstd supports the new API - and if necessary a check in configure.ac. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-10 Thread lgtm-com[bot]
This pull request **introduces 1 alert** when merging 41310c6ffda99386b1e7f8354ebb542ffc310317 into ae163b56468e5e83cbba192dab02ebdb9cf3df5d - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-ada2169273c889f9f6fe1cafe2bcc19672203382) **new alerts:** * 1 for

[Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-10 Thread KOLANICH
Can usually be available using CamelCased prefix, class members have the prefix stripped. ```python import rpm print(rpm.RPMBuild.CHECK | rpm.RPMBuild.CLEAN) # RPMBuild.CLEAN|CHECK: 24 print(rpm.RPMBuild(24)) # RPMBuild.CLEAN|CHECK: 24 ``` You can view, comment on, or merge this pull request

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread torsava
Looks good to me! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1308#issuecomment-656673366___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Miro Hrončok
See https://bugzilla.redhat.com/show_bug.cgi?id=1853597#c11 pkg_resources from setuptools 42+ no longer only use platform.python_version(), but also platform.python_version_tuple() -- this was updated in packaging 19.1+. This fix makes it work again with both new and old setuptools, hopefully

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-10 Thread marxin
@marxin pushed 1 commit. 1d965759205bf5f072724c397004ba1a433f7c7f Support threading for zstd compression. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] zstd compression: port to the new API. (#1303)

2020-07-10 Thread marxin
@marxin pushed 1 commit. fff307dd41294192560a33cca09e3675a0af925a Support threading for zstd compression. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add %postbuild section / Allow dynamic sub packages (#1239)

2020-07-10 Thread nim-nim
My understanding of the feature is that it will eventually require some mecanism to reconciliate the subpackage metadata (that the feature directly targets in the new section) and srpm metadata. Because without such a mechanism, you’ll be asking packagers to be extra careful to never put

Re: [Rpm-maint] [rpm-software-management/rpm] Add %postbuild section / Allow dynamic sub packages (#1239)

2020-07-10 Thread Pavel Raiskup
Is this contribution ever meant to modify the built source RPM content? I.e. can `%postbuild` be (mis-)used so that `rpmbuild -ba` and `rpmbuild -br` both generate a different variant of source RPM? -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] zstd compression: port to the new API. (#1303)

2020-07-10 Thread marxin
So the answer is that it's stable and reproducible. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: