in the linux-rtc git at the moment, so it makes sense
> to fix it there.
>
> arch/x86/kernel/nmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
You rece
mp;& (mday <= 31)) is false for mday == 32.
>
> When verifying the day of month the binary and the BCD mode
> have to be considered.
>
> v2:
> consider ds1685_rtc_read_alarm
> consider rtc->bcd_mode as indicated by Alexandre Belloni
>
> Signed-off-by:
g | 12
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-max6916.c| 167
> ++
> 3 files changed, 180 insertions(+)
>
I've applied it but you probably edited the diff by hand so I had to
edit it a bit more to get it to apply correctly. Also,
ssible until the expired alarm is cleared.
>
I'm not completely sure to understand what is happening but could you
check whether that one is solved by
2b2f5ff00f63847d95adad6289bd8b05f5983dd5 in my tree (rtc-next).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineer
p
> + */
> + if (wday != tm.tm_wday) {
> + wday = i2c_smbus_read_byte_data(client, MCP794XX_REG_WEEKDAY);
> + wday = wday & ~MCP794XX_REG_WEEKDAY_WDAY_MASK;
> + wday = wday | (tm.tm_wday + 1);
> + i2c_smbus_write_byte_data(client, MCP794XX_REG_WEEKDAY
On 17/06/2016 at 12:22:07 +0200, Neil Armstrong wrote :
> In order to support RTC on Qualcomm MDM9615 SoC, add support for
> the pm8018 rtc in rtc-pm8xxx driver.
>
> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.bell.
t; > not have vendor prefixes. Will fix in v2.
>
> Okay, then they are fine if you are using existing properties. Perhaps
> these should all be in a common binding doc though.
>
I'll try to collect the existing common properties and write that doc
this week.
--
Alexandre Belloni, Free E
rq = true;
> - }
>
> i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
> ds1307->regs[0]);
> --
> 2.5.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
htt
quot;
> + "Re-enabling it\n");
> }
>
> /* clock halted? turn it on, so clock can tick. */
> @@ -1507,7 +1525,7 @@ static int ds1307_chip_sanity_check(const struct ds1307
> *ds1307)
> i2c_smbus_write_byte_data(cl
tector.
> + Should be set if no backup battery is used.
I guess we need to make that one generic. I would use
voltage-detection-disable.
Andrey, can you use that one instead of
dallas,disable-oscillator-stop-flag ?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineer
; config RTC_DRV_CMOS
> tristate "PC-style 'CMOS'"
> - depends on X86 || ARM || M32R || PPC || MIPS || SPARC64
> + depends on X86 || ARM || M32R || PPC || MIPS || SPARC64 || MN10300
> default y if X86
> help
> Say "yes" here to get direct supp
Add missing files to the RTC entry of MAINTAINERS
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 72c28f4520d5..e86cf021113c 100644
--- a/MAINTAINERS
+++ b/MAINT
rtc-v3020.h belongs to include/linux/platform_data/
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
Cc: Daniel Mack <dan...@zonque.org>
Cc: Haojian Zhuang <haojian.zhu...@gmail.com>
Cc: Robert Jarzmik <robert.jarz...@free.fr>
Cc: linux-arm-ke
Akinobu Mita (2):
rtc: ds1302: fix error check in set_time
rtc: ds1302: fix write value for day of week register
Alexandre Belloni (1):
rtc: remove useless DRV_VERSION
Anurag Kumar Vulisha (3):
rtc: zynqmp
BCD_MASK);
>
> /* Check the month date for validity. */
> - if (!(mday >= 1) && (mday <= 31))
> + if ((mday < 1) || (mday > 31))
> return -EDOM;
>
> /*
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and An
> ---
> drivers/rtc/rtc-at91sam9.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Pl
2bin(regs.minutes & BQ32K_SECONDS_MASK);
> + tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK);
> tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK);
> tm->tm_mday = bcd2bin(regs.date);
> tm->tm_wday = bcd2bin(regs.day) - 1;
> --
> 2.7.4
reg &= ~BQ32K_OF;
> - error = bq32k_write(dev, , BQ32K_MINUTES, 1);
> - }
> if (error)
> return error;
> + if (reg & BQ32K_OF)
> + dev_warn(dev, "Oscillator Failure. Check RTC battery.\n");
>
> if
+robh
On 14/07/2016 at 22:10:48 +0200, Arnaud Ebalard wrote :
> Alexandre Belloni <alexandre.bell...@free-electrons.com> writes:
>
> > The ISL12057 has a documentation file, remove it from trivial-devices.txt
> >
> > Signed-off-by: Alexandre Belloni <ale
C_DRV_DS1307 and RTC_DRV_DS1307_CENTURY in Kconfig?
>
Well, I tried multiple things but making RTC_DRV_ISL12057 hidden makes it
unable to select both RTC_DRV_DS1307 and RTC_DRV_DS1307_CENTURY. I'll
try to find a solution but I pretty much prefer not having
RTC_DRV_ISL12057 selectable anymore
--
Al
es (if the workaround fails). This
> change also makes the I²C transfer return value checks consistent.
>
Well, my initial idea was that the workaround is actually needed only
for operations that are not restartable from userspace.
Did you it that bug? On which RTC?
--
Alexandre Belloni, Free El
wing what conditions are leading to
endless interrupts.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux
gt; has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk>
> ---
> drivers/rtc/rtc-abx80x.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
Applied, thanks.
--
Alexandre Be
solution is to write a proper driver bitbanging
microwire (maybe in the SPI subsystem) that everybody could use,
including old architectures.
Else, I may as well revert to the previous driver.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
Y
akh...@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com>
> Tested-by: Pankaj Dubey <pankaj.du...@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c |2 --
> 1 file changed, 2 dele
f Kozlowski <k.kozlow...@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com>
> Tested-by: Pankaj Dubey <pankaj.du...@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c |2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Free
read_alarm set .tm_sec to 0 to signal minute
> accuracy
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.
is DeBruin <cdeb5...@gmail.com>
> ---
> drivers/rtc/rtc-pcf85063.c | 48
> +-
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
Applied after fixing some whitespace issues, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Lin
d, 380 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt
> create mode 100644 drivers/rtc/rtc-meson.c
>
> --
> 2.8.1
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You re
On 12/07/2016 at 18:27:12 +0100, Ben Dooks wrote :
> On 12/07/16 18:22, Alexandre Belloni wrote:
> > Hi,
> >
> > Very few comments below
> >
> > On 05/07/2016 at 20:48:41 +0100, Ben Dooks wrote :
> >> +/* registers accessed from cpu bus */
> &
The year range is not validated properly
As the driver has been mainlined in 2014, it is not an issue to stop
handling dates between 1970 and 2000 with the benefit of handling dates up
to 2100.
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/rtc-pc
n
spi-gpio.
My understanding is that while microwire seems compatible with SPI mode
0, it actually isn't and this should be treated as a different mode.
If we want to do something generic, I think we should have a
microwire-gpio driver. Maybe in the SPI subsystem?
How do yo currently select microwire mode for
Forgot to add Mark in Cc:
On 27/06/2016 at 14:44:32 +0200, Alexandre Belloni wrote :
> On 27/06/2016 at 14:50:49 +0300, Sergei Ianovich wrote :
> > On Mon, 2016-06-27 at 20:19 +0900, Akinobu Mita wrote:
> > > The rtc-ds1302 driver now implemented using SPI 3wire mode.
>
On 05/01/2016 at 08:08:50 -0800, Mark Salyzyn wrote :
> On 01/04/2016 04:00 PM, Alexandre Belloni wrote:
> > I'd say that the proper course of action is to refuse to set dates
> > before 2000 and after 2100. See
> > http://patchwork.ozlabs.org/patch/541037/
> Got it.
>
++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at
ita <akinobu.m...@gmail.com>
> > Cc: Sergey Yanovich <ynv...@gmail.com>
> > Cc: Alessandro Zummo <a.zu...@towertech.it>
> > Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> > ---
> > .../devicetree/bindings/rtc/maxim-ds1302.txt | 1
tc-rv8803.c | 3 ---
> drivers/rtc/rtc-rx8010.c | 8 +---
> drivers/rtc/rtc-rx8025.c | 5 -
> drivers/rtc/rtc-s3c.c | 12
> drivers/rtc/rtc-tegra.c | 6 --
> 16 files changed, 5 insertions(+), 98 deletions(-)
>
All applied, thanks.
--
Alexa
/rtc-s35390a.c | 157
> +++---
> 2 files changed, 120 insertions(+), 41 deletions(-)
>
All applied, thanks!
I added a quick commit message in 4/5.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electron
ock output support is added in the next patch.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> ---
> Changes since v4:
>
> - None.
>
> Changes since v3:
>
> - Moved month/year
er.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> ---
> Changes since v4: none
>
> Changes since v3:
>
> - Renamed clk32k prefixes to clkout, except for the internal 32k clk
> - Cha
ck);
>372
>373platform_set_drvdata(pdev, chip);
>374 chip->dev = >dev;
>
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all
COMPILE_TEST was wrongly placed, move it to the "depends on" line. Also,
select COMMON_CLK has the driver now needs it to be properly compiled.
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/Kconfig | 5 +++--
1 file changed, 3 insertions
+++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http:/
able the build as a module
> rtc: sun6i: Add some locking
> rtc: sun6i: Switch to the external oscillator
> rtc: sun6i: Expose the 32kHz oscillator
> rtc: sun6i: Switch to devm_rtc_device_register
> ARM: sun8i: a23/a33: Enable the real LOSC and use it
> ARM: sun8i: a
)
RTC fixes for 4.10:
- Allow jz4740 to build as a module again by using kernel_halt()
Alexandre Belloni (1):
rtc: jz4740: make the driver buildable as a module again
drivers/rtc
> + chip->gpio[DS1682_DQ].gpio);
> +
> + platform_set_drvdata(pdev, chip);
> +
> + chip->rtc = devm_rtc_device_register(>dev, "ds1682",
> + _rtc_ops, THIS_MODULE);
> + if (IS_ERR(chip->rtc)) {
>
> - if (IS_ERR(chip->base))
> - return PTR_ERR(chip->base);
> -
> chip->irq = platform_get_irq(pdev, 0);
> if (chip->irq < 0) {
> dev_err(>dev, "No IRQ resource\n");
> @@ -404,6 +524,8 @@ static int sun6i_rtc_probe(struct platform
insertions(+), 33 deletions(-)
>
> base-commit: 99cef370ac9939df2aeb16c96d07e842b2fa8201
> --
> git-series 0.8.11
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux&q
more diff linies :-S
> What do you think ?
Then, what about:
regmap_bulk_read(pcf2127->regmap, PCF2127_REG_SC, (buf + PCF2127_REG_SC),
sizeof(buf) - PCF2127_REG_SC);
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
Yo
_region->kref);
>
> - dev->devt = dev_t;
> dev->class = dax_class;
> dev->parent = parent;
> dev->groups = dax_attribute_groups;
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-elect
gt; > + dev_err(dev, "Could not request update irq: %d\n", err);
> > > + return err;
> > > + }
> > > + disable_irq(rtc->update_irq);
> > > +
> > > + err = device_init_wakeup(dev, 1);
> >
> > If you use device
outer <alex+ker...@digriz.org.uk>
>
Ok, then I've applied the whole series. I'll send that to Linus by the
end of the week.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "r
t; + THIS_MODULE);
> + if (IS_ERR(ds3232->rtc))
> + return PTR_ERR(ds3232->rtc);
> +
> return 0;
> }
>
> --
> 1.8.3.1
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You rece
following:
>
> devmem2 0xf428401c w 0
> devmem2 0xf4284018 w 0x2000
The question being what does that do and whether it could be done in the
driver instead.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this messa
On 24/02/2017 at 10:32:40 +0800, Phil Reid wrote:
> On 24/02/2017 09:46, Alexandre Belloni wrote:
> > On 22/02/2017 at 09:33:14 +0800, Phil Reid wrote:
> > > On 22/02/2017 04:33, Alexandre Belloni wrote:
> > > > On 17/02/2017 at 09:44:58 +0800, Phil Reid wrote:
>
On 22/02/2017 at 09:33:14 +0800, Phil Reid wrote:
> On 22/02/2017 04:33, Alexandre Belloni wrote:
> > On 17/02/2017 at 09:44:58 +0800, Phil Reid wrote:
> > > The wakealarm attribute is currently not exposed in the sysfs interface
> > > as the device has not been
s:
- is this the only rtc with a driver on your system ?
- is it selected as the RTC_SYSTOHC_DEVICE or RTC_HCTOSYS_DEVICE. I've
checked the code and I don't think this is the issue but it is worth
testing.
Thanks,
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.
nges since v1:
> - fixed indentation
> - use of more defines
>
> drivers/rtc/rtc-pcf2127.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.
80-rtc.txt | 8 ++-
> drivers/rtc/rtc-armada38x.c| 65
> ++
> 2 files changed, 70 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
insertions(+), 53 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux
On 21/02/2017 at 17:04:07 +, Hartley Sweeten wrote:
> On Tuesday, February 21, 2017 9:37 AM, Alexandre Belloni wrote:
> > On 15/02/2017 at 09:35:23 -0700, H Hartley Sweeten wrote:
> >> The RTC is an optional feature at purchase time on some Technologic
> >
Sweeten <hswee...@visionengravers.com>
> Cc: Alessandro Zummo <a.zu...@towertech.it>
> Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> Cc: Alexander Clouter <a...@digriz.org.uk>
> ---
> drivers/rtc/rtc-m48t86.c | 36 +++
> + "rtc_1hz", rtc);
I don't think this IRQ is actually useful. It doesn't really harm but
the tests should pass without it.
> + if (err) {
> + dev_err(dev, "Could not request update irq: %d\n", err);
> + return err;
> +
S is actually incrementing after being instantiated, if it looks weird
> >> then
> >> to unbind its-self.
>
> Or the probe could do that check and return -ENODEV if it fails.
>
If it is always incrementing, even when it has never been set (first
boot or battery is dea
IS_ERR().
>
> Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator")
> Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
> ---
> drivers/rtc/rtc-sun6i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free E
rom this driver, along with
> platform_data/rtc-m48t86.h.
>
> H Hartley Sweeten (3):
> rtc: m48t86: shorten register name defines
> rtc: m48t86: allow driver to manage it's resources
> rtc: m48t86: add NVRAM support
>
> drivers/rtc/rtc-m48t86.c | 247
> +++++
7);
This is weirdly indented/wrapped. Also, you can probably make buf a
char[7] and continue using sizeof() or even better, ARRAY_SIZE()
> if (ret) {
> dev_err(dev, "%s: read error\n", __func__);
> return ret;
--
Al
nvalid date/time\n");
> +
nitpick: I'm not sure this is useful. You'll probably know soon enough
that it is invalid as I'm pretty sure something will read the date at
boot time.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You re
(ec);
>
> + /* check whether this EC instance has RTC host command support */
> + if (cros_ec_check_features(ec, EC_FEATURE_RTC))
> + cros_ec_rtc_register(ec);
> +
> return 0;
>
> dev_reg_failed:
> --
> 2.9.3
>
--
Alexandre Belloni,
;base + SUN6I_ALARM_CONFIG);
>
> + /* switch to the external, more precise, oscillator */
> + writel(SUN6I_LOSC_CTRL_KEY | SUN6I_LOSC_CTRL_EXT_OSC,
> +chip->base + SUN6I_LOSC_CTRL);
> +
> chip->rtc = rtc_device_register("rtc-sun6i", >
On 16/01/2017 at 17:13:49 +0100, Maxime Ripard wrote :
> On Mon, Jan 16, 2017 at 04:39:59PM +0100, Alexandre Belloni wrote:
> > On 16/01/2017 at 16:21:48 +0100, Maxime Ripard wrote :
> > > The RTC is clocked from either an internal, imprecise, oscillator or an
> > > ext
return -EFAULT;
> +
> + case RTC_VL_CLR:
> + /* update flag and clear register */
> + err = s35390a_reset(s35390a, );
> + if ((err == 1) || (err == 0))
Whatever the error, once the first s35390a_get_reg(), the POC and BLD
flags are lost.
gt; s35390a->client[0] = client;
> i2c_set_clientdata(client, s35390a);
> + s35390a->isinvalid = 0;
>
> /* This chip uses multiple addresses, use dummy devices for them */
> for (i = 1; i < 8; ++i) {
> --
> 1.8.3.1
>
--
Alexandre Belloni, Free
...@st.com>
> ---
> drivers/rtc/rtc-stm32.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscr
On 17/01/2017 at 09:24:17 +0100, Fabien Lahoudere wrote :
> On Mon, 2017-01-16 at 18:50 +0100, Alexandre Belloni wrote:
> > Hi,
> >
> > On 12/01/2017 at 11:43:37 +0100, Fabien Lahoudere wrote :
> > > If RTC time have been altered by low voltage, we notify users
ts |
>
> For me it looks like the debug prints may delay the poweroff driver
> long enough, that some other driver (rtc?) writes the 0x0b bits.
>
Is snvs_rtc_alarm_irq_enable() waiting long enough? I'd say yes but you
never know... You can also use the kernel tracin infrastructure to trace
: calibration support
Akinobu Mita (1):
bindings: rtc: correct wrong reference in required properties
Alexandre Belloni (1):
rtc: sun6i: extend test coverage
Amelie Delaunay (4):
dt-bindings: document the STM32 RTC
Gunthorpe <log...@deltatee.com>
Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> ---
> drivers/rtc/class.c | 14 ++
> drivers/rtc/rtc-dev.c | 17 -
> 2 files changed, 10 insertions(+), 21 deletions(-)
>
> diff --git
kobject parent without using device_add.
>
> [1] https://lkml.org/lkml/2017/2/13/700
> [2] https://lkml.org/lkml/2017/2/10/370
>
> Signed-off-by: Logan Gunthorpe <log...@deltatee.com>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
Reviewed-by: Alexandre Belloni &l
orm_set_drvdata(pdev, priv);
> + spin_lock_init(>lock);
>
> irq_alarm = platform_get_irq(pdev, 0);
> if (irq_alarm < 0) {
> --
> 2.7.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You recei
m_expired) {
Is there any issue dropping is_wkalrm_expired and calling
cmos_is_wkalrm_expired() here? That would avoid calling
cmos_is_wkalrm_expired on each wakeup.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message
; -
> 3 files changed, 181 insertions(+), 8 deletions(-)
>
I'm fine with this patch and I'll apply it as soon as you fix the
comments from Rob.
Thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You
; +{
> + ktime_t ret;
> +
> + memset(, 0, sizeof(ktime_t));
> + return ret;
> +}
> +
> +static inline struct rtc_time rtc_ktime_to_tm(ktime_t kt)
> +{
> + struct rtc_time ret;
> +
> + memset(, 0, sizeof(struct rtc_time));
> + return ret;
> +}
> +#e
The rtc-asm9260 driver uses a discrete spinlock (wrongly uninitialized).
Use the rtc mutex to lock mmio accesses instead.
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/rtc-asm9260.c | 16 ++--
1 file changed, 2 insertions(+), 14 del
The rtc-asm9260 driver compiles correctly on other architectures, add
COMPILE_TEST to improve code coverage.
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/Kco
The rtc-asm9260 driver uses a discrete spinlock (wrongly uninitialized).
Use the rtc mutex to lock mmio accesses instead.
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/rtc-asm9260.c | 20 +---
1 file changed, 5 insertions(+), 15 del
On 31/08/2016 at 17:14:27 +0200, Oleksij Rempel wrote :
> Hi
>
> Am 31.08.2016 um 02:18 schrieb Alexandre Belloni:
> > The rtc-asm9260 driver uses a discrete spinlock (wrongly uninitialized).
> > Use the rtc mutex to lock mmio accesses instead.
> >
> >
ARTZCAP_7pF 0
> +#define PCF85263_QUARTZCAP_6pF 1
> +#define PCF85263_QUARTZCAP_12p5pF2
> +
> +/* Quartz drive strength */
> +#define PCF85263_QUARTZDRIVE_NORMAL 0
> +#define PCF85263_QUARTZDRIVE_LOW 1
> +#define PCF85263_QUARTZDRIVE_HIGH
rtc_control = CMOS_READ(RTC_CONTROL);
if (rtc_control & RTC_AIE) {
cmos_rtc.suspend_ctrl &= ~RTC_AIE;
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "
max_mday = rtc_month_days(now.tm_mon, now.tm_year);
> + if (now.tm_mday == max_mday)
> + allow_leap_day = true;
> + }
> +
> + max_date.tm_year += 1;
> + max_mday = rtc_month_days(max_date.tm_mon, max_date.tm_year);
| 1 +
> drivers/rtc/rtc-ds1347.c | 96
> ++--
> 2 files changed, 54 insertions(+), 43 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you
tions(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.
s/buillt/built/g
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 24b0778f6e28..ab55f35019fc 100644
--- a/drivers/rtc/K
jz4740_rtc_poweroff() is only called from the driver, stop exporting it.
Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
drivers/rtc/rtc-jz4740.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz
> ---
> drivers/rtc/Kconfig | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "
+++--
> 2 files changed, 51 insertions(+), 5 deletions(-)
>
> v2: No change
> v3: No change
>
All applied, thanks
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to
hanged, 9 insertions(+), 10 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.googl
-by: Mirza Krak <mirza.k...@hostmobility.com>
> ---
> drivers/rtc/rtc-pcf85063.c | 7 +++
> 1 file changed, 7 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you
> ---
> drivers/rtc/Kconfig| 4 ++--
> drivers/rtc/rtc-cmos.c | 3 ---
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message beca
1 - 100 of 225 matches
Mail list logo
