[Rails-core] [ANN] Rails 6.0.2.1 has been released!

2019-12-18 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 6.0.2.1 has been released. This is a complementary release to rack in order to address [CVE-2019-16782](https://www.openwall.com/lists/oss-security/2019/12/18/2). ## CHANGES since 6.0.2 To view the changes for each gem, please read the

[Rails-core] [ANN] Rails 5.2.4.1 has been released!

2019-12-18 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.2.4.1 has been released. This is a complementary release to rack in order to address [CVE-2019-16782](https://www.openwall.com/lists/oss-security/2019/12/18/2). ## CHANGES since 5.2.4 To view the changes for each gem, please read the

[Rails-core] [ANN] Rails 6.0.2 has been released!

2019-12-13 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 6.0.2 has been released. ## CHANGES since 6.0.1 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG](https://github.com/rails/rails/blob/v6.0.2/actioncable/CHANGELOG.md) * [Action Mailbox

[Rails-core] [ANN] Rails 6.0.2.rc2 has been released!

2019-12-09 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 6.0.2.rc2 has been released. If no regressions are found, expect the final release on Friday, December 12, 2019. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so

[Rails-core] [ANN] Rails 5.2.4 has been released

2019-11-27 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.2.4 has been released. ## CHANGES since 5.2.3 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG](https://github.com/rails/rails/blob/v5.2.4/actioncable/CHANGELOG.md) * [Action Mailer

[Rails-core] [ANN] Rails 6.0.2.rc1 has been released

2019-11-27 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 6.0.2.rc1 has been released. If no regressions are found, expect the final release on Monday, December 2, 2019. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so

[Rails-core] [ANN] Rails 5.2.4.rc1 has been released!

2019-11-22 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.2.4.rc1 has been released. This is going to be the last bug fix release of the 5.2 series, so please test the releases candidates and report regressions so we can fix before the final release. If no regressions are found, expect the final

Re: [Rails-core] Add origin as part of `redirect_to.action_controller` Instrumentation

2019-11-22 Thread Rafael Mendonça França
Please open the PR. On Fri, Nov 22, 2019, at 3:09 PM, Austin Story wrote: > Requesting to extend an existing feature > > > I would like to add 'origin' to the 'redirect_to.action_controller' > instrumentation. This change will allow subscribers to the notification to > report on both where we

Re: [Rails-core] Proposal to run spell check on GItHub Actions

2019-10-29 Thread Rafael Mendonça França
While I agree we should try to avoid typos in our codebase. Fixing typos It is a very easy and low barrier way to get new contributors, and I think this kind of contribution is very welcome, so I’d prefer to not discourage or even remove the possibility of people to submit typo PRs. Maybe,

Re: [Rails-core] Backport ActiveRecord query cache feature from 6.x to 5.2

2019-10-18 Thread Rafael Mendonça França
Hello! With the release of Rails 6.0.0, Rails 5.2 became a security only release. No bug fixes or new features are going to be added to 5.2 unless it is for security reasons. See https://edgeguides.rubyonrails.org/maintenance_policy.html#bug-fixes

Re: [Rails-core] Question: Is ::Upload used anywhere in Rails?

2019-08-08 Thread Rafael Mendonça França
I hope this commit answers the question https://github.com/rails/rails/commit/fb5f8d4f86a4a08705d6e9b39b44203df22ab50d . > On Aug 8, 2019, at 14:51, Al wrote: > > Is "::Upload" used anywhere in Rails? Sorbet is

Re: [Rails-core] Deprecate strip_heredoc?

2019-06-08 Thread Rafael Mendonça França
/89bcca59e91fa9da941de890012872e8288e77b0 for the reasoning and https://github.com/rails/rails/blob/6729cef7516207efa1980de65fb4e1c72b4376d1/railties/lib/rails/generators/actions.rb#L330 for one place where we don't have an equivalent method. Rafael Mendonça França http://twitter.com/rafaelfranca https

Re: [Rails-core] [Feature] [ActionPack] Add deep_transform_keys to ActionController::StrongParameters

2019-05-13 Thread Rafael Mendonça França
 for this method.Can you open the PR? Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Mon, May 13, 2019 at 6:48 AM Gustavo Gutierrez wrote: > We are currently working with Rails API interacting with a frontend app. > In order to si

Re: [Rails-core] [Feature] Move the "to_param" logic out of ActiveRecord

2019-05-09 Thread Rafael Mendonça França
or.new(@article)) # => /admin/articles/12 class AdminArticleDecorator def initialize(article) @artile = article end def to_param(*) @article.id end end Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Thu, May 9, 2019 at 7:29 PM Rom

[Rails-core] [ANN] Rails 5.1.7 has been released

2019-03-27 Thread Rafael Mendonça França
to the many contributors who helped with this release. Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop

[Rails-core] [ANN] Rails 5.2.3 has been released

2019-03-27 Thread Rafael Mendonça França
f9b51b66a91d556d63d36d04449ecc23867683f99531db21eb7a263be2d7ecdc rails-5.2.3.gem 042388decffb47dab796e4ddb30a2d615047d7c334de7fe47208545e1677c9be railties-5.2.3.gem ``` As always, huge thanks to the many contributors who helped with this release. Rafael Mendonça França http://twitter.com/rafaelfranca

Re: [Rails-core] [ActiveRecord] [Feature Proposal] Common Table Expression support

2019-01-15 Thread Rafael Mendonça França
to the framework and maintain this feature. We are planing to expose arel as public API sometime in the future so maybe that would be enough to allow people who wants to use CTE to be able to use in their application. Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com

Re: [Rails-core] [ActiveRecord] [Feature Proposal] Common Table Expression support

2019-01-15 Thread Rafael Mendonça França
proposing adding to the rails framework? Thanks. Rafael Mendonça França http://twitter.com/rafaelfranca https://github.com/rafaelfranca On Tue, Jan 15, 2019 at 7:12 PM Daniel Heath wrote: > I'd like to be able to use my ActiveRecord scopes in a CTE for another > scope. > > Proposed syntax

[Rails-core] [ANN] Rails 5.2.2.rc1 has been released

2018-11-28 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.2.2.rc1 has been released. If no regressions are found, expect the final release on Monday, December 3, 2018. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so

Re: [Rails-core] autoload_reloader by Shopify

2018-11-01 Thread Rafael Mendonça França
When the author wrote that gem the idea was to integrate it to Rails. When I open sourced that gem the idea was to give the Rails core members material to review and experiment. So, yes, we are looking on it. On Thu, Nov 1, 2018 at 19:03 wrote: > Hi, > > I was wondering if anybody thinks that

[Rails-core] [ANN] Rails 5.2.1 has been released!

2018-08-07 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.2.1 has been released. ## CHANGES since 5.2.0 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG](https://github.com/rails/rails/blob/v5.2.1/actioncable/CHANGELOG.md) * [Action Mailer

[Rails-core] [ANN] Rails 5.2.1.rc1 has been released!

2018-07-30 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.2.1.rc1 has been released. If no regressions are found, expect the final release on Monday, August 6, 2018. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so that

Re: [Rails-core] [Feature] Symbol to_proc coercions: Enumerable#map can take several symbols

2018-05-11 Thread Rafael Mendonça França
If you think that method would be useful there is no reason why it should be Rails specific. Please send a feature request to the Ruby issue tracker here  https://bugs.ruby-lang.org/. Rafael França On May 11, 2018, 13:10 -0400, Alberto Almagro , wrote: > These days I

Re: [Rails-core] Is it a sane idea to add to_an? as an alias to to_a?

2018-04-19 Thread Rafael Mendonça França
Ruby used to have `exists?` and `exist?`. The former was deprecatted even that in some care it is more natual to read. I’d follow the same rule here. I believe consistence is more important than readability in this case. It make code easier to search, since you only need to search for `is_a?`

Re: [Rails-core] [Feature Request] adding .sample to ActiveRecord

2018-03-27 Thread Rafael Mendonça França
One of the first things to do is check if this feature would not proposed before. I think you will see that it was already proposed and rejected. See https://github.com/rails/rails/pull/16997 On Wed, Mar 28, 2018 at 1:21 AM Regan Ryan wrote: > Hi there, > > I've never

Re: [Rails-core] Adding the ability to show causes in the DebugExceptions view

2018-03-08 Thread Rafael Mendonça França
Looks good to me. Please open a pr On Thu, Mar 8, 2018 at 10:20 PM wrote: > Hi all, > > The Exception#cause > > method has been added to Ruby 2.1.0 back in 2013. Since then Rails has > adopted it to

[Rails-core] Rails 5.1.5 has been released

2018-02-14 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.1.5 has been released. ## CHANGES since 5.1.4 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG](https://github.com/rails/rails/blob/v5.1.5/actioncable/CHANGELOG.md) * [Action Mailer

[Rails-core] [ANN] Rails 5.1.5.rc1 has been released!

2018-02-01 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.1.5.rc1 has been released. If no regressions are found, expect the final release on Tuesday, February 6, 2018. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so

Re: [Rails-core] Payload names for 'sql.active_record' instrumentation

2017-09-13 Thread Rafael Mendonça França
Please do investigate, maybe there is no reason for that difference and we would be really happy to merge a fix for this. On Wed, Sep 13, 2017 at 5:57 PM Jeremy Green wrote: > When I subscribe to sql.active_record, when a Post is loaded the payload > name is "Post Load",

[Rails-core] Rails 5.1.2 has been released

2017-06-26 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.1.2 has been released. ## CHANGES since 5.1.1 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG](https://github.com/rails/rails/blob/v5.1.2/actioncable/CHANGELOG.md) * [Action Mailer

[Rails-core] Rails 4.2.9 has been released

2017-06-26 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.9 has been released. Following our [maintenance policy](http://guides.rubyonrails.org/maintenance_policy.html), since the release of Rails 5.1.0, the 4.2 series will only receive new releases in case of severe security issues. ## CHANGES

[Rails-core] Rails 5.1.2.rc1 has been released

2017-06-20 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.1.2.rc1 has been released. If no regressions are found, expect the final release on Monday, June 26, 2017. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so that

[Rails-core] Rails 4.2.9.rc2 has been released!

2017-06-19 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.9.rc2 has been released. This is going to be the last bug fix release of the 4.2 series, so please test this release candidate. If no regressions are found, expect the final release on Monday, June 26, 2017. If you find one, please open an

[Rails-core] Rails 5.0.4 has been released

2017-06-19 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.0.4 has been released. ## CHANGES since 5.0.3 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG](https://github.com/rails/rails/blob/v5.0.4/actioncable/CHANGELOG.md) * [Action Mailer

[Rails-core] [ANN] Rails 5.0.4.rc1 has been released

2017-06-14 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.0.4.rc1 has been released. If no regressions are found, expect the final release on Monday, June 19, 2017. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so that

[Rails-core] [ANN] Rails 4.2.9.rc1 has been released!

2017-06-13 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.9.rc1 has been released. If no regressions are found, expect the final release on Monday, June 19, 2017. If you find one, please open an [issue on GitHub](https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so that

Re: [Rails-core] Question about rc1 in RAILS_VERSION file?

2017-03-21 Thread Rafael Mendonça França
It needs to be 5.2.0.alpha. We are working on this change. On Mon, Mar 20, 2017 at 9:23 PM Al wrote: > Just saw rc1 for Rails. Have a question. > > Does https://github.com/rails/rails/blob/master/RAILS_VERSION in master > (edge rails) need to be "5.1.0.rc1"? > > Thanks > > --

[Rails-core] [ANN] Rails 5.0.2 has been released!

2017-03-01 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.0.2 has been released. ## CHANGES since 5.0.1 To view the changes for each gem, please read the changelogs on GitHub: * [Action Cable CHANGELOG]( https://github.com/rails/rails/blob/v5.0.2/actioncable/CHANGELOG.md) * [Action Mailer CHANGELOG](

[Rails-core] [ANN] Rails 5.0.2.rc1 has been released!

2017-02-24 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 5.0.2.rc1 has been released. If no regressions are found, expect the final release on Wednesday, March 1, 2017. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it, so

Re: [Rails-core] Regarding JavaScript testing

2017-02-23 Thread Rafael Mendonça França
Thank you for the feedback Rodrigo. I think it is worth to explore possibilities for JavaScript tests. I don’t see why Rails could not integrate better with the test ecosystem in the JavaScript community and I think it is a valuable direction to take. We didn’t included anything in this line in

[Rails-core] [ANN] Rails 4.2.8.rc1 has been released!

2017-02-09 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.8.rc1 has been released. If no regressions are found, expect the final release on Wednesday, February 15, 2017. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me (@rafaelfranca) on it,

Re: [Rails-core] [Suggestion] Allow proc in belongs_to's optional flag

2017-02-07 Thread Rafael Mendonça França
I believe this make `belongs_to` too complex and open a precedent to people want to customize the validation in other ways using the `belongs_to` syntax. The required validation is just a convenience. It is a good default but sometimes people want more than the default. In those cases they should

Re: [Rails-core] Unit testing ActionCable

2016-11-22 Thread Rafael Mendonça França
https://github.com/rails/rails/pull/23211 On Tue, Nov 22, 2016 at 12:55 PM Roman Snitko wrote: > It seems there currently is no easy (or hard even) way to unit test > ActionCable channels, which makes me very sad. There is a bit of logic in > my Channels which would be

Re: [Rails-core] New i18n release (0.8.0.beta1)

2016-11-21 Thread Rafael Mendonça França
I ran the Rails test suite with the beta version of i18n and everything is looking great! https://travis-ci.org/rails/rails/builds/177754824 Thank you for taking care of it Ryan. On Sun, Nov 20, 2016 at 9:46 PM Ryan Bigg wrote: > Hello all, > > I've been helping Sven Fuchs

Re: [Rails-core] Link_to conditional classes with 'class:' feature request (and all the other helpers that take CSS classes)

2016-10-25 Thread Rafael Mendonça França
There is an open question here. From here those conditional methods are coming from? From helpers modules? This will add a lot of this kind of methods in the global namespace since helpers are global and will make code harder to understand. On Mon, Oct 24, 2016 at 10:12 PM

Re: [Rails-core] [Suggestion] Prevent Rails from writing development/test log files by default

2016-10-24 Thread Rafael Mendonça França
I personally use `test.log` a lot to check the sql queries that are being made in my test run. Also setups using pow or any long running web server only uses the development.log so changing this will break that setup. I can see we disabling the boardcast, but I’d not do that by default. On Mon,

Re: [Rails-core] [Feature Request] 'On' option for after_save callbacks

2016-09-05 Thread Rafael Mendonça França
Is not that what after_update does? On dom, 4 de set de 2016 at 17:46 Anuj N wrote: > Hi folks! > > As per https://github.com/rails/rails/issues/22515, 5.0 saw > after_create_commit, after_update_commit, after_destroy_commit being > added as aliases to after_commit,

Re: [Rails-core] Timestamps in migration

2016-07-05 Thread Rafael Mendonça França
+3 пользователь Rafael Mendonça > França написал: >> >> Yes. And I think in Rails 4.2 it show a deprecation warning to tell >> people that it is going to default to null: false in Rails 5 >> ​ >> >> On Tue, Jul 5, 2016 at 4:07 PM Andrey Molchanov <neo...@gmail.co

Re: [Rails-core] Timestamps in migration

2016-07-05 Thread Rafael Mendonça França
gt; versions? > > вторник, 5 июля 2016 г., 22:00:37 UTC+3 пользователь Rafael Mendonça > França написал: >> >> I think this is already the default in Rails 5. Isn't? >> >> On Tue, Jul 5, 2016 at 3:52 PM Andrey Molchanov <neo...@gmail.com> wrote: >> >

Re: [Rails-core] Timestamps in migration

2016-07-05 Thread Rafael Mendonça França
I think this is already the default in Rails 5. Isn't? On Tue, Jul 5, 2016 at 3:52 PM Andrey Molchanov wrote: > Hi there! > If we create migrate with > > t.timestamps > > it will add lines > > t.datetime "created_at" > > t.datetime "updated_at" > > In schema.rb file. > What

[Rails-core] [ANN] Rails 4.2.7.rc1 and 4.1.16.rc1 have been released!

2016-07-01 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.7.rc1 and 4.1.16.rc1 have been released. As [Rails 5 was released]( http://weblog.rubyonrails.org/2016/6/30/Rails-5-0-final/), this is probably going to be the last release of Rails 4.1. Please take some time to upgrade your application to Rails

Re: [Rails-core] [Feature Request] Force test schema to be up to date when running tests

2016-06-28 Thread Rafael Mendonça França
Automatic test schema maintainance is a feature of Rails since 4.1 http://guides.rubyonrails.org/4_1_release_notes.html#railties-notable-changes On Tue, Jun 28, 2016 at 5:32 PM Chad Woolley wrote: > +1, this is one of a few things that doesn't "work out of the box" for

Re: [Rails-core] [Feature request] Raise an error for invalid options on migrations

2016-06-13 Thread Rafael Mendonça França
It is an limitation of the implementation. All database adapters share the same migrations helpers. If the SQLite3 adapter doesn't not accept the `limit` option to a string column and we raise an error when the users pass it the PostgreSQL adapter will also raise an error even that it is

Re: [Rails-core] [Feature request] Raise an error for invalid options on migrations

2016-06-09 Thread Rafael Mendonça França
Like I said in the original issue https://github.com/rails/rails/issues/25330#issuecomment-224787746 This proposed solution makes impossible to different adapters introduce different options to the migration helpers without monkey patching rails. In you specific case, a database like Oracle could

Re: [Rails-core] proposal: add option to pretty-print in json renderer

2016-05-23 Thread Rafael Mendonça França
In Rails 5.1 you will be able to change how the JSON is serialized. See https://github.com/rails/rails/pull/21496. On Mon, May 23, 2016 at 7:59 PM Gabriel Burt wrote: > My reading of the action_controller json renderer >

Re: [Rails-core] Raise on missing translations (unify controllers and views)

2016-05-23 Thread Rafael Mendonça França
I'm positive to adding such generic option. I18n already have the `transalate!` method to raise an error if the translation is missing maybe we should use it in the Rails wrappers? On Mon, May 23, 2016 at 7:59 PM Kevin Sjöberg wrote: > I'm on a mission to unify the logic

Re: [Rails-core] Improve user feedback in rails update [Feature Request]

2016-05-16 Thread Rafael Mendonça França
Hi, For what I could see in your explanation you are expecting the update task to teach people about the changes between some pre-releases. I don't think it is sustainable to do that. I'm all for improving the update task to give better feedback when do a minor version upgrade. I believe we have

Re: [Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-08 Thread Rafael Mendonça França
ter warning complementing the current > explanation. > > Best, > Rodrigo. > > > Em 06-05-2016 14:51, Rafael Mendonça França escreveu: > > That makes sense. Thank you for pointing out. Do you have a suggestion how > to improve it? Could you open a pull request? > On

Re: [Rails-core] Significant change should be better explained in the Changelog regarding non ERB view partials

2016-05-06 Thread Rafael Mendonça França
ithub.com/rails/rails/blob/v5.0.0.beta4/actionview/CHANGELOG.md > > "Change the default template handler from ERB to Raw. > > Files without a template handler in their extension will be rendered > using the raw handler instead of ERB. > > Rafael Mendonça França" > >

[Rails-core] [ANN] Rails 4.2.6 and 4.1.15 have been released!

2016-03-11 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.6 and 4.1.15 have been released. ## CHANGES since 4.1.14 To view the changes for each gem, please read the changelogs on GitHub: * [Action Mailer CHANGELOG]( https://github.com/rails/rails/blob/v4.1.15/actionmailer/CHANGELOG.md) * [Action Pack

[Rails-core] [ANN] Rails 4.2.6.rc1 and 4.1.15.rc1 have been released!

2016-03-01 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.6.rc1 and 4.1.15.rc1 have been released. If no regressions are found expect the final release this Friday, on March 4, 2016. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me

Re: [Rails-core] Enhancement: improved ActiveModal::Errors enumeration

2016-02-29 Thread Rafael Mendonça França
I'm positive for this enhancement. The type information is already retained in Rails 5 but having real object could be real handy. On Mon, Feb 29, 2016 at 12:47 PM Evan Prothro wrote: > I love the concept and usability of an ActiveModel::Errors paradigm. > However, I and

Re: [Rails-core] ActiveRecord::Result#to_hash doesn't return a hash

2016-01-29 Thread Rafael Mendonça França
That method seems to be private API of Rails (at least it should be) so go ahead to remove/deprecate it. On Fri, Jan 22, 2016 at 1:10 PM Kache wrote: > Was about to open GitHub issue, but found this mailing list. > > [ActiveRecord::Result#to_hash]( >

Re: [Rails-core] Bump Mail dependency to pick up downstream memory improvements

2016-01-23 Thread Rafael Mendonça França
It is already allowed to use mail 2.6 with rails, so why should we disallow to use mail < 2.6? On Sat, Jan 23, 2016, 21:19 Karl Freeman wrote: > Hey all, > > Without wanting to claim the hard work of others!! I would love to create > an issue that tracks bumping Mail to

Re: [Rails-core] Backport of keyword parameters for controller tests for Rails 4?

2016-01-07 Thread Rafael Mendonça França
I don't think it is necessary. You can still use the same syntax with Rails 4 and Rails 5, you will only see deprecations warnings, and I believe it is acceptable in this case. On Thu, Jan 7, 2016 at 4:33 PM Prem Sichanugrist wrote: > I think that might be a good idea. > >

Re: [Rails-core] Reducing ActionCable dependencies?

2016-01-05 Thread Rafael Mendonça França
Mike, the Rails core already agreed that this would be the best direction but nobody yet had time to work on this. If you want to work on this it would be awesome. Let us know if you need something from our side. If you want to discuss I can invite you to our private Basecamp project. On

Re: [Rails-core] Any reason #in_batches is not backported to Rails 4.x?

2015-12-23 Thread Rafael Mendonça França
New features are not backported to stable branches. See our maintenance policy http://guides.rubyonrails.org/maintenance_policy.html#new-features On Wed, Dec 23, 2015 at 3:32 PM Kashyap Kondamudi wrote: > Hello > > The `ActiveRecord::Relation#in_batches`, similar to >

Re: [Rails-core] Deprecation warnings after changing to Rails 5/beta1

2015-12-19 Thread Rafael Mendonça França
Hi Al, this is a now issue. The turbolinks release that will be included in rails 5 is still in work in progress. These warnings will go when turbolinks 5 is released On Sat, Dec 19, 2015, 06:56 Al wrote: > Wanted to document this somewhere. > >- If you want to use Rails

[Rails-core] [ANN] Rails 4.2.5.rc2 and 4.1.14.rc2 have been released!

2015-11-06 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.5.rc2 and 4.1.14.rc2 have been released. If no regressions are found expect the final release this Wednesday, on November 11, 2015. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me

Re: [Rails-core] link_to_if/link_to_unless inconsistencies

2015-11-05 Thread Rafael Mendonça França
t. Right now you can't achieve the normal link_to behavior when > the condition is met. We can preserve the behavior for the negative case > and still get the content_tag block benefit for the positive case. > > On Thu, Nov 5, 2015 at 3:54 PM, Rafael Mendonça França < >

Re: [Rails-core] link_to_if/link_to_unless inconsistencies

2015-11-05 Thread Rafael Mendonça França
It is the way they work. See the documentation. The block is used only when the condition is not met. On Thu, Nov 5, 2015 at 1:26 PM Kevin Deisz wrote: > Hi there, > > Seems like in the positive condition, link_to_if and link_to_unless are > inconsistent. When I send a

[Rails-core] [ANN] Rails 4.2.5.rc1 and 4.1.14.rc1 have been released!

2015-10-30 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.5.rc1 and 4.1.14.rc1 have been released. If no regressions are found expect the final release this Wednesday, on November 4, 2015. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me

Re: [Rails-core] Suggesting an alternative to raising a file missing exception in `config_for`

2015-10-28 Thread Rafael Mendonça França
I see the file not being there an exceptional case. Making config_for not raise if the file doesn't exists can lead to more problems like not reading the config file because of a typo in the file name. ``` if config_for(:rdis) # configure the thing else # don't configure the thing end ```

[Rails-core] [ANN] Rails 4.2.4 and 4.1.13 have been released!

2015-08-24 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.4 and 4.1.13 have been released. No regressions were found so these releases include the same changes that the release candidates. ## CHANGES since 4.1.12 To view the changes for each gem, please read the changelogs on GitHub: * [Action

[Rails-core] [ANN] Rails 4.2.4.rc1 and 4.1.13.rc1 have been released!

2015-08-14 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.4.rc1 and 4.1.13.rc1 have been released. If no regressions are found expect the final release this Wednesday, on August 19, 2015. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me

Re: [Rails-core] Re: Nokogiri adds a lot of weight to ActionView

2015-08-10 Thread Rafael Mendonça França
I think it is worth to experiment yes, I don't want to decline anything without seeing the code and how it would feel. I can see advantages of doing that. On Mon, Aug 10, 2015 at 2:11 PM iybet...@gmail.com wrote: Rafael, I made 3 strong arguments in response to your point about capybara. I

Re: [Rails-core] Feature proposal: Silently skip add with before_add association callback using false

2015-08-04 Thread Rafael Mendonça França
Thank you for the suggestion. All callbacks now are only skipped if an exception is raised and we are removing the special meaning of false, so I think this behavior correct. On Tue, Aug 4, 2015 at 4:48 PM Bruno Macabeus bruno.macab...@gmail.com wrote: As stated in the documentation

Re: [Rails-core] TimeHelpers and DateTime

2015-07-22 Thread Rafael Mendonça França
It does now at master branch. On Wed, Jul 22, 2015 at 9:05 PM Tyler Margison kolor...@gmail.com wrote: I haven't been able to find anything about this by searching, on Google or GitHub, but you cannot use TimeHelpers and DateTime together. Is there a reason the travel_to function doesn't stub

Re: [Rails-core] Re: Nokogiri adds a lot of weight to ActionView

2015-07-14 Thread Rafael Mendonça França
Nokogiri is needed for tests and I don't think tests are often used, at least they should. I still don't see any reason for doing this even more because almost all Rails applications use capybara and nokogiri is also a capybara dependency. On Tue, Jul 14, 2015 at 10:47 AM iybet...@gmail.com

Re: [Rails-core] Optional locale argument for pluralize helper

2015-07-07 Thread Rafael Mendonça França
:shipit: On Tue, Jul 7, 2015 at 1:45 PM Stefan Daschek ste...@daschek.net wrote: Since Rails 4 it’ possible to use locale-specific pluralization rules by doing something like Produkt.pluralize(:de). Is there any reason why ActionView::Helpers::TextHelper#pluralize doesn’t accept an

[Rails-core] [ANN] Rails 4.2.3 and 4.1.12 have been released!

2015-06-26 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.3 and 4.1.12 have been released. No regressions were found so these releases include the same changes that the release candidates. ## CHANGES since 4.1.11 To view the changes for each gem, please read the changelogs on GitHub: * [Action

Re: [Rails-core] Re: RFC: Rails-API: Proposed better interface for registering serializers with the controller

2015-06-24 Thread Rafael Mendonça França
Go for it, this will improve the way different serializers hook inside Rails so I don't see any reason to not do so. On Wed, Jun 24, 2015 at 1:07 PM Benjamin Fleischer bfleisc...@gmail.com wrote: I'm a little bummed no one responded to this. Here's some new info: ActiveModelSerializers

[Rails-core] [ANN] Rails 4.2.3.rc1 and 4.1.12.rc1 have been released!

2015-06-22 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.3.rc1 and 4.1.12.rc1 have been released. If no regressions are found expect the final release this Thursday, on June 25, 2015. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me

Re: [Rails-core] proposal: deprecate save() in favor of save!()

2015-06-22 Thread Rafael Mendonça França
I think the documentation is very clear about this: Saves the model. If the model is new a record gets created in the database, otherwise the existing record gets updated. By default, save always run validations. If any of them fail the action is cancelled and save returns false. If it is not we

Re: [Rails-core] update_columns doesn't support an empty hash

2015-05-07 Thread Rafael Mendonça França
Yes. It is raised by `update_all(attributes)`. On Thu, May 7, 2015 at 3:19 PM Xavier Noria f...@hashref.com wrote: It makes sense to me, you get passed a hash with the attributes to update, which could be none. This is a no-op edge-case similar to append an empty list to a list, etc., and

Re: [Rails-core] update_columns doesn't support an empty hash

2015-05-07 Thread Rafael Mendonça França
of ways, like type casting for instance. On Thu, May 7, 2015 at 2:52 PM Rafael Mendonça França rafaelmfra...@gmail.com wrote: And what happen if users expect N to be between 1 and many and we silently do nothing when 0 is sent to these methods? In my opinion if you don't have changes

Re: [Rails-core] update_columns doesn't support an empty hash

2015-05-07 Thread Rafael Mendonça França
might have a procedure to gradually build up a list of things to change, starting with {} and appending to it if certain conditions are met. It wouldn't be an exceptional situation if none of those conditions are met. On Thursday, 7 May 2015 18:24:50 UTC+1, Rafael Mendonça França wrote

Re: [Rails-core] update_columns doesn't support an empty hash

2015-05-07 Thread Rafael Mendonça França
Are not both cases invalid input? Why should we accept empty hashes? On Thu, May 7, 2015 at 2:14 PM Michael Mahemoff mahem...@gmail.com wrote: The following will return an error: Post.first.update_columns({}) ArgumentError: Empty list of attributes to change I think that's

Re: [Rails-core] Addition of 'deep_assoc` method to Hash in core_ext

2015-04-16 Thread Rafael Mendonça França
I think we had this same request several times and we always rejected it. I never had to use this pattern and I believe it may be a code smell, but I'm not sure about your usage, so it would be great if you explain why you have this pattern in your application and how often. The reason that I'm

[Rails-core] [ANN] Rails 4.2.1 and 4.1.10 have been released!

2015-03-19 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that after four release candidates the final versions for Rails 4.2.1 and 4.1.10 have been released. ## CHANGES since 4.1.9 To view the changes for each gem, please read the changelogs on GitHub: * [Action Mailer CHANGELOG](

Re: [Rails-core] Rename transactional fixtures to something clearer and more descriptive

2015-03-10 Thread Rafael Mendonça França
Seems good to me. On Fri, Mar 6, 2015 at 4:04 AM Brandon Weiss bran...@anti-pattern.com wrote: I think the name transactional fixtures is a little misleading and confusing, because (as far as I can tell) it doesn't really have anything to do with fixtures. This is pretty embarrassing, but

[Rails-core] [ANN] Rails 4.2.1.rc3 and 4.1.10.rc3 have been released!

2015-03-02 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.1.rc3 and 4.1.10.rc3 have been released. There were found some regressions in the last release candidates so, following release process we are releasing new release candidates. If no regressions are found expect the final release this Thursday,

[Rails-core] [ANN] Rails 4.2.1.rc2 and 4.1.10.rc2 have been released!

2015-02-25 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.1.rc2 and 4.1.10.rc2 have been released. There were found some regressions in the last release candidates so, following release process we are releasing new release candidates. If no regressions are found expect the final release this Monday,

[Rails-core] [ANN] Rails 4.2.1.rc1 and 4.1.10.rc1 have been released!

2015-02-20 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.2.1.rc1 and 4.1.10.rc1 have been released. If no regressions are found expect the final release this Wednesday, on February 25, 2015. If you find one, please open an [issue on GitHub]( https://github.com/rails/rails/issues/new) and mention me

Re: [Rails-core] .html_safe is ambiguous and should be renamed

2015-02-06 Thread Rafael Mendonça França
Renaming this method is not an option. The main reason is: it should not be used by end users. It is an implementation detail of the framework and although it is exposed to the users we don't recommend to use it directly. So when Andrew said we should rename it to something even longer so that

Re: [Rails-core] .html_safe is ambiguous and should be renamed

2015-02-06 Thread Rafael Mendonça França
this clearer? On 6 February 2015 at 16:50, Rafael Mendonça França rafaelmfra...@gmail.com wrote: Renaming this method is not an option. The main reason is: it should not be used by end users. It is an implementation detail of the framework and although it is exposed to the users we don't recommend

Re: [Rails-core] .html_safe is ambiguous and should be renamed

2015-02-06 Thread Rafael Mendonça França
Kayserilioglu On 6 February 2015 at 17:50:24, Rafael Mendonça França ( rafaelmfra...@gmail.com) wrote: Renaming this method is not an option. The main reason is: it should not be used by end users. It is an implementation detail of the framework and although it is exposed to the users we

[Rails-core] [ANN] Rails 4.1.9 and 4.0.13 have been released!

2015-01-06 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.1.9 and 4.0.13 have been released. This will be also the last release of 4.0 series as announced [in a previous blog post]( http://weblog.rubyonrails.org/2014/9/12/Rails-4-1-6-and-4-0-10-has-been-released/ ). As per our maintenance policy, the

[Rails-core] [ANN] Rails 4.1.9.rc1 and 4.0.13.rc1 have been released!

2015-01-01 Thread Rafael Mendonça França
Hi everyone, I am happy to announce that Rails 4.1.9.rc1 and 4.0.13.rc1 have been released. This is the first release of the year and it includes a lot of bug fixes. This will be also the last release of 4.0 series as announced [in a previous blog post](

Re: [Rails-core] Making FormBuilder#select work better with ActiveRecord collections

2014-12-26 Thread Rafael Mendonça França
Does not the collection_select work o this way? I know it has a label_method that you can pass name to get the same behavior, and if I'm not wrong disabled can accept a proc. -- You received this message because you are subscribed to the Google Groups Ruby on Rails: Core group. To unsubscribe

  1   2   3   >