[scm-migration-dev] code review request for mercurial 1.0

2008-04-06 Thread Jim Walker
Mike Kupfer wrote: > Not yet. Or at least the Bugster CR showed it as in-progress when I > checked a couple days ago. > Correct. Meld is not in SFW yet. I've been impacted by a series of desktop bugs. I'm now working on a bug where I get a core every time gnome help is closed. I hope to find

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread Richard Lowe
Danek Duvall writes: > On Fri, Apr 04, 2008 at 12:10:28AM -0400, Richard Lowe wrote: > >> Do we want to ship a default system-wide hgrc with a sensible config >> for merge (mergetools.hgrc, but slightly adjusted I would imagine)? >> >> I'm not sure I have much of an opinion either way, at this p

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread James Carlson
Danek Duvall writes: > > What's the deal with man pages in SFW? You've moved the Mercurial > > ones from SUNWsfman ("GNU and open source man pages") to the package > > that holds the software itself. Most of the other SFW man pages seem > > to be in SUNWsfman. Is there some sort of reorganizatio

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread James Carlson
Danek Duvall writes: > http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0-2/ I almost hate to ask, but ... What's the deal with man pages in SFW? You've moved the Mercurial ones from SUNWsfman ("GNU and open source man pages") to the package that holds the software itself. Most of the oth

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread James Carlson
Danek Duvall writes: > On Fri, Apr 04, 2008 at 12:10:28AM -0400, Richard Lowe wrote: > > > Do we want to ship a default system-wide hgrc with a sensible config > > for merge (mergetools.hgrc, but slightly adjusted I would imagine)? > > > > I'm not sure I have much of an opinion either way, at thi

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread Mike Kupfer
> "Rich" == Richard Lowe writes: Rich> That seems fine, I think. I wasn't sure whether meld was in or Rich> not at this point. Not yet. Or at least the Bugster CR showed it as in-progress when I checked a couple days ago. mike

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread Danek Duvall
On Fri, Apr 04, 2008 at 09:49:58AM -0400, James Carlson wrote: > > I would tend not to, if for no other reason than nothing's actually shipped > > yet. > > If "nothing" refers to meld, then that's a pretty good reason not to > bother right now. Well, not even meld has shipped yet. > > I also d

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread Danek Duvall
On Fri, Apr 04, 2008 at 10:19:20AM -0400, James Carlson wrote: > Danek Duvall writes: > > http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0-2/ > > I almost hate to ask, but ... > > What's the deal with man pages in SFW? You've moved the Mercurial > ones from SUNWsfman ("GNU and open sour

[scm-migration-dev] code review request for mercurial 1.0

2008-04-04 Thread Richard Lowe
Danek Duvall writes: > http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0-2/ > > Here's the second round, with Rich's patch to fix 1052 applied, as well as > a few other fixes found in codereview. [the conglomerate of Matt's patch(es) that fix 1052...] > I sent a copy of patchlist.diff to

[scm-migration-dev] code review request for mercurial 1.0

2008-04-03 Thread Danek Duvall
On Fri, Apr 04, 2008 at 12:10:28AM -0400, Richard Lowe wrote: > Do we want to ship a default system-wide hgrc with a sensible config > for merge (mergetools.hgrc, but slightly adjusted I would imagine)? > > I'm not sure I have much of an opinion either way, at this point, but > it would seem defa

[scm-migration-dev] code review request for mercurial 1.0

2008-04-03 Thread John Levon
On Wed, Apr 02, 2008 at 01:43:33PM -0700, Danek Duvall wrote: > > I guess it's ok, but I'm confused -where did you stash hgmerge? - it's > > deleted from prototype_com. > > hgmerge is gone. I need to run a fasttrack for that. How do we specify the merge binary now? The xvm-gate tools have a mod

[scm-migration-dev] code review request for mercurial 1.0

2008-04-03 Thread Matt Mackall
On Thu, 2008-04-03 at 14:34 -0700, Danek Duvall wrote: > On Thu, Apr 03, 2008 at 10:09:42PM +0100, John Levon wrote: > > > On Wed, Apr 02, 2008 at 01:43:33PM -0700, Danek Duvall wrote: > > > > > > I guess it's ok, but I'm confused -where did you stash hgmerge? - it's > > > > deleted from prototy

[scm-migration-dev] code review request for mercurial 1.0

2008-04-03 Thread Danek Duvall
http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0-2/ Here's the second round, with Rich's patch to fix 1052 applied, as well as a few other fixes found in codereview. I sent a copy of patchlist.diff to the mercurial list yesterday, and Matt seemed at least okay with the idea, so I hope thi

[scm-migration-dev] code review request for mercurial 1.0

2008-04-03 Thread Danek Duvall
On Thu, Apr 03, 2008 at 10:09:42PM +0100, John Levon wrote: > On Wed, Apr 02, 2008 at 01:43:33PM -0700, Danek Duvall wrote: > > > > I guess it's ok, but I'm confused -where did you stash hgmerge? - it's > > > deleted from prototype_com. > > > > hgmerge is gone. I need to run a fasttrack for tha

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread James C. McPherson
Danek Duvall wrote: > http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/ > > If anyone can spare a few cycles, I'd like to get this into build 88, which > would allow us to put it in the Indiana repo. I don't know if anyone's > been using this yet. I haven't, but I'm going to start. I gu

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread James Carlson
Danek Duvall writes: > On Wed, Apr 02, 2008 at 09:10:09AM -0400, James Carlson wrote: > > ... and the gate readme seems to singularly unhelpful in guidance. > > Is there any rhyme or reason to what we're doing here? Or are these > > files just for fun? ;-} > > There's no real guidance for

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread Richard Lowe
Danek Duvall writes: > On Wed, Apr 02, 2008 at 09:10:09AM -0400, James Carlson wrote: > >> METADATA >> >> Just a nit, but it seems that Norm Jacobs is the only one following >> this "new" format you're using. Everyone else has this: >> >> Owner: Joe User >> License: MUMBLEFROTZ

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread Danek Duvall
On Wed, Apr 02, 2008 at 09:10:09AM -0400, James Carlson wrote: > METADATA > > Just a nit, but it seems that Norm Jacobs is the only one following > this "new" format you're using. Everyone else has this: > > Owner: Joe User > License: MUMBLEFROTZ > > Notes on the porting

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread Danek Duvall
On Wed, Apr 02, 2008 at 10:58:36PM +1000, James C. McPherson wrote: > I guess it's ok, but I'm confused -where did you stash hgmerge? - it's > deleted from prototype_com. hgmerge is gone. I need to run a fasttrack for that. > btw, is this the expected output when dealing with a binary > file wi

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread James Carlson
Richard Lowe writes: > > Makefile and prototype_com: > > > > I'm a little surprised that favicon.ico goes away and doesn't > > reappear in the templates/static directory. > > > > The favicon is gone, in the local test I did with 'hg serve' it looks > to be replaced with one of the other logo i

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread Richard Lowe
James Carlson writes: > Danek Duvall writes: >> http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/ > > METADATA > > Just a nit, but it seems that Norm Jacobs is the only one following > this "new" format you're using. Everyone else has this: > > Owner: Joe User > License:

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread Richard Lowe
Danek Duvall writes: > http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/ > > If anyone can spare a few cycles, I'd like to get this into build 88, which > would allow us to put it in the Indiana repo. I don't know if anyone's > been using this yet. I haven't, but I'm going to start. Yo

[scm-migration-dev] code review request for mercurial 1.0

2008-04-02 Thread James Carlson
Danek Duvall writes: > http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/ METADATA Just a nit, but it seems that Norm Jacobs is the only one following this "new" format you're using. Everyone else has this: Owner: Joe User License: MUMBLEFROTZ Notes on the p

[scm-migration-dev] code review request for mercurial 1.0

2008-04-01 Thread Danek Duvall
http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/ If anyone can spare a few cycles, I'd like to get this into build 88, which would allow us to put it in the Indiana repo. I don't know if anyone's been using this yet. I haven't, but I'm going to start. Thanks, Danek