On Tue, 3 May 2022 02:20:23 GMT, Xue-Lei Andrew Fan wrote:
>> Hi. Sorry, I should have brought this up earlier, but there is a jtreg test
>> library to help with ensuring the GC runs,
>> `test/lib/jdk/test/lib/util/ForceGC.java`. You might consider replacing the
>> test code that runs/checks t
On Tue, 3 May 2022 02:20:23 GMT, Xue-Lei Andrew Fan wrote:
>> Hi. Sorry, I should have brought this up earlier, but there is a jtreg test
>> library to help with ensuring the GC runs,
>> `test/lib/jdk/test/lib/util/ForceGC.java`. You might consider replacing the
>> test code that runs/checks t
On Mon, 2 May 2022 22:35:08 GMT, Brent Christian wrote:
> Hi. Sorry, I should have brought this up earlier, but there is a jtreg test
> library to help with ensuring the GC runs,
> `test/lib/jdk/test/lib/util/ForceGC.java`. You might consider replacing the
> test code that runs/checks the GC w
On Mon, 2 May 2022 15:27:39 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally wi
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
add intermitt
On Thu, 28 Apr 2022 18:32:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Thu, 28 Apr 2022 04:34:36 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Thu, 28 Apr 2022 04:34:36 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
add sleep bac
On Thu, 28 Apr 2022 04:34:36 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Thu, 28 Apr 2022 17:48:20 GMT, Weijun Wang wrote:
> I see you removed the `Thread.sleep(100)` calls. Given the failure of another
> similar test, maybe it's safer to add them back?
Yes. I'm evaluating if other proposal works or not. Otherwise, I will add the
sleep back.
-
PR
On Thu, 28 Apr 2022 04:34:36 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Wed, 27 Apr 2022 22:56:08 GMT, Weijun Wang wrote:
> please change them to use `othervm`.
Thanks for the catch. Updated to use othervm.
-
PR: https://git.openjdk.java.net/jdk/pull/8136
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
change to use
On Wed, 27 Apr 2022 21:24:43 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Wed, 27 Apr 2022 17:25:52 GMT, Weijun Wang wrote:
> I see you are still using the 1st version of the `Cleaners.java` test which
> runs on Windows. Please update to the current version (I've updated the code
> in place).
Oops, I missed it. Updated.
-
PR: https://git.openjdk.ja
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
renew the Cle
On Wed, 27 Apr 2022 07:48:44 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Correct test
On Wed, 27 Apr 2022 07:11:16 GMT, Xue-Lei Andrew Fan wrote:
> Can you try out this test?
Awesome! Thank you!
-
PR: https://git.openjdk.java.net/jdk/pull/8136
On Tue, 26 Apr 2022 15:43:09 GMT, Weijun Wang wrote:
> Can you try out this test?
>
> ```
> diff --git a/test/jdk/sun/security/krb5/auto/Cleaners.java
> b/test/jdk/sun/security/krb5/auto/Cleaners.java
> new file mode 100644
> index 000..43f06cb9f60
> --- /dev/null
> +++ b/test/jdk/sun/s
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
final pName a
On Mon, 25 Apr 2022 06:07:00 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request with a new targ
On Tue, 26 Apr 2022 13:38:04 GMT, Xue-Lei Andrew Fan wrote:
>> IMO, there's no need to reset it to zero in `dispose()`. As for the usage in
>> native implementation, if there is really a case that it gets updated, then
>> the cleanable you registered at the beginning will be useless. Isn't that
On Mon, 25 Apr 2022 06:07:00 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request with a new targ
On Tue, 26 Apr 2022 11:54:36 GMT, Weijun Wang wrote:
>> Did you mean pName? The dispose() method will reset it to zero. 'pName" is
>> used a lot in native implementation. It may be doable to make it final, but
>> it may be more complicated than I could expect. I would like to leave it as
>>
On Tue, 26 Apr 2022 05:05:30 GMT, Xue-Lei Andrew Fan wrote:
>> The same for `GSSName`. Where is a test for `GSSCredential`?
>
>> Where is a test for `GSSCredential`?
>
> I did not find a way to create a GSSCredential object successfully, exception
> thrown. Is there an example I can refer to?
On Tue, 26 Apr 2022 05:02:51 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSNameElement.java
>> line 54:
>>
>>> 52: private final Cleaner.Cleanable cleanable;
>>> 53:
>>> 54: long pName = 0; // Pointer to the gss_name_t structure
>>
On Tue, 26 Apr 2022 02:02:09 GMT, Weijun Wang wrote:
> Where is a test for `GSSCredential`?
I did not find a way to create a GSSCredential object successfully, exception
thrown. Is there an example I can refer to?
-
PR: https://git.openjdk.java.net/jdk/pull/8136
On Tue, 26 Apr 2022 01:53:43 GMT, Weijun Wang wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge and resovle merge conflict
>> - change the calling order in dispose()
>> - Mor
On Mon, 25 Apr 2022 06:07:00 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request with a new targ
On Tue, 26 Apr 2022 02:01:10 GMT, Weijun Wang wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge and resovle merge conflict
>> - change the calling order in dispose()
>> - Mor
On Fri, 22 Apr 2022 13:27:12 GMT, Daniel Fuchs wrote:
> Please get another reviewer for the security-libs related and native changes.
@wangweij Did you have cycle and have another look at the update?
-
PR: https://git.openjdk.java.net/jdk/pull/8136
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 1
On Wed, 20 Apr 2022 15:54:07 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Wed, 20 Apr 2022 15:20:15 GMT, Daniel Fuchs wrote:
> Also should there be some synchronized block?
I thought about the synchronization issue. It looks like this class is not
multiple-threads safe, and thus the upper layer will take care of the
synchronization. So I did not add synchroniza
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
change the ca
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with two
additional commits since the last revision:
- More code c
On Wed, 20 Apr 2022 15:12:23 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Update to set
On Sat, 9 Apr 2022 15:00:46 GMT, Weijun Wang wrote:
>>> You might try it on other objects:
>>
>> Nice idea to test object collection. I added two test cases.
>>
>>> The `NativeGSSContext` code still needs to be fixed.
>>
>> Could you have more details? I did not catch the comment about
>>
On Sat, 9 Apr 2022 06:19:12 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request with a new targe
On Sat, 9 Apr 2022 06:22:51 GMT, Xue-Lei Andrew Fan wrote:
> Could you have more details? I did not catch the comment about
> NativeGSSContext.
When `NativeGSSContext(GSSNameElement peer, GSSCredElement myCred, int time,
GSSLibStub stub)` is called, `pContext` is 0 and you haven't registered t
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes
On Fri, 8 Apr 2022 13:50:25 GMT, Weijun Wang wrote:
> You might try it on other objects:
Nice idea to test object collection. I added two test cases.
> The `NativeGSSContext` code still needs to be fixed.
Could you have more details? I did not catch the comment about
NativeGSSContext.
---
On Fri, 8 Apr 2022 13:50:25 GMT, Weijun Wang wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> @bchristi-git showed me this test. You might try it on other objects:
>
> import org.iet
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally wi
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally wi
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally wi
On Thu, 7 Apr 2022 20:00:00 GMT, Weijun Wang wrote:
> I'm not sure if it's possible to write a test on the cleanup, but at least we
> can temporarily add a `println` line there and see if it ever gets called.
I did not find a way to test cleanup yet. Yes, a temporary 'println" is what I
can u
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally wi
On Thu, 7 Apr 2022 17:54:35 GMT, Xue-Lei Andrew Fan wrote:
>> Hmm, the earlier JCE change would also needs to be updated as it calls a
>> cleanup method on the to-be-cleaned object.
>
>> Hmm, the earlier JCE change would also needs to be updated as it calls a
>> cleanup method on the to-be-clea
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Update copyri
On Thu, 7 Apr 2022 17:35:47 GMT, Valerie Peng wrote:
> Hmm, the earlier JCE change would also needs to be updated as it calls a
> cleanup method on the to-be-cleaned object.
Yes, I will check the cleaner used in the security components and make sure
there is object reference problems.
---
On Thu, 7 Apr 2022 15:48:50 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCredElement.java
>> line 74:
>>
>>> 72: name = srcName;
>>> 73:
>>> 74: Cleaner.create().register(this, this::dispose);
>>
>> This will create a memo
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
the object re
On Thu, 7 Apr 2022 10:51:13 GMT, Daniel Fuchs wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCred
On Thu, 7 Apr 2022 10:51:13 GMT, Daniel Fuchs wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCred
On Thu, 7 Apr 2022 04:10:55 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCred
Looks good to me, removes credentials when phantom reachable, doesn't do
anything that would prevent it from becoming reachable. You removed the
GNSSException that wasn't thrown.
Regards,
Peter.
On 7/04/2022 2:17 pm, Xue-Lei Andrew Fan wrote:
Please review the update to remove finalizer met
Please review the update to remove finalizer method in the java.security.jgss
module. It is one of the efforts to clean up the use of finalizer method in JDK.
-
Commit messages:
- 8284490: Remove finalizer method in java.security.jgss
Changes: https://git.openjdk.java.net/jdk/pull/
61 matches
Mail list logo
