On Wed, 3 Feb 2021 01:43:25 GMT, David Holmes wrote:
> Hi Thomas,
>
> Approval in principle, but changes suggested.
>
> Thanks,
> David
Hi David, thanks for looking at this. I changed text and tag as requested.
..Thomas
> src/hotspot/share/prims/jvmtiExport.cpp line 1509:
>
>> 1507: JavaT
> Analyzing out-of-resource situations in cloud scenarios is no fun. With
> CloudFoundry, a JVMTI agent (jvmkill) is hooked up intercepting the jvmti
> "resource exhausted" event, then attempts to write up a heap report. That may
> fail, e.g. due to bugs in the agent [1], but also because that r
On Wed, 27 Jan 2021 08:07:04 GMT, Roland Westrelin wrote:
>> I noticed that the SA's dumpreplaydata command fails with:
>>
>> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
>> please wait...
>> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata do
On Wed, 27 Jan 2021 08:07:04 GMT, Roland Westrelin wrote:
>> I noticed that the SA's dumpreplaydata command fails with:
>>
>> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
>> please wait...
>> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata do
We could see NPE on `LinuxCDebugger::loadObjectContainingPC` which is used
mainly by the clhsdb `findpc` command. (See
[JDK-8248876](https://bugs.openjdk.java.net/browse/JDK-8248876) for more
details)
It is caused by PIE executable handling.
Currently we use virtual address of top of PT_LOAD i
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains six additional commits since the
last rev
On Mon, 1 Feb 2021 06:16:34 GMT, Lin Zang wrote:
>>> I think if you can avoid the 4th argument by just enabling parallel by
>>> default sounds like a good idea. Is there any reason not to use parallel
>>> heap dump? Also, I'm not familiar with the terms "compression backends" and
>>> "active w
On Tue, 2 Feb 2021 11:02:18 GMT, Thomas Stuefe wrote:
> Analyzing out-of-resource situations in cloud scenarios is no fun. With
> CloudFoundry, a JVMTI agent (jvmkill) is hooked up intercepting the jvmti
> "resource exhausted" event, then attempts to write up a heap report. That may
> fail, e.
On Tue, 2 Feb 2021 20:46:08 GMT, Alex Menkov wrote:
>> Hi all,
>>
>> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled.
>> It would be better to fix it.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Marked as reviewed by amenkov (Reviewer).
Thanks @alexmenkov and @plummercj .
--
On Tue, 2 Feb 2021 03:43:29 GMT, Jie Fu wrote:
> Hi all,
>
> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled.
> It would be better to fix it.
>
> Thanks.
> Best regards,
> Jie
This pull request has now been integrated.
Changeset: a47befc8
Author:Jie Fu
URL: http
On Sun, 17 Jan 2021 03:57:59 GMT, Chris Plummer wrote:
> See the bug for most details. A few notes here about some implementation
> details:
>
> In the `PointerLocation` class, I added more consistency w.r.t. whether or
> not a newline is printed. It used to for some address types, but not oth
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 2 Feb 2021 20:43:29 GMT, Alex Menkov wrote:
>> test/jdk/com/sun/jdi/JdbOptions.java line 85:
>>
>>> 83: private static final String outFilename =
>>> UUID.randomUUID().toString() + ".out";
>>> 84: private static final Path outPath = Paths.get(outFilename);
>>> 85: private st
On Tue, 2 Feb 2021 20:12:27 GMT, Chris Plummer wrote:
>> The test expects debuggee output in jdb output stream.
>> But jdb redirects debuggee output asynchronously so sometimes it's
>> incomplete or mixed with jdb output.
>> The fix updates debuggee to print output to file and read/analyze it af
On Tue, 2 Feb 2021 03:43:29 GMT, Jie Fu wrote:
> Hi all,
>
> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled.
> It would be better to fix it.
>
> Thanks.
> Best regards,
> Jie
Marked as reviewed by cjplummer (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/p
On Tue, 2 Feb 2021 20:45:37 GMT, Alex Menkov wrote:
>> Special handling for options with commas, quotes and single quotes was added
>> many years ago for JFR (as it uses commas inside). The logic there is a bit
>> tricky and I didn't want to brake existing functionality when I made some
>> cha
On Tue, 2 Feb 2021 20:34:14 GMT, Alex Menkov wrote:
>> Thanks @plummercj for your review.
>>
>> Let's wait for @alexmenkov 's comments.
>> Thanks.
>
> Special handling for options with commas, quotes and single quotes was added
> many years ago for JFR (as it uses commas inside). The logic ther
On Tue, 2 Feb 2021 03:43:29 GMT, Jie Fu wrote:
> Hi all,
>
> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled.
> It would be better to fix it.
>
> Thanks.
> Best regards,
> Jie
Marked as reviewed by amenkov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pul
On Thu, 28 Jan 2021 22:40:57 GMT, Phil Race wrote:
> This removes the JNF dependency from the jdk.hotspot.agent module.
> The macro expansions are the same as already used in the Java desktop module
> - which actually uses a macro
> still but there there are hundreds of uses.
> The function of t
On Tue, 2 Feb 2021 04:17:39 GMT, Jie Fu wrote:
>> test/jdk/com/sun/jdi/JdbOptions.java line 99:
>>
>>> 97: test("-connect",
>>> 98:
>>> "com.sun.jdi.CommandLineLaunch:vmexec=java,options=\"-client\"
>>> \"-XX:+PrintVMOptions\""
>>> 99: + " -XX:+IgnoreUnr
On Sat, 30 Jan 2021 00:15:04 GMT, Alex Menkov wrote:
> The test expects debuggee output in jdb output stream.
> But jdb redirects debuggee output asynchronously so sometimes it's incomplete
> or mixed with jdb output.
> The fix updates debuggee to print output to file and read/analyze it after
On Mon, 25 Jan 2021 20:00:41 GMT, Chris Plummer wrote:
>> See the bug for most details. A few notes here about some implementation
>> details:
>>
>> In the `PointerLocation` class, I added more consistency w.r.t. whether or
>> not a newline is printed. It used to for some address types, but no
On Tue, 2 Feb 2021 18:23:04 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os/posix/signals_posix.cpp line 1297:
>
>> 1295: kern_return_t kr;
>
On Tue, 2 Feb 2021 18:52:29 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> Changes requested by gziemski (Committer).
There were bunch of assembly code that
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 2 Feb 2021 17:36:32 GMT, Serguei Spitsyn wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary CreateCoredumpOnCrash
>
> The update looks good.
> I think this is a trivial fix and does not ne
On Mon, 1 Feb 2021 10:38:30 GMT, Thomas Stuefe wrote:
> Hi,
>
> may I please have reviews for this trivial fix.
>
> We see timeouts with this test on slow large (memory wise) AIX machines, as
> well as large core files.
>
> This test is a negative test which tests that the VM corectly recogni
Analyzing out-of-resource situations in cloud scenarios is no fun. With
CloudFoundry, a JVMTI agent (jvmkill) is hooked up intercepting the jvmti
"resource exhausted" event, then attempts to write up a heap report. That may
fail, e.g. due to bugs in the agent [1], but also because that report ru
On Tue, 2 Feb 2021 12:00:00 GMT, Thomas Stuefe wrote:
>> Hi,
>>
>> may I please have reviews for this trivial fix.
>>
>> We see timeouts with this test on slow large (memory wise) AIX machines, as
>> well as large core files.
>>
>> This test is a negative test which tests that the VM corectly
On Tue, 2 Feb 2021 14:52:50 GMT, Daniel D. Daugherty wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary CreateCoredumpOnCrash
>
> Thumbs up! Thanks for taking care of this.
I think this is a trivi
On Tue, 2 Feb 2021 12:00:00 GMT, Thomas Stuefe wrote:
>> Hi,
>>
>> may I please have reviews for this trivial fix.
>>
>> We see timeouts with this test on slow large (memory wise) AIX machines, as
>> well as large core files.
>>
>> This test is a negative test which tests that the VM corectly
On Tue, 2 Feb 2021 11:56:12 GMT, Vladimir Kempik wrote:
> > > > Hello, hsdis is a separate out-of-tree project and is not part of this
> > > > jep.
> > >
> > >
> > > Unless there's something I'm missing it only requires a few lines of
> > > change to src/utils/hsdis/makefile (it already has s
On Tue, 2 Feb 2021 11:20:30 GMT, Serguei Spitsyn wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary CreateCoredumpOnCrash
>
> Hi Thomas,
> The fix looks good. Thank you fixing it.
> I've submitted
> Hi,
>
> may I please have reviews for this trivial fix.
>
> We see timeouts with this test on slow large (memory wise) AIX machines, as
> well as large core files.
>
> This test is a negative test which tests that the VM corectly recognizes an
> error condition and aborts. Code goes through
On Tue, 2 Feb 2021 11:14:12 GMT, Vladimir Kempik wrote:
> > > > Hello, hsdis is a separate out-of-tree project and is not part of this
> > > > jep.
> > >
> > >
> > > Unless there's something I'm missing it only requires a few lines of
> > > change to src/utils/hsdis/makefile (it already has s
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 1 Feb 2021 14:06:32 GMT, Magnus Ihse Bursie wrote:
>>> Hello, hsdis is a separate out-of-tree project and is not part of this jep.
>>
>> Unless there's something I'm missing it only requires a few lines of change
>> to src/utils/hsdis/makefile (it already has support for macos x86_64)
>
On Mon, 1 Feb 2021 10:38:30 GMT, Thomas Stuefe wrote:
> Hi,
>
> may I please have reviews for this trivial fix.
>
> We see timeouts with this test on slow large (memory wise) AIX machines, as
> well as large core files.
>
> This test is a negative test which tests that the VM corectly recogni
On Mon, 1 Feb 2021 10:38:30 GMT, Thomas Stuefe wrote:
> Hi,
>
> may I please have reviews for this trivial fix.
>
> We see timeouts with this test on slow large (memory wise) AIX machines, as
> well as large core files.
>
> This test is a negative test which tests that the VM corectly recogni
Hi,
may I please have reviews for this trivial fix.
We see timeouts with this test on slow large (memory wise) AIX machines, as
well as large core files.
This test is a negative test which tests that the VM corectly recognizes an
error condition and aborts. Code goes through jni_FatalError()->
40 matches
Mail list logo
