Thank you, Serguei for the review. Comments inline.
> -Original Message-
>
>
>It seems there is no need to check address for null as it is done
> inside the instantiateWrapperFor call.
Makes sense. I have removed those.
> At the lines 522-547 it is possible to define and use the
Thank you, Dmitry. Could I get one more reviewer to take a look at this ?
-Jini.
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, December 13, 2016 2:48 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8159127: hprof he
Modified webrev:
http://cr.openjdk.java.net/~jgeorge/8159127/webrev.01/
Thanks,
Jini.
> -Original Message-
> From: Jini Susan George
> Sent: Tuesday, December 13, 2016 10:09 AM
> To: Dmitry Samersoff; serviceability-dev@openjdk.java.net
> Subject: RE: RFR: JDK-8159127: h
Thank you, Dmitry. I will add the null check.
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Monday, December 12, 2016 5:06 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8159127: hprof heap dumps broken for lam
Could I please get a review done for the following SA defect?
Bug: https://bugs.openjdk.java.net/browse/JDK-8159127
Webrev: http://cr.openjdk.java.net/~jgeorge/8159127/webrev.00/
Thanks,
- Jini Susan George
Thank you, Serguei!
-jini
> -Original Message-
> From: Serguei Spitsyn
> Sent: Saturday, November 19, 2016 6:19 AM
> To: Jini Susan George; Dmitry Samersoff; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR: JDK-8169232: SA: TestCpoolForInvokeDynamic
Could I get one more reviewer to take a look at this, please?
Thanks,
Jini.
> -Original Message-
> From: Dmitry Samersoff
> Sent: Wednesday, November 16, 2016 4:06 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR:
Thank you, Dmitry !
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Wednesday, November 16, 2016 4:06 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8169232: SA: TestCpoolForInvokeDynamic.ja
Thank you, Robbin.
- jini.
> -Original Message-
> From: Robbin Ehn
> Sent: Wednesday, November 16, 2016 2:41 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8169638: serviceability/sa/TestInstanceKlassSize.java
> and
Thank you, Dmitry.
- Jini.
> -Original Message-
> From: Dmitry Samersoff
> Sent: Wednesday, November 16, 2016 2:14 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8169638: serviceability/sa/TestInstanceKlassSize.java
> and
Requesting a review of the small fix for:
https://bugs.openjdk.java.net/browse/JDK-8169638
Webrev: http://cr.openjdk.java.net/~jgeorge/8169638/webrev.00/
Thanks,
- Jini Susan George
Requesting a review of a possible fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8169232
Webrev: http://cr.openjdk.java.net/~jgeorge/8169232/webrev.00/
Details have been outlined in the bug.
Thanks,
- Jini Susan George
Thank you, Robbin !
-jini
> -Original Message-
> From: Robbin Ehn
> Sent: Tuesday, November 08, 2016 4:02 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-7107018:
> sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect
The updated webrev: http://cr.openjdk.java.net/~jgeorge/8169344/webrev.01/
- jini.
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, November 08, 2016 11:22 AM
> To: Jini Susan George; David Holmes; serviceability-dev@openjdk.java.net
> Subject: Re: R
Thank you, Dmitry.
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, November 08, 2016 11:25 AM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-7107018:
> sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachCl
Thank you, Dmitry.
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, November 08, 2016 11:22 AM
> To: Jini Susan George; David Holmes; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8169344: Potential open file descriptor in exists() of
>
Thank you, David. Will make this change.
-jini
> -Original Message-
> From: David Holmes
> Sent: Tuesday, November 08, 2016 10:05 AM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8169344: Potential open file descriptor in exists
Requesting a review for the small fix for:
https://bugs.openjdk.java.net/browse/JDK-8169344
Webrev: http://cr.openjdk.java.net/~jgeorge/8169344/webrev.00/
Thanks,
- Jini Susan George
Gentle reminder !
Thanks,
Jini.
From: Jini Susan George
Sent: Thursday, November 03, 2016 9:34 AM
To: serviceability-dev@openjdk.java.net
Subject: RFR: JDK-7107018:
sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test
Please review the trivial fix for the bug below
Please review the trivial fix for the bug below (Unfortunately, the bug is
marked confidential):
https://bugs.openjdk.java.net/browse/JDK-7107018
Webrev: http://cr.openjdk.java.net/~jgeorge/7107018/webrev.00/index.html
Thanks,
- Jini Susan George
constant pool" assertion failure
>
> New files (LingeredAppWithInvokeDynamic.java,
> TestCpoolForInvokeDynamic.java) should just have current year for
> copyright (2005, 2015 should be removed).
>
> Other than that, +1
>
> -Sundar
>
>
> On 11/2/2016 9:2
Could I get one more review done for this, please ?
Thanks,
Jini.
> -Original Message-
> From: Dmitry Samersoff
> Sent: Monday, October 31, 2016 2:58 PM
> To: Jini Susan George; serviceability-dev
> Subject: Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall'
Thank you, Dmitry !
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Monday, October 31, 2016 2:58 PM
> To: Jini Susan George; serviceability-dev
> Subject: Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws
> "Corrupted constant
Please do review the changes for the SA defect:
https://bugs.openjdk.java.net/browse/JDK-8164783
The webrev is at:
http://cr.openjdk.java.net/~jgeorge/8164783/webrev.00/
Thanks,
- Jini Susan George
Thank you, Dmitry !
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, October 04, 2016 4:45 PM
> To: Jini Susan George; serviceability-dev
> Subject: Re: RFR: 8164383: jhsdb dumps core on Solaris 12 when loading
> dumped core
>
> Jini
Could I get a second review for this, please ?
Thanks,
Jini.
From: Serguei Spitsyn
Sent: Monday, October 03, 2016 10:22 AM
To: Jini Susan George; serviceability-dev
Subject: Re: RFR: 8164383: jhsdb dumps core on Solaris 12 when loading dumped
core
Ok.
Thanks, Jini.
Serguei
On 10/2
/Lib-jdk.hotspot.agent.gmk.
Thanks,
Jini.
From: Serguei Spitsyn
Sent: Monday, October 03, 2016 8:50 AM
To: Jini Susan George; serviceability-dev
Subject: Re: RFR: 8164383: jhsdb dumps core on Solaris 12 when loading dumped
core
On 10/2/16 19:39, HYPERLINK
"mailto:serguei
Could I please get reviews done for the following fix?
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8164383
Webrev: http://cr.openjdk.java.net/~jgeorge/8164383/webrev.00/
Thanks,
- Jini Susan George
Thank you, Dmitry.
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, September 13, 2016 10:21 PM
> To: Jini Susan George; serviceability-dev; Ioi Lam
> Subject: Re: RFR: 8027920: SA: Add default methods to InstanceKlass
>
> Jini,
>
> Look
Thank you, Ioi.
-jini
> -Original Message-
> From: Ioi Lam
> Sent: Tuesday, September 13, 2016 9:47 PM
> To: Jini Susan George; Dmitry Samersoff; serviceability-dev
> Subject: Re: RFR: 8027920: SA: Add default methods to InstanceKlass
>
> Hi Jini,
>
>
Thanks again, Dmitry. Modified webrev:
http://cr.openjdk.java.net/~jgeorge/8027920/webrev.02/
Rgds,
-Jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, September 13, 2016 5:36 PM
> To: Jini Susan George; serviceability-dev; Ioi Lam
> Subject: Re: RFR: 8
attach to self.
>
> -Dmitry
>
> On 2016-09-11 09:01, Jini Susan George wrote:
> > Hello,
> >
> >
> >
> > Could I please get a review for the following fix ?
> >
> >
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8027920
> &g
Hello,
Could I please get a review for the following fix ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8027920
Webrev: http://cr.openjdk.java.net/~jgeorge/8027920/webrev.00/
Thanks,
- Jini Susan George
Alan, this looks like a dup of
https://bugs.openjdk.java.net/browse/JDK-8164802.
- jini.
> -Original Message-
> From: Alan Burlison
> Sent: Wednesday, August 31, 2016 6:21 PM
> To: Arvind Aprameya; Yasumasa Suenaga; serviceability-
> d...@openjdk.java.net
> Subject: Re: jhsdb jstack can
Thank you, Mandy. Aiming at that.
-jini.
> -Original Message-
> From: Mandy Chung
> Sent: Tuesday, August 30, 2016 11:27 AM
> To: Jini Susan George
> Cc: David Holmes; serviceability-dev; Alejandro Murillo
> Subject: Re: RFR:(S): 8164562:
&
Thank you, David.
-jini.
> -Original Message-
> From: David Holmes
> Sent: Tuesday, August 30, 2016 11:07 AM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR:(S): 8164562:
> serviceability/sa/TestInstanceKlassSizeForInterface.java: fail
6 AM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR:(S): 8164562:
> serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE
>
> On 24/08/2016 4:10 PM, Jini Susan George wrote:
> > Hi all,
> >
> > Could you ple
,
Jini.
From: Mandy Chung
Sent: Saturday, August 27, 2016 7:14 AM
To: Jini Susan George
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR:(S): 8164562:
serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE
On Aug 23, 2016, at 11:10 PM, Jini Susan George
Susan George
I need one more reviewer, please !
Thanks,
Jini.
> -Original Message-
> From: Jini Susan George
> Sent: Tuesday, August 23, 2016 11:48 AM
> To: Dmitry Samersoff; serviceability-dev@openjdk.java.net
> Subject: RE: RFR: 8163150: SA: CLHSDB printmdo throws an
Thank you, Dmitry !
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Tuesday, August 23, 2016 11:44 AM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: 8163150: SA: CLHSDB printmdo throws an exception with
> "java.lang
Hello,
Could I please get a review for:
https://bugs.openjdk.java.net/browse/JDK-8163150
Webrev: http://cr.openjdk.java.net/~jgeorge/8163150/webrev.00/
The test BasicLauncherTest.java includes code leveraged from Yasumasa's webrev
for JDK-8163581.
Thanks,
- Jini
Thank you, Dmitry !
-jini
> -Original Message-
> From: Dmitry Samersoff
> Sent: Thursday, August 11, 2016 12:50 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net; Lindenmaier,
> Goetz
> Subject: Re: RFR: JDK-8163143: illegal bci error with interpreted fra
Thank you for this fix, Yasumasa. This issue was manifested through the
'universe' command in clhsdb also, and your change fixes that. It would be
great if you could modify BasicLauncherTest.java to have some testing done for
this also.
Thank you,
Jini (Not a Reviewer).
> -Original Messa
/webrev.01/
Thanks,
-Jini.
> -Original Message-
> From: Dmitry Samersoff
> Sent: Wednesday, August 10, 2016 1:42 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net; Lindenmaier,
> Goetz
> Subject: Re: RFR: JDK-8163143: illegal bci error with interpreted fra
on PPC64.
Thank you,
- Jini Susan George
:yasue...@gmail.com]
> Sent: Saturday, August 06, 2016 8:50 PM
> To: Jini Susan George
> Cc: serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8163272: jhsdb jinfo cannot show system properties
>
> Hi Jini,
>
> I changed BasicLauncherTest#launch() to handle un
Hi Yasumasa,
It would be great if you could modify
jdk/test/sun/tools/jhsdb/BasicLauncherTest.java to test for this also as a part
of your change.
Thanks,
Jini. (Not a Reviewer).
> -Original Message-
> From: Yasumasa Suenaga [mailto:yasue...@gmail.com]
> Sent: Friday, August 05, 2016
Hi Yasumasa,
Thanks for noticing this. Regarding the illegal bci, you seem to be right.
>From a quick look, this looks like this came in with the introduction of
interpreter_frame_mirror_offset.
(https://bugs.openjdk.java.net/browse/JDK-8154580).
>From frame_x86.hpp, we have:
...
71 inte
ode, then we want to
> >>>address such that we reduce any Findbugs noise
> >>>
> >>> 2) Fixing it could be considered to be a defense-in-depth change.
> >>>
> >>> Dan
> >>>
> >>>
> >>> On 7/29/16 7:
n value is non-null.
Cheers,
-JB-
On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George mailto:jini.geo...@oracle.com"; \njini.geo...@oracle.com> wrote:
Hi all,
Please review the fix for the following SA defect (to avoid exposing internal
representations by storing or returni
.00/
Thanks,
- Jini Susan George
ent:* Tuesday, July 05, 2016 9:54 PM *To:*
> >> serviceability-dev@openjdk.java.net
> >> <mailto:serviceability-dev@openjdk.java.net> *Subject:* RFR:
> >> JDK-8145627 (sun.jvm.hotspot.oops.InstanceKlass::getSize()
> returns
> >> the incorrect size and has no test)
> >>
> >>
> >>
> >> Hi all,
> >>
> >>
> >>
> >> Please review the fix in Serviceability Agent (SA) for:
> >>
> >> JDK-8145627
> >> <https://bugs.openjdk.java.net/browse/JDK-
> 8145627>(sun.jvm.hotspot.oops.InstanceKlass::getSize()
> >> returns the incorrect size and has no test)
> >>
> >>
> >>
> >> The webrev is at:
> >>
> >>
> <http://cr.openjdk.java.net/%7Esballal/sponsorship/8145627/webrev.00/>h
> ttp://cr.openjdk.java.net/~sballal/sponsorship/8145627/webrev.00/
> >>
> >>
> >>
> >>
> >> The modifications include the fix and 2 tests to check the
> >> InstanceKlass sizes representing some well known classes and
> that
> >> of an interface. The tests compare the sizes returned by SA to
> >> those returned by jcmd. At this point, SA cannot view the
> >> InstanceKlasses representing anonymous classes. (This issue will
> >> be addressed in JDK-8160228
> >> <https://bugs.openjdk.java.net/browse/JDK-8160228> (SA cannot
> view
> >> the LambdaMetaFactory generated anonymous instanceKlasses)).
> Hence
> >> the current fix does not include the size addition for
> >> InstanceKlasses representing anonymous classes.
> >>
> >>
> >>
> >> Thanks,
> >>
> >> - Jini Susan George
> >>
> >>
> >>
> >
rowse/JDK-8160228"JDK-8160228 (SA cannot view
the LambdaMetaFactory generated anonymous instanceKlasses)). Hence the current
fix does not include the size addition for InstanceKlasses representing
anonymous classes.
Thanks,
- Jini Susan George
54 matches
Mail list logo
