Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification [v2]

2020-10-12 Thread David Holmes
On Mon, 12 Oct 2020 12:07:23 GMT, Vladimir Kempik wrote: >> Please review this change for hotspot and one test. >> There is few JVMTI callback/event functions in jdk which signature doesn't >> match specification. >> for example: >> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEn

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification [v2]

2020-10-12 Thread Vladimir Kempik
On Mon, 5 Oct 2020 12:44:34 GMT, Vladimir Kempik wrote: >>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on >>> [hotspot-dev](mailto:hotspot-...@openjdk.java.net):_ >>> Hi Vladimir, >>> >>> On 2/10/2020 5:37 pm, Vladimir Kempik wrote: >>> >>> > On Fri, 2 Oct 2020 07

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification [v2]

2020-10-12 Thread Vladimir Kempik
> Please review this change for hotspot and one test. > There is few JVMTI callback/event functions in jdk which signature doesn't > match specification. > for example: > static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, > jboolean* enabled, ...) > but according to jvmti spec

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-05 Thread David Holmes
On 5/10/2020 10:47 pm, Vladimir Kempik wrote: On Fri, 2 Oct 2020 15:26:30 GMT, Vladimir Kempik wrote: Okay but look at the example that documentation gives: For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates that there is a jint parameter, the event handler should b

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-05 Thread Vladimir Kempik
On Fri, 2 Oct 2020 15:26:30 GMT, Vladimir Kempik wrote: >>> Okay but look at the example that documentation gives: >>> >>> > For example, if the jvmtiParamInfo returned by GetExtensionEvents >>> > indicates that there is a jint parameter, the event >>> > handler should be declared: ``` >>> >

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-04 Thread David Holmes
Hi Vladimir, On 3/10/2020 1:29 am, Vladimir Kempik wrote: On Fri, 2 Oct 2020 07:34:45 GMT, Vladimir Kempik wrote: If you still see no issues here we can delay and make this changeset part of JEP-391. But since this changeset isn't much macos-aarch64 specific, I thought it would be good to in

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-02 Thread Vladimir Kempik
On Fri, 2 Oct 2020 07:34:45 GMT, Vladimir Kempik wrote: >> Okay but look at the example that documentation gives: >> >>> For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates >>> that there is a jint parameter, the event >>> handler should be declared: >>> void JNI

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-02 Thread David Holmes
Hi Vladimir, On 2/10/2020 5:37 pm, Vladimir Kempik wrote: On Fri, 2 Oct 2020 07:27:17 GMT, David Holmes wrote: Okay but look at the example that documentation gives: For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates that there is a jint parameter, the event handle

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-02 Thread Vladimir Kempik
On Fri, 2 Oct 2020 07:27:17 GMT, David Holmes wrote: > Okay but look at the example that documentation gives: > > > For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates > > that there is a jint parameter, the event > > handler should be declared: ``` > > void JNICALL

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-02 Thread David Holmes
On Fri, 2 Oct 2020 06:59:13 GMT, Vladimir Kempik wrote: >> Vladimir, it looks good to me. > >> David, >> I think, Vladimir is referring to the JVMTI extension mechanism spec: >> https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#jvmtiExtensionFunction >> https://docs.oracle.com/en/ja

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-02 Thread Vladimir Kempik
On Fri, 2 Oct 2020 05:10:20 GMT, Serguei Spitsyn wrote: >> Please review this change for hotspot and one test. >> There is few JVMTI callback/event functions in jdk which signature doesn't >> match specification. >> for example: >> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-01 Thread Serguei Spitsyn
On Thu, 1 Oct 2020 15:02:01 GMT, Vladimir Kempik wrote: > Please review this change for hotspot and one test. > There is few JVMTI callback/event functions in jdk which signature doesn't > match specification. > for example: > static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-01 Thread David Holmes
Hi Vladimir, On 2/10/2020 1:09 am, Vladimir Kempik wrote: Please review this change for hotspot and one test. There is few JVMTI callback/event functions in jdk which signature doesn't match specification. for example: static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, jboo

RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-01 Thread Vladimir Kempik
Please review this change for hotspot and one test. There is few JVMTI callback/event functions in jdk which signature doesn't match specification. for example: static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, jboolean* enabled, ...) but according to jvmti specs it should be