RE: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c

Hi Alex, as far as I know, it's not possible to include hotspot headers in the JDK, so we have to leave it local. Best regards Christoph -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Alex Menkov Sent: Donnerstag, 7. Dezemb

RE: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c

Done: http://hg.openjdk.java.net/jdk/jdk/rev/8ad12da0cbc7 Thanks Christoph From: Chris Plummer [mailto:chris.plum...@oracle.com] Sent: Freitag, 8. Dezember 2017 06:48 To: Langer, Christoph ; serviceability-dev@openjdk.java.net; serguei.spit...@oracle.com Cc: Lindenmaier, Goetz Subject: Re: RFR

Re: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

Looks good. Thanks, Jini On 12/7/2017 2:25 PM, Sharath Ballal wrote: Thanks Jini. I have changed the testcase to run with both -Xint and -Xcomp. Updated webrev is http://cr.openjdk.java.net/~sballal/8193124/webrev.01/ Thanks, Sharath -Original Message- From: Jini George Sent: Wedne

RE: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

Thanks for the review Jini. Thanks, Sharath -Original Message- From: Jini George Sent: Friday, December 08, 2017 2:42 PM To: Sharath Ballal; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands Looks good. Thanks, Jini

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

On 07/12/2017 16:55, Daniel D. Daugherty wrote: : Greetings, I have a small fix for a very intermittent ServerSocket related test failure:     JDK-8182307: Error during JRMP connection establishment     https://bugs.openjdk.java.net/browse/JDK-8182307 : For the gory details of the reasons fo

RFR(S): 8192978: Missing checks and small fixes in jdwp library

Hi, this is a new webrev for 8192978. This change now only contains the coverity fixes. In detail: src/jdk.jdwp.agent/share/native/libjdwp/VirtualMachineImpl.c, static void writePaths(PacketOutputStream *out, char *string): strchr could be called with NULL argument because of assignment pos

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

On 12/8/17 4:28 AM, Alan Bateman wrote: On 07/12/2017 16:55, Daniel D. Daugherty wrote: : Greetings, I have a small fix for a very intermittent ServerSocket related test failure:     JDK-8182307: Error during JRMP connection establishment     https://bugs.openjdk.java.net/browse/JDK-8182307

RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Hi, Here's a proposal to clean up the usage of the JDWP header size within the source code of libjdwp. Bug: https://bugs.openjdk.java.net/browse/JDK-8193258 WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193258.0/ As for inStream.c, I'm wondering wether inStream_endOfInput shall be remove

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

+1 Thanks for cleaning this up. Chris On 12/8/17 12:12 PM, serguei.spit...@oracle.com wrote: Hi Christoph, The fix looks good to me. What tests did you run? On 12/8/17 07:07,

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Hi Christoph, The fix looks good to me. What tests did you run? On 12/8/17 07:07, Langer, Christoph wrote: Hi,   Here’s a proposal to clean up the usage of the JDWP header size withi

Re: RFR(S): 8192978: Missing checks and small fixes in jdwp library

Hi Christoph, On 12/8/17 5:48 AM, Langer, Christoph wrote: Hi,   this is a new webrev for 8192978. This change now only contains the coverity fixes.   In detail: src/jdk.jdwp.agent/sha

RE: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Hi Serguei, I did only run hotspot/jtreg/serviceability/jdwp, didn’t find a lot more in that area. I’m hoping/waiting for Chris’ tests then. I agree, I will then remove inStream_endOfInput. If something like that is needed for future developments, it can easily be added again. Best regards Ch

RE: RFR(S): 8192978: Missing checks and small fixes in jdwp library

Thanks in advance, Chris, for testing. Please let me know the outcome when you are done. Best regards Christoph From: Chris Plummer [mailto:chris.plum...@oracle.com] Sent: Freitag, 8. Dezember 2017 21:52 To: Langer, Christoph ; serviceability-dev@openjdk.java.net Cc: Lindenmaier, Goetz Subject

Re: RFR(S): 8192978: Missing checks and small fixes in jdwp library

All testing passed. thanks, Chris On 12/8/17 1:07 PM, Langer, Christoph wrote: Thanks in advance, Chris, for testing.   Please let me know the outcome when you are

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Hi Christoph, You need to run at least the jdk/com/sun/jdi tests. Thanks, Serguei On 12/8/17 13:07, Langer, Christoph wrote: Hi Serguei,   I did only run hotspot/jtreg/ser

Re: RFR(S): 8192978: Missing checks and small fixes in jdwp library

Hi Christoph, This looks good. Please, do not forget to run the jtreg jdk/com/sun/jdi tests for fixes in the debugger agent library. Thanks, Serguei On 12/8/17 05:48, Langer, Christoph wrote:

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Hi Chris, Thank you, Chris for doing this. In general, it is still a good idea for Christoph to always run the com/sun/jdi tests locally. The hotspot/jtreg/serviceability/jdwp tests do not provide a complete coverage. Thanks, Serg

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

I think I ran everything svc related. I did the following open/test/hotspot/jtreg/:hotspot_serviceability open/test/jdk/:jdk_svc Plus the closed equivalents and all our other closed svc test lists. Chris On 12/8/17 9:2

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Yes, those are covered by :jdk_svc, but he should also run them first. Chris On 12/8/17 9:56 PM, serguei.spit...@oracle.com wrote: Hi Chris, Thank you, Chris for doing this. In general, it is still a good ide

Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE

Right. Thanks, Serguei On 12/8/17 22:14, Chris Plummer wrote: Yes, those are covered by :jdk_svc, but he should also run them first. Chris On 12/8/17 9:56 PM, serguei.spit...@oracle.co