Changeset: c760f78e0a53
Author:stefank
Date: 2010-12-01 15:04 +0100
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c760f78e0a53
7003125: precompiled.hpp is included when precompiled headers are not used
Summary: Added an ifndef DONT_USE_PRECOMPILED_HEADER to
Changeset: e7ad5f6f4d29
Author:stefank
Date: 2010-12-15 05:43 -0800
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e7ad5f6f4d29
7006659: temporary adlc files are added to the build variables
Summary: Don't recurse into sub-directories when looking for source files.
Here's a fix for a simple copy-n-past bug in the handling of
annotations, affecting only class redefinition.
http://cr.openjdk.java.net/~stefank/7022100/webrev.00/
7022100: Method annotations are incorrectly set when redefining classes
Summary: Changed to the correct annotation arrays
Changeset: 34e2e90e7182
Author:rbackman
Date: 2012-01-24 14:48 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/34e2e90e7182
7130476: Remove use of #ifdef TRACE_DEFINE_KLASS_TRACE_ID from klass.hpp
Reviewed-by: kamg, phh, dsamersoff
Contributed-by: Rickard Backman
On 2012-01-27 14:30, David Holmes wrote:
On 27/01/2012 11:12 PM, Stefan Karlsson wrote:
Here's a fix for a simple copy-n-past bug in the handling of
annotations, affecting only class redefinition.
http://cr.openjdk.java.net/~stefank/7022100/webrev.00/
7022100: Method annotations
Changeset: 26a08cbbf042
Author:stefank
Date: 2012-01-27 13:46 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/26a08cbbf042
7022100: Method annotations are incorrectly set when redefining classes
Summary: Changed to the correct annotation arrays
Reviewed-by: kamg,
Changeset: 35431a769282
Author:stefank
Date: 2012-12-20 10:22 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/35431a769282
8004823: Add VM support for type annotation reflection
Reviewed-by: dholmes, coleenp
Contributed-by: joel.fra...@oracle.com
!
http://cr.openjdk.java.net/~stefank/8006506/webrev.00/
This test provokes the JVM crash described in bug: JDK-7174978.
I intend to push this to:
http://hg.openjdk.java.net/jdk8/tl/jdk
thanks,
StefanK
http://cr.openjdk.java.net/~stefank/8006506/webrev.02
After some feedback from Alan Bateman, I've updated to how the java
classes are compiled, to match the behavior of similar jtreg tests.
thanks,
StefanK
On 01/22/2013 02:11 PM, Stefan Karlsson wrote:
http://cr.openjdk.java.net/~stefank
http://cr.openjdk.java.net/~stefank/7140852/webrev.00/
This test provoked the bug in:
7022100: Method annotations are incorrectly set when redefining classes
thanks,
StefanK
to propagate up to jdk8/tl.
thanks,
StefanK
Thanks!!
Coleen
On 1/22/2013 8:11 AM, Stefan Karlsson wrote:
http://cr.openjdk.java.net/~stefank/8006506/webrev.00/
This test provokes the JVM crash described in bug: JDK-7174978.
I intend to push this to:
http://hg.openjdk.java.net/jdk8/tl/jdk
thanks
to be doRedefine as per Java coding
convention or is that a known variation?
Fixed. It was the name used in the test that I copied the code from.
http://cr.openjdk.java.net/~stefank/7140852/webrev.01/
thanks,
StefanK
Thanks,
Coleen
On 01/22/2013 09:39 AM, Stefan Karlsson wrote:
http
, Stefan Karlsson wrote:
http://cr.openjdk.java.net/~stefank/7140852/webrev.00/
This test provoked the bug in:
7022100: Method annotations are incorrectly set when redefining classes
thanks,
StefanK
-22 14:11, Stefan Karlsson wrote:
http://cr.openjdk.java.net/~stefank/8006506/webrev.00/
This test provokes the JVM crash described in bug: JDK-7174978.
I intend to push this to:
http://hg.openjdk.java.net/jdk8/tl/jdk
thanks,
StefanK
On 2013-02-01 09:50, serguei.spit...@oracle.com wrote:
Ship it.
Thanks!
StefanK
Thanks,
Serguei
On 1/31/13 11:50 PM, Stefan Karlsson wrote:
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me
(but I'm not an expert
behavior is expected.
http://cr.openjdk.java.net/~stefank/8006506/webrev.04/
Tell me if you think this is good enough.
thanks,
StefanK
Thanks,
Sergueri
On 2/1/13 12:13 AM, Stefan Karlsson wrote:
http://cr.openjdk.java.net/~stefank/8006506/webrev.03/
1) Reverted the ProblemList change, since
On 2013-02-01 12:11, serguei.spit...@oracle.com wrote:
On 2/1/13 1:57 AM, Stefan Karlsson wrote:
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug and the test are non-trivial, it'd make sense to
add a comment
On 2013-02-01 12:17, Stefan Karlsson wrote:
On 2013-02-01 12:11, serguei.spit...@oracle.com wrote:
On 2/1/13 1:57 AM, Stefan Karlsson wrote:
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug and the test are non
, Stefan Karlsson wrote:
On 2013-02-01 12:17, Stefan Karlsson wrote:
On 2013-02-01 12:11, serguei.spit...@oracle.com wrote:
On 2/1/13 1:57 AM, Stefan Karlsson wrote:
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug
Changeset: c6d77b2b4478
Author:stefank
Date: 2013-01-22 13:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6d77b2b4478
8006506: Add test for redefining methods in backtraces to java/lang/instrument
tests
Reviewed-by: sspitsyn, coleenp
+
Changeset: 470232a8e89d
Author:stefank
Date: 2013-03-22 15:01 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470232a8e89d
8005116: NPG: Rename -permstat option for jmap in jdk8 to -clstats
Reviewed-by: jmasa, sla
Contributed-by: Erik Helin erik.he...@oracle.com
!
Seems reasonable.
StefanK
On 03/25/2013 10:17 PM, Erik Gahlin wrote:
Hi,
Could you please review these small metadata changes for the event
tracing framework:
- Promotion Failed - objectCount has the datatype BYTES64, which
implies that it is a size. It is not, and the type should be an
Looks good.
StefanK
On 03/25/2013 09:13 PM, Erik Gahlin wrote:
Hi,
Could you please review this small change to the metadata for
StackTrace content type, used by the event tracing framework. A
boolean flag has been added so it's possible to see if a stack trace
has been truncated (not all
Hi Coleen,
Good to see all these oops moving to the mirrors. I think the changes
look good. I let someone else review the SA changes
Some comments below:
On 05/21/2013 12:39 AM, Coleen Phillimore wrote:
Summary: Inject protection_domain, signers, init_lock into
java_lang_Class
Net
On 21 maj 2013, at 16:12, Coleen Phillimore coleen.phillim...@oracle.com
wrote:
On 05/21/2013 05:11 AM, Stefan Karlsson wrote:
Hi Coleen,
Good to see all these oops moving to the mirrors. I think the changes look
good. I let someone else review the SA changes
Yes, I'm hoping
On 6/20/13 4:14 PM, Erik Gahlin wrote:
Hi,
Could I have a review of these small metadata changes for event
tracing, most importantly the split of the ParallelScavangeHeapSummary
event name..
http://cr.openjdk.java.net/~mgronlun/8016331/webrev01/
Looks good.
StefanK
Thanks in advance
Changeset: 4c84d351cca9
Author:stefank
Date: 2013-08-16 13:22 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4c84d351cca9
8007074: SIGSEGV at ParMarkBitMap::verify_clear()
Summary: Replace the broken large pages implementation on Linux. New flag:
On 9/12/13 9:21 PM, serguei.spit...@oracle.com wrote:
On 9/11/13 8:54 PM, David Holmes wrote:
Hi Dmitry,
It seems odd that you install the new_method even if there was an
exception. What if the new_method is not valid because of the
exception ?
Coleen suggested this fragment.
New methods
Changeset: b606775fd1a3
Author:stefank
Date: 2013-08-29 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3
8014659: NPG: performance counters for compressed klass space
Reviewed-by: jmasa, sla
Contributed-by: erik.he...@oracle.com
!
http://cr.openjdk.java.net/~stefank/8025996/webrev.00
Previously, the Metaspace memory usage was only tracked at the end of
the GCs. This causes the MemoryPoolMXBean.getUsageThreshold(…)
functionality to fail for the Metaspace memory pools. This patch adds
tracking of Metaspace usage when a
Please, review this test fix.
http://cr.openjdk.java.net/~stefank/7196801/webrev.00/
Most of the fix was implemented by Coleen, I've only done some small
tweaks and updated some comments.
The fix depends on these changes:
JDK-8025996 Track metaspace usage when metaspace is expanded
this thinking it has a corrupted constant
pool again.
OK. I though that was old debugging left-overs.
New webrev:
http://cr.openjdk.java.net/~stefank/7196801/webrev.01/
thanks,
StefanK
Thanks,
Coleen
On 10/11/2013 1:33 PM, Stefan Karlsson wrote:
Please, review this test fix.
http
On 10/11/13 8:04 PM, Coleen Phillimore wrote:
Looks good.
Thanks, Coleen.
StefanK
Thanks!
Coleen
On 10/11/2013 2:02 PM, Stefan Karlsson wrote:
On 10/11/13 7:44 PM, Coleen Phillimore wrote:
Stefan,
I added a check about the count exceeding 1 000 000 because it
causes the test
2013, at 20:02, Stefan Karlsson stefan.karls...@oracle.com
mailto:stefan.karls...@oracle.com wrote:
On 10/11/13 7:44 PM, Coleen Phillimore wrote:
Stefan,
I added a check about the count exceeding 1 000 000 because it
causes the test to create an invalid class file. With the shell
script
Changeset: f15a0087181e
Author:stefank
Date: 2013-10-14 14:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e
7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2
Reviewed-by: coleenp, sla
Contributed-by: stefan.karls...@oracle.com,
On 2013-10-16 18:09, Erik Helin wrote:
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop detector.
Instead of registering the oop as an unhandled oop, which would have
worked, I decided to wrap the oop in a handle
On 10/17/13 4:02 PM, Fredrik Arvidsson wrote:
Hi
I have added a new revision of my changes here:
http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.02/
http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.02/
I haven't looked at the patch i great detail, but I found this
Hi Markus,
On 2014-04-24 17:42, Markus Grönlund wrote:
Greetings,
Kindly asking for reviews for the following very small fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8041723
Webrev: http://cr.openjdk.java.net/~mgronlun/8041723/webrev01/
Jon suggested that I should add -Xincgc.
Here's the updated webrev:
http://cr.openjdk.java.net/~stefank/8055111/webrev.01/
thanks,
StefanK
On 2014-08-14 14:04, Stefan Karlsson wrote:
Hi all,
Please, review this patch to add -Xconcgc to the set of flags to be
filtered out
On 2014-08-19 12:51, Staffan Larsen wrote:
Looks good!
Thanks!
StefanK
Thanks,
/Staffan
On 19 aug 2014, at 12:25, Stefan Karlsson stefan.karls...@oracle.com wrote:
Hi all,
Please review this patch harden two MemoryMXBean tests. These tests cause
intermittent test failures when
Hi all,
Please review this patch to put the LowMemoryTest.java test in the
ProblemLists.txt. It currently hangs and leaves processes running after
the test run has completed.
http://cr.openjdk.java.net/~stefank/8056143/webrev.00/
thanks,
StefanK
Thanks.
StefanK
On 27/08/14 10:48, Chris Hegarty wrote:
Reviewed.
-Chris.
On 27/08/14 09:48, Stefan Karlsson wrote:
Hi all,
Please review this patch to put the LowMemoryTest.java test in the
ProblemLists.txt. It currently hangs and leaves processes running after
the test run has completed
I revoke this RFR. Bengt pointed out that I shouldn't use 8056143 to
updated the problem list. I've created a new bug JDK-8056148 and will
send out a new RFR.
thanks,
StefanK
On 27/08/14 10:48, Stefan Karlsson wrote:
Hi all,
Please review this patch to put the LowMemoryTest.java test
Hi all,
Please review this patch to put the LowMemoryTest.java test in the
ProblemLists.txt. It currently hangs and leaves processes running after
the test run has completed.
http://cr.openjdk.java.net/~stefank/8056148/webrev.00/
thanks,
StefanK
Hi all,
Please review this patch to make these tests a bit more stable. I've
changed the code to always allocate objects that are larger than the
young gen size.
http://cr.openjdk.java.net/~stefank/8057174/webrev.00/
I've tested this by running the tests through jprt.
thanks,
StefanK
Hi Daniel,
On 2014-09-04 16:58, Daniel Fuchs wrote:
Looks good Stefan!
Thanks a lot for reviewing.
I realized that I need to do some extra hardening so I'll have to send
out an updated version of the test.
thanks,
StefanK
best regards,
-- daniel
On 9/4/14 4:34 PM, Stefan Karlsson
(Adding GC)
Hi,
Could I get a couple of reviews for this test fix?
StefanK
On 2014-09-05 14:01, Stefan Karlsson wrote:
Hi all,
Here's an updated version of the test:
http://cr.openjdk.java.net/~stefank/8057174/webrev.01.delta/
http://cr.openjdk.java.net/~stefank/8057174/webrev.01/
1
://cr.openjdk.java.net/~stefank/8057174/webrev.02
and have restarted the test runs.
thanks,
StefanK
Other than that the change looks fine.
-JB-
On 09/09/2014 01:45 PM, Stefan Karlsson wrote:
(Adding GC)
Hi,
Could I get a couple of reviews for this test fix?
StefanK
On 2014-09-05 14:01, Stefan
On 2014-09-09 14:49, Daniel Fuchs wrote:
Hi,
Looks good to me - although I'm not a specialist of -XX options ;-)
:)
Thanks, Daniel.
StefanK
-- daniel
On 9/9/14 2:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav
On 2014-09-09 16:19, Jaroslav Bachorik wrote:
Thumbs up!
Thanks.
StefanK
-JB-
On 09/09/2014 02:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bachorik wrote:
Hi Stefan,
* test/java/lang/management/MemoryMXBean
On 2014-11-19 15:28, Markus Grönlund wrote:
Greetings,
Kindly asking for reviews for the following changeset to clean up the
usage of the INCLUDE_TRACE define:
Bug: https://bugs.openjdk.java.net/browse/JDK-8065361
Webrev: http://cr.openjdk.java.net/~mgronlun/8065361/webrev01/
On 2015-01-08 20:15, Chris Plummer wrote:
Hi Stefan,
Comments inline below:
On 1/8/15 2:50 AM, Stefan Karlsson wrote:
Hi Chris,
On 2015-01-08 00:29, Chris Plummer wrote:
Hi,
Please review the following changes for the addition of the
VM.class_hierarchy DCMD. Please read the bug first
Hi Chris,
On 2015-01-08 00:29, Chris Plummer wrote:
Hi,
Please review the following changes for the addition of the
VM.class_hierarchy DCMD. Please read the bug first for some background
information.
Webrev: http://cr.openjdk.java.net/~cjplummer/8054888/webrev.00/
Bug:
Hi,
Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS.
http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8078601
This code in thread.cpp is guarded by INCLUDE_ALL_GCS:
#if INCLUDE_ALL_GCS
// Dump concurrent locks
Looks good.
StefanK
On 2016-04-13 07:50, Robbin Ehn wrote:
Hi all,
Please review this bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154064
Test with tonga. (the 5 crashed tonga test no longer crashes)
Thanks!
/Robbin
diff -r 4823056a5bbd src/share/vm/prims/jvmtiExport.cpp
---
Looks good.
StefanK
On 2016-04-08 10:08, Robbin Ehn wrote:
Hi all,
Please review,
Webrev: http://cr.openjdk.java.net/~rehn/8153731/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153731
Tested with internal vm test (inc a new test for just this).
Thanks!
/Robbin
Hi Marcus,
On 23/03/16 11:59, Marcus Larsson wrote:
Hi Stefan,
On 03/23/2016 11:00 AM, Stefan Karlsson wrote:
Hi Marcus,
On 2016-03-23 10:23, Marcus Larsson wrote:
Hi,
Please review the following patch to fix the issue where duplicate
tagsets are created for the same logical tagset
Hi all,
Please, review this patch to optimize the log_is_enabled check in the
Unified Logging framework.
http://cr.openjdk.java.net/~stefank/8152538/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8152538
The following code:
void logLine() {
log_debug(gc)("logLine");
}
expands
Hi Robbin,
On 2016-03-23 14:50, Robbin Ehn wrote:
Hi all,
After more input, this is the current version.
Please have a look.
Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/
Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/
Looks good to me.
It's non-obvious why you
Looks good.
StefanK
On 2016-04-04 17:09, Robbin Ehn wrote:
Hi all,
Please review,
Webrev: http://cr.openjdk.java.net/~rehn/8153396/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153396
Tested with internal vm test.
Thanks!
/Robbin
Hi Ramki and Jon,
What's the status of this review thread? The bug is still open and
targeted for JDK 9.
Thanks,
StefanK
On 2015-06-03 08:15, Srinivas Ramakrishna wrote:
Thanks Jon for the review and the pointer to the test. I'll get back
to you later this week with a suitable test.
--
Hi Robbin,
This looks good to me. This breaks gc nightly and is a fairly trivial
change, so I'll push this right away.
Thanks,
StefanK
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug:
MemoryTestZGC.sh test, that calls MemoryTest 1
1 and explains that ZGC has one memory manager and one heap memory pool?
Thanks,
StefanK
Mandy
On 5/31/18 6:53 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http
On 2018-05-31 19:04, mandy chung wrote:
On 5/31/18 10:01 AM, Stefan Karlsson wrote:
Hi Mandy,
On 2018-05-31 18:44, mandy chung wrote:
Hi Stefan,
I think a better fix is to find another operation that will throw an
exception. ThreadMXBean::getThreadInfo throws IAE and it can
Thanks, Erik.
StefanK
On 2018-05-31 16:27, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2018-05-31 15:38, Stefan Karlsson wrote:
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http
with the other GCs.
Does this sound reasonable?
Thanks,
StefanK
Mandy
On 5/31/18 6:38 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http://cr.openjdk.java.net/~stefank/8204170/webrev.01/
https
On 2018-05-31 20:09, mandy chung wrote:
On 5/31/18 10:36 AM, Stefan Karlsson wrote:
Hi Mandy,
On 2018-05-31 18:19, mandy chung wrote:
Hi Stefan,
This change looks okay. Can you add a comment to describe the
expected memory pools for ZGC so that it explains why the min number
of heap
Thanks, Erik.
StefanK
On 2018-05-31 16:26, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2018-05-31 15:53, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank/8204173/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8204173
Just like the comment in the test says:
* NOTE: This expected result is hardcoded in
Looks good.
StefanK
On 2018-02-23 02:16, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8198585
http://cr.openjdk.java.net/~cjplummer/8198585/webrev.00/webrev/
Before removing ServiceUtil::visible_oop(), I want to make sure it
really isn't
Looks good to me.
StefanK
On 2018-03-20 01:48, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8195109
http://cr.openjdk.java.net/~cjplummer/8195109/webrev.00/index.html
The assert I added to make sure this is safe has been in place in
Looks good.
StefanK
On 2018-03-20 20:39, Chris Plummer wrote:
Hi,
New webrev:
http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html
There was a build failure on solaris-sparc in threadSMR.cpp. References
to the Copy class were producing "unresolved symbol" errors.
Looks good.
StefanK
On 2019-03-25 10:59, Per Liden wrote:
Clean up serviceability/sa/TestUniverse.java to remove the need for the
withZ/withoutZ option we currently pass in. This also changes the test
to only run with the selected GC instead of testing all GCs every time,
which should save
Looks good!
StefanK
On 2019-04-08 03:49, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8221584
webrev: http://cr.openjdk.java.net/~dholmes/8221584/webrev/
I'm really just sponsoring this fix as the problem was diagnozed by
Robbin Ehn and Stefan Karlsson - thanks guys
Hi all,
Please review this patch to ProblemList
serviceability/sa/TestJmapCoreMetaspace.java
https://cr.openjdk.java.net/~stefank/8219571/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8219571
Original bug:
https://bugs.openjdk.java.net/browse/JDK-8219443
Thanks,
StefanK
Thanks, Igor!
StefanK
On 2019-02-22 22:02, Igor Ignatyev wrote:
Hi Stefan,
LGTM.
-- Igor
On Feb 22, 2019, at 1:00 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to ProblemList
serviceability/sa/TestJmapCoreMetaspace.java
https://cr.openjdk.java.net/~stefank/8219571/webrev
Thanks, Serguei!
StefanK
On 2019-03-12 22:50, serguei.spit...@oracle.com wrote:
Hi Stefan,
The fix looks good to me.
Testing the tiers 1-7 for different GC's has to be good enough.
Thanks,
Serguei
On 3/12/19 8:19 AM, Stefan Karlsson wrote:
Hi all,
Please review and/or comment
On 2019-03-14 10:21, Erik Helin wrote:
On 12 Mar 2019, at 16:19, Stefan Karlsson wrote:
Hi all,
Hey StefanK,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::collect_simple_roots.
http://cr.openjdk.java.net/~stefank
Hi all,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::collect_simple_roots.
http://cr.openjdk.java.net/~stefank/8220342/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8220342
Thanks, Yasumasa!
StefanK
On 2019-02-15 01:54, Yasumasa Suenaga wrote:
Hi Stefan,
Both changes look good to me!
Thanks,
Yasumasa
2019年2月15日(金) 2:12 Stefan Karlsson :
Hi again,
I've separated the live regions iteration refactoring into this patch:
https://cr.openjdk.java.net/~stefank
Thanks, Erik.
StefanK
On 2019-02-18 10:35, Erik Österlund wrote:
Hi Stefan,
Looks good!
Thanks,
/Erik
On 2019-02-15 20:25, Stefan Karlsson wrote:
Testing showed that the re-enabling of the retiring of TLABs was
broken. This has been fixed with this patch:
http://cr.openjdk.java.net
Hi Jini,
On 2019-02-13 05:53, Jini George wrote:
Hi Stefan,
Looks good to me. Nits: pls do change the copyright year.
Thanks for reviewing. I'll update the copyright years.
Thanks,
StefanK
Thanks,
Jini.
On 2/11/2019 6:06 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch
Hi all,
Please review / comment on this patch to enable a best-effort live heap
region iteration implementation in ZGC.
http://cr.openjdk.java.net/~stefank/8218922/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218922
The SA has functionally that relies on live heap region information
Thanks, Erik.
Stefank
On 2019-02-14 09:38, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2019-02-11 09:13, Stefan Karlsson wrote:
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs
Thanks, Erik.
Stefank
On 2019-02-14 10:11, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2019-02-11 13:36, Stefan Karlsson wrote:
Hi all,
Please review this patch to add support for large bitmaps in the SA.
http://cr.openjdk.java.net/~stefank/8218743/webrev.01/
https
.
StefanK
Thanks,
/Erik
On 2019-02-11 09:39, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https://cr.openjdk.java.net/~stefank/8218734/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218734
Before this patch
Thanks, Erik.
Stefank
On 2019-02-14 09:19, Erik Österlund wrote:
Hi Stefan,
This looks good and trivial.
Thanks,
/Erik
On 2019-02-11 08:47, Stefan Karlsson wrote:
Hi all,
I propose this simple change to use the concrete class as the return
type of VMObjectFactory.newObject.
https
Thanks, Erik.
Stefank
On 2019-02-14 09:26, Erik Österlund wrote:
Hi Stefan,
Given that the remark from Jini is fixed, this looks good. I don't need
another webrev.
Thanks,
/Erik
On 2019-02-11 19:09, Stefan Karlsson wrote:
Hi Jini,
On 2019-02-11 19:00, Jini George wrote:
Hi Stefan
do that or not.
Otherwise looks good. Don't need another webrev.
I'll fix. Thanks for reviewing.
StefanK
Thanks,
/Erik
On 2019-02-11 14:55, Stefan Karlsson wrote:
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC in
the SA.
http://cr.openjdk.java.net/~stefank/8218
this further at some point in the future
to deal with broken Klass pointers better.
Thanks,
/Erik
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live
heap region iteration implementation in ZGC.
http://cr.openjdk.java.net
://cr.openjdk.java.net/~stefank/8218978/webrev.01/
I'm currently rerunning the tests to see that the latest changes didn't
break anything.
Thanks,
StefanK
Thanks,
Yasumasa
On 2019/02/13 23:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live heap
If this patch is accepted we also need this patch to turn on the SA
hprof implementation:
http://cr.openjdk.java.net/~stefank/8218970/webrev.01/
StefanK
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live heap
region
Thanks!
Jini.
On 2/11/2019 7:25 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC
in the SA.
http://cr.openjdk.java.net/~stefank/8218746/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218746
ZGC uses a 16TB virtual memory address
. The copyright year for some of the files need updation.
Sure.
This looks good to me otherwise.
Thanks for reviewing.
StefanK
Thanks,
Jini.
On 2/11/2019 2:09 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https
Hi again,
I've separated the live regions iteration refactoring into this patch:
https://cr.openjdk.java.net/~stefank/8219003/webrev.01/
And use this RFE for the ZGC specific parts:
https://cr.openjdk.java.net/~stefank/8218922/webrev.02/
Thanks,
StefanK
On 2019-02-14 14:39, Stefan Karlsson
On 2019-02-13 17:12, coleen.phillim...@oracle.com wrote:
On 2/13/19 10:40 AM, Stefan Karlsson wrote:
On 2019-02-13 14:40, coleen.phillim...@oracle.com wrote:
On 2/11/19 3:39 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the
(VM
/2019 1:23 PM, Stefan Karlsson wrote:
Hi all,
Please review this small patch to resolve ZPageAllocator::_physical
as a value object instead of a pointer.
https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218732
This fixes the Heap Parameters vie
Hi all,
Please review this small patch to resolve ZPageAllocator::_physical as a
value object instead of a pointer.
https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218732
This fixes the Heap Parameters view.
Thanks,
StefanK
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs to provide
their own implementations.
https://cr.openjdk.java.net/~stefank/8218733/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218733
This was found
Hi all,
I propose this simple change to use the concrete class as the return
type of VMObjectFactory.newObject.
https://cr.openjdk.java.net/~stefank/8218731/webrev.01
https://bugs.openjdk.java.net/browse/JDK-8218731
This allows us to specify the class only once when calling newObject.
For
1 - 100 of 206 matches
Mail list logo
