Thanks Serguei & Alan for the reviews.
Amit
From: Serguei Spitsyn
Sent: Tuesday, October 30, 2018 12:53 AM
To: Alan Bateman; Amit Sapre; serviceability-dev@openjdk.java.net
Subject: Re: RFR : JDK-8211951 - Broken links in java.management files
Hi Amit,
+1
Thanks,
Serguei
On 10/2
Hello,
Please review the docs fixes for broken links.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8211951
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8211951/00/webrev/
Thanks,
Amit
Ping.
Do review the changes.
From: Amit Sapre
Sent: Tuesday, April 03, 2018 3:38 PM
To: serviceability-dev@openjdk.java.net
Subject: RFR : JDK-8042215 -
javax/management/remote/mandatory/connection/ReconnectTest.java
NoSuchObjectException no such object in table
Hello,
Please
Hello,
Please review changes for refactored test case
As part of refactoring,
1) Removed iiop & jmxmp protocol related code
2) Added exception handling during connector connection.
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8042215/webrev.00/
Bug ID
Thanks Alan & mandy for reviews.
Amit
From: Alan Bateman
Sent: Friday, March 23, 2018 9:54 PM
To: Amit Sapre; Mandy Chung; serviceability-dev@openjdk.java.net;
compiler-...@openjdk.java.net
Subject: Re: RFR : JDK-8071367 - JMX: Remove SNMP support
On 23/03/2018 10:43, Amit Sapre w
Thanks all for the inputs.
This webrev addresses the inputs :
http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.02/
Amit
From: mandy chung
Sent: Thursday, March 22, 2018 11:15 PM
To: Alan Bateman; Amit Sapre
Cc: serviceability-dev@openjdk.java.net; compiler
, March 09, 2018 1:33 AM
To: Alan Bateman; Amit Sapre
Cc: serviceability-dev@openjdk.java.net; compiler-...@openjdk.java.net
Subject: Re: RFR : JDK-8071367 - JMX: Remove SNMP support
On 3/7/18 11:46 PM, Alan Bateman wrote:
On 08/03/2018 07:27, Amit Sapre wrote:
Hello,
Please review
Hello,
Please review the changes for removing SNMP support.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.00
Thanks,
Amit
ions to this bug for further reference, in case
we hit another timeout issue.
Thanks,
Amit
> -Original Message-
> From: David Holmes
> Sent: Thursday, January 11, 2018 12:39 PM
> To: Amit Sapre; Harsha wardhana B; serviceability-dev@openjdk.java.net
> Subject: Re: RFR
Hello,
Ping. Can somebody review this code changes ?
Thanks,
Amit
From: Amit Sapre
Sent: Wednesday, January 03, 2018 5:54 PM
To: Harsha wardhana B; serviceability-dev@openjdk.java.net
Subject: RE: RFR : JDK-8175542 - JMX: Not enough JDP packets received
Thanks Harsha
was declared failed because of time-out.
One possible fix would be to change line 80 to,
if (shouldContinue() && hasTestLivedLongEnough())
Thanks
Harsha
On Wednesday 13 December 2017 11:03 AM, Amit Sapre wrote:
Hello,
Please review the timeout fix for this bug.
Hello,
Please review the timeout fix for this bug.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8175542
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8175542/webrev.00/
Thanks,
Amit
Hello,
Please review this trival fix for removing test case from ProblemList.txt file.
The Test case got updated from other changeset
http://hg.openjdk.java.net/jdk/hs/rev/bc1cffa26561
But was not removed from ProblemList.txt.
Bug id :
Hi,
Please review the doc changes for removing technotes links
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8181895
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8181895/webrev.00/
Thanks,
Amit
Hello,
Please review this trivial fix to StartManagementAgent test case.
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8179700/webrev.00/
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8179700
Thanks,
Amit
Hello,
Please review this javadoc updates for java.lang.management.LockInfo class.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8176204
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8176204/webrev.00/
Thanks,
Amit
Hello,
http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-7132577/webrev.02/ has the
updated changes.
I ran this test on my VM and roughly takes 250-300 ms to get all the listener
count.
Thanks,
Amit
> -Original Message-
> From: Amit Sapre
> Sent: Thursday, February 23, 2017
least
> that way we can see what the values are when we timeout, and also if
> they have been changing.
>
> Thanks,
> David
>
> > Regards
> >
> > Harsha
> >
> >
> > On Wednesday 22 February 2017 03:29 PM, Amit Sapre wrote:
> >>
> >> Hel
Hello,
Please review this test bug fix which eliminates test case's own timeout
mechanism to default jtreg timeout.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-7132577
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-7132577/webrev.00/
Thanks,
Amit
Hello,
Please review minor improvements to jdp test helper class to handle error
conditions.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174915
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174915/webrev.00/
Thanks,
Amit
Thanks Daniel & Erik for the review
From: Erik Gahlin
Sent: Tuesday, February 14, 2017 5:52 PM
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR : JDK-8174196 : sun/management/jdp tests are not running
properly
Looks good.
Erik
Hello,
Please review following test case fix
Hello,
Please review following test case fix
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174196
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174196/webrev.00/
Thanks,
Amit
Thanks for the review Roger !
From: Roger Riggs
Sent: Friday, January 20, 2017 1:49 AM
To: Amit Sapre; serviceability-dev@openjdk.java.net
Cc: Harsha Wardhana B; Dmitry Samersoff
Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0"
instead of assigned port
Hi,
I updated the parsing logic for extracting port number in test case. Here is
the updated webrev :
http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8167337/webrev.01/
Thanks,
Amit
> -Original Message-
> From: Amit Sapre
> Sent: Wednesday, January 18, 2017 2:09 PM
> To:
gt; int slash = jmxurl.indexOf('/', colon); int port =
> >> Integer.parseInt(jmxurl, colon + 1, slash, 10);
> >>
> >>>
> >>> String portStr = jmxurl.substring(0,jmxurl.indexOf('/'));
> >>> int port = Integer.parseInt(portStr);
> >>>
t;:" character first
will
bring out all these uncertainties. That's the reason , I first split with "/",
whose count is constant for either form of jmx url.
So accessing token[6] will always give the substring containing remote port.
Amit
> -Original Message-
> From:
Thanks Dmitry for the review.
Can I have one more reviewer for this fix ?
Thanks,
Amit
> -Original Message-
> From: Dmitry Samersoff
> Sent: Sunday, January 15, 2017 4:49 PM
> To: Amit Sapre; serviceability-dev
> Subject: Re: RFR : JDK-8167337 - When jmxremote.port=0,
Hello,
Please review the fix for JDK-8167337
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8167337
Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8167337/webrev.00/
Thanks,
Amit
Thanks Fred for the review.
> -Original Message-
> From: Frederic Parain
> Sent: Wednesday, November 02, 2016 8:44 PM
> To: Amit Sapre; David Holmes; serviceability-dev
> Subject: Re: RFR - JDK-8006078 : [findbugs]
> java.lang.management.ThreadInfo returns mutable objec
Hello,
Can I have one more review for these changes ?
> -Original Message-
> From: David Holmes
> Sent: Saturday, October 29, 2016 12:22 AM
> To: Amit Sapre; serviceability-dev
> Subject: Re: RFR - JDK-8006078 : [findbugs]
> java.lang.management.ThreadInfo returns mutab
Hello,
Summary : Fixed findbugs reported warnings.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8006078
Webrev : http://cr.openjdk.java.net/~asapre/webrev/JDK-8006078/webrev.00/
Thanks,
Amit
> Sent: Tuesday, October 25, 2016 3:24 AM
> To: Amit Sapre
> Cc: serviceability-dev; Daniel Fuchs; David Holmes
> Subject: Re: RFR : JDK-8151099 :
> java.lang.management.ManagementFactory.getPlatformMXBeans() should work
> even if jdk.management is not present.
>
>
> > On
David Holmes
> Cc: Amit Sapre; serviceability-dev; Daniel Fuchs
> Subject: Re: RFR : JDK-8151099 :
> java.lang.management.ManagementFactory.getPlatformMXBeans() should work
> even if jdk.management is not present.
>
>
> > On Jul 14, 2016, at 8:55 AM, David Holmes <david.ho
Alan,
I updated the description and changes are available in this webrev
http://cr.openjdk.java.net/~jgeorge/sponsorships/8167294/webrev.01/
Amit
From: Alan Bateman
Sent: Thursday, October 13, 2016 1:03 PM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR : 8167294 - MXBean
Hello,
Please review this small javadoc update.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8167294
Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8167294/webrev.00/
Thanks,
Amit
Thanks David & Daniel
Amit
-Original Message-
From: David Holmes
Sent: Thursday, September 08, 2016 3:21 PM
To: Amit Sapre; Stuart Marks; Daniel Fuchs; serviceability-dev
Subject: Re: RFR : JDK-8165579 - Add missing javadoc information for deprecated
API's.
On 8/09/2016 6:55 PM,
Hello,
All updated changes are part of this webrev
http://cr.openjdk.java.net/~sballal/sponsorship/8165579/webrev.01/
Thanks,
Amit
-Original Message-
From: Stuart Marks
Sent: Wednesday, September 07, 2016 11:02 PM
To: Amit Sapre
Cc: Daniel Fuchs; David Holmes; serviceability-dev
-
From: Daniel Fuchs
Sent: Wednesday, September 07, 2016 3:46 PM
To: David Holmes; Amit Sapre; serviceability-dev; Stuart Marks
Subject: Re: RFR : JDK-8165579 - Add missing javadoc information for deprecated
API's.
Hi Amit,
On 07/09/16 10:34, David Holmes wrote:
> Hi Amit,
>
> On 7/09/2
Hello,
Please review the changes for missing javadoc updates for deprecated API.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8165579
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8165579/webrev.00/
Thanks,
Amit
Thanks Alan for pointing this out. Incorporated your comments in this webrev
http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.01/
Thanks,
Amit
From: Alan Bateman
Sent: Thursday, September 01, 2016 1:46 PM
To: Amit Sapre; serviceability-dev
Subject: Re: PING: RFR : JDK
Gentle reminder !
From: Amit Sapre
Sent: Tuesday, August 30, 2016 11:33 AM
To: serviceability-dev
Subject: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to
RMIConnector.OISWL is never null.
Hello,
Please review this small code change
Hello,
Fixed the alignment problem as well. Here is the updated webrev.
http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.02/
Thanks,
Amit
-Original Message-
From: David Holmes
Sent: Tuesday, August 30, 2016 11:44 AM
To: Amit Sapre; serviceability-dev
Subject: Re: PING
Hello,
Please review this small code change and a new test case to validate the
changes.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8164730
Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.00/
Thanks,
Amit
Hello,
I made changes as David suggested. Here is the new webrev link
http://cr.openjdk.java.net/~jgeorge/sponsorships/8164609/webrev.01/
Thanks,
Amit
-Original Message-
From: David Holmes
Sent: Monday, August 29, 2016 11:57 AM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR
Thanks David for your inputs.
I like to go the cleanup way and made changes accordingly.
The new webrev is
http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.01/
Thanks,
Amit
-Original Message-
From: David Holmes
Sent: Wednesday, August 24, 2016 12:24 PM
To: Amit Sapre
Hello,
Please review a small test only change.
Bug id : https://bugs.openjdk.java.net/browse/JDK-8164609
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8164609/webrev.00/
PS : Based on triaging , it looked like a timing issue in test case, so the
proposed changes are done
From: Amit Sapre
Sent: Monday, August 22, 2016 2:39 PM
To: serviceability-dev
Subject: RFR : JDK-8066635 - Fix deprecation warnings in java.management module
Hello,
Please review changes for fixing deprecation warnings.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8066635
Hello,
Please review changes for fixing deprecation warnings.
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8066635
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8066635/webrev.00/
Amit
Guys,
I need one more person to review these changes. Kindly help with the review.
Thanks,
Amit
-Original Message-
From: David Holmes
Sent: Thursday, August 11, 2016 5:55 AM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR : JDK-8162530 :
src/jdk.management/share/native
are in this webrev.
http://cr.openjdk.java.net/~sballal/sponsorship/8162530/webrev.02/
Thanks,
Amit
-Original Message-
From: David Holmes
Sent: Wednesday, August 03, 2016 5:50 AM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR : JDK-8162530 :
src/jdk.management/share/native
Hello,
I have made changes as David suggested.
Here is the new webrev link.
http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.01/
Thanks,
Amit
-Original Message-
From: David Holmes
Sent: Monday, August 01, 2016 12:33 PM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR
Hello,
Please review JNI exception handling related changes.
Bug id : https://bugs.openjdk.java.net/browse/JDK-8162530
Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.00/
Thanks,
Amit
David,
Indeed it is a good to have fix. This API is only used by jdk.management
package.
Findbugs tool reported this could be potential bug. So made changes accordingly.
Amit.
-Original Message-
From: David Holmes
Sent: Monday, August 01, 2016 6:10 AM
To: Amit Sapre; serviceability-dev
Hello,
Please review this small fix.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8162524
Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162524/webrev.00/
Thanks,
Amit
Hello,
Please review this small fix.
Bug : https://bugs.openjdk.java.net/browse/JDK-8162702
Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162702/webrev.00/
Amit
Thanks Alan & Mandy for your review comments.
I will incorporate your comments and send a fresh review.
Amit
-Original Message-
From: Mandy Chung
Sent: Thursday, July 14, 2016 11:32 AM
To: David Holmes
Cc: Amit Sapre; serviceability-dev; Daniel Fuchs
Subject: Re: RFR : JDK-815
Hello,
Please review the javadoc update
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8158350
webrev : http://cr.openjdk.java.net/~hb/sponsorship/8158350/webrev.01/
Amit
Hello,
Please review the fix
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099
Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/
Amit
58 matches
Mail list logo
