On Tue, 23 Mar 2021 13:58:03 GMT, Andrew Haley wrote:
> > [ Back-porting this patch to JDK 11] depends on the will of openjdk11
> > maintainers to accept this (and few other, like jep-388, as we depend on
> > it) contribution.
>
> To the extent that 11u has fixed policies :) we definitely
On Tue, 23 Mar 2021 13:26:19 GMT, Anton Kozlov wrote:
>> Build changes still look good. Hope you can get this done now! :)
>
>> > No, no, no! I am not suggesting you change anything else, just that
>> > you do not define contentless macros. You might as well define it
>> > to be something, and
On Tue, 23 Mar 2021 09:54:16 GMT, Andrew Haley wrote:
> So, where are we up to now? Are we done yet?
Hello
we would like to get approval for the final version we have now and then
integrate this pr as soon as Mark will target it to jdk17
-
PR:
On Tue, 2 Mar 2021 08:12:10 GMT, Anton Kozlov wrote:
>> I wasn't able to replicate JDK-8020753 and JDK-8186286. So will remove these
>> workaround
>> @gerard-ziemski, 8020753 was originally your fix, do you know if it still
>> needed on intel-mac ?
>
> The x86_bsd still carries the workaround
On Thu, 4 Mar 2021 17:36:22 GMT, Alan Hayward
wrote:
> I was building this PR on a new machine, and I now get the following error:
>
> > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31:
> > error: cast to smaller integer type
On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/java.base/macosx/native/libjli/java_md_macosx.m line 210:
>
>> 208:
On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Mon, 15 Feb 2021 19:07:40 GMT, Andrew Haley wrote:
>> Hello, we have updated PR, now this bailout is used only by the code which
>> can handle it (native wrapper generator), for the rest it will cause
>> guarantee failed if this bailout is triggered
>
> This is when passing a float, yes? In
On Mon, 1 Feb 2021 18:44:48 GMT, Andrew Haley wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 62 commits:
>>
>> - Merge branch 'master' into jdk-macos
>> - Update copyright year for
On Tue, 2 Feb 2021 21:52:47 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 810:
>
>> 808: #ifdef
On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Tue, 2 Feb 2021 22:08:14 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 221:
>
>> 219:
On Tue, 2 Feb 2021 22:14:42 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486:
>
>> 484:
On Tue, 2 Feb 2021 22:12:07 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 435:
>
>> 433: //
On Thu, 4 Feb 2021 22:54:42 GMT, Gerard Ziemski wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 363:
>>
>>> 361: address pc = os::Posix::ucontext_get_pc(uc);
>>> 362:
>>> 363: if (pc != addr && uc->context_esr == 0x924F) { //TODO: figure
>>> out what this value
On Tue, 2 Feb 2021 22:07:15 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 195:
>
>> 193: frame
On Thu, 4 Feb 2021 21:59:02 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
only
> when necessary. But for now, I don't have a robust and maintainable solution
> for this, sorry.
> _Mailing list message from [erik.joelsson at
> oracle.com](mailto:erik.joels...@oracle.com) on
> [2d-dev](mailto:2d-...@openjdk.java.net):_
>
> On 2021-01-2
On Thu, 4 Feb 2021 14:27:53 GMT, Andrew Haley wrote:
> > > You read my mind, Andrew. Unless, of course, it's optimized to leverage
> > > the fact that it's thread-specific..
> >
> >
> > it's thread-specific
> >
On Thu, 4 Feb 2021 08:26:35 GMT, Mikael Vidstedt wrote:
> You read my mind, Andrew. Unless, of course, it's optimized to leverage the
> fact that it's thread-specific..
it's thread-specific
https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon
On Tue, 2 Feb 2021 11:14:12 GMT, Vladimir Kempik wrote:
> > > > Hello, hsdis is a separate out-of-tree project and is not part of this
> > > > jep.
> > >
> > >
> > > Unless there's something I'm missing it only requires a few lines of
>
On Mon, 1 Feb 2021 14:06:32 GMT, Magnus Ihse Bursie wrote:
>>> Hello, hsdis is a separate out-of-tree project and is not part of this jep.
>>
>> Unless there's something I'm missing it only requires a few lines of change
>> to src/utils/hsdis/makefile (it already has support for macos x86_64)
On Mon, 1 Feb 2021 09:31:31 GMT, Alan Hayward
wrote:
> You need add macos arm64 to hsdis. Having it working is fairly essential for
> debugging.
>
> Inside src/utils/hsdis, After cloning binutils
>
> ```
> make; make demo; ./build/macosx-arm64/hsdis-demo
> ```
>
> Results in:
>
> ```
>
On Mon, 25 Jan 2021 09:48:46 GMT, Andrew Haley wrote:
>> Would you like me to do something about it now? The problem is that the
>> functions of SlowSignatureHandler are subtly different, so it will be
>> multiple tables, not sure how many. Such change is another candidate for a
>> separate
On Wed, 27 Jan 2021 08:36:19 GMT, Magnus Ihse Bursie wrote:
> Build changes per se now looks okay. However, I agree with Erik that unless
> this PR can wait for the JNF removal, at the very least the build docs needs
> to be updated to explain how to successfully build for this platform. (I
On Tue, 26 Jan 2021 09:23:18 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
>
On Tue, 26 Jan 2021 19:33:28 GMT, Weijun Wang wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert harfbuzz changes, disable warnings for it
>
> src/java.security.jgss/share/native/libj2gss/gssapi.h line 48:
>
On Mon, 25 Jan 2021 17:43:22 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
>
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> framework
> ie:
> `--with-extra-ldflags='-F
> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Frameworks/'`
On Mon, 25 Jan 2021 23:35:52 GMT, Phil Race wrote:
>> That may actually be a valid concern. Both say macOS 10.12+ ... which might
>> conflict with the 10.9 target.
>
> Maybe you should just file a bug after all for this to be dealt with
> separately.
> Certainly if it is NOT fixed now such a
On Mon, 25 Jan 2021 22:42:40 GMT, Phil Race wrote:
>> Min_macos version is changed to 11.0 for macos_aarch64
>>
>> https://github.com/openjdk/jdk/pull/2200/files/0c2cb0a372bf1a8607810d773b53d6959616a816#diff-7cd97cdbeb3053597e5d6659016cdf0f60b2c412bd39934a43817ee0b717b7a7R136
>
> 1) I meant
On Mon, 25 Jan 2021 22:22:06 GMT, Phil Race wrote:
>> It seems these workarounds are still needed:
>>
>> jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:300:39:
>> error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS
>> 10.14
On Mon, 25 Jan 2021 20:54:38 GMT, Vladimir Kempik wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 573:
>>
>>> 571: EXTRA_HEADER_DIRS := $(LIBFONTMANAGER_EXTRA_HEADER_DIRS), \
>>> 572: WARNINGS_AS_ERRORS_xlc := false, \
>>> 573:
On Mon, 25 Jan 2021 19:42:41 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
>
On Mon, 25 Jan 2021 14:03:40 GMT, Per Liden wrote:
> In `make/autoconf/jvm-features.m4` I notice that you haven't enabled ZGC for
> macos/aarch64. Is that just an oversight, or is there a reason for that?
because it does not work
processor_id has no "official docs"-friendly implementation,
On Mon, 25 Jan 2021 13:18:34 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
>
On Sat, 23 Jan 2021 11:43:31 GMT, Andrew Haley wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
>
On Thu, 1 Oct 2020 15:02:01 GMT, Vladimir Kempik wrote:
> Please review this change for hotspot and one test.
> There is few JVMTI callback/event functions in jdk which signature doesn't
> match specification.
> for example:
> static jvmtiError JNICALL IsClassUnloadingEnabled
On Mon, 5 Oct 2020 12:44:34 GMT, Vladimir Kempik wrote:
>>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
>>> [hotspot-dev](mailto:hotspot-...@openjdk.java.net):_
>>> Hi Vladimir,
>>>
>>> On 2/10/2020 5:37 pm, Vladimi
mes
> important to make it match the spec
> https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code
> This commit makes the above mentioned functions to have signature matching
> jvmti specification
Vladimir Kempik has updated the p
On Fri, 2 Oct 2020 15:26:30 GMT, Vladimir Kempik wrote:
>>> Okay but look at the example that documentation gives:
>>>
>>> > For example, if the jvmtiParamInfo returned by GetExtensionEvents
>>> > indicates that there is a jint parameter,
On Fri, 2 Oct 2020 07:34:45 GMT, Vladimir Kempik wrote:
>> Okay but look at the example that documentation gives:
>>
>>> For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates
>>> that there is a jint parameter, the event
>>> handl
On Fri, 2 Oct 2020 07:27:17 GMT, David Holmes wrote:
> Okay but look at the example that documentation gives:
>
> > For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates
> > that there is a jint parameter, the event
> > handler should be declared: ```
> > void JNICALL
On Fri, 2 Oct 2020 05:10:20 GMT, Serguei Spitsyn wrote:
>> Please review this change for hotspot and one test.
>> There is few JVMTI callback/event functions in jdk which signature doesn't
>> match specification.
>> for example:
>> static jvmtiError JNICALL IsClassUnloadingEnabled(const
Please review this change for hotspot and one test.
There is few JVMTI callback/event functions in jdk which signature doesn't
match specification.
for example:
static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env,
jboolean* enabled, ...)
but according to jvmti specs it should
On Mon, 28 Sep 2020 19:38:15 GMT, Bernhard Urban-Forster
wrote:
>> this looks better I think, if it's done right from beginning, we won't have
>> to modify it later.
>> The Question is, can we do it ahead of JEP-391 ?
>> If we can't then maybe better to leave it this way for now:
>>
On Mon, 28 Sep 2020 19:09:17 GMT, Bernhard Urban-Forster
wrote:
>> src/hotspot/cpu/aarch64/register_aarch64.cpp line 44:
>>
>>> 42: "rscratch1", "rscratch2",
>>> 43: "r10", "r11", "r12", "r13", "r14", "r15", "r16",
>>> 44: "r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls"), "r19",
On Mon, 28 Sep 2020 14:07:16 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around
Hi All,
I would like to backport fix for JDK-8048353 to 8u
Bug id: https://bugs.openjdk.java.net/browse/JDK-8048353
Changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/5133956b4a98
Fix applies cleanly to jdk8
Review thread for original fix:
hello
Can I have one more review for this please?
jstack/tmtools tested passed fine.
Thanks, Vladimir.
On 15.07.2015 17:31, Vladimir Kempik wrote:
Hello
Thanks for looking into this.
Where can I find jstack/tmtools tests to run them ?
Thanks, Vladimir.
On 14.07.2015 19:21, Daniel D
to the
Serviceability team...
The jstack and/or tmtools tests should also be run...
Dan
On 7/14/15 9:51 AM, Vladimir Kempik wrote:
Hello,
Please review the patch to fix 8048353.
Customer has an issue with this bug when running jstack on jdk7.
He tested FVB and cofirmed it has fixed the issue.
Before pushing jdk7
Hello
Please review this patch.
We've recently backported changes to testlibrary from jdk8 to jdk7 and
now I want to bring TL tests to jdk7 as well. jdk7u-dev/jdk already has
these tests, it's only hotspot that missing them.
Its partially backport of 8024677, but I don't remove old files and
the test code but don't
compile it to production libnpt.
-Dmitry
On 2014-04-09 11:12, Staffan Larsen wrote:
It’s been a very useful little test when changing the code in
utf.c. Not sure why it has to be removed.
/Staffan
On 8 apr 2014, at 17:30, Vladimir Kempik
vladimir.kem...@oracle.com
Hello
Please review this changeset:
File jdk/src/share/npt/utf.c contains a testcase that shouldn't be in
production library.
bug: https://bugs.openjdk.java.net/browse/JDK-8039368
webrev: http://cr.openjdk.java.net/~vkempik/8039368/webrev.00/
Thanks, Vladimir.
54 matches
Mail list logo
