[sigrok-devel] [PATCH] input/csv: fix import of analog value 0 in second and subsequent chunks

2022-12-02 Thread Markus Heidelberg
Hi, I found a problem with importing wrong values from CSV files when 0.0 voltage was given. clear_analog_samples() didn't clear, so old buffer content existed. I noticed it by sporadic peaks in low bus signal (around 0 voltage). https://github.com/sigrokproject/libsigrok/pull/201 Markus _

Re: [sigrok-devel] [PATCH] input/csv: fix import of analog value 0 in second and subsequent chunks

2022-12-02 Thread Gerhard Sittig
On Fri, 2022-12-02 at 19:51 +0100, Markus Heidelberg wrote: > > I found a problem with importing wrong values from CSV files when > 0.0 voltage was given. > > clear_analog_samples() didn't clear, so old buffer content existed. > I noticed it by sporadic peaks in low bus signal (around 0 voltage). >

Re: [sigrok-devel] [PATCH] input/csv: fix import of analog value 0 in second and subsequent chunks

2022-12-02 Thread Markus Heidelberg
Am Freitag, 2. Dezember 2022, 20:56:45 CET schrieb Gerhard Sittig: > On Fri, 2022-12-02 at 19:51 +0100, Markus Heidelberg wrote: > > I found a problem with importing wrong values from CSV files when > > 0.0 voltage was given. > > > > clear_analog_samples() didn't clear, so old buffer content existe

Re: [sigrok-devel] [PATCH] input/csv: fix import of analog value 0 in second and subsequent chunks

2022-12-02 Thread Gerhard Sittig
On Sat, 2022-12-03 at 00:24 +0100, Markus Heidelberg wrote: > > Am Freitag, 2. Dezember 2022, 20:56:45 CET schrieb Gerhard Sittig: > > > > Got example data to reproduce? Helps others review that change, > > improves the odds of having it go mainline. Could even be part of > > the commit message whe