On Sat, 2022-12-03 at 00:24 +0100, Markus Heidelberg wrote:
>
> Am Freitag, 2. Dezember 2022, 20:56:45 CET schrieb Gerhard Sittig:
> >
> > Got example data to reproduce? Helps others review that change,
> > improves the odds of having it go mainline. Could even be part of
> > the commit message when "the file" only got a few lines of text.
>
> I attached an example file. However, more than 2^19 samples are needed
> for the bug to become effective, so it couldn't be smaller.
>
> > There is prior art in some of the src/input/ modules.
>
> Didn't understand that part.
Thank you for that example data. Helped a lot. The point was to
make that very data available to those who review and later
maintain the software. That's why putting it into the commit
message when possible is so useful for awareness now and later.
Should be fixed in e7ed37042611. The implementation differs
though. Wanted to keep the set_analog_value() abstraction. And
ignored the malloc0 change since it does not harm, and cost is
negligable (executes once per file import).
Gave you a Reported-By. Thank you for submitting!
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
