Re: CVS commit: src/sys/dev/ic

Oops, never mind, I hadn't yet seen the follow-up revert. > On Aug 1, 2022, at 8:29 AM, Jason Thorpe wrote: > > > >> On Aug 1, 2022, at 12:34 AM, Michael van Elst wrote: >> >> Module Name: src >> Committed By: mlelstv >> Date: Mon Aug 1 07:34:28 UTC 2022 >> >> Modified Files: >>

Re: CVS commit: src/sys/dev/ic

> On Aug 1, 2022, at 12:34 AM, Michael van Elst wrote: > > Module Name: src > Committed By: mlelstv > Date: Mon Aug 1 07:34:28 UTC 2022 > > Modified Files: > src/sys/dev/ic: ahcisata_core.c bcmgenet.c nslm7x.c nvmereg.h nvmevar.h >rtl8169.c tulip.c tulipreg.h > > Log Message: > Also

Re: CVS commit: src/sys/dev/ic

In article <18083.1593053...@splode.eterna.com.au>, matthew green wrote: >"Jaromir Dolecek" writes: >> Module Name: src >> Committed By:jdolecek >> Date:Wed Jun 24 19:55:25 UTC 2020 >> >> Modified Files: >> src/sys/dev/ic: ibm561.c >> >> Log Message: >> avoid

re: CVS commit: src/sys/dev/ic

"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 19:55:25 UTC 2020 > > Modified Files: > src/sys/dev/ic: ibm561.c > > Log Message: > avoid allocating almost 5k struct ibm561data on stack in ibm561_cninit(); > it's too early for kmem_alloc(),

Re: CVS commit: src/sys/dev/ic

On 2020/03/24 12:45, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Tue Mar 24 03:45:26 UTC 2020 > > Modified Files: > src/sys/dev/ic: spdmem.c spdmemvar.h > > Log Message: > - Define some new parameters of DDR3 SPD ROM. > - Use fine timebase parameters

Re: CVS commit: src/sys/dev/ic

On 22.10.2019 14:09, Martin Husemann wrote: > Module Name: src > Committed By: martin > Date: Tue Oct 22 12:09:11 UTC 2019 > > Modified Files: > src/sys/dev/ic: wdc.c > > Log Message: > Fix channel locking - patch from Christos. > > > #include > -__KERNEL_RCSID(0, "$NetBSD:

Re: CVS commit: src/sys/dev/ic

On Wed, Oct 02, 2019 at 03:44:21AM +, Constantine A. Murenin wrote: > I'm getting a page fault trap after this patch, at netbsd:dk_open(), in > VirtualBox 6.0.12 r133076 with an empty NVME controller. There is a bug in dk_open when attachment didn't complete yet or failed. I'm about to fix

Re: CVS commit: src/sys/dev/ic

I'm getting a page fault trap after this patch, at netbsd:dk_open(), in VirtualBox 6.0.12 r133076 with an empty NVME controller. C. On 2019-W40-2 10:59 +, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Tue Oct 1 10:59:50 UTC 2019 Modified Files:

Re: CVS commit: src/sys/dev/ic

Date:Sun, 22 Sep 2019 07:23:00 +0100 From:Nick Hudson Message-ID: <793d2380-8d1a-78ab-3682-0468aea0d...@gmx.co.uk> | I was merely pointing out that it exists already. Understood, and thanks - at a minimum that will avoid adding it with a different name. | I'm

Re: CVS commit: src/sys/dev/ic

On 21/09/2019 20:19, Robert Elz wrote: Date:Sun, 22 Sep 2019 01:23:41 +0700 From:Robert Elz Message-ID: <8235.1569090...@jinx.noi.kre.to> | we'd need it in all the other ports before it can be used in MD code. I meant MI code of course... Sure. I was

Re: CVS commit: src/sys/dev/ic

Date:Sun, 22 Sep 2019 01:23:41 +0700 From:Robert Elz Message-ID: <8235.1569090...@jinx.noi.kre.to> | we'd need it in all the other ports before it can be used in MD code. I meant MI code of course... kre

Re: CVS commit: src/sys/dev/ic

Date:Sat, 21 Sep 2019 19:06:15 +0100 From:Nick Hudson Message-ID: | http://src.illumos.org/source/search?q=PRIxBUSADDR=PRIxBUSADDRnetbsd-src That shows that mips and arm have PRIxBUSADDR - we'd need it in all the other ports before it can be used in MD code.

Re: CVS commit: src/sys/dev/ic

On 21/09/2019 17:26, Jason Thorpe wrote: > Should we make a PRIxxx macro for it? > > -- thorpej > Sent from my iPhone. > >> On Sep 21, 2019, at 5:57 AM, Robert Elz wrote: >> >> Module Name:src >> Committed By:kre >> Date:Sat Sep 21 12:57:25 UTC 2019 >> >> Modified Files: >>

Re: CVS commit: src/sys/dev/ic

Date:Sat, 21 Sep 2019 09:26:21 -0700 From:Jason Thorpe Message-ID: | Should we make a PRIxxx macro for it? [since I deleted the context: "it" is bus_addr_t] Perhaps, for this particular case it doesn't really matter, but if code is likely to be printing

Re: CVS commit: src/sys/dev/ic

Should we make a PRIxxx macro for it? -- thorpej Sent from my iPhone. > On Sep 21, 2019, at 5:57 AM, Robert Elz wrote: > > Module Name:src > Committed By:kre > Date:Sat Sep 21 12:57:25 UTC 2019 > > Modified Files: >src/sys/dev/ic: mpt.c > > Log Message: > bus_addt_t is

Re: CVS commit: src/sys/dev/ic

Awesome, Jared - many thanks for this! On Fri, 28 Jun 2019 at 08:08, Jared D. McNeill wrote: > Module Name:src > Committed By: jmcneill > Date: Fri Jun 28 15:08:47 UTC 2019 > > Modified Files: > src/sys/dev/ic: nvme.c nvmevar.h > > Log Message: > Fix a performance issue

re: CVS commit: src/sys/dev/ic

> > also, what's IST_MPSAFE? sounds like some platform specific > > thing. > > Sure. Each platform should have it's own. Unless someone wants to make an > MI intr_establish. then it's not useful for MI driver. you quote spl(9): >At the time of writing, the global kernel_lock is

Re: CVS commit: src/sys/dev/ic

On 31/05/2019 07:27, matthew green wrote: > Nick Hudson writes: >> On 30/05/2019 21:46, matthew green wrote: Committed By: tnn Date: Thu May 30 07:37:17 UTC 2019 Modified Files: src/sys/dev/ic: ssdfb.c Log Message: - include uvm.h

re: CVS commit: src/sys/dev/ic

Nick Hudson writes: > On 30/05/2019 21:46, matthew green wrote: > >> Committed By: tnn > >> Date: Thu May 30 07:37:17 UTC 2019 > >> > >> Modified Files: > >>src/sys/dev/ic: ssdfb.c > >> > >> Log Message: > >> - include uvm.h before uvm_device.h > >> - don't need IPL_SCHED

Re: CVS commit: src/sys/dev/ic

On 30/05/2019 21:46, matthew green wrote: Committed By: tnn Date: Thu May 30 07:37:17 UTC 2019 Modified Files: src/sys/dev/ic: ssdfb.c Log Message: - include uvm.h before uvm_device.h - don't need IPL_SCHED here the IPL_SCHED change seems backwards to me. IPL_VM is the

re: CVS commit: src/sys/dev/ic

> Committed By: tnn > Date: Thu May 30 07:37:17 UTC 2019 > > Modified Files: > src/sys/dev/ic: ssdfb.c > > Log Message: > - include uvm.h before uvm_device.h > - don't need IPL_SCHED here the IPL_SCHED change seems backwards to me. IPL_VM is the "this driver is not updated to

Re: CVS commit: src/sys/dev/ic

On 01/12/2018 15:07, Jaromir Dolecek wrote: > -#define NVME_ID_CTRLR_ONCS_SET_FEATURES __BIT(4) > +#define NVME_ID_CTRLR_ONCS_SAVE __BIT(4) Unintended? sbin/nvmectl/identify.c:(cdata->oncs & NVME_ID_CTRLR_ONCS_SET_FEATURES) ? Nick

Re: CVS commit: src/sys/dev/ic

Date: Mon, 19 Sep 2016 01:36:14 + From: David Holland On Sun, Sep 18, 2016 at 09:52:37PM +, Jaromir Dolecek wrote: > Modified Files: > src/sys/dev/ic: ld_nvme.c > > Log Message: > must use PR_NOWAIT also during

Re: CVS commit: src/sys/dev/ic

On Sun, Sep 18, 2016 at 09:52:37PM +, Jaromir Dolecek wrote: > Modified Files: > src/sys/dev/ic: ld_nvme.c > > Log Message: > must use PR_NOWAIT also during ldattach()/dkwedge discover, our i/o is there > called with a spin lock held, which triggers LOCKDEBUG panic That sounds

Re: CVS commit: src/sys/dev/ic

On 06/28/16 17:00, Nick Hudson wrote: Module Name:src Committed By: skrll Date: Tue Jun 28 16:00:32 UTC 2016 Modified Files: src/sys/dev/ic: sl811hs.c Log Message: Add slhci_memtest which is run when SLHCI_DEBUG is defined. oops... this is from Felix Deichmann - I'll

Re: CVS commit: src/sys/dev/ic

Don't know if it's your change, but for the alpha... /usr/src/netbsd/sys/dev/ic/sl811hs.c: In function 'slhci_root_start': /usr/src/netbsd/sys/dev/ic/sl811hs.c:989:21: error: variable 'spipe' set but not used [-Werror=unused-but-set-variable] struct slhci_pipe *spipe; ^

Re: CVS commit: src/sys/dev/ic

In article <27894.1461718...@splode.eterna.com.au>, matthew green wrote: >"Christos Zoulas" writes: >> Module Name: src >> Committed By:christos >> Date:Tue Apr 26 21:17:20 UTC 2016 >> >> Modified Files: >> src/sys/dev/ic: rt2860reg.h >> Added

re: CVS commit: src/sys/dev/ic

"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Tue Apr 26 21:17:20 UTC 2016 > > Modified Files: > src/sys/dev/ic: rt2860reg.h > Added Files: > src/sys/dev/ic: rt2860.c rt2860var.h > > Log Message: > Unmodified OpenBSD sources (except Ids) ...

Re: CVS commit: src/sys/dev/ic

Sure, will request pullups after one week (Jul 29). -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) On 27 Jul 2015, at 02:15, Erik Fair f...@netbsd.org wrote: Pull up to netbsd-7 and netbsd-6? Erik On Jul 22, 2015, at 01:33, Juergen Hannken-Illjes

Re: CVS commit: src/sys/dev/ic

Pull up to netbsd-7 and netbsd-6? Erik On Jul 22, 2015, at 01:33, Juergen Hannken-Illjes hann...@netbsd.org wrote: Module Name: src Committed By: hannken Date: Wed Jul 22 08:33:51 UTC 2015 Modified Files: src/sys/dev/ic: mpt_netbsd.c Log Message: Adapter

Re: CVS commit: src/sys/dev/ic (spdmem.c)

On Thu, 02 Apr 2015 17:28:00 +0900 Masanobu SAITOH msai...@execsw.org wrote: A few weeks ago, I got a 2-way Xeon machine to test Intel X540 support. Afrer finishing X540 test, I noticed that the machine had DDR4. I tried to check the spdmem. It seemed that the machine's spdmem is not

Re: CVS commit: src/sys/dev/ic (spdmem.c)

Thank you. A few weeks ago, I got a 2-way Xeon machine to test Intel X540 support. Afrer finishing X540 test, I noticed that the machine had DDR4. I tried to check the spdmem. It seemed that the machine's spdmem is not connecte via C612's internal i2c bus but via others. I stopped writing DDR4

Re: CVS commit: src/sys/dev/ic (spdmem.c)

Module Name:src Committed By: msaitoh Date: Fri Mar 27 05:33:08 UTC 2015 Modified Files: src/sys/dev/ic: spdmem.c spdmemreg.h Log Message: Add DDR4 support a bit. Looking at the actual code change here @@ -76,6 +76,7 @@ static const char* spdmem_basic_types[]

Re: CVS commit: src/sys/dev/ic

On Tue, Oct 14, 2014 at 12:56:48AM +, Valeriy E. Ushakov wrote: Module Name: src Committed By: uwe Date: Tue Oct 14 00:56:48 UTC 2014 Modified Files: src/sys/dev/ic: rtl8169.c Log Message: RealTek 8139C+ incorrectly identifies UDP checksum 0x as bad. Force

Re: CVS commit: src/sys/dev/ic

On Tue, Oct 14, 2014 at 14:54:17 +0200, Joerg Sonnenberger wrote: On Tue, Oct 14, 2014 at 12:56:48AM +, Valeriy E. Ushakov wrote: Module Name:src Committed By: uwe Date: Tue Oct 14 00:56:48 UTC 2014 Modified Files: src/sys/dev/ic: rtl8169.c

Re: CVS commit: src/sys/dev/ic

Date: Thu, 10 Apr 2014 10:22:14 -0700 From: Brian Buhrow buh...@nfbcal.org hello. Yes, if you could be more specific about what you're asking for, I'll be happy to make the fixes. Here are the ones I see. Most of these are indentation issues. I know these all look like

Re: CVS commit: src/sys/dev/ic

Hello. Thanks for the detailed response. I've already gone through and, I believe, fixed the indentation issues with the code. Those fixes are checked in as V1.21 of the mpt_netbsd.c file. I'll next go through and make your suggested changes for comments and long lines. -thanks -Brian

Re: CVS commit: src/sys/dev/ic

hello. Yes, if you could be more specific about what you're asking for, I'll be happy to make the fixes. -thanks -Brian On Apr 7, 12:34pm, Taylor R Campbell wrote: } Subject: CVS commit: src/sys/dev/ic } [Resent in case you're not on source-changes-d.] } }Date: Tue, 1 Apr 2014

Re: CVS commit: src/sys/dev/ic

On 09/22/13 10:21, Adam Ciarcinski wrote: Module Name:src Committed By: adam Date: Sun Sep 22 09:21:56 UTC 2013 Modified Files: src/sys/dev/ic: sl811hs.c Log Message: Removed duplicated lines introduced in version 1.36. Thanks, Nick

re: CVS commit: src/sys/dev/ic

Module Name: src Committed By: jdc Date: Mon Feb 4 18:29:56 UTC 2013 Modified Files: src/sys/dev/ic: gem.c Log Message: Halt the RX watchdog callout when stopping. ah, is this why my gem(4) would crash at reboot time if it was marked for auto-detach at shutdown?

Re: CVS commit: src/sys/dev/ic

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Oct 20, 2012, at 9:31 AM, Michael Lorenz wrote: Module Name:src Committed By: macallan Date: Sat Oct 20 13:31:09 UTC 2012 Modified Files: src/sys/dev/ic: i128.c i128var.h Log Message: don't sync after each

Re: CVS commit: src/sys/dev/ic

macallan@ wrote: On Thu, 12 Jan 2012 18:19:26 +0900 Izumi Tsutsui tsut...@ceres.dti.ne.jp wrote: Module Name: src Committed By: macallan Date: Wed Jan 11 20:41:28 UTC 2012 Modified Files: src/sys/dev/ic: igsfb.c vga.c vga_raster.c Log Message:

Re: CVS commit: src/sys/dev/ic

Hello, On Fri, 13 Jan 2012 23:05:13 +0900 Izumi Tsutsui tsut...@ceres.dti.ne.jp wrote: - No man page update after API changes I'll update the man pages. - evbarm and hpcarm (and zaurus) are still broken on daily build due to API changes Should work now. The kernel version number

Re: CVS commit: src/sys/dev/ic

I should have added compat versions of wsfont_find() and wsfont_matches() before trying to fix every driver. Well I thought two days window would be okay to revert changed APIs but now param.h won't be reverted... --- Izumi Tsutsui

Re: CVS commit: src/sys/dev/ic

Hello, On Sat, 14 Jan 2012 01:43:36 +0900 Izumi Tsutsui tsut...@ceres.dti.ne.jp wrote: I should have added compat versions of wsfont_find() and wsfont_matches() before trying to fix every driver. Well I thought two days window would be okay to revert changed APIs but now param.h won't

Re: CVS commit: src/sys/dev/ic

Module Name: src Committed By: macallan Date: Wed Jan 11 20:41:28 UTC 2012 Modified Files: src/sys/dev/ic: igsfb.c vga.c vga_raster.c Log Message: wsfont_matches() and wsfont_find() take an extra parameter now Isn't it possible to provide compatible wrapper functions

Re: CVS commit: src/sys/dev/ic

Hello, On Thu, 12 Jan 2012 18:19:26 +0900 Izumi Tsutsui tsut...@ceres.dti.ne.jp wrote: Module Name:src Committed By: macallan Date: Wed Jan 11 20:41:28 UTC 2012 Modified Files: src/sys/dev/ic: igsfb.c vga.c vga_raster.c Log Message:

Re: CVS commit: src/sys/dev/ic

On Wed, Nov 02, 2011 at 04:54:51PM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Wed Nov 2 16:54:51 UTC 2011 Modified Files: src/sys/dev/ic: ahcisatareg.h Log Message: Additionally apply __aligned(8) to all __packed hardware data

Re: CVS commit: src/sys/dev/ic

On Sun, Aug 28, 2011 at 05:32:21AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Aug 28 09:32:21 UTC 2011 Modified Files: src/sys/dev/ic: wdc.c Log Message: Make this compile again without WDC_NO_IDS. Ops, sorry. Looks like I commited

Re: CVS commit: src/sys/dev/ic

In article 20101019222719.cb89217...@cvs.netbsd.org, Jared D. McNeill source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: jmcneill Date: Tue Oct 19 22:27:19 UTC 2010 Modified Files: src/sys/dev/ic: pcdisplay_subr.c Log Message: When disabling the

Re: CVS commit: src/sys/dev/ic

On Wed, Mar 31, 2010 at 04:06:47PM -0500, David Young wrote: bus_space_barrier() doesn't flush ... barriers only enforce the ordering of operations (and, of course, with respect to non-overlapping addresses ... obviously reads after writes of the same address in code will be enforced on

Re: CVS commit: src/sys/dev/ic

On Wed, Mar 31, 2010 at 05:09:41AM +, Michael Lorenz wrote: Module Name: src Committed By: macallan Date: Wed Mar 31 05:09:41 UTC 2010 Modified Files: src/sys/dev/ic: pcf8584.c Log Message: Do as OpenSolaris does and read the status register after each write. Now

Re: CVS commit: src/sys/dev/ic

On Wed, Mar 31, 2010 at 09:45:40AM -0500, David Young wrote: On Wed, Mar 31, 2010 at 05:09:41AM +, Michael Lorenz wrote: Module Name:src Committed By: macallan Date: Wed Mar 31 05:09:41 UTC 2010 Modified Files: src/sys/dev/ic: pcf8584.c Log

Re: CVS commit: src/sys/dev/ic

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Mar 31, 2010, at 10:45 AM, David Young wrote: On Wed, Mar 31, 2010 at 05:09:41AM +, Michael Lorenz wrote: Module Name:src Committed By: macallan Date: Wed Mar 31 05:09:41 UTC 2010 Modified Files:

Re: CVS commit: src/sys/dev/ic

On Wed, Mar 31, 2010 at 02:03:11PM -0400, Michael wrote: On Mar 31, 2010, at 10:45 AM, David Young wrote: I wonder, does the device need the read, or is the bus_space_barrier() insufficient to flush the write to the device? I thave no idea. It works without the read on some machines - might

Re: CVS commit: src/sys/dev/ic

I wonder, does the device need the read, or is the bus_space_barrier() insufficient to flush the write to the device? I thave no idea. It works without the read on some machines - might be a quirk in the Blade 2500's hardware. Either way we can probably get rid of the

Re: CVS commit: src/sys/dev/ic

On Wed, Mar 31, 2010 at 01:19:10PM -0700, Jason Thorpe wrote: On Mar 31, 2010, at 7:45 AM, David Young wrote: On Wed, Mar 31, 2010 at 05:09:41AM +, Michael Lorenz wrote: Module Name: src Committed By: macallan Date: Wed Mar 31 05:09:41 UTC 2010

Re: CVS commit: src/sys/dev/ic

On Sat, Feb 27, 2010 at 04:40:12AM +, Izumi Tsutsui wrote: Log Message: Always call device dependent functions via pointers rather than using conditionals to switch inline functions for modern processors. Eh ??? if (foo) bar(); else baz(); will probably execute faster than:

Re: CVS commit: src/sys/dev/ic

Eh ??? if (foo) bar(); else baz(); will probably execute faster than: (*bar_baz)(); since the indirect jump is (IIRC) always unpredicted. What do you have to predict on unconditional branches? Anyway, the most major user of MI dp8390 is NE2000 and it doesn't use inlined ones at all.

Re: CVS commit: src/sys/dev/ic

On Mon, Mar 01, 2010 at 12:28:17AM +0900, Izumi Tsutsui wrote: Eh ??? if (foo) bar(); else baz(); will probably execute faster than: (*bar_baz)(); since the indirect jump is (IIRC) always unpredicted. What do you have to predict on unconditional branches? The branch

Re: CVS commit: src/sys/dev/ic

Eh ??? if (foo) bar(); else baz(); will probably execute faster than: (*bar_baz)(); since the indirect jump is (IIRC) always unpredicted. What do you have to predict on unconditional branches? The branch destination. E.g. the CPU can't start prefetching from the

Re: CVS commit: src/sys/dev/ic (hme.c:1.77)

On Wednesday 2009-05-06 20:40 +, Julian Coleman output: :Module Name: src :Committed By: jdc :Date: Wed May 6 20:40:19 UTC 2009 : :Modified Files: : src/sys/dev/ic: hme.c : :Log Message: :Check for internal PHY first, so that it always attaches first, even when :we have an