CVS commit: src/doc

2021-10-22 Thread Robert Elz
Module Name:src Committed By: kre Date: Fri Oct 22 21:03:50 UTC 2021 Modified Files: src/doc: 3RDPARTY CHANGES Log Message: Note tzdata2021e update. To generate a diff of this commit: cvs rdiff -u -r1.1823 -r1.1824 src/doc/3RDPARTY cvs rdiff -u -r1.2844 -r1.2845 src/doc/

CVS commit: src/bin/sh

2021-10-25 Thread Robert Elz
Module Name:src Committed By: kre Date: Tue Oct 26 00:05:38 UTC 2021 Modified Files: src/bin/sh: main.c memalloc.c memalloc.h options.c sh.1 shell.h Log Message: PR bin/56464 After almost 30 years, finally do the right thing and read $HOME/.profile rather than .profile in

CVS commit: src/bin/sh

2021-10-25 Thread Robert Elz
Module Name:src Committed By: kre Date: Tue Oct 26 00:05:38 UTC 2021 Modified Files: src/bin/sh: main.c memalloc.c memalloc.h options.c sh.1 shell.h Log Message: PR bin/56464 After almost 30 years, finally do the right thing and read $HOME/.profile rather than .profile in

CVS commit: src/bin/sh

2021-10-26 Thread Robert Elz
Module Name:src Committed By: kre Date: Tue Oct 26 10:07:20 UTC 2021 Modified Files: src/bin/sh: main.c memalloc.c memalloc.h Log Message: Use a type-correct end marker for strstrcat() rather than NULL, as for a function with unknown number & types of args, the compiler is

CVS commit: src/bin/sh

2021-10-26 Thread Robert Elz
Module Name:src Committed By: kre Date: Tue Oct 26 10:07:20 UTC 2021 Modified Files: src/bin/sh: main.c memalloc.c memalloc.h Log Message: Use a type-correct end marker for strstrcat() rather than NULL, as for a function with unknown number & types of args, the compiler is

Re: CVS commit: src/bin/sh

2021-10-26 Thread Robert Elz
Date:Tue, 26 Oct 2021 15:07:23 - (UTC) From:chris...@astron.com (Christos Zoulas) Message-ID: | No issetugid()? No, because I'm not sure I understand that, nor that I believe: A process is tainted if [...] it has changed any of its real, effective or sav

Re: CVS commit: src

2021-10-26 Thread Robert Elz
Date:Tue, 26 Oct 2021 15:37:56 +0200 From:Joerg Sonnenberger Message-ID: | Personally, I would prefer to just kill -pg support completely, but | that's a separate discussion. Yes, it is. | I don't think per-file profiling is that useful Nor do I in general.

Re: CVS commit: src/bin/sh

2021-10-26 Thread Robert Elz
ps: Also, the code is (while refactored a little) essentially the same as the -p code you added in 2015 ... just now avoiding repeatedly calling geteuid() (etc) - the value it returns won't change unless the code does something to change it. kre

CVS commit: src/lib/libc

2021-10-29 Thread Robert Elz
Module Name:src Committed By: kre Date: Fri Oct 29 19:27:07 UTC 2021 Modified Files: src/lib/libc/gen: popen.c src/lib/libc/stdlib: system.c Log Message: Add "--" 'options end' parameter to the sh -c call that runs the command, so that the command cannot appear to

CVS commit: src/lib/libc

2021-10-29 Thread Robert Elz
Module Name:src Committed By: kre Date: Fri Oct 29 19:27:07 UTC 2021 Modified Files: src/lib/libc/gen: popen.c src/lib/libc/stdlib: system.c Log Message: Add "--" 'options end' parameter to the sh -c call that runs the command, so that the command cannot appear to

Re: CVS commit: src

2021-10-29 Thread Robert Elz
Date:Fri, 29 Oct 2021 17:50:38 + From:"Roland Illig" Message-ID: <20211029175038.33b08f...@cvs.netbsd.org> | Log Message: | indent: use prev/curr/next to refer to the current token | | The word 'last' just didn't match with 'next'. That depends upon how i

CVS commit: src/bin/sh

2021-10-30 Thread Robert Elz
Module Name:src Committed By: kre Date: Sun Oct 31 02:12:01 UTC 2021 Modified Files: src/bin/sh: cd.c Log Message: PR bin/45390 - fix for folly four In the pwd builtin, verify that curdir names '.' before simply printing it. Never alter PWD or OLDPWD in the pwd command.

CVS commit: src/bin/sh

2021-10-30 Thread Robert Elz
Module Name:src Committed By: kre Date: Sun Oct 31 02:12:01 UTC 2021 Modified Files: src/bin/sh: cd.c Log Message: PR bin/45390 - fix for folly four In the pwd builtin, verify that curdir names '.' before simply printing it. Never alter PWD or OLDPWD in the pwd command.

CVS commit: src/bin/sh

2021-10-30 Thread Robert Elz
Module Name:src Committed By: kre Date: Sun Oct 31 02:12:08 UTC 2021 Modified Files: src/bin/sh: sh.1 Log Message: PR bin/45390 Be explicit about what happens to PWD after a successful cd command. Also be very clear that "cd" and "cd -P" are the same thing, and the only

CVS commit: src/bin/sh

2021-10-30 Thread Robert Elz
Module Name:src Committed By: kre Date: Sun Oct 31 02:12:08 UTC 2021 Modified Files: src/bin/sh: sh.1 Log Message: PR bin/45390 Be explicit about what happens to PWD after a successful cd command. Also be very clear that "cd" and "cd -P" are the same thing, and the only

Re: CVS commit: src

2021-11-07 Thread Robert Elz
Date:Sat, 6 Nov 2021 10:40:58 -0700 From:Alistair Crooks Message-ID: | The author of the software made a conscious decision | to make the variable unsigned, sincr the length | would never be less than zero. | | The author then made a default definition for

CVS commit: src/bin/sh

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 15:26:34 UTC 2021 Modified Files: src/bin/sh: error.c eval.c expand.c redir.c trap.c Log Message: DEBUG mode changes only. NFC (NC) for any normally compiled shell. Mostly adding DEBUG mode tracing (when appropriate ver

CVS commit: src/bin/sh

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 15:26:34 UTC 2021 Modified Files: src/bin/sh: error.c eval.c expand.c redir.c trap.c Log Message: DEBUG mode changes only. NFC (NC) for any normally compiled shell. Mostly adding DEBUG mode tracing (when appropriate ver

CVS commit: src/bin/sh

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 15:58:39 UTC 2021 Modified Files: src/bin/sh: output.h Log Message: Add a couple of macro definitions for dealing with shell I/O errors. (Macros akin to stdio's ferror() and clearerr()). NFC: the macros are defined, but n

CVS commit: src/bin/sh

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 15:58:39 UTC 2021 Modified Files: src/bin/sh: output.h Log Message: Add a couple of macro definitions for dealing with shell I/O errors. (Macros akin to stdio's ferror() and clearerr()). NFC: the macros are defined, but n

CVS commit: src/bin/echo

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 17:35:45 UTC 2021 Modified Files: src/bin/echo: echo.c Log Message: With -Wall compiling this was giving: echo.c: In function 'main': echo.c:74:1: warning: control reaches end of non-void function This ra

CVS commit: src/bin/echo

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 17:35:45 UTC 2021 Modified Files: src/bin/echo: echo.c Log Message: With -Wall compiling this was giving: echo.c: In function 'main': echo.c:74:1: warning: control reaches end of non-void function This ra

CVS commit: src/bin/sh

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 18:25:52 UTC 2021 Modified Files: src/bin/sh: builtins.def Log Message: Ensure that all of the POSIX standard utilities are correctly identified with the -u flag (that is, I hope I identified all the ones that were missing

CVS commit: src/bin/sh

2021-11-10 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Nov 10 18:25:52 UTC 2021 Modified Files: src/bin/sh: builtins.def Log Message: Ensure that all of the POSIX standard utilities are correctly identified with the -u flag (that is, I hope I identified all the ones that were missing

Re: CVS commit: src/bin/echo

2021-11-10 Thread Robert Elz
Date:Wed, 10 Nov 2021 22:17:05 +0300 From:Valery Ushakov Message-ID: | > in the sense that simply falling out of main() is exit(0)? | | Surprisingly - yes. That's appalling, but perhaps not surprising. It breaks code which believed what was promised, and did

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Robert Elz
Date:Fri, 30 Apr 2010 06:00:14 + From:Jukka Ruohonen Message-ID: <20100430060014.7739117...@cvs.netbsd.org> | Module Name:src | Committed By: jruoho | Date: Fri Apr 30 06:00:14 UTC 2010 | | Modified Files: | src/lib/lib

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Robert Elz
Date:Tue, 4 May 2010 16:39:16 +0300 From:Jukka Ruohonen Message-ID: <20100504133916.ga9...@marx.bitnet> | In my manual page: [...] | What was the problem again? Something odd - sorry - it looks as if my (older) "nroff -mandoc" on current sources manages to lose

Re: CVS commit: src/lib/libc/stdio

2010-10-23 Thread Robert Elz
Date:Sat, 23 Oct 2010 16:33:37 +0100 From:Matthias Scheler Message-ID: <20101023153336.ga...@colwyn.zhadum.org.uk> | I'm sorry but this whole code is horrible. I agree with that, but ... | What is wrong with something as simple as this? | +#define _FPOS_OVERF

Re: CVS commit: src/lib/libc/stdio

2010-10-24 Thread Robert Elz
Date:Sun, 24 Oct 2010 16:00:46 +0100 From:Matthias Scheler Message-ID: <20101024150046.ga...@colwyn.zhadum.org.uk> | It doesn't have to be a macro anyway as it used only ones. Yes, I meant to ask about that, simply written inline would be no problem. kre

Re: CVS commit: src/external/cddl/osnet

2011-01-14 Thread Robert Elz
Date:Sat, 15 Jan 2011 14:36:50 +1100 From:matthew green Message-ID: <399.1295062...@splode.eterna.com.au> | > You also need to debug code with the same compilation options as you | > will use for any final builds - otherwise you can get some very | > nasty surpr

Re: CVS commit: src/usr.bin/units

2012-12-28 Thread Robert Elz
Date:Fri, 28 Dec 2012 17:57:46 + From:"Alan Barrett" Message-ID: <20121228175746.e19f117...@cvs.netbsd.org> | because unit names cannot contain hyphens. Should that not be mentioned in the man page? Perhaps together with a suggestion that if the name the user

Re: CVS commit: src/usr.sbin/rtsold

2013-05-24 Thread Robert Elz
Date:Fri, 24 May 2013 16:47:08 + From:David Holland Message-ID: <20130524164708.ga...@netbsd.org> | : -The default interval for router advertisements, which is on the order of 10 | : +The default interval for router advertisements, which is in the order of

Re: CVS commit: src/usr.sbin/rtsold

2013-05-26 Thread Robert Elz
Date:Sun, 26 May 2013 12:54:44 +0200 From:Thomas Klausner Message-ID: <20130526105444.gu9...@danbala.tuwien.ac.at> | Could one of the native speakers please fix it in a way that we won't | have this discussion again? Try the patch below, which I think is both cor

CVS commit: src/share/tmac

2019-11-26 Thread Robert Elz
Module Name:src Committed By: kre Date: Tue Nov 26 08:38:19 UTC 2019 Modified Files: src/share/tmac: doc2html Log Message: PR toolchain/54715 Remove duplicate (incorrect) version of the .Lk macro, so the earlier (fancier and functional) definition survives. For now simpl

CVS commit: src/share/tmac

2019-11-26 Thread Robert Elz
Module Name:src Committed By: kre Date: Tue Nov 26 08:38:19 UTC 2019 Modified Files: src/share/tmac: doc2html Log Message: PR toolchain/54715 Remove duplicate (incorrect) version of the .Lk macro, so the earlier (fancier and functional) definition survives. For now simpl

Re: CVS commit: src/distrib/notes/common

2019-12-04 Thread Robert Elz
Date:Wed, 4 Dec 2019 09:25:43 + From:"Thomas Klausner" Message-ID: <20191204092543.7c702f...@cvs.netbsd.org> | Module Name:src | Committed By: wiz | Date: Wed Dec 4 09:25:43 UTC 2019 | | Modified Files: | src/distrib/no

Re: CVS commit: src/distrib/notes/common

2019-12-04 Thread Robert Elz
Sorry, really meant to send that just to wiz@, rather than the list... kre

Re: CVS commit: src/share/tmac

2019-12-23 Thread Robert Elz
Date:Mon, 23 Dec 2019 23:45:34 +0100 From:Steffen Nurpmeso Message-ID: <20191223224534.8ufgy%stef...@sdaoden.eu> | |Troff reads .ie and checks the condition. The condition is true and | |so the rest of the line is executed. Then troff reads .el that | |mat

Re: CVS commit: src/share/tmac

2019-12-25 Thread Robert Elz
Date:Wed, 25 Dec 2019 18:06:39 +0100 From:Steffen Nurpmeso Message-ID: <20191225170639.ddhqn%stef...@sdaoden.eu> | Maybe the warning should really simply be removed, or only occur | if explicitly requested, i.e., remove the "el" warning bit from | the "all" leve

Re: CVS commit: src/sys/sys

2020-01-28 Thread Robert Elz
Date:Tue, 28 Jan 2020 16:40:27 + From:"Andrew Doran" Message-ID: <20200128164027.8558bf...@cvs.netbsd.org> | Log Message: | Put pri_t back to an int. It looks like there might be a sign extension | issue somewhere but it's not worth the hassle trying to fin

Re: CVS commit: src/bin/sh

2020-02-06 Thread Robert Elz
Date:Fri, 7 Feb 2020 01:25:08 + From:"Santhosh Raju" Message-ID: <20200207012508.38c9cf...@cvs.netbsd.org> | bin/sh: Fixes -Werror=shadow causing build breaks. Thanks for that. kre

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-12 Thread Robert Elz
Date:Thu, 13 Feb 2020 02:45:44 + From:Roy Marples Message-ID: | My understanding was if it could be promoted to an int it would be. | So it size_t is bigger in bits than uint16_t and int is also bigger then | promotion occurs and we then have signed vs uns

Re: CVS commit: src/sys/dev/usb

2020-03-17 Thread Robert Elz
Date:Tue, 17 Mar 2020 22:58:24 -0400 From:"Christos Zoulas" Message-ID: <20200318025824.93b28f...@cvs.netbsd.org> | Log Message: | define un (pointed out by kre@) The reason I didn't suggest that change, is that now un is unused when USB_DEBUG is not defined. A

Re: CVS commit: src/lib/librumpuser

2020-03-23 Thread Robert Elz
Date:Tue, 24 Mar 2020 01:56:56 + From:"Kamil Rytarowski" Message-ID: <20200324015656.33df1f...@cvs.netbsd.org> | Module Name:src | Committed By: kamil | Date: Tue Mar 24 01:56:56 UTC 2020 | | Modified Files: | src/lib/li

Re: CVS commit: src/lib/librumpuser

2020-03-23 Thread Robert Elz
Date:Tue, 24 Mar 2020 05:40:13 +0100 From:Kamil Rytarowski Message-ID: | This patch was sitting in the tree since August 2019. In your tree I assume you mean, it certainly hasn't been in mine. Was a PR filed about the issue back then? If so, shouldn't it have

Re: CVS commit: src/lib/librumpuser

2020-03-24 Thread Robert Elz
Date:Tue, 24 Mar 2020 13:27:45 +0100 From:Kamil Rytarowski Message-ID: <5ec1195a-f1c8-cd46-6a14-ea29da109...@gmx.com> | I patched it myself only when I reproduced the problems myself. I have no doubt that there's a bug that needs fixing - it is the fix proposed tha

Re: CVS commit: src/lib/librumpuser

2020-03-24 Thread Robert Elz
Date:Tue, 24 Mar 2020 19:37:02 +0100 From:Kamil Rytarowski Message-ID: <57a7e062-9af0-0be9-cb24-e155c5f83...@gmx.com> | ASan detects not a hypothetical, but factual momory corruption. Yes, I know that - and I believed you from the start that there was a buffer over

Re: CVS commit: src/lib/libc/string

2020-03-25 Thread Robert Elz
Date:Wed, 25 Mar 2020 20:51:25 + From:David Holland Message-ID: <20200325205125.ga11...@netbsd.org> | I don't agree -- because applications shouldn't attempt to modify the | result, it should be const. The only reason apps shouldn't modify the string is in ca

Re: CVS commit: src/external/gpl3

2020-03-25 Thread Robert Elz
Date:Wed, 25 Mar 2020 20:59:59 -0400 From:Greg Troxel Message-ID: | I'll fourth this sentiment. Me too (5th...) The idea that /tmp is smaller than /var/tmp (or has less available space) is based upon historic RAM sizes, my /tmp currently has about 10 times as muc

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Robert Elz
Date:Thu, 26 Mar 2020 15:11:46 +0100 From:Kamil Rytarowski Message-ID: <26eaf84f-616a-d48b-9a2f-7dd74cd69...@gmx.com> | Right. Addressing tools build independently (honoring TMPDIR?) This we should do. | defining TMPDIR in /etc shell profile for common use insi

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Robert Elz
Date:Thu, 26 Mar 2020 16:28:18 +0100 From:Kamil Rytarowski Message-ID: <84460ebb-b4bf-f3ee-e51b-e27d0b6e2...@gmx.com> | That is negligible cost of getting TMPDIR propagated to most programs. Sure, it isn't much, for one program, but when you're running tens of tho

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Robert Elz
Date:Thu, 26 Mar 2020 18:07:54 +0100 From:Kamil Rytarowski Message-ID: <723e979c-cb16-1a39-a51e-9d756f372...@gmx.com> | But nonetheless, I'm trying to fix it un GCC without TMPDIR. Not without, just without requiring. Something like tempnam(3) works - if TMPDIR i

Re: CVS commit: src/external/gpl3

2020-03-26 Thread Robert Elz
Date:Thu, 26 Mar 2020 23:22:57 + From:Andrew Doran Message-ID: <20200326232257.gf27...@homeworld.netbsd.org> | > Modern CPUs like Ryzen Threadripper 3990X can execute that extra amount | > of instructions (around 600) in a single clock cycle. | | NetBSD-cu

Re: CVS commit: src/external/gpl3

2020-03-27 Thread Robert Elz
Date:Sat, 28 Mar 2020 11:46:29 +1100 From:matthew green Message-ID: <15233.1585356...@splode.eterna.com.au> | can we just leave this as-is and let netbsd GCC people care? Only if the GCC people do care, and understand the issue, and implement what we want Base

Re: CVS commit: src/sys/modules/examples/fopsmapper

2020-04-01 Thread Robert Elz
Date:Wed, 1 Apr 2020 11:45:53 + From:"Kamil Rytarowski" Message-ID: <20200401114554.05167f...@cvs.netbsd.org> | Log Message: | Avoid comparison between signed and unsigned integer | | Cast PAGE_SIZE to size_t. This kind of pedantry is going way too far, P

Re: CVS commit: src/lib/librumpuser

2020-04-01 Thread Robert Elz
Date:Wed, 1 Apr 2020 15:54:15 +0200 From:Kamil Rytarowski Message-ID: <969362d2-d93e-2cf4-7437-ab593ab11...@gmx.com> | Ping? This still breaks. I am still working on it.Best I can tell at the minute is that the \0 is potentially needed (in a theoretical sense)

Re: CVS commit: src/sys/modules/examples/fopsmapper

2020-04-01 Thread Robert Elz
Date:Wed, 1 Apr 2020 16:31:01 +0200 From:Kamil Rytarowski Message-ID: | Does it look better? | | http://netbsd.org/~kamil/patch-00244-fopsmapper-PAGE_SIZE.txt Apart from it needing to be (expressed in the relevant make syntax, whatever that is) if (WA

Re: CVS commit: src/lib/libc/string

2020-04-05 Thread Robert Elz
Date:Sat, 4 Apr 2020 21:16:45 + From:David Holland Message-ID: <20200404211645.ga19...@netbsd.org> | I fail to see any scenario in which it's legitimate for an application | to scribble in internal data belonging to libc. Why should this be | permitted? You

Re: CVS commit: src/sys/netinet6

2020-04-12 Thread Robert Elz
Now that's a simpler fix than I imagined it would be... kre

Re: CVS commit: src/sys

2020-04-17 Thread Robert Elz
Date:Thu, 16 Apr 2020 18:04:04 -0700 From:Jason Thorpe Message-ID: <432f538a-b863-441b-b4d0-0cd2e9d38...@me.com> | The sooner we get off of "things that use RCS semantics" the better. For this, RCS and RCS semantics are irrelevant aren't they? The only relevance

Re: CVS commit: src/sys

2020-04-17 Thread Robert Elz
Date:Fri, 17 Apr 2020 15:37:33 +0200 From:Manuel Bouyer Message-ID: <20200417133733.ga5...@antioche.eu.org> | And that would be a problem for me. I regulary update a single file to a | specific revision in a source tree. Me too - I pull the current sh into NetBSD

Re: CVS commit: src/sys

2020-04-17 Thread Robert Elz
Date:Fri, 17 Apr 2020 07:52:53 -0700 From:Jason Thorpe Message-ID: <7e54033f-9f14-4db3-a11a-01d63cd92...@me.com> | The New Hotness (which isn't particularly new, at this point) | is to create branches and merge what you want into that branch. What I don't underst

Re: CVS commit: src/sys

2020-04-18 Thread Robert Elz
Date:Sat, 18 Apr 2020 10:29:33 + From:m...@netbsd.org Message-ID: <20200418102933.ga24...@homeworld.netbsd.org> | I feel like it's difficult to decide which is objectively better. It all depends upon usage patterns, and objectives. | CVS encourages you to kee

Re: CVS commit: src/lib/librumpuser

2020-05-05 Thread Robert Elz
Date:Wed, 6 May 2020 07:30:17 +0200 From:Kamil Rytarowski Message-ID: | I reverted my fix It wasn't a fix, it simply made the problem go away, incorrectly. If you want you can just delete the relevant lines (the ones you changed). I've been running like that now

Re: CVS commit: src/bin/kill

2020-05-06 Thread Robert Elz
Date:Wed, 6 May 2020 11:28:42 +0200 From:Kamil Rytarowski Message-ID: | While there, we have got a long standing issue with wait.1 man page, Huh! I had no idea any such thing existed... (do you know of any more bizarre ones like that?) | it should be either

Re: CVS commit: src/tests/lib/libc/sys

2020-05-11 Thread Robert Elz
Date:Mon, 11 May 2020 11:03:15 + From:"Kamil Rytarowski" Message-ID: <2020050315.54b13f...@cvs.netbsd.org> | Do not fail when trying to kill a dying process | | A dying process can disappear for a while. Rather than aborting, retry | sending SIGKILL to

Re: CVS commit: src/tests/lib/libc/sys

2020-05-11 Thread Robert Elz
Date:Mon, 11 May 2020 13:47:45 +0200 From:Kamil Rytarowski Message-ID: <54178983-82d1-df3d-fd54-549a6c73f...@gmx.com> | The only purpose of the test is to check whether misaligned program | counter can crash the kernel (it can for NetBSD/sparc). Later, if a | pr

Re: CVS commit: src

2020-06-04 Thread Robert Elz
Date:Fri, 5 Jun 2020 01:50:47 +0200 From:Kamil Rytarowski Message-ID: | What happened to RT signal names? | | I'm not sure what's wrong as this code works under a debugger. No idea right now, but I will take a look. Which shell are you using for that? And w

Re: CVS commit: src

2020-06-04 Thread Robert Elz
Date:Fri, 5 Jun 2020 04:19:09 +0200 From:Kamil Rytarowski Message-ID: <99440f2e-c0fc-5e47-4f8b-137bdf5a3...@netbsd.org> | I can see the problem now. It's a fault in ksh(1). Whether this actually amounts to being called a "fault" or not is not so clear ... most sys

Re: CVS commit: src/sys/compat/sys

2020-06-28 Thread Robert Elz
Date:Sat, 27 Jun 2020 11:49:30 -0400 From:"Christos Zoulas" Message-ID: <20200627154930.84e22f...@cvs.netbsd.org> | Modified Files: | src/sys/compat/sys: mount.h | | Log Message: | Ignore the supplied size, and always use the argument size that we know.

Re: CVS commit: src/usr.bin/printf

2020-06-28 Thread Robert Elz
Date:Fri, 26 Jun 2020 22:05:05 + From:"Valeriy E. Ushakov" Message-ID: <20200626220505.e9030f...@cvs.netbsd.org> | Modified Files: | src/usr.bin/printf: printf.1 | | Log Message: | Drop redundant quoting in the nested printf example. I don't think t

Re: CVS commit: src/usr.bin/printf

2020-06-29 Thread Robert Elz
Date:Sun, 28 Jun 2020 22:58:52 +0300 From:Valery Ushakov Message-ID: <20200628195852.gc20...@pony.stderr.spb.ru> | but I'd expect people that actually use IFS with octal digits | or a backslash to also understand and know how to add necessary | quoting in that c

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Robert Elz
Date:Sat, 11 Jul 2020 18:24:51 +0300 From:Kimmo Suominen Message-ID: <20200711152451.ga1...@homeworld.netbsd.org> | On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: | > I don't understand the change. When was this broken? This has always worked

Re: CVS commit: src/bin/kill

2020-08-30 Thread Robert Elz
Date:Sun, 30 Aug 2020 16:10:40 + From:"Robert Elz" Message-ID: <20200830161040.57630f...@cvs.netbsd.org> | Log Message: | Use the POSIX specified format [...] Ugh ... that should have mentioned that this applies to the output of "kill -l" kre

Re: CVS commit: src/usr.bin/make

2020-09-14 Thread Robert Elz
Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't have | named constants as well. Most likely t

Re: CVS commit: src/external/public-domain/tz/dist

2020-10-08 Thread Robert Elz
Date:Thu, 08 Oct 2020 19:11:59 +1100 From:matthew green Message-ID: <22915.1602144...@splode.eterna.com.au> | at least pacificnew is referenced by the build still: Yes, sorry, the way that tzdata updates get done makes it essentially impossible to test what is goin

Re: CVS commit: src/external/gpl3/gcc/dist/gcc/config/aarch64

2020-10-16 Thread Robert Elz
Date:Fri, 16 Oct 2020 04:07:31 + From:"Thomas Mueller" Message-ID: <20201016052422.e063084...@mail.netbsd.org> | Should I add ,linux to the end of the procfs line? You can, but it isn't needed these days -- I used to mount procfs twice, once without the linux o

Re: CVS commit: src/sbin/mount

2020-10-24 Thread Robert Elz
Date:Sat, 24 Oct 2020 10:51:34 + From:"Nia Alarie" Message-ID: <20201024105134.6539bf...@cvs.netbsd.org> | file systems that are used as what spools? Ah, youth! The old text: This option is useful for optimizing read performance on file systems

Re: please put back cat man pages, and what's the deal with warp?

2020-11-10 Thread Robert Elz
Date:Tue, 10 Nov 2020 10:07:32 +0100 From:Kamil Rytarowski Message-ID: | Revert MKCATPAGES change? No, the changes to the mtree config that stopped creating the catN directories, and anything else that has happened that is not 100% MKCATPAGES. On games/dungeon

Re: CVS commit: src/external/bsd/unbound/lib/libunbound

2021-01-01 Thread Robert Elz
Date:Fri, 1 Jan 2021 20:38:36 + From:"Roy Marples" Message-ID: <20210101203836.2cadcf...@cvs.netbsd.org> | Modified Files: | src/external/bsd/unbound/lib/libunbound: Makefile | | Log Message: | libunbound: Now we use libevent, don't build mini_event

Re: CVS commit: src/sys/arch

2021-01-25 Thread Robert Elz
Date:Mon, 25 Jan 2021 08:19:44 -0800 From:Jason Thorpe Message-ID: | Using { 0 } makes an assumption about the first member of the | structure which is not guaranteed to remain true. That's right, but you could explicitly init a named field, most likely the one

Re: CVS commit: src/lib/libc/stdio

2021-01-31 Thread Robert Elz
Date:Sun, 31 Jan 2021 18:34:22 +0100 From:Joerg Sonnenberger Message-ID: | That makes no sense. Just turn them into a short read, which is | something users have to deal with anyway. I'm not sure I agree with that one. If the user's size * nmemb overflows a si

Re: CVS commit: src/lib/libc/stdio

2021-02-01 Thread Robert Elz
Date:Mon, 1 Feb 2021 17:50:54 + From:"Jaromir Dolecek" Message-ID: <20210201175054.112e7f...@cvs.netbsd.org> | FreeBSD has a similar check, but they return EINVAL instead, feel | free to adjust if SUS or other standard mandates specific value Not currently (u

Re: CVS commit: othersrc/usr.bin/sleepto

2021-02-26 Thread Robert Elz
Date:Fri, 26 Feb 2021 16:42:37 +1100 From:Simon Burge Message-ID: <20210226054237.6b07d4e...@thoreau.thistledown.com.au> | Thinking about adding this to our existing sleep(1), so anything | in existing libraries that makes this (much!) easier is welcome. I use th

Re: CVS commit: src/share/misc

2021-03-31 Thread Robert Elz
Date:Wed, 31 Mar 2021 03:03:53 - (UTC) From:chris...@astron.com (Christos Zoulas) Message-ID: | There are 3 x 'sizeof(' in the tree compared to 'sizeof ' in '*.c' and | I am counting 'sizeof (' as 'sizeof ': | | 191337 'sizeof(' | 63508 'sizeof ' |

Re: CVS commit: src/usr.bin/at

2021-04-02 Thread Robert Elz
Date:Fri, 2 Apr 2021 06:31:53 + From:"Simon Burge" Message-ID: <20210402063153.773c7f...@cvs.netbsd.org> | Add an XXX reminder to convert at(1) to use parsedate(3) in . If that's intended as an optional facility (at -d ... or something), then fine, but please d

Re: CVS commit: src/sys/dev

2021-04-23 Thread Robert Elz
Date:Sat, 24 Apr 2021 00:15:37 + From:"Michael Lorenz" Message-ID: <20210424001537.c5c83f...@cvs.netbsd.org> | add an ioctl() to get a list of fonts currently available via wsfont It seems to me it would be useful for that ioctl to copyout() the fi_numentries f

Re: CVS commit: src/sys/dev

2021-04-23 Thread Robert Elz
Oh, I see from your code change to wsfontload.c that you intended for the fi_numentries field to get copied out, it just doesn't seem to happen. I also see that the addr==NULL case happens if malloc() (in wsfontload.c) failed - going ahead with the ioctl() in that case seems like a mistake, optimi

Re: CVS commit: src/include

2021-04-30 Thread Robert Elz
Date:Fri, 30 Apr 2021 12:07:49 -0400 From:"Christos Zoulas" Message-ID: <20210430160749.3a4dbf...@cvs.netbsd.org> | src/include: resolv.h | | Log Message: | Default to check-names for safety. Please don't do that, check-names applies at the wrong place, a

Re: CVS commit: xsrc/external/mit/xterm/dist

2021-05-16 Thread Robert Elz
Date:Sun, 16 May 2021 16:32:55 +1000 From:Simon Burge Message-ID: <20210516063255.13f704e...@thoreau.thistledown.com.au> | Roland Illig wrote: | > therefore I did it this way, for consistency. | | Good reason :) Actually, it isn't. Consistency is good, but c

Re: CVS commit: src/lib/libc/sys

2021-06-08 Thread Robert Elz
Date:Tue, 8 Jun 2021 16:15:12 + From:"Nia Alarie" Message-ID: <20210608161512.1d7c3f...@cvs.netbsd.org> | vfork.2: recommend posix_spawn instead You might want to reconsider the wording there, posix_spawn() is an alternative to [v]fork() + exec*(). Not just v

vfork() and posix_spawn() [was: Re: CVS commit: src/lib/libc/sys]

2021-06-13 Thread Robert Elz
Date:Sat, 12 Jun 2021 23:13:54 +0200 From:Joerg Sonnenberger Message-ID: Sorry, missed this message when I was cherry picking messages to read in a timely fashion. | On Wed, Jun 09, 2021 at 01:03:20AM +0700, Robert Elz wrote: | > after a vfork() the child

Re: vfork() and posix_spawn() [was: Re: CVS commit: src/lib/libc/sys]

2021-06-14 Thread Robert Elz
Date:Mon, 14 Jun 2021 03:56:48 +0200 From:Joerg Sonnenberger Message-ID: | This is even more true for multi-threaded applications | (where POSIX explicitly suggests that requirement). Sure, anything with fork() and threads has issues, that's messy. Even I know t

Re: CVS commit: src/etc/rc.d

2021-08-01 Thread Robert Elz
Date:Mon, 2 Aug 2021 11:54:27 +0900 From:Rin Okuyama Message-ID: | Install /etc/rc.d/zfs for everyone? Add a new dummy rc.d script (like LOGIN or DISKS) have devpubd come before that, and everything which should come later require it. That's cleaner. We should

Re: CVS commit: src/etc/rc.d

2021-08-02 Thread Robert Elz
Date:Mon, 2 Aug 2021 20:02:28 +0900 From:Rin Okuyama Message-ID: <21dae7de-f153-2e53-4e66-cc61c8241...@gmail.com> quoting Michael van Elst: | > If you insist on a separate barrier, one name would be USERDEVICEPATHS | > or short UDEV. UDEV (or UDEVS) sounds good

Re: CVS commit: src/sbin/devpubd/hooks

2021-08-08 Thread Robert Elz
Sorry, no idea what happened with that. And thanks Martin for fixing it. kre

Re: CVS commit: src/usr.bin

2021-08-19 Thread Robert Elz
Date:Thu, 19 Aug 2021 21:21:04 + From:"Roland Illig" Message-ID: <20210819212104.7c965f...@cvs.netbsd.org> | mkdep: fix prototype of findcc That broke the build. | A function that modifies a string argument must not declare that | argument as 'const char *

Re: CVS commit: src/sys/fs/puffs

2014-10-06 Thread Robert Elz
Date:Mon, 6 Oct 2014 14:26:44 + From:"Havard Eidnes" Message-ID: <20141006142644.7693...@cvs.netbsd.org> | Make this build again without debugging enabled; DPRINTF() can end up | as empty, and in an if conditional, you then need braces if that's the | only p

Re: CVS commit: src/sys/arch/amd64/conf

2014-10-15 Thread Robert Elz
Date:Sun, 12 Oct 2014 00:17:22 +0900 From:Masao Uebayashi Message-ID: For what it is worth, this change (below) just "bit" me - I did my first new builds for a couple of weeks, and my own Dom0 config failed to build (because even though the standard XEN3_DOM0 got th

Re: CVS commit: src/sys/fs/puffs

2014-10-15 Thread Robert Elz
Date:Wed, 15 Oct 2014 19:41:40 +0100 From:David Laight Message-ID: <20141015184140.gl23...@snowdrop.l8s.co.uk> | Consider what happens if you write: | When DPRINTF() expands 'if (xxx) yyy' it all goes horribly wrong. Of course, the do { } while(0) wrapping is nee

<    2   3   4   5   6   7   8   9   10   11   >