Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sun, Jul 12, 2020 at 12:05:37AM +0700, Robert Elz wrote: > Just to make things clear here, the LUN you're talking about is not > the scsi unit number (which is what I think Martin was referring to) > but a sub-device number within a single scsi ID. Right? Correct. I should have written "SCSI

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Robert Elz
Date:Sat, 11 Jul 2020 18:24:51 +0300 From:Kimmo Suominen Message-ID: <20200711152451.ga1...@homeworld.netbsd.org> | On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: | > I don't understand the change. When was this broken? This has always worked

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 06:24:51PM +0300, Kimmo Suominen wrote: > I think all real SCSI hardware I've had has always just only had LUN 0, > and each disk has been on its own SCSI ID (target). Yes, I confused ID and LUN here - just ignore me. Martin

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: > I don't understand the change. When was this broken? This has always worked > for me e.g. with the sd0 at LUN 3 and the controller at 6 or 7. I think all real SCSI hardware I've had has always just only had LUN 0, and each disk

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 05:57:46PM +0300, Kimmo Suominen wrote: > On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > > I'd reckon a pullup to NetBSD 9 would be in order? > > Yes, I was just waiting to be able to link to mail-index. I had > already checked that the patch applies

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > I'd reckon a pullup to NetBSD 9 would be in order? Yes, I was just waiting to be able to link to mail-index. I had already checked that the patch applies cleanly to both netbsd-9 and netbsd-8.

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Jukka Ruohonen
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote: > Use case 2: A Linode boot profile with multiple disks results in > the first disk ("sda") on LUN 1, while the second disk ("sdb") is > on LUN 0, each on their own bus. As Linode is quite popular, and supposedly uses a rather

[mii locking] Re: CVS commit: src/sys

2020-07-09 Thread Maxime Villard
Module Name:src Committed By: thorpej Date: Sun Mar 15 23:04:51 UTC 2020 Modified Files: src/sys/arch/arm/amlogic: gxlphy.c src/sys/arch/x86/pci: if_vmx.c src/sys/dev/mii: acphy.c amhphy.c atphy.c bmtphy.c brgphy.c ciphy.c dmphy.c etphy.c

Re: CVS commit: src/sys/conf

2020-07-08 Thread Simon Burge
"Valeriy E. Ushakov" wrote: > Module Name: src > Committed By: uwe > Date: Wed Jul 8 19:39:22 UTC 2020 > > Modified Files: > > src/sys/conf: assym.mk > > Log Message: > > Drop -fstack-usage* from CFLAGS passed genassym. > We don't want it to create a "-.su" file. Thanks! Cheers,

Re: CVS commit: src/sys

2020-07-08 Thread Jason Thorpe
> On Jul 8, 2020, at 12:22 AM, Martin Husemann wrote: > > On Tue, Jul 07, 2020 at 03:38:49AM +, Jason R Thorpe wrote: >> Provide a new resource provider API: > > This is *extremly* verbose and overflows message buffer, can you move the > new messages to aprint_debug or ifdef with some

Re: CVS commit: src/sys

2020-07-08 Thread Martin Husemann
On Tue, Jul 07, 2020 at 03:38:49AM +, Jason R Thorpe wrote: > Provide a new resource provider API: This is *extremly* verbose and overflows message buffer, can you move the new messages to aprint_debug or ifdef with some proper DEBUG_* please? Martin

Re: CVS commit: src/sys/arch/powerpc/booke

2020-07-06 Thread Rin Okuyama
On 2020/07/07 9:51, Jason Thorpe wrote: On Jul 6, 2020, at 5:28 PM, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Tue Jul 7 00:28:31 UTC 2020 Modified Files: src/sys/arch/powerpc/booke: e500_tlb.c Log Message: Fix kernel panic due to tmpfs. pmap for

Re: CVS commit: src/sys/arch/powerpc/booke

2020-07-06 Thread Jason Thorpe
> On Jul 6, 2020, at 5:28 PM, Rin Okuyama wrote: > > Module Name: src > Committed By: rin > Date: Tue Jul 7 00:28:31 UTC 2020 > > Modified Files: > src/sys/arch/powerpc/booke: e500_tlb.c > > Log Message: > Fix kernel panic due to tmpfs. > > pmap for booke assumes that the

Re: CVS commit: src

2020-07-04 Thread Paul Goyette
On Sat, 4 Jul 2020, Chuck Silvers wrote: Hi Paul, it's not clear to me why you were trying to do the thing that you were having trouble with in that PR... there shouldn't have been any need to include any xen headers or have any xen-conditional code in a module in the first place.

Re: CVS commit: src

2020-07-04 Thread Chuck Silvers
Hi Paul, it's not clear to me why you were trying to do the thing that you were having trouble with in that PR... there shouldn't have been any need to include any xen headers or have any xen-conditional code in a module in the first place. x86/cpu_ucode.c provides the same set of functions for

Re: CVS commit: src

2020-07-04 Thread Paul Goyette
Chuck, Does this mean that PR port-xen/53130 is no longer relevant? And I can now include microcode-loader compat code in the appropriate compat_xx module? :) On Sat, 4 Jul 2020, Chuck Silvers wrote: Module Name:src Committed By: chs Date: Sat Jul 4 21:02:16 UTC 2020

Re: CVS commit: src/usr.bin/make

2020-07-04 Thread Joerg Sonnenberger
On Sat, Jul 04, 2020 at 03:44:07PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Sat Jul 4 15:44:07 UTC 2020 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > make(1): fix :hash modifier on 16-bit platforms > > On platforms where int

Re: CVS commit: src/external/bsd/kyua-cli

2020-07-02 Thread Christos Zoulas
In article <20200702140653.gf12...@mewburn.net>, Luke Mewburn wrote: >On 20-06-21 18:23, Christos Zoulas wrote: > | In article <20200621142616.60471f...@cvs.netbsd.org>, > | Luke Mewburn wrote: > | >-=-=-=-=-=- > | > > | >Module Name: src > | >Committed By: lukem > | >Date:

Re: CVS commit: src/sys/arch/aarch64/aarch64

2020-07-02 Thread Jared McNeill
I think this will have issues on some big.LITTLE configurations like Rockchip RK3399. In the RK3399 case cpu[0-3] is VIPT I$ and cpu[4-5] is PIPT I$. Boot order of secondaries is not guaranteed so it is possible to get different values of aarch64_cache_vindexsize from one boot to the next.

Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi

2020-07-02 Thread scole_mail
Martin Husemann writes: > > That build pre-dates Luke's fix. > Ahh, you are correct and it built fine for me, apologies. Thanks

Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi

2020-07-02 Thread Martin Husemann
On Thu, Jul 02, 2020 at 08:03:09AM -0700, scole_mail wrote: > That change didn't work: > > http://releng.netbsd.org/builds/HEAD/202007020210Z/ia64.build.failed > ... > nbmake[10]: nbmake[10]: don't know how to make loader.efi.c. Stop That build pre-dates Luke's fix. Martin

Re: CVS commit: src/sys/arch/ia64/stand/ia64/efi

2020-07-02 Thread scole_mail
"Luke Mewburn" writes: > Module Name: src > Committed By: lukem > Date: Thu Jul 2 09:07:25 UTC 2020 > > Modified Files: > src/sys/arch/ia64/stand/ia64/efi: Makefile > > Log Message: > loader.efi doesn't have source > > (Untested fix) > > > To generate a diff of this commit: > cvs

Re: CVS commit: src/external/bsd/kyua-cli

2020-07-02 Thread Luke Mewburn
On 20-06-21 18:23, Christos Zoulas wrote: | In article <20200621142616.60471f...@cvs.netbsd.org>, | Luke Mewburn wrote: | >-=-=-=-=-=- | > | >Module Name: src | >Committed By: lukem | >Date: Sun Jun 21 14:26:16 UTC 2020 | > | >Modified Files: | >

Re: CVS commit: src/usr.bin/printf

2020-06-29 Thread Robert Elz
Date:Sun, 28 Jun 2020 22:58:52 +0300 From:Valery Ushakov Message-ID: <20200628195852.gc20...@pony.stderr.spb.ru> | but I'd expect people that actually use IFS with octal digits | or a backslash to also understand and know how to add necessary | quoting in that

Re: CVS commit: src/usr.bin/printf

2020-06-28 Thread Valery Ushakov
On Sun, Jun 28, 2020 at 21:52:23 +0700, Robert Elz wrote: > Date:Fri, 26 Jun 2020 22:05:05 + > From:"Valeriy E. Ushakov" > Message-ID: <20200626220505.e9030f...@cvs.netbsd.org> > > | Modified Files: > | src/usr.bin/printf: printf.1 > | > | Log Message:

Re: CVS commit: src/usr.bin/printf

2020-06-28 Thread Robert Elz
Date:Fri, 26 Jun 2020 22:05:05 + From:"Valeriy E. Ushakov" Message-ID: <20200626220505.e9030f...@cvs.netbsd.org> | Modified Files: | src/usr.bin/printf: printf.1 | | Log Message: | Drop redundant quoting in the nested printf example. I don't think

Re: CVS commit: src/sys/compat/sys

2020-06-28 Thread Christos Zoulas
> On Jun 28, 2020, at 10:24 AM, Robert Elz wrote: > >Date:Sat, 27 Jun 2020 11:49:30 -0400 >From:"Christos Zoulas" >Message-ID: <20200627154930.84e22f...@cvs.netbsd.org> > > | Modified Files: > |src/sys/compat/sys: mount.h > | > | Log Message: > | Ignore

Re: CVS commit: src/sys/compat/sys

2020-06-28 Thread Robert Elz
Date:Sat, 27 Jun 2020 11:49:30 -0400 From:"Christos Zoulas" Message-ID: <20200627154930.84e22f...@cvs.netbsd.org> | Modified Files: | src/sys/compat/sys: mount.h | | Log Message: | Ignore the supplied size, and always use the argument size that we know.

Re: CVS commit: src/sys/arch/powerpc/include

2020-06-27 Thread Rin Okuyama
Perhaps yes, but I'm not sure. How do you mips guys think? Thanks, rin On 2020/06/27 19:08, Jaromír Doleček wrote: Perhaps we can use a similar technique for mips too? There also the kernel actually always uses a compile-time fixed page size AFAICS. Jaromir Le sam. 27 juin 2020 à 04:51, Rin

Re: CVS commit: src/tests/lib/libc/stdlib

2020-06-27 Thread Jukka Ruohonen
On Sat, Jun 27, 2020 at 10:39:08AM +, m...@netbsd.org wrote: > > Add the default TNF copyright (2005), cf. PR misc/55419. > > I don't think we can generally do this. Can you clarify if you discussed > this with the author in commit messages? Well, the committer is christos, and I doubt he

Re: CVS commit: src/tests/lib/libc/stdlib

2020-06-27 Thread maya
On Sat, Jun 27, 2020 at 10:19:43AM +, Jukka Ruohonen wrote: > Module Name: src > Committed By: jruoho > Date: Sat Jun 27 10:19:43 UTC 2020 > > Modified Files: > src/tests/lib/libc/stdlib: t_mbtowc.c > > Log Message: > Add the default TNF copyright (2005), cf. PR misc/55419. >

Re: CVS commit: src/sys/arch/powerpc/include

2020-06-27 Thread Jaromír Doleček
Perhaps we can use a similar technique for mips too? There also the kernel actually always uses a compile-time fixed page size AFAICS. Jaromir Le sam. 27 juin 2020 à 04:51, Rin Okuyama a écrit : > > Module Name:src > Committed By: rin > Date: Sat Jun 27 02:51:23 UTC 2020 > >

re: CVS commit: src/sys/dev/ofw

2020-06-27 Thread matthew green
"Martin Husemann" writes: > Module Name: src > Committed By: martin > Date: Fri Jun 26 10:14:32 UTC 2020 > > Modified Files: > src/sys/dev/ofw: ofw_subr.c > > Log Message: > Remove !cold KASSERT - it does not compile on all kernels, and it is not the > right thing to test for

[statfs12] Re: CVS commit: src

2020-06-27 Thread Maxime Villard
Module Name:src Committed By: christos Date: Fri Oct 4 01:28:03 UTC 2019 Modified Files: src/lib/libc/compat/sys: compat_statfs.c src/sys/compat/common: vfs_syscalls_20.c src/sys/compat/sys: mount.h Log Message: deduplicate the conversion function from

Re: CVS commit: src/sys/arch/mips/cavium/dev

2020-06-26 Thread Simon Burge
Hi Rin, Rin Okuyama wrote: > Hi, > > On 2020/06/23 14:18, Simon Burge wrote: > > Module Name:src > > Committed By: simonb > > Date: Tue Jun 23 05:18:43 UTC 2020 > > > > Modified Files: > > src/sys/arch/mips/cavium/dev: octeon_uart.c > > > > Log Message: > > Add

Re: CVS commit: src/sys/arch/mips/cavium/dev

2020-06-26 Thread Rin Okuyama
Hi, On 2020/06/23 14:18, Simon Burge wrote: Module Name:src Committed By: simonb Date: Tue Jun 23 05:18:43 UTC 2020 Modified Files: src/sys/arch/mips/cavium/dev: octeon_uart.c Log Message: Add support for a very simple output-only console so early printf() can work.

re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m

2020-06-26 Thread matthew green
Sevan Janiyan writes: > On 25/06/2020 12:42, matthew green wrote: > > the manual in the tree might be called "foo.1m" by upstream, > > however, we should just install those into man8/foo.8. > > > > be nice to have a generic 1m -> 8 rule here, since i doubt > > that upstream will change from

Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m

2020-06-26 Thread Sevan Janiyan
On 25/06/2020 12:42, matthew green wrote: the manual in the tree might be called "foo.1m" by upstream, however, we should just install those into man8/foo.8. be nice to have a generic 1m -> 8 rule here, since i doubt that upstream will change from svr4/solaris naming. Ok, I'll take a look

Re: CVS commit: src/sys/dev/ic

2020-06-25 Thread Christos Zoulas
In article <18083.1593053...@splode.eterna.com.au>, matthew green wrote: >"Jaromir Dolecek" writes: >> Module Name: src >> Committed By:jdolecek >> Date:Wed Jun 24 19:55:25 UTC 2020 >> >> Modified Files: >> src/sys/dev/ic: ibm561.c >> >> Log Message: >> avoid

re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m

2020-06-25 Thread matthew green
> > The best way should be automatically converting them by some script > > when building. But if it is too difficult, we can install these files > > as is with minimum adjustments for our system; mandoc still works for > > them, although output is not very beautiful. > > I shouldn't have

Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m

2020-06-25 Thread Rin Okuyama
On 2020/06/25 17:39, Sevan Janiyan wrote: On 25/06/2020 08:48, Rin Okuyama wrote: > Thank you for working on this, but this makes sync with upstream > very difficult... I will be upstreaming these changes. upstream: github.com/opendtrace/toolkit Just need to find a better way for presenting

Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m

2020-06-25 Thread Sevan Janiyan
Hello, On 25/06/2020 08:48, Rin Okuyama wrote: > Thank you for working on this, but this makes sync with upstream > very difficult... I will be upstreaming these changes. upstream: github.com/opendtrace/toolkit Just need to find a better way for presenting the columns for field descriptions,

Re: CVS commit: src/external/cddl/dtracetoolkit/dist/Man/man1m

2020-06-25 Thread Rin Okuyama
Hi, On 2020/06/25 3:06, Sevan Janiyan wrote: Module Name:src Committed By: sevan Date: Wed Jun 24 18:06:01 UTC 2020 Modified Files: src/external/cddl/dtracetoolkit/dist/Man/man1m: opensnoop.1m Log Message: mdocify Thank you for working on this, but this makes sync

re: CVS commit: src/sys/arch/x86/x86

2020-06-24 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 22:28:08 UTC 2020 > > Modified Files: > src/sys/arch/x86/x86: multiboot2.c > > Log Message: > don't try allocating 16KB of scratch space on stack > > it's too early for kmem_alloc(), so use

re: CVS commit: src/sys/dev/ic

2020-06-24 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 19:55:25 UTC 2020 > > Modified Files: > src/sys/dev/ic: ibm561.c > > Log Message: > avoid allocating almost 5k struct ibm561data on stack in ibm561_cninit(); > it's too early for kmem_alloc(),

Re: CVS commit: src/sys/arch/x86/x86

2020-06-24 Thread Joerg Sonnenberger
On Wed, Jun 24, 2020 at 10:28:08PM +, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 22:28:08 UTC 2020 > > Modified Files: > src/sys/arch/x86/x86: multiboot2.c > > Log Message: > don't try allocating 16KB of scratch space on stack > >

Re: CVS commit: src/tests/usr.sbin

2020-06-24 Thread Jukka Ruohonen
On Wed, Jun 24, 2020 at 03:05:45PM +, Martin Husemann wrote: > Modified Files: > src/tests/usr.sbin/stdethers: Makefile > src/tests/usr.sbin/stdhosts: Makefile > > Log Message: > Add input files Ups. I try to be more careful, now that I again remember the nitty-gritties. - Jukka

Re: CVS commit: src/sys/arch/xen/xen

2020-06-24 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Fri Apr 10 18:03:06 UTC 2020 > > Modified Files: > src/sys/arch/xen/xen: if_xennet_xenbus.c > > Log Message: > convert to bus_dma(9), remove now not necessary XENPVHVM redefines > [...] > +

re: CVS commit: src/external/gpl3/gcc/usr.bin/host-libcpp

2020-06-24 Thread matthew green
> Modified Files: > src/external/gpl3/gcc/usr.bin/host-libcpp: Makefile > > Log Message: > PR bin/55411 (Akihiko HAYASHI) > > Remove stray ``&&'' introduced in the previous revision, so that > host tools are correctly passed to configure script. > > No similar problem for gcc.old. No

Re: CVS commit: src/distrib/sets/lists/man

2020-06-23 Thread Rin Okuyama
On 2020/06/24 6:34, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Tue Jun 23 21:34:44 UTC 2020 Modified Files: src/distrib/sets/lists/man: mi Log Message: Fix prefix for previous. Oops, s/prefix/suffix/ apparently. I need coffee... Thanks, rin

Re: CVS commit: src/sys/dev/acpi

2020-06-23 Thread Jukka Ruohonen
On Mon, Jun 22, 2020 at 04:14:18PM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Mon Jun 22 16:14:18 UTC 2020 > > Modified Files: > src/sys/dev/acpi: acpi.c > > Log Message: > Fix memory leak. Found by kLSan. > + > + default: > +

Re: CVS commit: src/tests/lib/libc/sys

2020-06-22 Thread Rin Okuyama
Committed. Thank you for your comment! rin On 2020/06/22 20:09, Kamil Rytarowski wrote: On 22.06.2020 04:51, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon Jun 22 02:51:07 UTC 2020 Modified Files: src/tests/lib/libc/sys: t_ptrace_signal_wait.h

Re: CVS commit: src/sys/arch/powerpc

2020-06-22 Thread Joerg Sonnenberger
On Mon, Jun 22, 2020 at 05:34:57AM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Mon Jun 22 05:34:57 UTC 2020 > > Modified Files: > src/sys/arch/powerpc/include: mcontext.h types.h > src/sys/arch/powerpc/powerpc: sig_machdep.c > > Log Message: >

Re: CVS commit: src/tests/lib/libc/sys

2020-06-22 Thread Kamil Rytarowski
On 22.06.2020 04:51, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Mon Jun 22 02:51:07 UTC 2020 > > Modified Files: > src/tests/lib/libc/sys: t_ptrace_signal_wait.h t_ptrace_wait.h > > Log Message: > Turn trigger_fpe() back to integer division by zero for a

Re: CVS commit: src/sys/arch/powerpc

2020-06-21 Thread Rin Okuyama
On 2020/06/22 5:10, Joerg Sonnenberger wrote: On Sun, Jun 21, 2020 at 12:40:00AM +, Rin Okuyama wrote: - Obsolete __lwp_settcb() in order to let kernel know new TLS address via _lwp_setprivate(2). Alternatively, we can call _lwp_setprivate(2) within __lwp_settcb() like mips, but it is

Re: CVS commit: src/sys/arch/powerpc

2020-06-21 Thread Joerg Sonnenberger
On Sun, Jun 21, 2020 at 12:40:00AM +, Rin Okuyama wrote: > - Obsolete __lwp_settcb() in order to let kernel know new TLS address via > _lwp_setprivate(2). Alternatively, we can call _lwp_setprivate(2) within > __lwp_settcb() like mips, but it is just double handling; we adjust %r2 >

Re: CVS commit: src/external/bsd/kyua-cli

2020-06-21 Thread Christos Zoulas
In article <20200621142616.60471f...@cvs.netbsd.org>, Luke Mewburn wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: lukem >Date: Sun Jun 21 14:26:16 UTC 2020 > >Modified Files: > src/external/bsd/kyua-cli: Makefile.inc > >Log Message: >kyua-cli: avoid warning about

Re: CVS commit: src/sys/rump/include/rump

2020-06-17 Thread Kamil Rytarowski
On 16.06.2020 14:23, Kamil Rytarowski wrote: > On 16.06.2020 12:25, J. Hannken-Illjes wrote: >>> On 15. Jun 2020, at 01:38, Kamil Rytarowski wrote: >>> >>> Module Name:src >>> Committed By: kamil >>> Date: Sun Jun 14 23:38:25 UTC 2020 >>> >>> Modified Files: >>>

Re: CVS commit: src/tests/lib/libc/sys

2020-06-17 Thread Rin Okuyama
On 2020/06/17 17:42, Rin Okuyama wrote: Now, all *_crash_fpe tests pass for powerpc, and nothing changes for amd64 at least. Here, powerpc means powerpc/oea, more specifically Mac mini G4. At the moment, fenv.h doesn't work correctly on booke and ibm4xx, where FPU is emulated in software. For

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Paul Goyette
On Tue, 16 Jun 2020, Martin Husemann wrote: On Tue, Jun 16, 2020 at 09:12:40AM -0700, Paul Goyette wrote: It might be better to run the test in a rump-kernel rather than in a "live" environment The test this is about is a plain userland test: it extracts/compresses/decompresses various

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Martin Husemann
On Tue, Jun 16, 2020 at 09:12:40AM -0700, Paul Goyette wrote: > It might be better to run the test in a rump-kernel rather than in a > "live" environment The test this is about is a plain userland test: it extracts/compresses/decompresses various archive formats and compares results. Only

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Paul Goyette
On Tue, 16 Jun 2020, Greg Troxel wrote: Jason Thorpe writes: On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: No, that is definitively not OK, which is what the PR is about. It is not OK for a regular atf run to cause a reboot of the test machine though, so this is a temporary hack

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Greg Troxel
Jason Thorpe writes: >> On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: >> >> No, that is definitively not OK, which is what the PR is about. >> >> It is not OK for a regular atf run to cause a reboot of the test machine >> though, so this is a temporary hack around the issue (and

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Jason Thorpe
> On Jun 16, 2020, at 8:43 AM, Martin Husemann wrote: > > No, that is definitively not OK, which is what the PR is about. > > It is not OK for a regular atf run to cause a reboot of the test machine > though, so this is a temporary hack around the issue (and admitedly a very > ugly hack).

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Martin Husemann
On Tue, Jun 16, 2020 at 03:38:26PM -, Christos Zoulas wrote: > So we are saying that it is ok for process running with regular priority, > to be able to starve another process at the same priority from getting > any runtime for 21 seconds in a uniprocessor kernel, and this does not > indicate

Re: CVS commit: src/tests/lib/libarchive

2020-06-16 Thread Christos Zoulas
In article <20200616075907.ecafcf...@cvs.netbsd.org>, Martin Husemann wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: martin >Date: Tue Jun 16 07:59:07 UTC 2020 > >Modified Files: > src/tests/lib/libarchive: t_libarchive.sh > >Log Message: >PR kern/55272: skip this test

Re: CVS commit: src/sys/rump/include/rump

2020-06-16 Thread Kamil Rytarowski
On 16.06.2020 12:25, J. Hannken-Illjes wrote: >> On 15. Jun 2020, at 01:38, Kamil Rytarowski wrote: >> >> Module Name: src >> Committed By:kamil >> Date:Sun Jun 14 23:38:25 UTC 2020 >> >> Modified Files: >> src/sys/rump/include/rump: rump.h >> >> Log Message: >>

Re: CVS commit: src/sys/rump/include/rump

2020-06-16 Thread J. Hannken-Illjes
> On 15. Jun 2020, at 01:38, Kamil Rytarowski wrote: > > Module Name: src > Committed By: kamil > Date: Sun Jun 14 23:38:25 UTC 2020 > > Modified Files: > src/sys/rump/include/rump: rump.h > > Log Message: > Remove old compat include of rump_syscallshotgun.h > > It was

Re: CVS commit: src/common/lib/libprop

2020-06-12 Thread Kamil Rytarowski
On 12.06.2020 03:09, Joerg Sonnenberger wrote: > On Fri, Jun 12, 2020 at 02:59:40AM +0200, Kamil Rytarowski wrote: >> On 12.06.2020 02:07, Joerg Sonnenberger wrote: >>> On Fri, Jun 12, 2020 at 01:28:15AM +0200, Kamil Rytarowski wrote: Please list legitimate false positives. There is

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Joerg Sonnenberger
On Fri, Jun 12, 2020 at 02:59:40AM +0200, Kamil Rytarowski wrote: > On 12.06.2020 02:07, Joerg Sonnenberger wrote: > > On Fri, Jun 12, 2020 at 01:28:15AM +0200, Kamil Rytarowski wrote: > >> Please list legitimate false positives. There is practically nothing > >> like that possible for using

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Kamil Rytarowski
On 12.06.2020 02:07, Joerg Sonnenberger wrote: > On Fri, Jun 12, 2020 at 01:28:15AM +0200, Kamil Rytarowski wrote: >> Please list legitimate false positives. There is practically nothing >> like that possible for using deprecated APIs (at least kept longer >> term). Besides that, the report shall

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Joerg Sonnenberger
On Fri, Jun 12, 2020 at 01:28:15AM +0200, Kamil Rytarowski wrote: > Please list legitimate false positives. There is practically nothing > like that possible for using deprecated APIs (at least kept longer > term). Besides that, the report shall be lowered to warning (like it > used to be for

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Jason Thorpe
> On Jun 11, 2020, at 4:28 PM, Kamil Rytarowski wrote: > >> Repeating that statement doesn't make it true. The amount of legit >> problems found by them is dwarfed by far by the number of false >> positives seen. That's complete ignoring basic QoI issues like "where is >> this actually

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Christos Zoulas
As Joerg mentioned, he believes that the error behavior is the way to go. I think that it is not useful behavior to error out on these warnings. If we wanted this behavior, we would not use linker warnings, we'd outright remove the deprecated symbols. christos > On Jun 11, 2020, at 6:58 PM,

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Kamil Rytarowski
On 12.06.2020 01:11, Joerg Sonnenberger wrote: > On Fri, Jun 12, 2020 at 12:58:45AM +0200, Kamil Rytarowski wrote: >> On 12.06.2020 00:55, Christos Zoulas wrote: >>> In article <20200611222544.6d3a6f...@cvs.netbsd.org>, >>> Joerg Sonnenberger wrote: -=-=-=-=-=- Module Name:

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Joerg Sonnenberger
On Fri, Jun 12, 2020 at 12:58:45AM +0200, Kamil Rytarowski wrote: > On 12.06.2020 00:55, Christos Zoulas wrote: > > In article <20200611222544.6d3a6f...@cvs.netbsd.org>, > > Joerg Sonnenberger wrote: > >> -=-=-=-=-=- > >> > >> Module Name: src > >> Committed By: joerg > >> Date:

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Joerg Sonnenberger
On Thu, Jun 11, 2020 at 10:55:16PM -, Christos Zoulas wrote: > In article <20200611222544.6d3a6f...@cvs.netbsd.org>, > Joerg Sonnenberger wrote: > >-=-=-=-=-=- > > > >Module Name: src > >Committed By:joerg > >Date:Thu Jun 11 22:25:44 UTC 2020 > > > >Modified Files: > >

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Kamil Rytarowski
On 12.06.2020 00:55, Christos Zoulas wrote: > In article <20200611222544.6d3a6f...@cvs.netbsd.org>, > Joerg Sonnenberger wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:joerg >> Date:Thu Jun 11 22:25:44 UTC 2020 >> >> Modified Files: >>

Re: CVS commit: src/common/lib/libprop

2020-06-11 Thread Christos Zoulas
In article <20200611222544.6d3a6f...@cvs.netbsd.org>, Joerg Sonnenberger wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: joerg >Date: Thu Jun 11 22:25:44 UTC 2020 > >Modified Files: > src/common/lib/libprop: prop_object_impl.h > >Log Message: >Unbreak clang builds by

Re: CVS commit: src/share/misc

2020-06-11 Thread Sevan Janiyan
On 11/06/2020 10:15, Sevan Janiyan wrote: > Sync with r359561 That should've been r361673 Sevan

re: CVS commit: src

2020-06-10 Thread matthew green
"Maxime Villard" writes: > Module Name: src > Committed By: maxv > Date: Sun Jun 7 09:45:20 UTC 2020 > > Modified Files: > src/etc: MAKEDEV.tmpl > src/sys/arch/amd64/conf: ALL GENERIC > src/sys/conf: files majors > src/sys/kern: files.kern subr_pool.c > Added

Re: CVS commit: src/sys/arch/mips/mips

2020-06-09 Thread Simon Burge
Simon Burge wrote: > > > Module Name: src > > > Committed By: simonb > > > Date: Tue Jun 9 06:18:01 UTC 2020 > > > > > > Modified Files: > > > src/sys/arch/mips/mips: mips_machdep.c > > > > > > Log Message: > > > If we are on a SiByte or Cavium CPU with an FPU, report as

Re: CVS commit: src/sys/arch/mips/mips

2020-06-09 Thread Simon Burge
Izumi Tsutsui wrote: > > Module Name:src > > Committed By: simonb > > Date: Tue Jun 9 06:18:01 UTC 2020 > > > > Modified Files: > > src/sys/arch/mips/mips: mips_machdep.c > > > > Log Message: > > If we are on a SiByte or Cavium CPU with an FPU, report as

Re: CVS commit: src/lib/libpthread

2020-06-09 Thread Andrew Doran
On Thu, Jun 04, 2020 at 06:26:07PM +, Martin Husemann wrote: > On Wed, Jun 03, 2020 at 10:10:24PM +, Andrew Doran wrote: > > Module Name:src > > Committed By: ad > > Date: Wed Jun 3 22:10:24 UTC 2020 > > > > Modified Files: > > src/lib/libpthread:

Re: CVS commit: src/sys/arch/mips/mips

2020-06-09 Thread Izumi Tsutsui
> Module Name: src > Committed By: simonb > Date: Tue Jun 9 06:18:01 UTC 2020 > > Modified Files: > src/sys/arch/mips/mips: mips_machdep.c > > Log Message: > If we are on a SiByte or Cavium CPU with an FPU, report as "built-in FPU" > instead of saying it's an unknown FPU type. >

Re: CVS commit: src

2020-06-07 Thread Joerg Sonnenberger
On Sun, Jun 07, 2020 at 02:43:06PM -0700, Jason Thorpe wrote: > > > On Jun 7, 2020, at 1:57 PM, Joerg Sonnenberger wrote: > > > >> Example? > > > > https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html#index-g_t_0040code_007bdeprecated_007d-attribute_002e-2502 > > I meant an

Re: CVS commit: src

2020-06-07 Thread Jason Thorpe
> On Jun 7, 2020, at 1:57 PM, Joerg Sonnenberger wrote: > >> Example? > > https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html#index-g_t_0040code_007bdeprecated_007d-attribute_002e-2502 I meant an example in our tree. We use __warn_reference() in several places already. I

Re: CVS commit: src

2020-06-07 Thread Kamil Rytarowski
On 07.06.2020 22:57, Joerg Sonnenberger wrote: > On Sun, Jun 07, 2020 at 01:27:48PM -0700, Jason Thorpe wrote: >> >>> On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: >>> >>> On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: ==> Deprecate mutable prop_data(3) and

Re: CVS commit: src

2020-06-07 Thread Kamil Rytarowski
On 07.06.2020 22:27, Jason Thorpe wrote: > >> On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: >> >> On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: >>> ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old >>>APIs that support them still exist, but

Re: CVS commit: src

2020-06-07 Thread Joerg Sonnenberger
On Sun, Jun 07, 2020 at 01:27:48PM -0700, Jason Thorpe wrote: > > > On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: > > > > On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: > >> ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old > >>APIs that

Re: CVS commit: src

2020-06-07 Thread Jason Thorpe
> On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: > > On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: >> ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old >>APIs that support them still exist, but will now produce link-time >>warnings when

Re: CVS commit: src

2020-06-07 Thread Joerg Sonnenberger
On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: > ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old > APIs that support them still exist, but will now produce link-time > warnings when used. Please replace them with proper deprecration annotation in

Re: CVS commit: src/sys/dev/acpi

2020-06-07 Thread Nick Hudson
On 10/08/2018 18:11, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Fri Aug 10 17:11:56 UTC 2018 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Don't hold up boot: defer acpibat(4) inquiry until threads are running. ok jmcneill@

Re: CVS commit: src

2020-06-07 Thread Jason Thorpe
> On Jun 6, 2020, at 10:51 PM, matthew green wrote: > > "Jason R Thorpe" writes: >> Module Name: src >> Committed By:thorpej >> Date:Sat Jun 6 21:26:00 UTC 2020 >> >> Modified Files: >> src/lib/libprop: Makefile shlib_version > > i wonder, since this adds to

re: CVS commit: src

2020-06-06 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Sat Jun 6 21:26:00 UTC 2020 > > Modified Files: > src/lib/libprop: Makefile shlib_version i wonder, since this adds to the kernel ABI, you should have also bumped the kernel version, since modules using

Re: CVS commit: src/tests/lib/libc/sys

2020-06-06 Thread Andrew Doran
On Sat, Jun 06, 2020 at 06:11:21PM +, Jason R Thorpe wrote: > Module Name: src > Committed By: thorpej > Date: Sat Jun 6 18:11:21 UTC 2020 > > Modified Files: > src/tests/lib/libc/sys: t_lwp_create.c > > Log Message: > Add a test case to ensure that _lwp_create() fails with

Re: CVS commit: src/lib/libpthread

2020-06-06 Thread Andrew Doran
On Thu, Jun 04, 2020 at 09:28:09PM +, Andrew Doran wrote: > On Thu, Jun 04, 2020 at 06:26:07PM +, Martin Husemann wrote: > > > On Wed, Jun 03, 2020 at 10:10:24PM +, Andrew Doran wrote: > > > Module Name: src > > > Committed By: ad > > > Date: Wed Jun 3 22:10:24

Re: CVS commit: src/sys/arch/x86/x86

2020-06-06 Thread Christos Zoulas
In article <20200606135850.ge14...@pony.stderr.spb.ru>, Valery Ushakov wrote: >On Sat, Jun 06, 2020 at 11:25:19 +0200, Kamil Rytarowski wrote: > >> On 06.06.2020 09:42, Simon Burge wrote: >> > "Kamil Rytarowski" wrote: >> > >> >> Module Name: src >> >> Committed By: kamil >> >> Date:

Re: CVS commit: src/sys/arch/x86/x86

2020-06-06 Thread Valery Ushakov
On Sat, Jun 06, 2020 at 11:25:19 +0200, Kamil Rytarowski wrote: > On 06.06.2020 09:42, Simon Burge wrote: > > "Kamil Rytarowski" wrote: > > > >> Module Name: src > >> Committed By: kamil > >> Date: Fri Jun 5 21:48:04 UTC 2020 > >> > >> Modified Files: > >> > >>

Re: CVS commit: src/sys/arch/x86/x86

2020-06-06 Thread Kamil Rytarowski
On 06.06.2020 09:42, Simon Burge wrote: > "Kamil Rytarowski" wrote: > >> Module Name: src >> Committed By:kamil >> Date:Fri Jun 5 21:48:04 UTC 2020 >> >> Modified Files: >> >> src/sys/arch/x86/x86: cpu_rng.c >> >> Log Message: >> >> Change const unsigned to

<    9   10   11   12   13   14   15   16   17   18   >