Re: [SoX-devel] better sndio support in SoX

2016-09-21 Thread Alexandre Ratchov
On Wed, Sep 21, 2016 at 12:19:59PM +0100, Måns Rullgård wrote: > Jan Stary writes: > > >> commit ea4f3fb3c6de93e10786fbfc1cb1bdf9006bbcdb > >> Author: Alexandre Ratchov > >> Date: Tue Sep 20 22:00:40 2016 + > >> > >> sndio: handle 24-bit samples properly on OpenBSD > > > > That's a bi

Re: [SoX-devel] better sndio support in SoX

2016-09-21 Thread Alexandre Ratchov
On Wed, Sep 21, 2016 at 09:19:26AM +0200, Jan Stary wrote: > On Sep 21 06:58:52, normalper...@yhbt.net wrote: > > > > commit ea4f3fb3c6de93e10786fbfc1cb1bdf9006bbcdb > > > > Author: Alexandre Ratchov > > > > Date: Tue Sep 20 22:00:40 2016 + > > > > > > > > sndio: handle 24-bit samples p

Re: [SoX-devel] better sndio support in SoX

2016-09-21 Thread Måns Rullgård
Jan Stary writes: >> commit ea4f3fb3c6de93e10786fbfc1cb1bdf9006bbcdb >> Author: Alexandre Ratchov >> Date: Tue Sep 20 22:00:40 2016 + >> >> sndio: handle 24-bit samples properly on OpenBSD > > That's a bit misleading: it will properly handle > whatever bitwidth SoX asks for. The 24 vs

Re: [SoX-devel] better sndio support in SoX

2016-09-21 Thread Jan Stary
On Sep 21 06:58:52, normalper...@yhbt.net wrote: > > > commit ea4f3fb3c6de93e10786fbfc1cb1bdf9006bbcdb > > > Author: Alexandre Ratchov > > > Date: Tue Sep 20 22:00:40 2016 + > > > > > > sndio: handle 24-bit samples properly on OpenBSD > > > > That's a bit misleading: it will properly h

Re: [SoX-devel] better sndio support in SoX

2016-09-20 Thread Eric Wong
Jan Stary wrote: > On Sep 20 22:24:28, normalper...@yhbt.net wrote: > > Thanks, it's sitting in my "pu" branch on git://80x24.org/sox > > with Alex credited as the author. > > Thank you. > > What is the relation of this git branch at git://80x24.org/sox > to the actual SoX repository at git://gi

Re: [SoX-devel] better sndio support in SoX

2016-09-20 Thread Jan Stary
On Sep 20 22:24:28, normalper...@yhbt.net wrote: > Jan Stary wrote: > > Eric Wong wrote: > > > with Måns sox, > > Sorry, copy+paste error since I can't type 'å' properly :x > > > > The patch looks sane, and if OpenBSD is anyway building with this, it's > > > probably good to pick it up. > > > >

Re: [SoX-devel] better sndio support in SoX

2016-09-20 Thread Eric Wong
Jan Stary wrote: > Eric Wong wrote: > > with Måns sox, Sorry, copy+paste error since I can't type 'å' properly :x > > The patch looks sane, and if OpenBSD is anyway building with this, it's > > probably good to pick it up. > > Yes, the OpenBSD port of SoX is using this. > (I am not sure whether

Re: [SoX-devel] better sndio support in SoX

2016-09-20 Thread Jan Stary
> Seems reasonable; but I have little experience with using sndio > with Måns sox, much less the API. Perhaps Måns has an opinion, > too. > > Fwiw, it would be helpful if example files could be > provided/generated showing where the improvement is. Any 24bit PCM file will exemplify this. > Tha

Re: [SoX-devel] better sndio support in SoX

2016-09-20 Thread Måns Rullgård
Eric Wong writes: > Jan Stary wrote: >> Hi Eric, >> >> recently, Alex Ratchov (of OpenBSD's sndio) has added a diff >> to src/sndio.c that enables a finer setting of the desired >> parameters of the underlying audio (namely, bit width). >> >> Currently, the diff (attached) exists as a patch to

Re: [SoX-devel] better sndio support in SoX

2016-09-20 Thread Eric Wong
Jan Stary wrote: > Hi Eric, > > recently, Alex Ratchov (of OpenBSD's sndio) has added a diff > to src/sndio.c that enables a finer setting of the desired > parameters of the underlying audio (namely, bit width). > > Currently, the diff (attached) exists as a patch to the OpenBSD > port of SoX (w

[SoX-devel] better sndio support in SoX

2016-09-15 Thread Jan Stary
Hi Eric, recently, Alex Ratchov (of OpenBSD's sndio) has added a diff to src/sndio.c that enables a finer setting of the desired parameters of the underlying audio (namely, bit width). Currently, the diff (attached) exists as a patch to the OpenBSD port of SoX (which I maintain). Would you please