Re: [Spacewalk-devel] 489775 - fixing listERrata api due to bad query

2009-03-13 Thread Justin Sherrill
Jan Pazdziora wrote: > On Fri, Mar 13, 2009 at 10:55:18AM -0400, Justin Sherrill wrote: >> jmrodri wrote: >>> why is this a BAD query? I think this was done on purpose to return the >>> issue_date as date. >> The query was 'bad' because evidently date is a reserved word. Try to >> do anything as

Re: [Spacewalk-devel] 489775 - fixing listERrata api due to bad query

2009-03-13 Thread Jan Pazdziora
On Fri, Mar 13, 2009 at 10:55:18AM -0400, Justin Sherrill wrote: > jmrodri wrote: > > why is this a BAD query? I think this was done on purpose to return the > > issue_date as date. > > The query was 'bad' because evidently date is a reserved word. Try to > do anything as 'select id as date fro

Re: [Spacewalk-devel] 489775 - fixing listERrata api due to bad query

2009-03-13 Thread Justin Sherrill
jmrodri wrote: > why is this a BAD query? I think this was done on purpose to return the > issue_date as date. > > jesus > > The query was 'bad' because evidently date is a reserved word. Try to do anything as 'select id as date from rhnServer'. Wont' work. Feel free to look at the refere

Re: [Spacewalk-devel] 489792- fixing incorrect api return types

2009-03-13 Thread Justin Sherrill
jmrodri wrote: > Instead of > > + List list = (List) listErrata(sessionKey, channelLabel, "", ""); > + // > + for (Map item : list) { > + item.put("date", item.get("issue_date")); > + } > + return list; > > why not change the query to return date as the column name instead of > issue_date OR > ch

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread Miroslav Suchý
James Bowes wrote: Well nobody's going to give a first time contributor commit access right away, are they? In my own experiences, going through a review of a patch No, I attached patch to BZ and expected that somebody will pick it up. But they forced me to go through review tool (including crea

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread James Bowes
On Fri, Mar 13, 2009 at 10:05:58AM -0400, Jesus M. Rodriguez wrote: > On Fri, Mar 13, 2009 at 9:57 AM, Miroslav Suchý wrote: > > James Bowes wrote: > >> > >> Why not take away everyone's commit access and make all changes go > >> through the mailing list first? > > > > E.g. Google has it this way.

Re: [Spacewalk-devel] PGPORT: additional packages

2009-03-13 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 13 Mar 2009 19:18:22 +0530 Vikram Rai wrote: > Hi Devan, > > Attached are additional packages that need to be checked into the > repository. > Since I do not have rights to check them in, could you please check > them into the following loca

Re: [Spacewalk-devel] PGPORT: additional packages

2009-03-13 Thread Jesus M. Rodriguez
On Fri, Mar 13, 2009 at 9:48 AM, Vikram Rai wrote: > Hi Devan, > > Attached are additional packages that need to be checked into the > repository. > Since I do not have rights to check them in, could you please check them > into the following location: > > spacewalk/schema/spacewalk/postgresql/pac

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread Jesus M. Rodriguez
On Fri, Mar 13, 2009 at 9:57 AM, Miroslav Suchý wrote: > James Bowes wrote: >> >> Why not take away everyone's commit access and make all changes go >> through the mailing list first? > > E.g. Google has it this way. And it was enough PITA that I did not finished > that process and take my patch f

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread Miroslav Suchý
James Bowes wrote: Why not take away everyone's commit access and make all changes go through the mailing list first? E.g. Google has it this way. And it was enough PITA that I did not finished that process and take my patch for their project back. Patches sent to mailing lists for review

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread Jesus M. Rodriguez
On Fri, Mar 13, 2009 at 9:45 AM, James Bowes wrote: > Why not take away everyone's commit access and make all changes go > through the mailing list first? I've never liked standalone code review > tools, because they make me leave my safe cave-like environment of vim, > mutt, and the command line.

[Spacewalk-devel] PGPORT: additional packages

2009-03-13 Thread Vikram Rai
Hi Devan, Attached are additional packages that need to be checked into the repository. Since I do not have rights to check them in, could you please check them into the following location: spacewalk/schema/spacewalk/postgresql/packages/ Thanks Vikram Rai EnterpriseDB rhn_packages.tar.gz Desc

Re: [Spacewalk-devel] [PATCH] fix bootstrap scripts to retrieve server cert using SSL

2009-03-13 Thread Joshua Roys
Jan Pazdziora wrote: On Fri, Mar 13, 2009 at 09:33:36AM -0400, Joshua Roys wrote: Hello all, My sense of paranoia tells me this should be https. Will the https work, without certificates available on the client? If wget is used with the --no-check-certificate option, which is checked for

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread James Bowes
On Thu, Mar 12, 2009 at 03:31:53PM -0400, Jesus M. Rodriguez wrote: > 2009/3/12 Michael Mraka : > > Pradeep Kilambi wrote: > > % Miroslav Suchý wrote: > > % >Seeing as Jesus likes reviewing commit... I'm just wondering - do we > > % >want to setup some Code Review tools? Will we use it? Or gitk/tig

Re: [Spacewalk-devel] [PATCH] fix bootstrap scripts to retrieve server cert using SSL

2009-03-13 Thread Jan Pazdziora
On Fri, Mar 13, 2009 at 09:33:36AM -0400, Joshua Roys wrote: > Hello all, > > My sense of paranoia tells me this should be https. Will the https work, without certificates available on the client? -- Jan Pazdziora Senior Software Engineer, Satellite Engineering, Red Hat

[Spacewalk-devel] [PATCH] fix bootstrap scripts to retrieve server cert using SSL

2009-03-13 Thread Joshua Roys
Hello all, My sense of paranoia tells me this should be https. Thanks, Joshua Roys >From 727fb359e77d1fd5560edbe6eac552825c895167 Mon Sep 17 00:00:00 2001 From: Joshua Roys Date: Fri, 13 Mar 2009 08:47:56 -0400 Subject: [PATCH] fix bootstrap scripts to retrieve server cert using SSL --- spac

Re: [Spacewalk-devel] Fixed a iprange issue where the iprange delete URLs weren't being correctly ...

2009-03-13 Thread Partha Aji
You'd get it if you saw the iprange.jspf.. The delete link wants the complete URL, , the other line says which doesnot want the /rhn .. Partha jmrodri wrote: Why do we have to pass in the /rhn/ to the url here where we don't on the others? jesus Sent to you by jmrodri via Google Reader:

Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk

2009-03-13 Thread Miroslav Suchý
I agree with commit hooks. Anyway format bugzilla numbers is more complicated (multiple bz numbers or none). Wait. Why anyone would want to put two bugzilla into one commit? Either two BZs describe one issue - then mark one as DUPLICATE or (if one BZ is satellite and one spacewalk) say in sate

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread Miroslav Suchý
Jesus M. Rodriguez wrote: at the commit logs as mike & I do. I look at them for a few reasons: 1) understand what's going on 2) looking for glaring errors and duplicate code While a tool might help us get better, if everyone spent sometime reviewing the commit logs. Agree. Good slides explain