Jesus M. Rodriguez wrote:
at the commit logs as mike & I do. I look at them for a few reasons:
1) understand what's going on
2) looking for glaring errors and duplicate code
While a tool might help us get better, if everyone spent sometime
reviewing the commit logs.
Agree. Good slides explaining why (and how) to do code review
http://www.aleax.it/osc08_crev.pdf
I don't think the process will work if it is up to a developer to ask
for reviews, having done that
in the past it never really worked for me.
+1
I more think about marking what has been reviewed and what not. I'm
targeting to try avoid situation when some commits will be reviewed by
10 people and some not looked at at all.
--
Miroslav Suchy
RHN Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
