On Fri, Mar 13, 2009 at 9:45 AM, James Bowes <[email protected]> wrote: > Why not take away everyone's commit access and make all changes go > through the mailing list first? I've never liked standalone code review > tools, because they make me leave my safe cave-like environment of vim, > mutt, and the command line. Patches sent to mailing lists for review > before commit let me use the tools I already know and love; reading > commit logs do the same thing, but at that point it's too late, in a > sense.
Because we would implode with the sheer number of commits. I think reviewing every commit before hand would cause such a bottleneck that it would become unsustainable. I guess my attempt at having folks participate in reviewing commits is to help each team member learn from each other. For example, if I wrote a bunch of pages that use ListTag and you are knew to it, I'd expect you to do something completely different and I can educate you on what we've already done. Also, I'd like folks look over my stuff (which I never get enough of -- and no 'you code?' jokes) :) jesus _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
