On Fri, Mar 13, 2009 at 10:05:58AM -0400, Jesus M. Rodriguez wrote: > On Fri, Mar 13, 2009 at 9:57 AM, Miroslav Suchý <[email protected]> wrote: > > James Bowes wrote: > >> > >> Why not take away everyone's commit access and make all changes go > >> through the mailing list first? > > > > E.g. Google has it this way. And it was enough PITA that I did not finished > > that process and take my patch for their project back.
Well nobody's going to give a first time contributor commit access right away, are they? In my own experiences, going through a review of a patch on a mailing list has been quite usefull. And isn't this how occasional contributors to spacewalk already submit changes? > > > >> Patches sent to mailing lists for review > >> before commit let me use the tools I already know and love; reading > >> commit logs do the same thing, but at that point it's too late, in a > >> sense. > > > > Do we want to have nice and clean repo, without accidental or partially > > wrong commits? I think we do not need it. It will slows downs the work. > > It is better to commit earlier and if you done it wrong, then correct or > > revert later. That's actually not what I meant. I mean that having people to opt-in to review other's code by looking at a commit list is obviously not being very effective in spacewalk's case, or else you wouldn't be looking at other review methods. In hindsight, I didn't express this well at all. So my first email fails review. > > +1 to all of your comments Miroslav. /me thinks I broke a rule here by not > adding anything meaningful to the thread :) > Nah, you're the guy doing most of the existing review, so you get a pass here. Anyhoo, I'm much less vested in this than you two are, so you probably know what's more useful for you team. > jesus > > _______________________________________________ > Spacewalk-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-devel -James
pgpVRgsjXJ4HW.pgp
Description: PGP signature
_______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
