Re: [Spacewalk-devel] Spacewalk test suite/SQL validation?

2015-02-20 Thread Silvio Moioli
for you guys to be happy if I submit a pull request allowing installation on > a 12.1 database? >From the SUSE Manager team's perspective if your patches result in all unit >tests to run correctly and some minimal manual testing is done (setup - >register one system - patch it)

[Spacewalk-devel] [PATCH] Errors with unrequired field "Prefix"

2012-11-15 Thread Johannes Renner
s reliably on Oracle as well as on PG. The attached patch fixes the problem by setting the apparently correct empty value of " ", just in case it is empty (== ""). The select in the form might even return it correctly as " ", but looks like it is maybe trimmed away so

Re: [Spacewalk-devel] Timezone problem with DB timestamps

2013-02-13 Thread Johannes Renner
On 08/01/2012 06:04 PM, Tomas Lestach wrote: > Hello Johannes, > > I somehow misread the javadoc you linked in your original e-mail. > I made some quick tests and applied your original patch. :-) > > spacewalk.git: 3bc5907dd0f669fb391701188055102433d65e9f It looks like we migh

[Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-14 Thread Silvio Moioli
aticMethod(boolean b); MethodUtil will pick the first compatible method it finds, then since getMethods() does not guarantee any ordering[1] behavior is non-deterministic and the test fails (at least in some JVM/environment combinations). Please find the attached patch to force method sorting and

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-08 Thread Michael Calmer
Hi, Am Montag, 7. März 2011, 15:49:59 schrieb Miroslav Suchý: > On 03/07/2011 02:28 PM, Michael Calmer wrote: > > Hello, [...] > Regarding patch 0001-implement-updateinfo-Errata-import-5.patch... > It seems to me that it is merge of 4 smaller commits and therefore the > com

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-06-06 Thread Johannes Renner
On 06/04/2012 08:47 PM, Miroslav Suchy wrote: >> So here is the latest version of the patches. > > Committed (with some white space and check style fixes). Thanks for > contribution. Thank you very much, here is already a first follow up patch: Replace "default" str

[Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-06 Thread Johannes Renner
(3); The reason for doing it like this might have been a small sized field in the database, but AFAIK we already upstreamed a patch to enlarge the respective field. Since cloned errata currently end up with rather strange names, I would like to propose to do the naming like this instead: String clon

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-04 Thread Johannes Renner
On 03/22/2013 02:55 PM, Michael Calmer wrote: > Hi, > > please do not apply these patches. I found out, that it is not correct. > It removes the channels at more places than needed. I guess the initial patch would be fine, as long as we add some additional small fixes on top. Her

[Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-08-28 Thread Silvio Moioli
Hi, The attached patch attempts to fix an issue we found while running some Selenium-based automated UI tests. Basically multiple requests that involve an RhnSet can overlap if the user is "clicking very quickly" and that might result in an ISE because RHNSET.RHN_SET_USER_LABEL_E

[Spacewalk-devel] [PATCH] AdvDataSourceTest: do not rely on test execution order

2013-08-29 Thread Silvio Moioli
but not in the latter. More specifically, oneTimeSetup() inserts a row in adv_datasource and testDelete() will fail if it does not find it. On the other hand, testStressedElaboration() will fail if it finds it, because row.getTestColumn() is null for that test line. The proposed patch simply

[Spacewalk-devel] [PATCH] NPE when scheduling a package (install/remove/upgrade) action + remote command

2011-09-08 Thread Johannes Renner
on.java:38 If it can be reproduced, I will open a bug on bugzilla.redhat.com. Here is my patch, but I'm not sure if this is the right way to go: After the NPE is fixed within ScriptAction.java there appears to be a problem with the redirect. Since HTTP GET method is used for the redirect, but

[Spacewalk-devel] [PATCHES] two patches for SUSE support

2012-01-02 Thread Michael Calmer
y it fixes some python errors in the original code. You cannot assign a class which is defined later. The second one is a small patch to check for the zypp plugin and hide the warning about the not installed yum plugin. -- Regards Mich

Re: [Spacewalk-devel] "All relevant errata" as "All Errata"

2012-03-05 Thread Duncan Mac-Vicar P.
ange it to "All Types" un both Errata->All and Errata->Relevant. Comments? I agree. Attached patch for english and spanish. In spanish I did not need to mention "all TYPES" as I can use the gender difference to make it very obvious if I am talking of erratas types or

Re: [Spacewalk-devel] [PATCH] Kickstart profiles error handling

2012-11-08 Thread Johannes Renner
loaded file contents should >> actually be shown to the user. The cobbler returns a status 500 in this >> case, so what we see on this page is the source code of the apache error >> page. Further, the download link is of course not working. > > Right. I see your point. >

[Spacewalk-devel] [PATCH] com.redhat.rhn.common.db.datasource tests: get database username from configuration file

2013-08-29 Thread Silvio Moioli
Hi, it seems that some test cases in the com.redhat.rhn.common.db.datasource.test package have hardcoded database user names, which does not really work with our setup. I propose the attached patch to simply get the database name from rhn.conf. I am not really sure I understand why the

[Spacewalk-devel] [PATCH] Proposal to remove QuartzTest

2013-09-08 Thread Silvio Moioli
ed in this class, though). I believe this is a temporary class created during development and then forgot. I attached a patch to delete it. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany >From 439ab9cbb978d8c6cae91ba75ebf9254d15a0fb1 Mon Sep 17 00:00

Re: [Spacewalk-devel] On quality of patches

2014-01-30 Thread Duncan Mac-Vicar P.
On 30/01/14 11:57, Matej Kollar wrote: > Hi all. > > We welcome community contributions and we want to maintain some level > of quality. Natural expectation is that every proposed patch is > tested for the functionality. I fully agree with you that this is not acceptable. No

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-05 Thread Duncan Mac-Vicar P.
sure the date picker object (Java part) support this (if needed at all). > - week starts on Sunday in all localizations Fixed, I will include it in an updated patch. > - clicking on calendar icon pops-up date picker but clicking on clock > icon doesn't pop-up time picker Fixed

Re: [Spacewalk-devel] Incorrect timezone in new 2.1 date / time picker.

2014-05-04 Thread Duncan Mac-Vicar P.
and we will send a patch. About the other issues: 1) On a 1.7 server 1.1) I set my profile to use GMT+1 (Europe Central) 1.1.1- The (old) date picker shows CEST 1.1.2- The event pending page shows CEST (this is a perl page) 1.1.3- The event history page shows CEST (this is a perl page) 1.2

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Michael Calmer
Hi, Am Freitag, 11. März 2011, 09:58:39 schrieb Jan Pazdziora: > On Fri, Mar 11, 2011 at 09:40:25AM +0100, Jan Pazdziora wrote: > > [...] > > _buildExternalValue(extObject, object, parentTableObj) > > File "/usr/lib/python2.6/site- > > packages/spacewalk/server/importlib/backe

Re: [Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-16 Thread Silvio Moioli
Hello Tomas, > As I wrote directly within the commit message displaying > /rhn/channels/ChannelPackages.do > page with 15 000 packages takes over 1.5 minutes with your patch in > comparison to 3-4secs > without the patch. Thanks for the feedback. I also confirm the regression -

[Spacewalk-devel] [PATCH] filename stays the same when kickstart is renamed

2011-11-08 Thread Uwe Gansert
problems when you create a 2nd profile now with the old name that was used before. So if you have created a kickstart "test_profile" and then you rename it later to "webserver_profile" and then you create a new "test_profile", your webserver_profile is lost as a file.

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-02 Thread Johannes Renner
xactly this one. If >> one of you >> can reproduce it I could create a bug report for spacewalk, or are you aware >> of such >> misbehavior already? >> >> To me it looks like the used statement >> ('insert_new_cache_entries_by_packages' in >

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-04 Thread Johannes Renner
; It removes the channels at more places than needed. >> >> I guess the initial patch would be fine, as long as we add some additional >> small fixes on top. Here is another single patch containing everything. >> >> Basically what we are doing is to distinguish between &q

[Spacewalk-devel] [PATCH] junit tests: some logging cleanups

2013-09-12 Thread Silvio Moioli
more and I am attaching a patch to fix them as well. Note: at the moment we haven't looked into main application code yet. This ends this patch batch, hopefully, as we were finally able to run all the tests successfully, at least on Postgres :-) Regards, -- Silvio Moioli SUSE LINUX Products

[Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

2014-01-17 Thread Johannes Renner
LL on these columns. We therefore have to allow null there, please see and apply my attached patch. This can also be problematic when there is values that were created before installing the fix for 889633. These will have null as lastModifiedBy as long as they have never been edited. Even

[Spacewalk-devel] [PATCH] Insert pxt session errors on postgres

2012-08-15 Thread Johannes Renner
:///help/about.pxt Attached please find a patch for the issue. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 76dfe76b7cb8a7882951849ed537a66154aa86cc Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 15

[Spacewalk-devel] [PATCH] junit tests: do not rely on Cobbler

2013-09-12 Thread Silvio Moioli
Hi, We propose some patches to avoid the junit testsuite to depend on Cobbler. With those, we are able to run all the tests using only a database instance seeded with the latest schema version. Details: - patch 17 calls setupTestConfiguration() on KickstartDataTest before calling other members

[Spacewalk-devel] Future of the development stack?

2013-06-07 Thread Duncan Mac-Vicar P.
bootstrap for new features, but we would be afraid to have them rejected by upstream. But another possibility would be to contribute upstream a port of all the styling to bootstrap from the beginning, which would be a mega-patch, but we would not start working on something like this without having

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-08 Thread Johannes Renner
On 01/08/2014 02:34 PM, Michael Mraka wrote: > Maximilian Meister wrote: > % >I see. Then it should keep the original name so we can easily figure out > % >where it came from and replace it with newer version in the future. > % > % Hi Michael, > % > % the original name would be pwstrength.js (in

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-24 Thread Maximilian Meister
On 01/24/2014 12:29 PM, Matej Kollar wrote: * Warning pop-up. * Could it be moved to the right or bottom of the filed? Yes. Though on the bottom it overlaps with the bar, and on the right it could end up being compressed, depending on the window size of your browser. I guess I could tr

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-04-11 Thread Johannes Renner
>>> published.getAdvisoryName().substring(3); String clonedAdvisory = "CL" + >>>>> published.getAdvisory().substring(3); >>>>> >>>>> The reason for doing it like this might have been a small sized field in >>>>> the database

Re: [Spacewalk-devel] using XML RPC to create a virtual machine fails

2011-06-27 Thread Uwe Gansert
the cause of the problem. I found some more problems in the code and I have attached a patch. The default disk size will be set to 2TB instead of 2GB - that's easy to fix in the Java Code but there is one more problem in the pythion code in kickstart_guest.py Some values are set to "None"

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-02-29 Thread Johannes Renner
xactly this one. If >> one of you >> can reproduce it I could create a bug report for spacewalk, or are you aware >> of such >> misbehavior already? >> >> To me it looks like the used statement >> ('insert_new_cache_entries_by_packages' in >

[Spacewalk-devel] [PATCH] change jabberd default password

2012-08-10 Thread Uwe Gansert
Hi, I have attached a patch to change the default password in jabberd during setup. You had code for that in 2009 already but then you did some changes on how you write the config for jabberd and during that change, the code for setting the password to a random string got lost. The attached

[Spacewalk-devel] [PATCH] ListTag and decorators setCurrentList

2013-11-26 Thread Duncan Mac-Vicar P.
same list. This patch moves setting the list to one place, when adding the decorator, this makes the code more robust as it is more predictable that every decorator will get their list set, once, and in a predictable place. And fixes the bug mentioned above. Please don't apply this patch,

[Spacewalk-devel] [PATCH] Query not elaborated?

2012-08-03 Thread Johannes Renner
actually elaborated. So I am coming up with two patch proposals, since I am not really sure about how we are intended to solve the problem: - The first patch fixes it by calling elaborate() manually once - The second patch is a more generic fix and calls elaborate() in BaseManager.java even if

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Michael Calmer
Hi, Am Freitag, 11. März 2011, 11:23:09 schrieb Jan Pazdziora: > On Fri, Mar 11, 2011 at 10:31:45AM +0100, Michael Calmer wrote: > > > > > > is at fault -- at least in that Fedora 7 updateinfo, the version > > > is not integer. When I've changed the line to > > > > > > e['advisory_rel'] = 1 >

Re: [Spacewalk-devel] "All relevant errata" as "All Errata"

2012-03-02 Thread Duncan Mac-Vicar P.
ame errata content. We might want to drop one of them. Ok, I have a patch that gets rid of errata/Overview.do. I need to rebase for master. attached. Is the removal of strings with this file as context needed? Duncan >From 36ebcfc0f1be2cb7c193907f3a0f81716bb18771 Mon Sep 17 00:00:00 2001 Fro

[Spacewalk-devel] [PATCH] Do not use America/New_York as the default timezone

2013-03-08 Thread Duncan Mac-Vicar P.
timezones, but one per offset, we take the first one that matches the offset. Duncan >From bc80a6ff58aa2926dc01b8a4d6aaf80fce837a56 Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P Date: Fri, 8 Mar 2013 16:06:01 +0100 Subject: [PATCH] Do not use America/New_York as the default timezone for the fi

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-05 Thread Johannes Renner
s two errata listed, "xxx" and "CLxxx", but only >>>> "CLxxx" should be. Also the table 'RhnServerNeededCache' shows even >>>> more entries where errata_id == null? >>>> >>>> I found a lot of open bugs about this

[Spacewalk-devel] [PATCH] Add support for uploaded files in mocked requests, fix CryptoKeyCreateActionTest

2013-09-13 Thread Silvio Moioli
RhnPostMockStrutsTestCase (patch 008). Code is a little convoluted because the API required an extra class, yet I prefer RhnPostMockStrutsTestCase to be self-contained - other solutions are possible if you particularly dislike the proposed implementation. This is of course reusable in other cases where

[Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-10 Thread Johannes Renner
Hey, Here is a patch for adding some validation to the HTTP proxy field on the general config page (https:///rhn/admin/config/GeneralConfig.do). This validator will allow FQDN or FQDN:port only, while a simple hostname will not pass. IPv4 addresses will pass, but IPv6 won't. Feel fr

[Spacewalk-devel] [PATCH] Kickstart profiles error handling

2012-11-06 Thread Johannes Renner
nload link is of course not working. The attached patch contains the following proposed changes to the code: 1. Change the error message text to point to the file contents on the 'Details' tab 2. Hide the content on the 'Kickstart File' tab in case the download failed Reg

Re: [Spacewalk-devel] [PATCH] Kickstart profiles error handling

2012-11-12 Thread Johannes Renner
know since my first tries with Spacewalk > kickstart profiles. I mean it's because of the templating feature. > You either have to escape the dollar signs or have to put the dollar > containing code into the #raw..#end block. > >> >> Thanks, >> Johannes > &

[Spacewalk-devel] [PATCH] Fix errata clone name generation in perl code

2012-04-23 Thread Johannes Renner
14:15:01 +0200 Subject: [PATCH] Fix errata clone name generation in perl code --- web/modules/rhn/RHN/DB/ErrataEditor.pm | 68 .../sniglets/Sniglets/ListView/ErrataList.pm |2 +- 2 files changed, 56 insertions(+), 14 deletions(-) diff --git a/web/modu

Re: [Spacewalk-devel] spacecmd: system_schedulehardwarerefresh and system_schedulepackagerefresh

2012-08-12 Thread Parsons, Aron
Stefan, Committed as df5078c9d5e803a875896dba654d45f0b7a63af5. Thanks for the patch. /aron From: stefan.me...@generali.de To: spacewalk-devel@redhat.com Subject: [Spacewalk-devel] spacecmd: system_schedulehardwarerefresh and

Re: [Spacewalk-devel] Twitter Bootstrap: Standardizing the CSS framework?

2013-07-26 Thread Duncan Mac-Vicar P.
On 26/07/13 14:05, Tomas Lestach wrote: > How can we be sure, that you cover all the Spacewalk pages, if you focus > on downstream, that has a different set of pages? > If the sent patch was against Suse Manager, I suppose that you do not > really work with Spacewalk itself. > So, a

Re: [Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP

2014-02-05 Thread Johannes Renner
On 01/22/2014 12:18 PM, Johannes Renner wrote: Hello, The SUSE Studio API will no longer process requests via unencrypted HTTP after Jan 2014, see here: http://blog.susestudio.com/2013/12/coming-soon-https-only-on-suse-studio.html Therefore attached is a patch to change the default endpoint

Re: [Spacewalk-devel] dto's from the database?

2012-04-04 Thread Duncan Mac-Vicar P.
y. Thanks for the suggestions. I am implementing the feature in 4 parts: a) showing an icon next to a patch that needs reboot b) a list System -> Requiring Reboot (to be used with System Set Manager) c) a yellow sign on the system page "This system requires a reboot [link to schedule

[Spacewalk-devel] [PATCH] Fix Search for Custom Info Values + NPE

2013-11-12 Thread Johannes Renner
Hey, attached is a patch to fix the advanced search for custom info values. The indexing seems to work fine, it's only the removal of old index records that is failing. And AFAICS it is failing for custom info values only while it seems to work fine for e.g. system name/description. The

[Spacewalk-devel] [PATCH] Pam setting on the user page not saving

2011-10-12 Thread Johannes Renner
am option for a user via "Users" -> ) Apply my attached patch for a fix, i.e. save the pam option using either AdminUserEditAction.java or SelfUserEditAction.java. Thanks, Johannes P.S.: I can also create a bugzilla entry if necessary, just tell me. -- SUSE LINUX Products GmbH, Maxfe

Re: [Spacewalk-devel] On quality of patches

2014-03-03 Thread Lamont Peterson
s called by multiple parts of the web interface it may break other pages than the one the developer is focused on. I think we need a map of what these shared file and functions effect so we can do more formal QA testing in the future -- Sent from my HP Pre3 On Jan

[Spacewalk-devel] [PATCH] SUSE Studio integration patches

2012-11-14 Thread Johannes Renner
ner Date: Tue, 13 Nov 2012 13:47:37 +0100 Subject: [PATCH 1/3] Workaround for Studio API returning incomplete URLs --- .../frontend/action/renderers/ImagesRenderer.java | 29 +++- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/java/code/src/com/redhat/rhn/front

Re: [Spacewalk-devel] [PATCH] build rhn-client-tools on openSUSE

2011-04-15 Thread Michael Calmer
5:34 +0200 Subject: [PATCH 01/13] modify spec file to build rhn-client-tools on SUSE - some packages named different - use zypper and zypp-plugin-spacewalk on SUSE - change category in desktop file - provide some extra directories in the filelist --- client/rhel/rhn-client-tools/rhn-client

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-08 Thread Johannes Renner
On 03/07/2012 10:04 AM, Tomas Lestach wrote: >> I will find time for that in the next days and I can then come up with a new >> patch for that file after I verified the behavior. > > Great! > Thank you Johannes, So, AFAICS the rhnServerNeededCache table is there for caching

Re: [Spacewalk-devel] Pushing to spacewalk.git

2013-12-10 Thread Silvio Moioli
work on master-bootstrap-css-fixes here, we do not really like force pushing. At the moment we are merging master back to the branch from time to time - I hope that you don't mind some extra merge commits moio: sure, just do whatever suits you the best tkasparek thanks np I hope this is no

[Spacewalk-devel] On picking a standard on HTML5 void tags (was: Date/Time picker)

2014-02-18 Thread Silvio Moioli
d be inconsistent (=bad), I think that the goal of a coding convention is mostly patch consistency - picking one style to avoid unneeded git conflicts because of different programmers having different habits. Goal here is not being nice on browsers' lexers IMO. Actually I would say that this

[Spacewalk-devel] [PATCH] Support native kvm images in SUSE Studio integration

2013-02-06 Thread Johannes Renner
-- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 652f1fdac22834021235829434f53c48759dba3e Mon Sep 17 00:00:00 2001 From: Michael Calmer Date: Tue, 29 Jan 2013 15:21:22 +0100 Subject: [PATCH] support studio KVM image type --- client/to

Re: [Spacewalk-devel] editarea and apache 2.4

2014-02-12 Thread Duncan Mac-Vicar P.
ditArea SF site. > Attached is a patch that changes the editor to the ACE editor. I have packaged ace-editor here https://build.opensuse.org/package/show/home:dmacvicar:spacewalk/ace-editor (note, right now the jspf includes the unminified version, though all are included in the package, I

Re: [Spacewalk-devel] [PATCH] build rhn-virtualization on openSUSE

2011-04-15 Thread Michael Calmer
Hi, Am Freitag, 8. April 2011, 15:07:12 schrieb Michael Calmer: > Hi, > > here is the patch to build rhn-virtualization on openSUSE. > > 0010-build-rhn-virtualization-on-SUSE.patch: > - modify the specfile > - add SUSE init script Attached is a new version of t

[Spacewalk-devel] [PATCH] build rhnsd on openSUSE

2011-04-08 Thread Michael Calmer
Hi, here is the patch to build and run rhnsd on openSUSE. 0005-changes-to-build-rhnsd-on-SUSE.patch: - specfile work - provide SUSE init script -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX Products

[Spacewalk-devel] [PATCH] build rhn-virtualization on openSUSE

2011-04-08 Thread Michael Calmer
Hi, here is the patch to build rhn-virtualization on openSUSE. 0010-build-rhn-virtualization-on-SUSE.patch: - modify the specfile - add SUSE init script -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX

[Spacewalk-devel] [PATCH] build rhnmd on openSUSE

2011-04-08 Thread Michael Calmer
Hi, here is a patch to build rhnmd on openSUSE. 0014-build-rhnmd-on-SUSE.patch - modify the specfile - add init script for openSUSE For SUSE I have removed the ssh key generation from the %post section. I added the generation into the SUSE init script. The reason for this is, that if you do it

[Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-06-10 Thread Silvio Moioli
found some other places in the code where the same problem could happen, since the implementation assumes some object can be cast to ClonedChannel. We then purpose this patch to avoid relying on that mechanism, using a separate method that will work regardless if the Channel is actually a Hibernat

[Spacewalk-devel] [PATCH] OrgHandlerTest: don't depend on a channel family with free entitlement slots

2013-09-12 Thread Silvio Moioli
necessarily true in any instance, and IMO test code should take care of setting up and tearing down such a channel since it is needed to run tests. The attached patch adds some setup code to do that. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany >F

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-23 Thread Maximilian Meister
cript next to other spacewalk-*.js. Hi, here is the new patch with the * recent release of jquery.pwstrength.bootstrap * a spec file to build a package from it * the patch to the sources during rpmbuild * the customization/caller script + a function to generate the tick icon * custom styles fo

[Spacewalk-devel] upstreaming some of our .spec file changes

2013-08-01 Thread Duncan Mac-Vicar P.
ing which blocks you do do Spacewalk vanilla releases on SUSE, I'm > sure the Spacewalk team will be happy to consider those patches for > master. This is something we probably should do. I think the 80% of the patch are SUSE/RH differences, and the minor part SUSE Manager/Spacewalk specific.

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-02-04 Thread Maximilian Meister
On 01/29/2014 02:22 PM, Michael Mraka wrote: I see :(, I was not aware of it. Anyway I'd still prefer not to use javascript if not necessary. So in this particular case I'd replace html:password with direct html input tag: Hi Michael, i changed the patch. So no additional

Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support

2011-03-11 Thread Uwe Gansert
.java @@ -30,6 +30,7 @@ import org.apache.struts.util.LabelValueBean; > > > > import java.util.Iterator; > > import java.util.List; > > +import java.net.*; > > We generally don't include entire packages without our code. Please > only include the specific classes that you are using.

Re: [Spacewalk-devel] Bootstrap image feature

2012-08-02 Thread Uwe Gansert
On 02.08.2012 11:15, Jan Pazdziora wrote: I have attached patches that fit into master. But actually they are more to show what I did and for discussion maybe. The schema-upgrade for example is still missing because I don't know yet in which version that patch will end. We are still a

Re: [Spacewalk-devel] [PATCH] build rhnmd on openSUSE

2011-04-15 Thread Michael Calmer
Hi, Am Freitag, 8. April 2011, 15:23:52 schrieb Michael Calmer: > Hi, > > here is a patch to build rhnmd on openSUSE. > > 0014-build-rhnmd-on-SUSE.patch > - modify the specfile > - add init script for openSUSE > > For SUSE I have removed the ssh key generation from t

Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-09-03 Thread Silvio Moioli
On 09/03/2013 02:33 PM, Tomas Lestach wrote: > to be honest, I personally do not like seeing DB index names in > the application code. I agree that it is not really an elegant solution, but I could not find another way of ignoring such specific exceptions. Ideas welcome :-) > (Btw. does it work o

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-28 Thread Maximilian Meister
On 01/24/2014 12:29 PM, Matej Kollar wrote: Hi everybody, here you can find the new patch with the following changes: Hi Maximilian. I see you have made some nice work there but there are still few things that need to be fixed. * Warning pop-up. * Could it be moved to the right or

Re: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

2014-01-21 Thread Johannes Renner
On 01/21/2014 03:38 PM, Jan Dobes wrote: > - Original Message - >> From: "Johannes Renner" >> To: spacewalk-devel@redhat.com >> Sent: Friday, January 17, 2014 12:30:09 PM >> Subject: [Spacewalk-devel] [PATCH] Allow null as createdBy and >

[Spacewalk-devel] [PATCH] some patches for monitoring on postgres and pylint findings

2011-11-28 Thread Michael Calmer
ffc17d8bce7322d8108d55293dd6e411157d3196 Mon Sep 17 00:00:00 2001 From: Michael Calmer Date: Sun, 27 Nov 2011 15:35:12 +0100 Subject: [PATCH 1/6] add missing import E:132,54:ConfigManagement.management_remove_channel: Undefined variable 'sys' --- .../handlers/config_mgmt/rhn_config_management.py |1

[Spacewalk-devel] [PATCH] build osad on openSUSE

2011-04-08 Thread Michael Calmer
Hi, here is the patch to build and run osad on openSUSE. 0006-build-osad-on-SUSE.patch: - specfile work - add init script for SUSE - osad.py missed and import of the config module -- Regards, Michael Calmer

[Spacewalk-devel] [PATCH] Frontend monitoring tests: ensure a Monitoring Scout exists

2013-09-12 Thread Silvio Moioli
Hi, In some frontend tests it is assumed that at least one Monitoring Scout exists, and those tests will fail if there is none. The proposed attached patch creates a test Monitoring Scout before any operation that requires one, thus eliminating this precondition. Regards, -- Silvio Moioli SUSE

Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java

2014-01-21 Thread Silvio Moioli
lipse.xml. Matej will fix that configuration file, meanwhile I fixed the patch. By the way I also fixed my review-pending branches with these commits: e9ac621 -> master-pxe-default-image-no-powermanagement 9e04ed5 -> master-power-management-ssm > * Preferred space indentation for `.js

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

2012-11-22 Thread Johannes Renner
m. (But we of course >> try to keep the naming sensefull as well.) > > Ok, I might come up with a patch these days, fixing the existing API call so > it behaves like its name is suggesting + maybe add a new call to provide the > previous behavior in addition to that. > > Tha

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-18 Thread Johannes Renner
On 09/14/2012 02:32 PM, Tomas Lestach wrote: [...] > > Hi Johannes, > > the patch look good. > > However looking at [1] I see the code is licensed under the Apache License, > Version 2.0. I'm afraid this version isn't compatible with the Spacewalk's > GP

Re: [Spacewalk-devel] [PATCH] build osad on openSUSE

2011-04-15 Thread Michael Calmer
Hi, Am Freitag, 8. April 2011, 14:55:50 schrieb Michael Calmer: > Hi, > > here is the patch to build and run osad on openSUSE. > > 0006-build-osad-on-SUSE.patch: > - specfile work > - add init script for SUSE > - osad.py missed and import of the config module I have

Re: [Spacewalk-devel] [PATCH] some patches for monitoring on postgres and pylint findings

2011-11-29 Thread Michael Calmer
01 > > From: Michael Calmer > > Date: Mon, 28 Nov 2011 16:30:11 +0100 > > Subject: [PATCH 4/6] replace synonyms with real table names and change > > sysdate to current_timestamp > > Hmm I would be happy to apply that part with s/sysdate/current_timestamp/ > > But I

[Spacewalk-devel] [PATCH] Schedule updates for the software update stack first

2012-10-19 Thread Johannes Renner
Hello, attached is patches that will take care that, in case there is an update to the software update stack, it will be scheduled before all other (regular) patch updates. This way we would like to ensure, that if there is bugs in the update stack, they will be fixed before any other patch

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-14 Thread Johannes Renner
On 09/12/2012 05:51 PM, Tomas Lestach wrote: [...] > Anyway, please, suppose Spacewalk is IPv6 ready, so if you allow IPv4 > addresses, please allow IPv6 addresses as well. > In case it turns out something doesn't work as expected, we'd face the issue. > > I'll

[Spacewalk-devel] [PATCH] adding support zypper in bootstrap script and allow multiple GPG keys

2011-04-08 Thread Michael Calmer
Hi, here is a patch for the server side. This patch add support for zypper as installer to the bootstrap script. Additionally it enhances the ORG_GPG_KEY variable to be a comma seperated list like the activation keys. 0013-support-zypper-in-bootstrap-script-and-allow-multipl.patch - add

[Spacewalk-devel] [PATCH] Single-system reboot page ported to Java

2014-01-17 Thread Silvio Moioli
Dear Spacewalkers, Those two patches are from my colleague Michael Calmer and they contain ported Java code for the reboot page. Patch 0002 removes stale Perl code; HTML has been adapted for Bootstrap already. Bootstrap porting of the Date picker widget, as you know, is being tackled separately

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-08-28 Thread Silvio Moioli
s to drop assumptions of having virtualization channels with appropriate packages available. Since this varies some methods semantics a bit (produced servers now have a base channel and consume entitlements), patch tests using that class accordingly (ServerFactoryTest and VirtualizationEntitlementsMana

[Spacewalk-devel] [PATCH] SUSE/AutoYaST Support

2011-03-08 Thread Uwe Gansert
uot; an option for a "kickstartable tree" 0004-bnc-664915-rhnreg_ks-help-failed-if-LANG-de_DE.UTF-8.patch nothing kickstart related but rhnreg_ks crashed with LANG=de_DE.UTF8 when you called it with "--help" 0005-fixed-virtual-KVM-machines-in-the-webui-bnc-674344.patch let space

Re: [Spacewalk-devel] Audit Logging

2011-08-26 Thread Johannes Renner
/GeneralConfig.do { >key = "CONF" >value = "email=${POST.email};." > } > > etc. you probably got the idea now. > And those url not specified will not be logged. I got the idea and I was even researching such an approach already. For the webapp I

[Spacewalk-devel] Twitter Bootstrap: Standardizing the CSS framework?

2013-07-25 Thread Duncan Mac-Vicar P.
port (See patch attached). Mostly the base layout and the tags. There are a lot of jsp pages with plain html that need porting by hand, but hey, it is a good start. Here is a gallery with Spacewalk being customized by just changing a LESS [²] file with variables (similar to what http://twitter

Re: [Spacewalk-devel] [PATCH] perl List port to new css/markup

2014-01-10 Thread Duncan Mac-Vicar P.
On 09/01/14 15:40, Duncan Mac-Vicar P. wrote: > Attached patch with all mentioned issues corrected. Now attached for real. diff --git a/branding/templates/header.pxt b/branding/templates/header.pxt index d90e605..c567b3a 100644 --- a/branding/templates/header.pxt +++ b/branding/templa

[Spacewalk-devel] [PATCH] build rhn-client-tools on openSUSE

2011-04-08 Thread Michael Calmer
berg) From 59d44ce683dbfc933baeec4bf92a4a415c225936 Mon Sep 17 00:00:00 2001 From: Michael Calmer Date: Mon, 4 Apr 2011 11:10:55 +0200 Subject: [PATCH 01/17] get hostname on not RedHat systems Other Linux distributions may not have a file named /etc/sysconfig/network. So we should check if it is a file and use the other

[Spacewalk-devel] [PATCHES] another patch set fixing PG SQL statements and other things

2011-12-08 Thread Michael Calmer
Hi, here is a list of small patches which fixes a lot of SQL statements for postgres. 0011-create-dir-if-it-does-not-exist.patch fixes a problem with not existing directory at rhnpush. I found another small issue where I currently do not have a patch for. But I want to let you know about it

[Spacewalk-devel] [PATCH] Show systems that need reboot because of an errata

2012-04-17 Thread Duncan Mac-Vicar P.
e need_reboot flag. (no 'Actions' in the sentence) I'm not sure, why you join also the rhnPackageName, if you do not really use it. Sorry for wasting your time. I pasted directly from the pgadmin3 console. Attached patch, rebased against master. It contains all suggestions and

Re: [Spacewalk-devel] dto's from the database?

2012-04-12 Thread Duncan Mac-Vicar P.
On 04/11/2012 11:00 AM, Tomas Lestach wrote: This is ok, because it's not used in the elaborator. Regards, Ok, here is a patch for review for the first part: adding a list of systems that need review, and showing a notification in the system detail that it needs reboot with a link t

Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal

2013-04-24 Thread Johannes Renner
On 04/12/2013 01:24 PM, Jan Pazdziora wrote: > Johannes, > > let me summarize some big picture impressions, without commenting on > every detail. > > You propose to address two situations: > > 1) clients in DMZ that cannot reach the server, with server able to >reach the clients; > > 2) ove

[Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2013-12-20 Thread Maximilian Meister
Hi everybody, this patch would add a bootstrapified password strength meter to all pages where user details are being created or edited (create the initial admin user, create/edit normal users and create organization). There is also a tick icon on the side of the password input fields, which

[Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

2013-08-19 Thread Johannes Renner
Hey, here is a small feature patch that allows users to choose semicolon (";") as an alternative to comma (",") for the delimiter in all downloadable CSV files that we generate from the webapp. This seems to be helpful for importing those files into MS Excel for example. Unf

[Spacewalk-devel] [PATCH] 'es improve channel status display

2013-02-11 Thread Duncan Mac-Vicar P.
ate catch block if the catch code is the same (none). >From ce3c088b4890e40273aa846bad0501bd62367080 Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P Date: Wed, 30 Jan 2013 18:29:25 +0100 Subject: [PATCH 1/6] FileNotFoundException inherits IOException so no need for a separate catch

<    1   2   3   4   >