Hi Edouard, Tim,
Tim Woodall ([EMAIL PROTECTED]) wrote:
Wouldn't
num_bytes_read -= nb_cells * ATM_CELL_TOTAL_SIZE;
num_bytes_new = num_bytes_read;
be better?
Yes it would be better, so much better that i've never commited
something else than this piece of code :-)
I noticed this,
Tim Woodall ([EMAIL PROTECTED]) wrote:
Wouldn't
num_bytes_read -= nb_cells * ATM_CELL_TOTAL_SIZE;
num_bytes_new = num_bytes_read;
be better?
Yes it would be better, so much better that i've never commited
something else than this piece of code :-)
Patches aren't applied blindly.
--
Hello Edouard,
The changes may show up in the anonymous cvs soon[1].
They finally did. I see in the changelog says Checks for
frames that are too long., but that part you actually dropped.
Against the current pppoa3.c the following minor cleanups
could be applied:
$ diff -pu pppoa3.c.000
Hi,
(One man thread :)
Correction. unused_cells is initialised to lbuf at the first loop, and the
value of unused_cells is changed to atm_pointer by the call to
aal5_frame_from_atm_cells. This is probably a way to walk through lbuf. Ie
the use of unused_cells instead of lbuf makes sense.
Hello Edouard,
I guess the sourceforge anonymous cvs is still in a pity state and
lagging way behind the developer cvs access.
This patch was already applied with the changes I listed. It was not a
patch modification request but a report. Let's blame sourceforge that
made you
Hello Edouard,
It's been a while since the last commits. This is probably going to be
released as beta3. Then i'll do rc releases for a final 1.2.
Please consider the patches I supplied via sourceforge before jumping to
beta3. TIA.
Bye,
Leonard.
--
How clean is a war when you shoot
Leonard den Ottolander ([EMAIL PROTECTED]) wrote:
Please consider the patches I supplied via sourceforge before jumping
to beta3. TIA.
Thanks to point me to them, as it's very rare to have patches on the sf
site :-)
The cleanup patch is not a problem, accepted as is.
The second one will
Leonard den Ottolander ([EMAIL PROTECTED]) wrote:
Please consider the patches I supplied via sourceforge before jumping
to beta3. TIA.
Ok concerning the second patch, i'm going to apply it with slight
changes:
- the 'idiotic' message isn't good as this driver can be used on
And the patch to modem_run send a few days ago by Howard Wilkinson?
Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se désinscrire : mailto:[EMAIL PROTECTED]
Gilles Espinasse ([EMAIL PROTECTED]) wrote:
And the patch to modem_run send a few days ago by Howard Wilkinson?
Sure. I just turned the -T option into -t to have lower cases option
only (and -t was not used). And added some comments (2 iirc) and turned
the last return statement
Hello Edouard,
Ok concerning the second patch, i'm going to apply it with slight
changes:
- the 'idiotic' message isn't good as this driver can be used on
networks with mtu 1500. Not all the networks are Ethernet, and it's up
to your ISP to negotiate the MTU value
Leonard den Ottolander ([EMAIL PROTECTED]) wrote:
Is there a way to check the frame length against the negotiated length, or
do you just drop this check?
No, pppoa daemons are just sort of bridging pipe. It's just a dumb piece
of software: read data on one side, copy it to the other side.
I
Hello Edouard,
Just a quick reply, more tomorrow.
I just dropped the test. See if it makes CRC problems appear again.
Just dropping the test for pos 1536 shouldn't change anything afaict.
Remember I inserted the else after that check. Also I always saw both
Idiotic frame lengths and CRC
13 matches
Mail list logo
