[GIT PULL] SPI bug fixes for v3.8 merge window

2012-12-19 Thread Grant Likely
+++- drivers/spi/spi-sh-hspi.c |2 +- drivers/spi/spi.c |5 +++- 7 files changed, 53 insertions(+), 11 deletions(-) create mode 100644 Documentation/devicetree/bindings/spi/spi_atmel.txt -- Grant Likely, B.Sc.,

Re: [PATCH V2] spi: remove check for bits_per_word on transfer from low level driver

2012-12-19 Thread Grant Likely
On Tue, 18 Dec 2012 14:25:43 +0530, Laxman Dewangan wrote: > The spi core make sure that each transfer structure have the proper > setting for bits_per_word before calling low level transfer APIs. > > Hence it is no more require to check again in low level driver for > this field whether this is

Re: [PATCH] spi: tegra: sequence compatible strings as per preference

2012-12-19 Thread Grant Likely
On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding wrote: > On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: > > On 11/09/2012 10:10 AM, Mark Brown wrote: > > > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: > > > > > >> However just FYI, it should not be necessar

Re: [PATCH 4/4 v2] devicetree: Add Renesas SH Mobile MSIOF spi controller binding doc

2012-12-19 Thread Grant Likely
applied together. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Imp

Re: [PATCH 1/4 v2] spi: sh-msiof: Remove unneeded clock name

2012-12-19 Thread Grant Likely
On Wed, 12 Dec 2012 12:54:46 +0100, Bastian Hecht wrote: > From: Bastian Hecht > > clk_get() no longer needs a character string for associating the right > clock as this is done via the device struct now. > > Signed-off-by: Bastian Hecht This change is already in mainline. g. -

Re: [PATCH 2/4 v2] spi: Add SH Mobile series as dependency to MSIOF controller

2012-12-19 Thread Grant Likely
On Wed, 12 Dec 2012 12:54:47 +0100, Bastian Hecht wrote: > From: Bastian Hecht > > The MSIOF hardware block is used in the SH Mobile series as well, so we > add it here. > > Signed-off-by: Bastian Hecht > --- Also already applied. g.

Re: [PATCH 3/4 v2] spi: sh-msiof: Add device tree parsing to driver

2012-12-19 Thread Grant Likely
On Mon, 17 Dec 2012 12:25:26 +0100, Bastian Hecht wrote: > Hi Nobuhiro, > > 2012/12/17 Nobuhiro Iwamatsu : > > Hi, Bastian. > > > > On Wed, Dec 12, 2012 at 8:54 PM, Bastian Hecht wrote: > >> From: Bastian Hecht > >> > >> This adds the capability to retrieve setup data from the device tree > >>

Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

2012-12-19 Thread Grant Likely
e spi_master. If that is not the case then it is a bug to be fixed. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs

Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

2012-12-19 Thread Grant Likely
On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto wrote: > > Hi > > > According to its documentation, clk_get() returns a "valid IS_ERR() > > condition > > containing errno", so we should call IS_ERR() rather than a NULL check. > > > > Signed-off-by: Cyril Roelandt > > Acked-by: K

Re: [PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-12-19 Thread Grant Likely
On Sat, 24 Nov 2012 18:20:08 +0100, Federico Vaga wrote: > This patch introduce the use of the sysfs attribute for the spidev > configuration. This avoid the user to have a specific program which does > ioctl() on spidev. The user can easily does cat (to read) and echo (to > write) on the sysfs f

Re: [PATCH - v2] spi: davinci: add OF support for the spi controller

2012-12-19 Thread Grant Likely
On Sat, 15 Dec 2012 00:27:58 +, Grant Likely wrote: > On Tue, 11 Dec 2012 16:20:39 -0500, Murali Karicheri > wrote: > > This adds OF support to DaVinci SPI controller to configure platform > > data through device bindings. Also replaces clk_enable() with > > of clk_

Re: [PATCH 1/1] spi/atmel: add DT support

2012-12-17 Thread Grant Likely
On Mon, 17 Dec 2012 11:13:51 +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 01:03 Sat 15 Dec , Grant Likely wrote: > > On Wed, 12 Dec 2012 16:13:08 +0100, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > > > On 14:37 Fri 23 Nov , Nicolas Ferre wrote: > &

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-16 Thread Grant Likely
On Thu, 13 Dec 2012 17:09:34 +0800, chao bi wrote: > On Tue, 2012-12-11 at 16:46 +0000, Grant Likely wrote: > > On Tue, 11 Dec 2012 16:58:31 +0800, chao bi wrote: > > > On Thu, 2012-12-06 at 12:38 +, Grant Likely wrote: > > > > On Wed, 21 Nov 2012

Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

2012-12-16 Thread Grant Likely
On Sat, 15 Dec 2012 16:55:46 +0200, Felipe Balbi wrote: > On Sat, Dec 15, 2012 at 12:32:24AM +0000, Grant Likely wrote: > > On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi wrote: > > > there are a few spi master drivers which make > > > use of that flag but

Re: [PATCH 1/1] spi/atmel: add DT support

2012-12-14 Thread Grant Likely
On Wed, 12 Dec 2012 16:13:08 +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 14:37 Fri 23 Nov , Nicolas Ferre wrote: > > On 11/23/2012 01:44 PM, Jean-Christophe PLAGNIOL-VILLARD : > > > the atmel_spi use only gpio for chip select > > > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLAR

Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

2012-12-14 Thread Grant Likely
|= SPI_CS_HIGH; > if (of_find_property(nc, "spi-3wire", NULL)) > spi->mode |= SPI_3WIRE; > + if (of_find_property(nc, "spi-loopback", NULL)) > + spi->mode |= SPI_LOOP; > >

Re: [PATCH 1/2] spi: omap2: disable DMA requests before complete()

2012-12-14 Thread Grant Likely
; > > - complete(&mcspi_dma->dma_tx_completion); > - > /* We must disable the DMA TX request */ > omap2_mcspi_set_dma_req(spi, 0, 0); > + > + complete(&mcspi_dma->dma_t

Re: [PATCH - v2] spi: davinci: add OF support for the spi controller

2012-12-14 Thread Grant Likely
> Signed-off-by: Murali Karicheri > Reviewed-by : Grant Likely Applied, thanks. I did remove the OF_ALIAS_N property though. I know the COMPATIBLE one uses it, but it is actually kind of redundant since it can also be determined by counting the number of OF_ALIAS_* entries, and having the

[GIT PULL] SPI changes for v3.8

2012-12-13 Thread Grant Likely
): spi/bcm63xx: remove driver version spi/bcm63xx: add missing spi_master_{resume,suspend} calls to PM callbacks spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer() Grant Likely (4): Merge branch 'spi-next' from git://git.kernel.org/.../broonie/misc.git

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-11 Thread Grant Likely
On Tue, 11 Dec 2012 16:58:31 +0800, chao bi wrote: > On Thu, 2012-12-06 at 12:38 +0000, Grant Likely wrote: > > On Wed, 21 Nov 2012 10:16:43 +0800, chao bi wrote: > > > > + master->mode_bits = SPI_CPOL | SPI_CPHA; > > > + master->bus_num = SSP_CFG_GET

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-11 Thread Grant Likely
On Tue, 11 Dec 2012 10:00:16 +0800, chao bi wrote: > > > +static void dump_trailer(const struct device *dev, char *buf, int len, > > > int sz) > > > +{ > > > + int tlen1 = (len < sz ? len : sz); > > > + int tlen2 = ((len - sz) > sz) ? sz : (len - sz); > > > + unsigned char *p; > > > + static cha

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

2012-12-10 Thread Grant Likely
On Fri, 07 Dec 2012 12:30:57 -0500 (EST), David Miller wrote: > From: Grant Likely > Date: Tue, 4 Dec 2012 21:49:26 + > > > On Tue, Dec 4, 2012 at 9:10 PM, David Miller wrote: > >> From: Grant Likely > >> Date: Tue, 4 Dec 2012 14:44:57 + > >

Re: [PATCH] ARM: Kirkwood: Add SPI_CHPA and SPI_CPOL support to spi-orion

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 14:38:00 +0100, Andrew Lunn wrote: > Hi Jason > > I tested your patch to add SPI_CHPA and SPI_CPOL on a QNAP box which > has SPI NAND. No problems seen. > > Tested-by: Andrew Lunn > Thanks Andrew. g. ---

Re: [PATCH] ARM: Kirkwood: Add SPI_CHPA and SPI_CPOL support to spi-orion

2012-12-07 Thread Grant Likely
On Thu, 6 Dec 2012 19:49:33 -0500, Jason Cooper wrote: > On Thu, Dec 06, 2012 at 05:14:33PM -0700, Jason Gunthorpe wrote: > > On Thu, Dec 06, 2012 at 06:53:11PM -0500, Jason Cooper wrote: > > > On Thu, Dec 06, 2012 at 04:49:17PM -0700, Jason Gunthorpe wrote: > > > > Jason: Do you have any of these

Re: [PATCH] spi: Remove SPI_BUFSIZ restriction on spi_write_then_read()

2012-12-07 Thread Grant Likely
On Fri, 7 Dec 2012 12:41:41 +0900, Mark Brown wrote: > On Thu, Dec 06, 2012 at 02:04:27PM +0000, Grant Likely wrote: > > > Alright, applied. I've also merged in your spi-next tree. Let me know if > > that causes problems because it needs to be rebased. > > No probl

Re: [PATCH resend] spi: Add support for specifying 3-wire mode via device tree

2012-12-07 Thread Grant Likely
if (of_find_property(nc, "spi-cs-high", NULL)) > spi->mode |= SPI_CS_HIGH; > + if (of_find_property(nc, "spi-3wire", NULL)) > + spi->mode |= SPI_3WIRE; > > /* Device speed */ >

[PATCH] spi: Fix comparison of different integer types

2012-12-06 Thread Grant Likely
enabled by default] The change to SPI_BUFSIZ was introduced in commit b3a223ee2, "spi: Remove SPI_BUFSIZ restriction on spi_write_then_read()" Cc: Mark Brown Reported-by: kbuild test robot Signed-off-by: Grant Likely --- drivers/spi/spi.c |2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH] ARM: Kirkwood: Add SPI_CHPA and SPI_CPOL support to spi-orion

2012-12-06 Thread Grant Likely
On Thu, 6 Dec 2012 10:25:04 -0700, Jason Gunthorpe wrote: > On Thu, Dec 06, 2012 at 02:25:21PM +0000, Grant Likely wrote: > > On Wed, 21 Nov 2012 12:23:35 -0700, Jason Gunthorpe > > wrote: > > > Support these transfer modes from the SPI layer by setting > > &

Re: [PATCH] spi: spi-mpc52xx.c: Init bus_num to 0 as this driver only supports one bus

2012-12-06 Thread Grant Likely
_probe(struct > platform_device *op) > master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST; > master->dev.of_node = op->dev.of_node; > > + /* Only one SPI bus from this driver possible */ > + master->bus_num = 0; > + > dev_set_drvdat

Re: [PATCH v2] spi: sh-hspi: Improve performance

2012-12-06 Thread Grant Likely
On Fri, 23 Nov 2012 14:46:24 +, Phil Edworthy wrote: > The driver attempts to read the received data immediately after > writing to the transmit buffer. If no data is available, the driver > currently waits 20ms until trying again. Since the hardware needs > to shift out the transmitted data,

Re: [RFC] spi: spi-fsl-spi: Making spi-fsl-spi partly platform-agnostic and adding a new mode for a new core

2012-12-06 Thread Grant Likely
On Thu, 22 Nov 2012 10:26:15 +0100, Andreas Larsson wrote: > I am looking into writing a driver for a core running on sparc that is mostly > but not entirely compatible with the cpu mode of spi-fsl-spi. I am thinking of > what could be the best approach for realizing this. Any comments on a > pre

Re: [PATCH] ARM: Kirkwood: Add SPI_CHPA and SPI_CPOL support to spi-orion

2012-12-06 Thread Grant Likely
> /* we support only mode 0, and no options */ > - master->mode_bits = 0; > + master->mode_bits = SPI_CPHA | SPI_CPOL; > > master->setup = orion_spi_setup; > master->transfer_one_message = orion_spi_transfer_one_message; > -- > 1.7.5.4 > > > _

Re: [PATCH] spi: make sure all transfer has bits_per_word set

2012-12-06 Thread Grant Likely
On Mon, 12 Nov 2012 11:03:56 +0100, Jonas Gorski wrote: > Hi, > > On 9 November 2012 10:06, Laxman Dewangan wrote: > > When spi client does the spi transfer and does not sets > > the bits_per_word for each transfer then set it as default > > of spi device in spi core before calling low level tra

Re: [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver

2012-12-06 Thread Grant Likely
On Wed, 7 Nov 2012 12:40:06 +0100, Bastian Hecht wrote: > This adds the capability to retrieve setup data from the device tree > node. The usage of platform data is still available. > > Signed-off-by: Bastian Hecht Aside from the binding issues I've pointed out on patch 4, this change looks fi

Re: [PATCH 4/4] devicetree: Add Renesas SH Mobile MSIOF spi controller binding doc

2012-12-06 Thread Grant Likely
On Thu, Dec 6, 2012 at 2:08 PM, Grant Likely wrote: > On Wed, 7 Nov 2012 12:40:07 +0100, Bastian Hecht wrote: >> Add binding documentation for Renesas' MSIOF SPI controller. >> >> Signed-off-by: Bastian Hecht >> --- >> Documentation/devic

Re: [PATCH 4/4] devicetree: Add Renesas SH Mobile MSIOF spi controller binding doc

2012-12-06 Thread Grant Likely
On Wed, 7 Nov 2012 12:40:07 +0100, Bastian Hecht wrote: > Add binding documentation for Renesas' MSIOF SPI controller. > > Signed-off-by: Bastian Hecht > --- > Documentation/devicetree/bindings/spi/sh-msiof.txt | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > create

Re: [PATCH 1/4] spi: sh-msiof: Remove unneeded clock name

2012-12-06 Thread Grant Likely
e software, and manage PCs from one command center > Diagnose problems and improve visibility into emerging IT issues > Automate, monitor and manage. Do more in less time with Central > http://p.sf.net/sfu/logmein12331_d2d > ___ > spi-devel-general mailing list > spi-devel-gene

Re: [PATCH] spi: Remove SPI_BUFSIZ restriction on spi_write_then_read()

2012-12-06 Thread Grant Likely
On Thu, 6 Dec 2012 14:37:33 +0900, Mark Brown wrote: > On Thu, Dec 06, 2012 at 12:00:26AM +0000, Grant Likely wrote: > > > Looks good to me. Probably 3.9 material though. > > > Acked-by: Grant Likely > > Hrm, I'd be inclined to apply it now - it's isolate

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-06 Thread Grant Likely
On Wed, 21 Nov 2012 10:16:43 +0800, chao bi wrote: > > This patch is to implement SSP SPI controller driver, which has been applied > and > validated on intel Moorestown & Medfield platform. The patch are originated by > Ken Mills and Sylvain Centelles > , > and to be further developed by Chan

Re: [PATCH] spi: Remove SPI_BUFSIZ restriction on spi_write_then_read()

2012-12-05 Thread Grant Likely
> the transfer won't fit. > > Signed-off-by: Mark Brown Looks good to me. Probably 3.9 material though. Acked-by: Grant Likely > --- > drivers/spi/spi.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/drivers/s

Re: [linux-keystone] [PATCH v1 1/1] spi: davinci: add OF support for the spi controller

2012-12-05 Thread Grant Likely
gt; Hi Murali. Thanks for the patch. Comments below... > Signed-off-by: Murali Karicheri > Reviewed-by : Grant Likely > --- > .../devicetree/bindings/spi/spi-davinci.txt| 51 ++ > drivers/spi/spi-davinci.c | 102 > +--- &

Re: [PATCH RESEND] spi: stmp: remove obsolete driver

2012-12-05 Thread Grant Likely
register_master(master); > - if (err) { > - dev_dbg(&dev->dev, "cannot register spi master, %d\n", err); > - goto out_free_irq_2; > - } > - dev_info(&dev->dev, "at (mapped) 0x%08X, irq=%d, bus %d, %s mode\n", > -

Re: [PATCH v4] spi: Add Lattice ECP3 FPGA configuration via SPI

2012-12-05 Thread Grant Likely
spi0.0: FPGA succesfully configured! > > Signed-off-by: Stefan Roese > Cc: Ming Lei > Cc: Grant Likely Hi Stefan, Comments below. > --- > v4: > - Allocate per-device struct to store the completion > variable unique per device > > v3: > - Removed unnecessary

Re: [v2 PATCH 02/14] of_spi: add generic binding support to specify cs gpio

2012-12-05 Thread Grant Likely
On Tue, 4 Dec 2012 15:53:48 +0800, Wenyou Yang wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > This will allow to use gpio for chip select with no modification in the > driver binding > > When use the cs-gpios, the gpio number will be passed via the cs_gpio field > and the number of chip s

Re: [PATCH RESEND] ARM/SPI: New driver for SPI master controller for CLPS711X-target

2012-12-05 Thread Grant Likely
ue to platform limitations driver supports only 8 bit transfer mode. > > > Chip select control is handled via GPIO. > > > > > > Signed-off-by: Alexander Shiyan > > > > Acked-by: Arnd Bergmann > > > > Please apply this patch in the SPI tree. Appli

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

2012-12-04 Thread Grant Likely
On Tue, Dec 4, 2012 at 9:10 PM, David Miller wrote: > From: Grant Likely > Date: Tue, 4 Dec 2012 14:44:57 + > >> On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson wrote: >>> This series removes the dependency on !SPARC for OF_I2C and removes the >>> depence

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

2012-12-04 Thread Grant Likely
On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson wrote: > This series removes the dependency on !SPARC for OF_I2C and removes the > depencency of !defined(CONFIG_SPARC) for the function > of_register_spi_devices. I find no reason for these to be unavailable > for sparc. > > I am not sure if these s

Re: [PATCH RESEND] spi: erase pointer to drvdata on removal

2012-12-04 Thread Grant Likely
); > + return status; > } > > static void spi_drv_shutdown(struct device *dev) > -- > 1.7.11.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@v

Re: [linux-keystone] Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-12-03 Thread Grant Likely
On Fri, 30 Nov 2012 17:57:38 -0500, Murali Karicheri wrote: > On 11/15/2012 11:20 AM, Grant Likely wrote: > > On Mon, 12 Nov 2012 16:28:22 -0500, Murali Karicheri > > wrote: > >> This adds OF support to DaVinci SPI controller to configure platform > >

Re: [PATCH 2/2] spi: sh-hspi: add CS manual control support

2012-11-23 Thread Grant Likely
On Thu, 22 Nov 2012 14:37:27 +, Phil Edworthy wrote: > The current HSPI driver used automatic CS control, leading to CS > active for each byte transmitted. This patch changes the driver > to manual CS control, and ensures CS is active thoughout a whole > message. Additionally, it uses the cs_

Re: [PATCH 1/2] spi: sh-hspi: Improve performance

2012-11-23 Thread Grant Likely
On Thu, 22 Nov 2012 14:37:26 +, Phil Edworthy wrote: > The driver attempts to read the recieved data immediately after > writing to the transmit buffer. If no data is available, the driver > currently waits 20ms until trying again. Since the hardware needs > to shift out the transmitted data,

Re: [linux-keystone] Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-11-21 Thread Grant Likely
On Fri, 16 Nov 2012 11:32:46 -0500, Murali Karicheri wrote: > On 11/15/2012 11:20 AM, Grant Likely wrote: > > On Mon, 12 Nov 2012 16:28:22 -0500, Murali Karicheri > > wrote: > >> This adds OF support to DaVinci SPI controller to configure platform > >

Re: [PATCH 1/1 v2] of_spi: add generic binding support to specify cs gpio

2012-11-21 Thread Grant Likely
On Thu, 15 Nov 2012 20:19:57 +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > This will allow to use gpio for chip select with no modification in the > driver binding > > When use the cs-gpios, the gpio number will be passed via the cs_gpio field > and the number of chip select will automaticall

Re: [PATCH 02/16] of_spi: add generic binding support to specify cs gpio

2012-11-15 Thread Grant Likely
On Wed, 10 Oct 2012 14:27:20 +0800, Wenyou Yang wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > This will allow to use gpio for chip select with no modification in the > driver binding > > When use the cs-gpios, the gpio number will be passed via the cs_gpio field > and the number of chip s

Re: [PATCH] spi: Export OF interfaces.

2012-11-15 Thread Grant Likely
On Wed, 31 Oct 2012 17:57:33 +0200, Pantelis Antoniou wrote: > Export an interface that other in-kernel users can utilize. > > Signed-off-by: Pantelis Antoniou I'm not going to apply this before an in-kernel user exists for this. I know it's part of the whole runtime population of the device t

Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-11-15 Thread Grant Likely
ce table, else try of irq method */ > dspi->irq = platform_get_irq(pdev, 0); > + if (dspi->irq <= 0) > + dspi->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > + This should never be needed. The i

Re: [PATCH] spi: omap2-mcspi: remove duplicated include from spi-omap2-mcspi.c

2012-11-14 Thread Grant Likely
; index 474e217..b8b2f03 100644 > --- a/drivers/spi/spi-omap2-mcspi.c > +++ b/drivers/spi/spi-omap2-mcspi.c > @@ -39,7 +39,6 @@ > #include > #include > #include > -#include > > #include &

Re: [GIT PULL] Disintegrate UAPI for spi

2012-10-12 Thread Grant Likely
On Sat, Oct 13, 2012 at 12:06 AM, David Howells wrote: > Grant Likely wrote: > >> > Can you merge the following branch into the spi tree please. >> >> Do you want this merged into 3.7? If so, go ahead and push it directly >> to Linus. I've not been able

Re: [GIT PULL] Disintegrate UAPI for spi

2012-10-12 Thread Grant Likely
sintegrate include/linux/spi > > include/linux/spi/Kbuild | 1 - > include/uapi/linux/spi/Kbuild | 1 + > include/{ => uapi}/linux/spi/spidev.h | 0 > 3 files changed, 1 insertion

Re: [RFC PATCH v2 00/16] DMA Engine support for AM33xx

2012-10-11 Thread Grant Likely
Hey Matt, Do you know now similar are the EDMA engines on the am33xx and am389x? I've been working on am389x upstreaming and I'll try these patches out if it is the same engine. g. On Oct 11, 2012 8:03 PM, "Matt Porter" wrote: > Changes since v1: > - Rebased on top of mainline from 1225

Re: [GIT PULL] SPI updates for 3.7

2012-10-02 Thread Grant Likely
On Tue, Oct 2, 2012 at 6:49 PM, Mark Brown wrote: > The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d: > > Linux 3.6-rc7 (2012-09-23 18:10:57 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git tags/spi

Re: Ack possibility for '[PATCH] SPI: OMAP: remove unnecessary includes of plat/clock.h' ?

2012-09-11 Thread Grant Likely
this patch so we can merge it > via OMAP: > > http://marc.info/?l=linux-omap&m=134740630311140&w=2 > > Just noticed we have a dependency on that patch for some common clock > framework conversion patches also... > > > - Paul -- Gra

Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-08-02 Thread Grant Likely
On Thu, Aug 2, 2012 at 5:08 PM, Aaro Koskinen wrote: > This reverts commit 9fdca9dfe093c76fe1ac1a09888ba9679d46996a. > > Changing omap2_mcspi_init() from subsys_initcall to device_initcall broke > the display initialization on N900 when all the drivers are compiled > built-in. Display subsystem dr

RE: [PATCH V5 16/17] SPI: MIPS: lantiq: add FALCON spi driver

2012-05-30 Thread Grant Likely
On Tue, 29 May 2012 13:05:18 +, "Langer Thomas (LQDE CPE AE SW)" wrote: > Hello Grant, hello John, > > John Crispin wrote on 2012-05-26: > > > >> What exactly does this mean? How does it not support any other type > >> of SPI peripheral? SPI is a really simple protocol, so what is it > >

Re: [PATCH V5 16/17] SPI: MIPS: lantiq: add FALCON spi driver

2012-05-30 Thread Grant Likely
On Sat, 26 May 2012 15:47:24 +0200, John Crispin wrote: > > > What exactly does this mean? How does it not support any other type > > of SPI peripheral? SPI is a really simple protocol, so what is it > > about this hardware that prevents it being used with other SPI > > hardware? > > > > I see

Re: [PATCH V5 16/17] SPI: MIPS: lantiq: add FALCON spi driver

2012-05-26 Thread Grant Likely
On Sun, 20 May 2012 15:46:19 +0200, John Crispin wrote: > From: Thomas Langer > > The external bus unit (EBU) found on the FALCON SoC has spi emulation that is > designed for serial flash access. This driver has only been tested with m25p80 > type chips. The hardware has no support for other typ

Re: [PATCH] spi: Keep chipselect assertion during one message

2012-05-26 Thread Grant Likely
else > - disable_cs(sdd, spi); > } > > msg->actual_length += xfer->len; > -- > 1.7.1 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. --

Re: [PATCH 1/3] spi/bcm63xx: remove driver version

2012-05-26 Thread Grant Likely
On Mon, 21 May 2012 19:05:58 +0200, Florian Fainelli wrote: > As Grant Likely reported, this does not make any sense in a mainline kernel > remove that driver version string. > > Reported-by: Grant Likely > Signed-off-by: Florian Fainelli Applied, thanks. g. > ---

Re: [PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer()

2012-05-26 Thread Grant Likely
uot;, > - spi->mode & ~MODEBITS); > - return ret; > - } > - > dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u nsec/bit\n", > __func__, spi->

Re: [PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks

2012-05-26 Thread Grant Likely
int bcm63xx_spi_resume(struct device *dev) > > clk_enable(bs->clk); > > + spi_master_resume(master); > + > return 0; > } > > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -

Re: [PATCH 3/3] spi: bitbang: convert to using core message queue

2012-05-26 Thread Grant Likely
atus = spi_register_master(bitbang->master); > - if (status < 0) > - goto err2; > - > - return status; > - > -err2: > - destroy_workqueue(bitbang->workqueue); > -err1: > - return status; > + return spi_register_master(master); > } &

Re: [PATCH] spi/fsl-espi: Add missing cell-index OF property

2012-05-26 Thread Grant Likely
> spi-devel-general mailing list > spi-devel-general@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/spi-devel-general -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. --

Re: [PATCH] spi: Change FIFO flush operation and spi channel off

2012-05-26 Thread Grant Likely
64XX_SPI_CH_RXCH_ON | S3C64XX_SPI_CH_TXCH_ON); > - writel(val, regs + S3C64XX_SPI_CH_CFG); > } > > static void s3c64xx_spi_dmacb(void *data) > -- > 1.7.1 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ---

Re: [PATCH] spi: Add AD-FMCOMMS1-EBZ I2C-SPI bridge driver

2012-05-26 Thread Grant Likely
i2c = i2c; > + > + master->num_chipselect = 16; > + master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_3WIRE; > + master->setup = spi_xcomm_setup; > + master->transfer_one_message = spi_xcomm_transfer_one; > + master->dev.of_node = i2c->dev.of_node; >

Re: [PATCH 2/3] spi: bitbang: (cosmetic) simplify list manipulation

2012-05-26 Thread Grant Likely
> - m = container_of(bitbang->queue.next, struct spi_message, > - queue); > - list_del_init(&m->queue); > + list_del(&m->queue); > spin_unlock_irqrestore(&bitbang->lock, flags); >

Re: [PATCH 1/3] spi: bitbang: avoid needless loop flow manipulations

2012-05-26 Thread Grant Likely
bitbang->chipselect(spi, BITBANG_CS_INACTIVE); > + ndelay(nsecs); > + } > } > > m->status = status; > -- > 1.7.2.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.

[GIT PULL] spi changes for v3.5 merge window

2012-05-24 Thread Grant Likely
module_platform_driver Grant Likely (4): Merge branch 'spi' of git://gitorious.org/linus-tree/linus-tree into spi/next spi/devicetree: Move devicetree support code into spi directory Merge tag 'v3.4-rc6' into spi/next spi: By default setup spi_masters with 1 chipselect and

Re: of/spi: Supply proper "spi:" modalias prefixes.

2012-05-22 Thread Grant Likely
ribute > *a, char *buf) > { > const struct spi_device *spi = to_spi_device(dev); > > - return sprintf(buf, "%s\n", spi->modalias); > + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); > } > > static struct de

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

2012-05-22 Thread Grant Likely
Cool, thanks. g. On Tue, May 22, 2012 at 4:49 PM, David Daney wrote: > On 05/22/2012 01:09 PM, Grant Likely wrote: >> >> On Tue, May 22, 2012 at 1:45 PM, David Daney >>  wrote: >>> >>> On 05/19/2012 11:08 PM, Grant Likely wrote: >>>>

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

2012-05-22 Thread Grant Likely
On Tue, May 22, 2012 at 1:45 PM, David Daney wrote: > On 05/19/2012 11:08 PM, Grant Likely wrote: >> >> On Sat, 19 May 2012 23:54:36 -0600, Grant >> Likely  wrote: >>> >>> On Fri, 11 May 2012 15:05:21 -0700, David Daney >>>  wrote: >>>>

Re: [PATCH 3/3] eeprom/of: Add device tree bindings to at25.

2012-05-19 Thread Grant Likely
ct spi_device_id at25_id[] = { > + {"at25", 0}, > + {"m95256", 0}, > + { } > +}; > +MODULE_DEVICE_TABLE(spi, at25_id); > + > static struct spi_driver at25_driver = { > .driver = { > .name = "at25", >

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

2012-05-19 Thread Grant Likely
On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: > On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > > From: David Daney > > > > When generating MODALIASes, it is convenient to add things like "spi:" > > or "i2c:" to the

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > From: David Daney > > When generating MODALIASes, it is convenient to add things like "spi:" > or "i2c:" to the front of the strings. This allows the standard > modprobe to find the right driver when automatically populating bus > childre

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 14:34:46 -0700, David Daney wrote: > From: David Daney > > Add the driver, link it into the kbuild system and provide device tree > binding documentation. > > Signed-off-by: David Daney Some comments below, but you can add my a-b: Acked-by: Grant Li

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-05-19 Thread Grant Likely
On Mon, 14 May 2012 11:13:41 -0700, David Daney wrote: > On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote: > > Hi David, > > A few comments. > > > > On Sat, May 12, 2012 at 3:04 AM, David Daney wrote: > [...] > > >> + > >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */ > >

Re: [PATCH 1/2] MIPS: OCTEON: Add register definitions for SPI host hardware.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 14:34:45 -0700, David Daney wrote: > From: David Daney > > Needed by SPI driver. > > Signed-off-by: David Daney > --- > arch/mips/include/asm/octeon/cvmx-mpi-defs.h | 328 > ++ > 1 files changed, 328 insertions(+), 0 deletions(-) > create mode 10

Re: [PATCH] SPI: PRIMA2: use the newest APIs of PINCTRL to fix compiling errors

2012-05-19 Thread Grant Likely
On Tue, 15 May 2012 10:02:01 +0200, Linus Walleij wrote: > On Tue, May 15, 2012 at 4:21 AM, Barry Song wrote: > > > From: Barry Song > > > > Fix the compiling errors: > > drivers/spi/spi-sirf.c: In function 'spi_sirfsoc_probe': > > drivers/spi/spi-sirf.c:563: error: implicit declaration of fun

Re: [PATCH V3 16/17] SPI: MIPS: lantiq: add FALCON spi driver

2012-05-19 Thread Grant Likely
On Mon, 14 May 2012 22:00:42 +0200, John Crispin wrote: > From: Thomas Langer > > The external bus unit (EBU) found on the FALCON SoC has spi emulation that is > designed for serial flash access. This driver has only been tested with m25p80 > type chips. The hardware has no support for other typ

Re: [PATCH] spi/spi-fsl-spi: reference correct pdata in fsl_spi_cs_control

2012-05-19 Thread Grant Likely
dev = spi->dev.parent->parent; > > struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data); > > u16 cs = spi->chip_select; > > int gpio = pinfo->gpios[cs]; > > So it seems > Acked-by: Joakim Tjernlund > Applied, thanks. g.

Re: [PATCH v2 6/6] spi: s3c64xx: add device tree support

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham wrote: > Add support for device based discovery. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely ... but one nitpick below... > +#ifdef CONFIG_OF > +static const s

Re: [PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-19 Thread Grant Likely
as the slave select line, this callback can be removed from the > controller data and replaced with call to gpio_set_value in the driver. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > arch/arm/plat-samsung/include/plat/s3c64xx-

Re: [PATCH v2 2/6] spi: s3c64xx: move controller information into driver data

2012-05-19 Thread Grant Likely
t; it can be moved into the driver data and removed from platform data. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > arch/arm/mach-exynos/clock-exynos4.c | 18 +- > arch/arm/mach-exynos/setup-spi.c

Re: [PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:28 +0530, Thomas Abraham wrote: > The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > drivers/spi/spi-s3c64xx.c |4 >

Re: [PATCH v2 0/6] spi: s3c64xx: add support for device tree

2012-05-19 Thread Grant Likely
t/s3c64xx-spi.h | 31 +- > drivers/spi/spi-s3c64xx.c | 467 > +++++--- > 20 files changed, 611 insertions(+), 300 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/spi-samsung.txt > -- Grant Likely, B.Sc, P.Eng. Secre

Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated

2012-05-19 Thread Grant Likely
On Tue, 15 May 2012 21:58:01 +0200, Andrew Lunn wrote: > On Thu, May 10, 2012 at 09:24:55PM -0600, Grant Likely wrote: > > On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij > > wrote: > > > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D > > > wrote: >

Re: [PATCH] spi: refactor spi-coldfire-qspi to use SPI queue framework.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 16:28:57 +1000, Greg Ungerer wrote: > On 11/05/12 02:26, Steven King wrote: > > Use the new SPI queue framework; remove use of workqueue, replace > > mcfqspi_transfer with mcfqspi_transfer_one_message, add > > mcfqspi_prepare_transfer_hw and mcfqspi_unprepare_transfer_hw, updat

Re: [PATCH] spi/omap2-mcspi: convert to the pump message infrastructure

2012-05-19 Thread Grant Likely
On Tue, 15 May 2012 12:04:15 +0530, Shubhrajyoti Datta wrote: > Hi Linus, > > On Tue, May 15, 2012 at 1:42 AM, Linus Walleij > wrote: > > On Thu, May 10, 2012 at 2:57 PM, Shubhrajyoti D wrote: > > > >> This patch converts the OMAP SPI driver to use the SPI infrastructure > >> pump message que

Re: [PATCH] SPI: Refactor spi-orion to use SPI framework queue.

2012-05-19 Thread Grant Likely
transfer_hardware = orion_spi_prepare_transfer; > + master->unprepare_transfer_hardware = orion_spi_unprepare_transfer; > master->num_chipselect = ORION_NUM_CHIPSELECTS; > > dev_set_drvdata(&pdev->dev, master); > @@ -503

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-19 Thread Grant Likely
as the slave select line, this callback can be removed from the > controller data and replaced with call to gpio_set_value in the driver. > > Cc: Jaswinder Singh > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > arch/arm/plat-samsung/include/plat/s3c64xx-spi.

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-19 Thread Grant Likely
> > I'd not say the diff is *that* big (and most of what's there is simple > and repetitive), and bisection is a very useful tool. I know I > frequently find it enormously painful trying to figure out breakage when > large chunks of the history don't

<    1   2   3   4   5   6   7   8   9   10   >