URL: https://github.com/SSSD/sssd/pull/655
Title: #655: Invalid id provider prevents other domains to start
mzidek-rh commented:
"""
I pushed the patch that fixes the issue with 'local' provider. I think this
version should be OK (low risk, no weird hacks, etc. :) )
I think
URL: https://github.com/SSSD/sssd/pull/655
Author: mzidek-rh
Title: #655: Invalid id provider prevents other domains to start
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/655/head:pr655
git checkout pr655
From
URL: https://github.com/SSSD/sssd/pull/657
Title: #657: be: use be_is_offline for the main domain when asking for domain
status
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/657
Title: #657: be: use be_is_offline for the main domain when asking for domain
status
mzidek-rh commented:
"""
Can you please add a FIXME comment to the code with short explanation and link
to the https://pagure.io/SSSD/sssd/issue/383
URL: https://github.com/SSSD/sssd/pull/655
Title: #655: Invalid id provider prevents other domains to start
mzidek-rh commented:
"""
Just a small update.
We had a debug seesion with jhrozek today and the observation is following:
The reason why SSSD is terminating is because
URL: https://github.com/SSSD/sssd/pull/649
Title: #649: sudo: respect case sensitivity in sudo responder
mzidek-rh commented:
"""
ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/649#issuecomment-420656810
URL: https://github.com/SSSD/sssd/pull/649
Title: #649: sudo: respect case sensitivity in sudo responder
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/649
Title: #649: sudo: respect case sensitivity in sudo responder
mzidek-rh commented:
"""
Sorry for the delay I ran into some issues while setting up the sudo.
The patch works as expected.
Code looks good to me.
When CI fini
URL: https://github.com/SSSD/sssd/pull/655
Title: #655: Invalid id provider prevents other domains to start
mzidek-rh commented:
"""
TLDR: I will update the PR :)
Actually I think there are two issues here.
One is that the domain has invalid config that prevents it to start (b
URL: https://github.com/SSSD/sssd/pull/655
Title: #655: Invalid id provider prevents other domains to start
mzidek-rh commented:
"""
But I think it is really convenient to detect this error in this part of the
code (where current patches do it) because detecting the error
URL: https://github.com/SSSD/sssd/pull/655
Title: #655: Invalid id provider prevents other domains to start
mzidek-rh commented:
"""
In that case we probably could detect only that the module (.so) failed to load
and make that non fatal. I looked into that part of code a
URL: https://github.com/SSSD/sssd/pull/655
Author: mzidek-rh
Title: #655: Invalid id provider prevents other domains to start
Action: opened
PR body:
"""
See the commit message.
https://pagure.io/SSSD/sssd/issue/3828
"""
To pull the PR as Git branch:
git remote
URL: https://github.com/SSSD/sssd/pull/645
Title: #645: SELINUX: Always add SELinux user to the semanage database if it
doesn't exist
mzidek-rh commented:
"""
Hi,
the code looks good to me.
I tested the patch and it works as expected.
ACK.
There is one thing that I think is w
URL: https://github.com/SSSD/sssd/pull/645
Title: #645: SELINUX: Always add SELinux user to the semanage database if it
doesn't exist
mzidek-rh commented:
"""
I set up machines to review this. If nobody was reviewing it so far I can pick
this for a review after the
URL: https://github.com/SSSD/sssd/pull/649
Title: #649: sudo: respect case sensitivity in sudo responder
mzidek-rh commented:
"""
In case nobody is reviewing this today I will take this for a review (probably
on Monday).
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/648
Author: mzidek-rh
Title: #648: GPO: Add gpo_implicit_deny option
Action: opened
PR body:
"""
This option (when set to True) can be used to deny access to
users even if there is not applicable GPO. Normally users are
allowed access in
URL: https://github.com/SSSD/sssd/pull/643
Title: #643: KCM: Don't error out if creating a new ID as the first step
mzidek-rh commented:
"""
Works for me. ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/638
Title: #638: Explicitly add GPLv3+ license blob to several files
mzidek-rh commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/638#issuecomment-412502789
URL: https://github.com/SSSD/sssd/pull/638
Title: #638: Explicitly add GPLv3+ license blob to several files
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/637
Title: #637: Relicense GPLv2 only files as GPLv3+
mzidek-rh commented:
"""
Ok, then it is an ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/637#issuecomment-412490392
URL: https://github.com/SSSD/sssd/pull/637
Title: #637: Relicense GPLv2 only files as GPLv3+
mzidek-rh commented:
"""
LGTM.
Does it make sense to run a CI for this? I think the CI infra is quite
overloaded and this is just change in comments. I would probably skip the CI
for t
URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space
mzidek-rh commented:
"""
ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/622#issuecomment-408442516
URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space
mzidek-rh commented:
"""
Thanks @jhrozek for the explanation, It makes sense to me now. I will just run
a CI check and if it passes then I will give my ACK.
&q
URL: https://github.com/SSSD/sssd/pull/625
Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation"
mzidek-rh commented:
"""
Note: The issue was that stpncpy returns pointer to the end of the copied
string not to the beginning.
"""
See the
URL: https://github.com/SSSD/sssd/pull/625
Author: mzidek-rh
Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation"
Action: opened
PR body:
"""
This reverts commit 2951a9a84bd85f384213a3e071ffc167907df2d7.
The original use stpncpy was correct. Chan
URL: https://github.com/SSSD/sssd/pull/578
Title: #578: proxy: proxy_child hardening
mzidek-rh commented:
"""
@jhrozek Hi, sorry missed the question before (thanks @fidencio for the
notice). AFAIK we do not sanitize the domain name nor do we check if it is a
valid domain
URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir
mzidek-rh commented:
"""
The CI passed. ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/598#issuecomment-397608091
_
URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora
URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir
mzidek-rh commented:
"""
The patch looks good. Just waiting for the CI to finish.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir
mzidek-rh commented:
"""
@fidencio Thanks for the info. I will try to do the review before today's call.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/591
Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf
mzidek-rh commented:
"""
@amitkumar50 How did you test the patch? I can see the traceback even with the
patch applied when I put spaces at the beginning of th
URL: https://github.com/SSSD/sssd/pull/596
Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section
mzidek-rh commented:
"""
Hi Amit,
sorry, but the solution you propose is not backward compatible.
We need:
- current SSSD configurations to work as they do
URL: https://github.com/SSSD/sssd/pull/593
Author: mzidek-rh
Title: #593: Better debug messages for some GPO misconfigurations
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/593/head:pr593
git checkout pr593
From
URL: https://github.com/SSSD/sssd/pull/593
Author: mzidek-rh
Title: #593: Better debug messages for some GPO misconfigurations
Action: opened
PR body:
"""
Both patches are inspired by real world struggles of people with debug logs :)
The second patch solves:
https://pagure.io/
URL: https://github.com/SSSD/sssd/pull/560
Title: #560: NSS: close files after mmap
mzidek-rh commented:
"""
@ChrisKowalczyk Hmm.. i thought we are using the fd in the memory cache
operations, but it does not seem to be the case, so yes we do not need the fd,
just the pointe
URL: https://github.com/SSSD/sssd/pull/560
Title: #560: NSS: close files after mmap
mzidek-rh commented:
"""
Hi,
I do not know what issue is this patch trying to solve (I do not have Suse
bugzilla account and I get Bugzilla – Access Denied), but the patch is not
correct.
W
URL: https://github.com/SSSD/sssd/pull/552
Title: #552: GPO: Store security CSE settings of all applicable GPOs
mzidek-rh commented:
"""
So, I am closing this PR and would like to redirect all future discussion to
https://pagure.io/SSSD/sssd/issue/3712
Thanks,
Michal
"&quo
URL: https://github.com/SSSD/sssd/pull/552
Author: rdratlos
Title: #552: GPO: Store security CSE settings of all applicable GPOs
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/552/head:pr552
git checkout pr552
URL: https://github.com/SSSD/sssd/pull/552
Title: #552: GPO: Store security CSE settings of all applicable GPOs
mzidek-rh commented:
"""
Hi,
I would personally close this PR and open an RFE ticket on Pagure (actually
just did it https://pagure.io/SSSD/sssd/issue/3712)
URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules
mzidek-rh commented:
"""
Hi @rdratlos ,
the PR #552 does not solve the problem described in issue
https://pagure.io/SSSD/sssd/issue/3680 .
The changes made in that PR seem to be unrelat
URL: https://github.com/SSSD/sssd/pull/551
Author: mzidek-rh
Title: #551: GPO: Fix bug with empty GPO rules
Action: opened
PR body:
"""
Resolves:
https://pagure.io/SSSD/sssd/issue/3680
To reproduce:
On AD server create 2 GPO rules:
- Allow log on locally - allow group Administ
URL: https://github.com/SSSD/sssd/pull/549
Author: mzidek-rh
Title: #549: Respect ad_site option in GPO resolution
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/549/head:pr549
git checkout pr549
From
URL: https://github.com/SSSD/sssd/pull/549
Author: mzidek-rh
Title: #549: Respect ad_site option in GPO resolution
Action: opened
PR body:
"""
GPO resolution requires AD site name to work properly.
We ignored the ad_site option to override autodiscovered ad site i
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
ACK.
CI results:
$SSSD_LAB.com/:8080/job/ci/8697/
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
Actually, I do not have permissions to close this PR :D
So, someone who does have it, please close this PR :)
"""
See
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
@simo5 `domain/_defaults_` sounds good to me as well :) , I will updated the
issue and I am closing this PR.
Thanks everyone for your
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
Ok, I just pushed to last iteration to CI. If it is green I will ACK :)
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
@simo5 : I understand why you want to set defaults in the [sssd] section and it
makes sense to me. But I also think we may end up f
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
The last version does not work for me:
```
# PEP8_IGNORE="--ignore=E121,E123,E126,E226,E24,E704,W503"
# find ./src -path ./src/config -prune
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
I pushed the patch to CI.
This issue blocks CI, so I will ACK it when the results are green. I am not
python expert either, but the fix LGTM. If s
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
I opened https://pagure.io/SSSD/sssd/issue/3664 to track the logging issue.
Thank you @CendioOssman for this feedback.
About putting
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
Hello,
I do not think this is a good way to approach this issue. There can be hundreds
of different PAM services that could be mapp
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
Hello,
it is not necessary to change the internal defaults to support ThinLinc. The
mapping of PAM services to GPO rules is configura
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to tune the memcache size
mzidek-rh commented:
"""
fidencio wrote:
>
> Do we still want to have those changes merged at some point?
>
Yes, but there was condition that we need a way to get statistic
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to tune the memcache size
mzidek-rh commented:
"""
fidencio wrote:
>
> Do we still want to have those changes merged at some point?
>
Yes, but there was condition that we need a way to get statistic
URL: https://github.com/SSSD/sssd/pull/527
Author: mzidek-rh
Title: #527: PEP8 Fixes and enable PEP8 check in CI
Action: opened
PR body:
"""
Hi,
because @fidencio is on PTO I allowed myself to rebase and update his branch:
https://github.com/fidencio/sssd/tree/wip/ci_en
URL: https://github.com/SSSD/sssd/pull/510
Author: amitkumar50
Title: #510: MAN: Explain how does auto_private_groups affect subdomains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/510/head:pr510
git checkout pr510
URL: https://github.com/SSSD/sssd/pull/507
Title: #507: SELINUX: Check if SELinux is managed in selinux_child
mzidek-rh commented:
"""
Here is some summary of the changes in the new version.
After offline discussion with Lukas, these changes were done:
- the function sss_is_
URL: https://github.com/SSSD/sssd/pull/507
Author: mzidek-rh
Title: #507: SELINUX: Check if SELinux is managed in selinux_child
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/507/head:pr507
git checkout pr507
From
URL: https://github.com/SSSD/sssd/pull/507
Title: #507: SELINUX: Check if SELinux is managed in selinux_child
mzidek-rh commented:
"""
'!a' -> 'a == NULL' nitpick mentioned by @fidencio was fixed. Otherwise it is
the same patch.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/507
Author: mzidek-rh
Title: #507: SELINUX: Check if SELinux is managed in selinux_child
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/507/head:pr507
git checkout pr507
From
URL: https://github.com/SSSD/sssd/pull/507
Author: mzidek-rh
Title: #507: SELINUX: Check if SELinux is managed in selinux_child
Action: opened
PR body:
"""
If SELinux policy is not managed at all, don't call any SELinux user
handling functions and instead return that no u
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
mzidek-rh commented:
"""
I checked the coding guidelines if there is something about upper-cased
constants and did not find anyth
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
mzidek-rh commented:
"""
> I personally think 'const' is better then #define if we do not need to put
> the constant into a h
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
mzidek-rh commented:
"""
Hi!
I personally think 'const' is better then #define if we do not need to put the
constant into a head
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
mzidek-rh commented:
"""
Hi @amitkumar50!
I am not native English speaker and I do often make mistakes when I use
English, so I definitely do not wan
URL: https://github.com/SSSD/sssd/pull/473
Title: #473: Revert "intg: Disable add_remove tests"
mzidek-rh commented:
"""
I also lost local VM were I was able to reproduce the failure and since then I
was not sure if I was just lucky that it passes or if the issue some
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
mzidek-rh commented:
"""
I have a training today, so I am not sure if I will be able to review and test
this patch today or tomorrow,
URL: https://github.com/SSSD/sssd/pull/460
Title: #460: sysdb-test: Fix warning may be used uninitialized
mzidek-rh commented:
"""
CI passed. ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/460#issuecomment-347513115
__
URL: https://github.com/SSSD/sssd/pull/460
Title: #460: sysdb-test: Fix warning may be used uninitialized
mzidek-rh commented:
"""
LGTM.
Launched CI.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/460#issuecomment-347496359
__
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
On 11/23/2017 12:50 PM, lslebodn wrote:
> On (23/11/17 11:31), mzidek-rh wrote:
> >mzidek-rh commented on this pull request.
> >I
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
The CI results for @fidencio 's change arrived. ACK to the patchset.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
Fabiano's change LGTM. I resubmitted the patchset to the CI.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
Hi @fidencio ,
at first look I also thought covscan found an issue here, but looking closer
this seems to be a false positive match. Few lines
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/455#issuecomment-346023383
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
Thanks Sumit. Just waiting for the CI to finish before ACKing.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
mzidek-rh commented:
"""
Ok, closing this PR, we can continue on Pagure.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/412
Author: mzidek-rh
Title: #412: Gpo contributed patches
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/412/head:pr412
git checkout pr412
URL: https://github.com/SSSD/sssd/pull/455
Title: #455: mmap_cache: make checks independent of input size
mzidek-rh commented:
"""
Just two really minor nitpicks (typo in word 'relative' and missing space
around '+'):
```
diff --git a/src/responder/nss/nsssrv_mmap_cache.c
b/sr
URL: https://github.com/SSSD/sssd/pull/454
Title: #454: TESTS: Order list of entries in some lists
mzidek-rh commented:
"""
Updated. There should be no valgrind issues now.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/454
Title: #454: TESTS: Order list of entries in some lists
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/454
Title: #454: TESTS: Order list of entries in some lists
mzidek-rh commented:
"""
I rewrote it to use the qsort. Also added the revert patch for the patch that
disables the tests.
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
mzidek-rh commented:
"""
Hi,
I think it is OK if this PR is closed and a new one is opened here on GH by
@rdratlos . It is also OK if he updates the PR on Pagure. Whatever works better
for @rdr
URL: https://github.com/SSSD/sssd/pull/451
Title: #451: BUILD: Disable tests with know failures
mzidek-rh commented:
"""
Here is the PR:
https://github.com/SSSD/sssd/pull/454
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/454
Author: mzidek-rh
Title: #454: TESTS: Order list of entries in some lists
Action: opened
PR body:
"""
Some tests started to fail becuase we depended on specific
order users in groups or messages in ldb results to be
returned and tha
URL: https://github.com/SSSD/sssd/pull/451
Title: #451: BUILD: Disable tests with know failures
mzidek-rh commented:
"""
@lslebodn yeah I see (just tried the patch)... the tests need to be modified
and that part in the branch may not be even necessary... so forget the branch,
URL: https://github.com/SSSD/sssd/pull/451
Title: #451: BUILD: Disable tests with know failures
mzidek-rh commented:
"""
Here is the branch if interested to look at the scope, but as I said I need to
run it in the environment where it was failing before submitting PR
https://gi
URL: https://github.com/SSSD/sssd/pull/451
Title: #451: BUILD: Disable tests with know failures
mzidek-rh commented:
"""
Sorry I forgot about this. I do have a patch for
https://pagure.io/SSSD/sssd/issue/3563 in ordererd-string-arrays (I just pushed
the branch to gh). Bu
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
mzidek-rh commented:
"""
@fidencio Dan did run the tests and I had results, but the tests were all
failing due to SSSD not been able to start. IIRC it was due to wrong selinux
policy installed in
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
Here is the issue that tracks the email in 'nameAlias' attribute issue:
https://pagure.io/SSSD/sssd/issue/3567
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
mzidek-rh commented:
"""
Hi,
the whole point of the issue is to update the tests (that fail with this patch)
to use confdb and stop using the code path that automatically generat
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
mzidek-rh commented:
"""
Hi,
the whole point of the issue is to update the test to use confdb and stop using
the code path that automatically generates the options, because
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
On 11/03/2017 05:41 PM, lslebodn wrote:
> On (03/11/17 16:19), mzidek-rh wrote:
> >No, I used good example. Your example is the wrong one
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
No, I used good example. Your example is the wrong one and would not trigger
the error.
What do you think will happen if in my example sc
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
About logging message to syslog. I am not against it. I wanted to solve it by
MAN + DEBUG. MAN + DEBUG + SYSLOG, looked like overkill to me, es
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
You are wrong.
It will not generate the message you wrote.
It will never show shortname in the output.
It will not generate the error if you sea
301 - 400 of 698 matches
Mail list logo
