[SSSD] Re: Client Support for Trusts

2024-02-27 Thread Sumit Bose
Am Tue, Feb 27, 2024 at 05:47:50PM +0200 schrieb Alexander Bokovoy: > On Аўт, 27 лют 2024, David L wrote: > > I'm looking for clarity about SSSD's *client-side* support for trusts. > > 1. Does SSSD support login for cross-domain (e.g., parent/child) trusts? > > 2. Does SSSD support login for

[SSSD] Re: Basic Question: C Using SASL or SPNEGO

2024-02-08 Thread Sumit Bose
Am Thu, Feb 08, 2024 at 11:08:52PM - schrieb David L: > I have a couple basic questions about using OpenLDAP with SSSD in a > C/C++ program. Since I think SSSD uses OpenLDAP to do this already > within it's service, I thought y'all would be the ones to task. > Pardon my ignorance. If you

[SSSD] Re: Optimize memberOf lookups openldap

2022-08-22 Thread Sumit Bose
Am Fri, Aug 19, 2022 at 02:02:00PM +0200 schrieb Erik de Waard: > When openldap is configured to make use of the dynlist module it can update > the member and memberOf population recursively for nested groups by just > quering with a searchfilter memberOf for it. > > This should eliminates the

[SSSD] [sssd PR#5955][opened] man: clarify ldap_idmap_range_max

2022-01-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5955 Author: sumit-bose Title: #5955: man: clarify ldap_idmap_range_max Action: opened PR body: """ ldap_idmap_range_max is the first ID which cannot be used for mapping anymore. Resolves: https://github.com/SSSD/sssd/issues/5938 &quo

[SSSD] [sssd PR#5945][-Waiting for review] INTG: Restrict smartcard in sc auth tests

2022-01-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5945][+Accepted] INTG: Restrict smartcard in sc auth tests

2022-01-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests sumit-bose commented: """ Hi, thank you. ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests sumit-bose commented: """ Hi, thanks, I'm still fine with the patches. I'd just like to ask to split out the change to `pamsrv_p11.c` into an extra patch? The change is n

[SSSD] [sssd PR#5945][+Accepted] INTG: Restrict smartcard in sc auth tests

2022-01-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests sumit-bose commented: """ Hi, thanks for the patch, it should make the Smartcard auth unit tests more resilient. ACK bye, Sumit """ See the full comment at htt

[SSSD] [sssd PR#5928][comment] IPA: Add password expire warning

2022-01-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5928 Title: #5928: IPA: Add password expire warning sumit-bose commented: """ > @sumit-bose if there is a chance you can take a look at the code of this PR > and tell me if approach with hard coded options is OK in this case? H

[SSSD] [sssd PR#5941][+Accepted] Minor updates in `IPA: get_object_from_cache()`

2022-01-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5941 Title: #5941: Minor updates in `IPA: get_object_from_cache()` Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5941][-Waiting for review] Minor updates in `IPA: get_object_from_cache()`

2022-01-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5941 Title: #5941: Minor updates in `IPA: get_object_from_cache()` Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5940][opened] ipa: fix reply socket of selinux_child

2022-01-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5940 Author: sumit-bose Title: #5940: ipa: fix reply socket of selinux_child Action: opened PR body: """ Commit c92d39a30fa0162d4efdfbe5883c8ea9911a2249 accidentally switched the reply socket of selinux_child from stdout to stderr while

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, I agree with @alexey-tikhonov, it is better to just fail hard if chain ID support is missing. bye, Sumit """

[SSSD] [sssd PR#5927][opened] ad: add required 'cn' attribute to subdomain object

2021-12-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5927 Author: sumit-bose Title: #5927: ad: add required 'cn' attribute to subdomain object Action: opened PR body: """ If the forest root is not part of the return trusted domain objects from the local domain controller we generate an obj

[SSSD] [sssd PR#5918][comment] Client ca validation error

2021-12-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5918 Title: #5918: Client ca validation error sumit-bose commented: """ Hi, I'm fine with the patches, I would only recommend to use a higher value then `2` for the exit code since e.g. the monitor is already using `2` for other purpo

[SSSD] [sssd PR#5863][+Accepted] Responder and Child process tevent chain id improvements

2021-12-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5863][-Changes requested] Responder and Child process tevent chain id improvements

2021-12-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, thanks for the patch, it is working well in my (quite basic) tests for PAM and NSS. I'm afraid I can't remember what we planne

[SSSD] [sssd PR#5918][+Changes requested] Client ca validation error

2021-12-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5918 Title: #5918: Client ca validation error Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5918][comment] Client ca validation error

2021-12-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5918 Title: #5918: Client ca validation error sumit-bose commented: """ Hi, there is a pep8 issue: ``` Start: Wed Dec 15 08:53:56 UTC 2021 + find . -path ./src/config -prune -o -name '*.py' -exec pycodestyle --ignore=E121,E123,E126,E22

[SSSD] [sssd PR#5910][+Accepted] SPEC: avoid weak dependencies

2021-12-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#5910][-Waiting for review] SPEC: avoid weak dependencies

2021-12-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5910][comment] SPEC: avoid weak dependencies

2021-12-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies sumit-bose commented: """ Hi, sure, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-992421744

[SSSD] [sssd PR#5910][comment] SPEC: avoid weak dependencies

2021-12-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies sumit-bose commented: """ > > Please see my in-line comments. > > Thank you. I updated the patch. > > But what do you think about: > > > I'm not sure what to d

[SSSD] [sssd PR#5910][comment] SPEC: avoid weak dependencies

2021-12-09 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies sumit-bose commented: """ Hi, thanks for the patch. The boolean dependencies seem to work as expected, at least on RHEL-8 where I tested them. Please see my in-line comments. bye, Sumit &q

[SSSD] [sssd PR#5902][+Accepted] SSS_CLIENT: fixed few covscan issues

2021-12-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5902 Title: #5902: SSS_CLIENT: fixed few covscan issues Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5902][comment] SSS_CLIENT: fixed few covscan issues

2021-12-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5902 Title: #5902: SSS_CLIENT: fixed few covscan issues sumit-bose commented: """ Hi, thanks, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5902#issuecomment-987616210 __

[SSSD] [sssd PR#5901][+Accepted] utils: ignore systemd and sd-pam process in get_active_uid_linux()

2021-12-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5901 Title: #5901: utils: ignore systemd and sd-pam process in get_active_uid_linux() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5901][comment] utils: ignore systemd and sd-pam process in get_active_uid_linux()

2021-12-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5901 Title: #5901: utils: ignore systemd and sd-pam process in get_active_uid_linux() sumit-bose commented: """ Hi, thanks, I'm fine with the code. Since @alexey-tikhonov approved the patch as well and it was tested internally by @sgo

[SSSD] [sssd PR#5909][opened] Various fixes related forest and site name discovery - 1-16

2021-12-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5909 Author: sumit-bose Title: #5909: Various fixes related forest and site name discovery - 1-16 Action: opened PR body: """ Resolves: https://github.com/SSSD/sssd/issues/5875 https://github.com/SSSD/sssd/issues/5822

[SSSD] [sssd PR#5883][comment] Various fixes related forest and site name discovery

2021-12-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5883 Title: #5883: Various fixes related forest and site name discovery sumit-bose commented: """ Hi, sure, I can include one of the patches in the backport. I think the issue in #5645 is related to github. I checked the copies in the

[SSSD] [sssd PR#5883][comment] Various fixes related forest and site name discovery

2021-12-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5883 Title: #5883: Various fixes related forest and site name discovery sumit-bose commented: """ > Since this claims to fix https://bugzilla.redhat.com/show_bug.cgi?id=2006866 > , this also need to be backported to 1-16 branch. &

[SSSD] [sssd PR#5863][+Accepted] Responder and Child process tevent chain id improvements

2021-11-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5863][-Waiting for review] Responder and Child process tevent chain id improvements

2021-11-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-11-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, thanks, remaining CI issues are not related, ACK. bye, Sumit """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#5881][comment] SDAP: Do not fail ASQ search when parsing a referenced entry fails

2021-11-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5881 Title: #5881: SDAP: Do not fail ASQ search when parsing a referenced entry fails sumit-bose commented: """ Hi, thanks, so the behavior is insistent, depending on the value of `ldap_deref_threshold`. I guess the reason is https://

[SSSD] [sssd PR#5881][comment] SDAP: Do not fail ASQ search when parsing a referenced entry fails

2021-11-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5881 Title: #5881: SDAP: Do not fail ASQ search when parsing a referenced entry fails sumit-bose commented: """ Hi, I think `ldap_ignore_unreadable_references` would be sufficient. Btw, what happens if the members are looked up in

[SSSD] [sssd PR#5885][+Accepted] LDAP: expire accounts when today >= shadowExpire

2021-11-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5885 Title: #5885: LDAP: expire accounts when today >= shadowExpire Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5885][comment] LDAP: expire accounts when today >= shadowExpire

2021-11-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5885 Title: #5885: LDAP: expire accounts when today >= shadowExpire sumit-bose commented: """ Hi, thank you for the patch, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-11-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, I'm sorry I didn't pull the latest version when running the tests. Since the chain_id option is now added unconditionally `test

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-11-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, I'm fine with the patches and test are working locally for me. I restarted the CI task to hopefully get some CI results as we

[SSSD] [sssd PR#5872][+Accepted] p11_child: Fixes for authentication

2021-11-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5872 Title: #5872: p11_child: Fixes for authentication Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5872][comment] p11_child: Fixes for authentication

2021-11-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5872 Title: #5872: p11_child: Fixes for authentication sumit-bose commented: """ Hi, thanks a lot for the patches. I agree with all the changes and have no further comments. I was thinking about how to add tests for the `--wait_fo

[SSSD] [sssd PR#5881][comment] SDAP: Do not fail ASQ search when parsing a referenced entry fails

2021-11-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5881 Title: #5881: SDAP: Do not fail ASQ search when parsing a referenced entry fails sumit-bose commented: """ Hi, thanks for the patch. I think an option is needed to control this behavior because SSSD does not know if the den

[SSSD] [sssd PR#5762][comment] krb5: add support for idp:oauth2 challenge

2021-11-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5762 Title: #5762: krb5: add support for idp:oauth2 challenge sumit-bose commented: """ Hi, thanks for the update, if updates my [oidc_child](https://github.com/sumit-bose/sssd/tree/oidc_child) tree accordingly and all is still working fi

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-11-08 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ > Now that the RID # is passed to the child log files, `sssctl analyze request > show #` will check these child logs and print tho

[SSSD] [sssd PR#5855][-Waiting for review] CKM_RSA_PKCS support.

2021-11-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5855 Title: #5855: CKM_RSA_PKCS support. Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#5855][+Accepted] CKM_RSA_PKCS support.

2021-11-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5855 Title: #5855: CKM_RSA_PKCS support. Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#5855][comment] CKM_RSA_PKCS support.

2021-11-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5855 Title: #5855: CKM_RSA_PKCS support. sumit-bose commented: """ Hi, thanks, ACK. Looks like the tests were not run, not sure why? """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5847][+Accepted] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-11-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5847 Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5847][comment] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-11-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5847 Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC sumit-bose commented: """ Hi, thanks for the swift reply, then I'm fine with the patch, ACK. bye, Sumit """ See the full

[SSSD] [sssd PR#5847][comment] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-11-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5847 Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC sumit-bose commented: """ Hi, thank you for the analysis and the patch. There is a slight difference between the online and the offline ca

[SSSD] [sssd PR#5855][comment] CKM_RSA_PKCS support.

2021-11-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5855 Title: #5855: CKM_RSA_PKCS support. sumit-bose commented: """ Hi, thank you for the patch. Code-wise I'm fine and my test were successful as well. While talking about test, I think it would be good to have tests as well. SoftHSM2 a

[SSSD] [sssd PR#5860][+Accepted] [monitor] Fix untranslated string

2021-11-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5860 Title: #5860: [monitor] Fix untranslated string Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5860][comment] [monitor] Fix untranslated string

2021-11-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5860 Title: #5860: [monitor] Fix untranslated string sumit-bose commented: """ Hi, thanks you for the new version, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5850][synchronized] ad: filter trusted domains

2021-11-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5850 Author: sumit-bose Title: #5850: ad: filter trusted domains Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5850/head:pr5850 git checkout pr5850 From

[SSSD] [sssd PR#5850][comment] ad: filter trusted domains

2021-10-29 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5850 Title: #5850: ad: filter trusted domains sumit-bose commented: """ > Hi @sumit-bose, > > does it apply to 1.16 branch or do we need a separate PR? Hi, yes, currently it applies cleanly to the 1.16 branch. bye, Sumit &

[SSSD] [sssd PR#5850][opened] ad: filter trusted domains

2021-10-29 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5850 Author: sumit-bose Title: #5850: ad: filter trusted domains Action: opened PR body: """ The fix for https://github.com/SSSD/sssd/issues/5528 might discover domains which are not trusted (one-way trust) or are from a different fores

[SSSD] [sssd PR#5826][-Waiting for review] DEBUG: fix missing "va_end"

2021-10-14 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5826 Title: #5826: DEBUG: fix missing "va_end" Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5826][+Accepted] DEBUG: fix missing "va_end"

2021-10-14 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5826 Title: #5826: DEBUG: fix missing "va_end" Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code

[SSSD] [sssd PR#5826][comment] DEBUG: fix missing "va_end"

2021-10-14 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5826 Title: #5826: DEBUG: fix missing "va_end" sumit-bose commented: """ Hi, thanks, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5826#issuecomment-944022983 __

[SSSD] [sssd PR#5825][comment] krb5: use hidden file when creating config snippets

2021-10-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5825 Title: #5825: krb5: use hidden file when creating config snippets sumit-bose commented: """ > There is `ding-libs/path_utils` that has relevant functions but I think it > doesn't make sense to pull it in... Hi, yes, there ar

[SSSD] [sssd PR#5825][synchronized] krb5: use hidden file when creating config snippets

2021-10-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5825 Author: sumit-bose Title: #5825: krb5: use hidden file when creating config snippets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5825/head:pr5825 git checkout pr5825

[SSSD] [sssd PR#5825][opened] krb5: use hidden file when creating config snippets

2021-10-13 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5825 Author: sumit-bose Title: #5825: krb5: use hidden file when creating config snippets Action: opened PR body: """ When creating config snippets fir libkrb5 SSSD first creates a temporary file with a random suffix and renames this

[SSSD] [sssd PR#5823][+Accepted] krb5_child: fixed incorrect checks on length value

2021-10-12 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5823 Title: #5823: krb5_child: fixed incorrect checks on length value Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5823][comment] krb5_child: fixed incorrect checks on length value

2021-10-12 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5823 Title: #5823: krb5_child: fixed incorrect checks on length value sumit-bose commented: """ Hi, thanks for spotting this, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5802][+Accepted] MONITOR: reduce logs severity around signalling

2021-10-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5802 Title: #5802: MONITOR: reduce logs severity around signalling Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5802][-Waiting for review] MONITOR: reduce logs severity around signalling

2021-10-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5802 Title: #5802: MONITOR: reduce logs severity around signalling Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5802][comment] MONITOR: reduce logs severity around signalling

2021-10-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5802 Title: #5802: MONITOR: reduce logs severity around signalling sumit-bose commented: """ Hi, thanks for the patch, I'm fine with the changes. ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5784][comment] proxy: allow removing group members

2021-10-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5784 Title: #5784: proxy: allow removing group members sumit-bose commented: """ > @sumit-bose , can it happen (is it supported) two groups in different domains > have the same GID? Hi, if the two domains are managed separately it

[SSSD] [sssd PR#5722][+Accepted] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5722 Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5722][comment] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5722 Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available sumit-bose commented: """ > Hi @sumit-bose , did you have a chance to take a look at this? Hi, thanks for the reminder. I'm fine with the p

[SSSD] [sssd PR#5771][comment] sdap: always create sdap object for a forest root

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Title: #5771: sdap: always create sdap object for a forest root sumit-bose commented: """ > There is a typo in the commit message: `:fixes: Even is the forest` -> > `:fixes: Even IF the forest` sorry, fixed in latest v

[SSSD] [sssd PR#5771][synchronized] sdap: always create sdap object for a forest root

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Author: sumit-bose Title: #5771: sdap: always create sdap object for a forest root Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5771/head:pr5771 git checkout pr5771 From

[SSSD] [sssd PR#5788][comment] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported sumit-bose commented: """ > Patches look good to me. > But strictly speaking commit message of a first patch isn't correct anymore: > backtra

[SSSD] [sssd PR#5788][synchronized] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Author: sumit-bose Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5788/head:pr5788 git

[SSSD] [sssd PR#5788][synchronized] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Author: sumit-bose Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5788/head:pr5788 git

[SSSD] [sssd PR#5771][comment] sdap: always create sdap object for a forest root

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Title: #5771: sdap: always create sdap object for a forest root sumit-bose commented: """ Hi Pavel, thanks for the review, I added a `:fixes:`. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5771][synchronized] sdap: always create sdap object for a forest root

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Author: sumit-bose Title: #5771: sdap: always create sdap object for a forest root Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5771/head:pr5771 git checkout pr5771 From

[SSSD] [sssd PR#5791][comment] sysdb: more specific mpg search filter

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5791 Title: #5791: sysdb: more specific mpg search filter sumit-bose commented: """ Hi Pavel, thanks for the review, I've fixed the typo and added a `:fixes:`. bye, Sumit """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#5791][synchronized] sysdb: more specific mpg search filter

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5791 Author: sumit-bose Title: #5791: sysdb: more specific mpg search filter Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5791/head:pr5791 git checkout pr5791 From

[SSSD] [sssd PR#5791][opened] sysdb: more specific mpg search filter

2021-09-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5791 Author: sumit-bose Title: #5791: sysdb: more specific mpg search filter Action: opened PR body: """ Originally all user of an mpg domain had an automatically created user-private group and as a result the ID space was unifi

[SSSD] [sssd PR#5788][opened] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Author: sumit-bose Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported Action: opened PR body: """ The return code ERR_GET_ACCT_DOM_NOT_SUPPORTED is an expected return code if the backend d

[SSSD] [sssd PR#5712][+Accepted] Health and Support Analyzer - Add request log parsing utility

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5712][-Waiting for review] Health and Support Analyzer - Add request log parsing utility

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi, thanks for checking the help message, as long as this is the default behavior of argparse I'm fine. I build and installed the

[SSSD] [sssd PR#5787][opened] krb5: fix ccache ownership for offline Smartcard authentication

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5787 Author: sumit-bose Title: #5787: krb5: fix ccache ownership for offline Smartcard authentication Action: opened PR body: """ During Smartcard authentication/PKINIT the krb5_child process is running as privileged user for some time to

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-09-14 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi, thanks for the updates. I think from now on every enhancement should be done not in this PR but in a new one. What I still

[SSSD] [sssd PR#5760][+Accepted] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5760][-Waiting for review] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ Hi, thanks for the update, the CI failures are not related, ACK. bye, Sumit """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ > > > As before p11_child can only wait on a single reader, in the old version > > > it was the first, now it is the l

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ Hi, my testing went well. Now wait_for_card is working with multiple empty readers again. As before p11_child can only wait on a single rea

[SSSD] [sssd PR#5771][opened] sdap: always create sdap object for a forest root

2021-09-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Author: sumit-bose Title: #5771: sdap: always create sdap object for a forest root Action: opened PR body: """ Even if the forest root is disabled for user and group lookups a sdap object is needed to lookup trusted domains. Thi

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-27 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ Hi, thank you for the update, code-wise I'm fine with the patches, I'd like to run some tests during the weekend and will give my final ACK

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) sumit-bose commented: """ Hi, thanks for the hint, I have to admit that I didn't test the patch with `wait_for_card`. @assafmo, would you like

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-08-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi Justin, thanks for the latest updates. I think the log lines from `accept_fd_handler` e.g. 2021-08-18 10:36:3

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-08-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi Scott, thanks for the latest updates. I think the log lines from `accept_fd_handler` e.g. 2021-08-18 10:36:3

  1   2   3   4   5   6   7   8   9   10   >