Re: [SSSD] [PATCH] TEST: recent_valid filter testing

There is previous commit to this ticket, so you can see what tests were removed. https://git.fedorahosted.org/cgit/sssd.git/commit/?id=bdf422fde0fd6b40b3412bad3b200f8fd7ea8693 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] cache_req: support UPN

On 09/17/2015 11:06 AM, Pavel Březina wrote: I wanted to avoid writing types for send_fn and done_fn. I'll do it if you want me to, but I think this is good enough for test. Well. # return run_cache_req(...) but it doesn't provide value. It was there originally then I realized I don't have

Re: [SSSD] [PATCH] AD: add debug messages for netlogon get info

On 09/22/2015 05:25 PM, Pavel Reichl wrote: Hello, please see trivial patch attached. Hello, it works. CI tests: http://sssd-ci.duckdns.org/logs/job/27/54/summary.html ACK Petr ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

ot sure if I added originalMemberOf version of statement above wheter it is not more like the second version of patch. If I understood the problem right, we wouldn't have saved both kind of memberOf in our DB. Regards Petr >From dea854068e6384714238ab9ec7f5c02b267227bf Mon Sep 17 00:00:00 2001 From: Petr C

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

aid that I didn't understand anything. As I wrote in previous mail; new function should not be added to old version block. It looks more clear for me now. Petr >From 7b93a7bdc2c9b3eeaef1333d1f3697b5ca0c48da Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

if (ret) { goto fail; } to make it work in my tests. bye, Sumit > >Regards >Petr >From d37e9f80b7a0fce3ca5bf89bde48ee9bc831b4c6 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed, 2 Sep 2015 11:51:12 -0400 Subject

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

ping On 09/14/2015 04:36 PM, Petr Cech wrote: On 09/11/2015 11:02 AM, Lukas Slebodnik wrote: I do not understand how is the function chown_debug_file related to journald. sssd can be compiled with journald support and in the same time can log to the files. This is a default for fedora

[SSSD]Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

Hi Lukas, thank you for review. I will send new version of tests, in one patch. And I will address your comments. However I would like to shed light on why I made the changes gradually. API consists of three functions. I wanted every patch adding just one feature of the API. First, I tested

[SSSD]Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

On 12/08/2015 11:40 AM, Lukas Slebodnik wrote: On (07/12/15 15:51), Petr Cech wrote: Hi Lukas, thank you for review. I will send new version of tests, in one patch. And I will address your comments. However I would like to shed light on why I made the changes gradually. API consists of three

[SSSD]Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

On 12/07/2015 03:04 PM, Lukas Slebodnik wrote: On (30/11/15 14:44), Petr Cech wrote: Hi, this patch set adds tests on colondb API. You can find more information in headers of patches. Regards Petr From 334a4a807750dc4a149e17bbebe26c17dae267ca Mon Sep 17 00:00:00 2001 From: Petr Cech <

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

On 12/07/2015 03:43 PM, Jakub Hrozek wrote: On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: So, I have choose the 2) option and the patch is attached. I think this patch goes in the right direction, but still needs more work. See inline. Hello Jakub, thank you for careful review

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

On 12/03/2015 05:26 PM, Jakub Hrozek wrote: On Tue, Dec 01, 2015 at 05:02:39PM +0100, Petr Cech wrote: On 11/27/2015 10:35 AM, Jakub Hrozek wrote: On Thu, Nov 19, 2015 at 05:57:56PM +0100, Petr Cech wrote: On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100

[SSSD][PATCH] KRB5_CHILD: Debug logs for PAC timeout

Hi, simple patch is attached. Regards Petr >From 1d66ce62cebd55651d1442396ef9354d174c5e4c Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed, 9 Dec 2015 08:13:59 -0500 Subject: [PATCH] KRB5_CHILD: Debug logs for PAC timeout This patch adds debug messages that in

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

On 12/11/2015 11:56 AM, Jakub Hrozek wrote: On Thu, Dec 10, 2015 at 01:39:42PM +0100, Petr Cech wrote: On 12/10/2015 11:31 AM, Jakub Hrozek wrote: On Wed, Dec 09, 2015 at 02:25:06PM +0100, Petr Cech wrote: Hi, simple patch is attached. Regards Petr I think we should put the debug message

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

On 12/11/2015 12:46 PM, Jakub Hrozek wrote: On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote: From 45754d761d6b549e4055f8af38a1229ad2689527 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed, 9 Dec 2015 08:13:59 -0500 Subject: [PATCH] KRB5_CHILD: Debug logs f

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

On 12/11/2015 03:13 PM, Lukas Slebodnik wrote: On (11/12/15 12:59), Petr Cech wrote: On 12/11/2015 12:46 PM, Jakub Hrozek wrote: On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote: From 897fd7a64770955a58c2dc7f71acdbf086477e8f Mon Sep 17 00:00:00 2001 From: Petr Cech <

[SSSD] Re: [PATCH] DEBUG: Add missing new lines

On 12/11/2015 12:47 PM, Lukas Slebodnik wrote: ehlo, I generated patch for master and 1.13 branch LS Hi Lukas, thank you for patches, both look good (to me). There are CI tests: http://sssd-ci.duckdns.org/logs/job/34/51/summary.html http://sssd-ci.duckdns.org/logs/job/34/52/summary.html 2

[SSSD] [PATCH] SDAP_ASYNC: Avoid useless debug message

to set ldap_deref_threshold = 0 it was still falling into bad case and printed I/O error. So, if we considered patch is right, there is question if advice in new message is valid for IPA 3.x. Regards Petr >From fe6690e6c950bc1140bb68f2c86c6ed79be1e909 Mon Sep 17 00:00:00 2001 From: Petr Cech

[SSSD] Re: [PATCH] tests: use unittest.TestCase.assertCountEqual if possible

On 11/23/2015 03:09 PM, Jakub Hrozek wrote: On Wed, Nov 11, 2015 at 12:26:41PM +0100, Jakub Hrozek wrote: When Python3 was used, the tests used our own compat function for checking sequences. It's better to stick to the standard-library provided methods. More details are in the commit

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

On 12/10/2015 11:31 AM, Jakub Hrozek wrote: On Wed, Dec 09, 2015 at 02:25:06PM +0100, Petr Cech wrote: Hi, simple patch is attached. Regards Petr I think we should put the debug message into sss_send_pac() after we actually succeeded in writing to the socket to avoid printing the message

[SSSD] Re: [PATCH] tests: use unittest.TestCase.assertCountEqual if possible

On 12/10/2015 01:27 PM, Lukas Slebodnik wrote: On (10/12/15 12:54), Petr Cech wrote: On 11/23/2015 03:09 PM, Jakub Hrozek wrote: On Wed, Nov 11, 2015 at 12:26:41PM +0100, Jakub Hrozek wrote: When Python3 was used, the tests used our own compat function for checking sequences. It's better

[SSSD] Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

On 12/10/2015 11:33 AM, Lukas Slebodnik wrote: On (10/12/15 11:26), Jakub Hrozek wrote: On Tue, Dec 08, 2015 at 04:57:02PM +0100, Petr Cech wrote: On 12/07/2015 03:43 PM, Jakub Hrozek wrote: On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: One style nitpick and then we can push

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

bump ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

On 12/14/2015 09:02 AM, Lukas Slebodnik wrote: On (14/12/15 08:57), Petr Cech wrote: bump I will take a look later today. I'm sorry sudo patches have higther priority. LS It's OK. Thank you. Petr ___ sssd-devel mailing list sssd-devel

[SSSD]Re: [PATCH] CONTRIB: Add clang-format support

On 12/01/2015 09:44 AM, Lukas Slebodnik wrote: On (30/11/15 14:55), Petr Cech wrote: Hi, there is little patch which adds clang-format support. More info is in header of patch. My previous patch set [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API is formatted by clang

[SSSD][PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

Hi, this patch set adds tests on colondb API. You can find more information in headers of patches. Regards Petr >From 334a4a807750dc4a149e17bbebe26c17dae267ca Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 24 Nov 2015 10:34:10 -0500 Subject: [PATCH 1/4] COL

[SSSD][PATCH] CONTRIB: Add clang-format support

00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 30 Nov 2015 08:46:35 -0500 Subject: [PATCH] CONTRIB: Add clang-format support This patch add support for clang-format. Sometimes we write new source file to codebase. It could be helpfull to use clang-format for autoformating. Or

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

On 11/27/2015 10:35 AM, Jakub Hrozek wrote: On Thu, Nov 19, 2015 at 05:57:56PM +0100, Petr Cech wrote: On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: On 11/11/2015 02:42 PM, Jakub Hrozek wrote: Hi, I think it's a good idea to only say

[SSSD][PATCH] DEBUG: Add text tag after hexadecimal debug level

Hi, there is patch resolving https://fedorahosted.org/sssd/ticket/2808 Regards Petr >From 576ca8774302e90af4bc3bdfca73d4f91cef034e Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 20 Nov 2015 10:06:56 -0500 Subject: [PATCH] DEBUG: Add text tag after hexadeci

[SSSD]Replace hexadecimal debug level code in log messages with a text tag

Hello all, I would like to work on: https://fedorahosted.org/sssd/ticket/2808 However, there are two different opinions. Ticket description says: Currently a log message of SSSD like e.g. # (Mon Jun 29 22:10:59 2015) [sssd[be[lab.runlevelone.lan]]]

[SSSD]Re: Replace hexadecimal debug level code in log messages with a text tag

On 11/23/2015 08:37 AM, Lukas Slebodnik wrote: On (23/11/15 08:32), Petr Cech wrote: On 11/23/2015 08:13 AM, Lukas Slebodnik wrote: On (23/11/15 08:03), Petr Cech wrote: On 11/20/2015 12:13 PM, Petr Cech wrote: Hello all, I would like to work on: https://fedorahosted.org/sssd/ticket/2808

[SSSD]Re: [PATCH] DEBUG: Add text tag after hexadecimal debug level

On 11/20/2015 06:28 PM, Lukas Slebodnik wrote: On (20/11/15 16:10), Petr Cech wrote: Hi, there is patch resolving https://fedorahosted.org/sssd/ticket/2808 Regards Petr From 576ca8774302e90af4bc3bdfca73d4f91cef034e Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: F

[SSSD]Re: Replace hexadecimal debug level code in log messages with a text tag

On 11/20/2015 12:13 PM, Petr Cech wrote: Hello all, I would like to work on: https://fedorahosted.org/sssd/ticket/2808 However, there are two different opinions. Ticket description says: Currently a log message of SSSD like e.g. # (Mon Jun 29 22:10:59 2015) [sssd

[SSSD]Re: Replace hexadecimal debug level code in log messages with a text tag

On 11/23/2015 08:13 AM, Lukas Slebodnik wrote: On (23/11/15 08:03), Petr Cech wrote: On 11/20/2015 12:13 PM, Petr Cech wrote: Hello all, I would like to work on: https://fedorahosted.org/sssd/ticket/2808 However, there are two different opinions. Ticket description says

[SSSD]Re: Replace hexadecimal debug level code in log messages with a text tag

On 11/23/2015 09:40 AM, Jakub Hrozek wrote: On Mon, Nov 23, 2015 at 09:28:59AM +0100, Lukas Slebodnik wrote: On (23/11/15 09:16), Jakub Hrozek wrote: On Mon, Nov 23, 2015 at 09:02:05AM +0100, Lukas Slebodnik wrote: On (23/11/15 08:56), Petr Cech wrote: On 11/23/2015 08:37 AM, Lukas

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

On 11/19/2015 05:57 PM, Petr Cech wrote: On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: >On 11/11/2015 02:42 PM, Jakub Hrozek wrote: > >Hi, I think it's a good idea to only say we don't handle services for > >IPA subdoma

[SSSD]Re: Replace hexadecimal debug level code in log messages with a text tag

On 11/24/2015 10:01 AM, Pavel Reichl wrote: On 11/24/2015 09:50 AM, Jakub Hrozek wrote: On Mon, Nov 23, 2015 at 03:00:05PM +0100, Pavel Reichl wrote: On 11/23/2015 02:53 PM, Lukas Slebodnik wrote: On (23/11/15 14:37), Pavel Reichl wrote: On 11/23/2015 10:26 AM, Lukas Slebodnik wrote:

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: >On 11/11/2015 02:42 PM, Jakub Hrozek wrote: > >Hi, I think it's a good idea to only say we don't handle services for > >IPA subdomains. But I also think it would be bet

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

bump ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] SDAP_ASYNC: Avoid useless debug message

:36 PM, Petr Cech wrote: Hi all, there is patch for https://fedorahosted.org/sssd/ticket/2791 attached. Result of patch: The message: Dec 14 14:16:11 vm-058-166 sssd[be[uma.dev]]: dereference processing failed : Input/output error is replaced by Dec 14 15:29:26 vm-058-166 sssd[be[uma.dev]]: LDAP

[SSSD] Re: [PATCH] DP: Print warning when the handler is not configured

On 01/12/2016 10:14 AM, Jakub Hrozek wrote: Hi, the attached patch fixes a bug spotted by Lukas. 0001-DP-Print-warning-when-the-handler-is-not-configured.patch From 0e2e48102aec5d7ffb15aeec23830e595bc91961 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 11 Jan

[SSSD] Re: [PATCH] RESPONDERS: Negative caching of local users

On 05/31/2016 02:42 PM, Pavel Březina wrote: On 05/30/2016 05:49 PM, Petr Cech wrote: On 05/30/2016 10:42 AM, Pavel Březina wrote: On 05/27/2016 04:32 PM, Petr Cech wrote: Hi, I have new version of this patch set. I fixed CI tests on debian [1]. My thanks belongs to Lukas and Nikolai. [1

[SSSD] Re: [PATCH] AD_PROVIDER: Fix constant char *

bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] [PATCH SET] AD_PROVIDER: ad_enabled_domains

but it happened during manual testing.) Regards -- Petr^4 Čech >From 69def6fdecd9983701909a26b4a5027b7f90ecf3 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 13 May 2016 05:21:07 -0400 Subject: [PATCH 1/5] AD_PROVIDER: Add ad_enabled_domains option Resolv

[SSSD] Re: [PATCH] RESPONDERS: Negative caching of local users

On 05/30/2016 10:42 AM, Pavel Březina wrote: On 05/27/2016 04:32 PM, Petr Cech wrote: Hi, I have new version of this patch set. I fixed CI tests on debian [1]. My thanks belongs to Lukas and Nikolai. [1] http://sssd-ci.duckdns.org/logs/job/44/04/summary.html Regards Ack to the patches

[SSSD] Re: [PATCH] RESPONDERS: Negative caching of local users

Hi, I have new version of this patch set. I fixed CI tests on debian [1]. My thanks belongs to Lukas and Nikolai. [1] http://sssd-ci.duckdns.org/logs/job/44/04/summary.html Regards -- Petr^4 Čech >From 49700263a32151a723b99b900f17583c97c69bba Mon Sep 17 00:00:00 2001 From: Petr Cech

[SSSD] Re: [PATCH] Improve handling of fds with child processes

On 05/19/2016 10:17 PM, Jakub Hrozek wrote: Hi, the attached two patches fix issues with handling of pipes towards our child processes. The first patch is more important as the leak occurs always. I don't think we need to write_fd to the renewal process at all at this point, but wanted to do a

[SSSD] Re: Add sysdb_{add,replace,delete}_string() and sysdb_{add,replace,delete}_ulong()

Hi Fabiano, thanks for patch set. The first version passed CI tests. The second version looks good to me, I will finally ack your patch set after second run of CI tests. Regards -- Petr^4 Čech ___ sssd-devel mailing list

[SSSD] Re: Add sysdb_{add,replace,delete}_string() and sysdb_{add,replace,delete}_ulong()

On 05/27/2016 07:19 AM, Petr Cech wrote: Hi Fabiano, thanks for patch set. The first version passed CI tests. The second version looks good to me, I will finally ack your patch set after second run of CI tests. Hi Fabiano, CI tests passed the second version of patch set: http://sssd

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

On 06/14/2016 05:21 PM, Petr Cech wrote: Hello list, there is patch set attached resolving: https://fedorahosted.org/sssd/ticket/2828 You can also see: https://github.com/celestian/sssd/commits/subdomains_v2 This patch set is without tests yet. I will send tests after Pavel B. refactor of AD

[SSSD] Re: [PATCH] SYSDB: Fixing DB update

On 06/22/2016 11:14 AM, Lukas Slebodnik wrote: On (20/06/16 14:44), Petr Cech wrote: >Hi, > >there is patch for #3023 attached. > >Reason for this patch is explained in commit message. > >I am open to discussion. In my opinion we don't need to connect sysdb pointer &

[SSSD] [PATCH] SYSDB: Fixing DB update

rom d0cee759147272f33427388af76ea66307e34881 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 20 Jun 2016 09:19:03 -0300 Subject: [PATCH] SYSDB: Fixing DB update Functions sysdb_user_base_dn() and sysdb_group_base_dn() expect that struct sss_domain_info contains pointer to struct

[SSSD] Re: [PATCH] KRB5: Adding DNS SRV lookup for krb5 provider

On 01/11/2016 12:35 PM, Petr Cech wrote: Hi, there is a patch for [1] attached. And there is the second version where sss_strerror() is used. Regards -- Petr^4 Cech >From f606d1f852ac7d6d16d2fb3a904bd1861e033229 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date

[SSSD] [PATCH] KRB5: Adding DNS SRV lookup for krb5 provider

Hi, there is a patch for [1] attached. Regards -- Petr^4 Cech [1] https://fedorahosted.org/sssd/ticket/2888 >From 17c3994e7f6e152e0094e63df0ec1e501e49f500 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 11 Jan 2016 06:18:33 -0500 Subject: [PATCH] KRB5: Addin

[SSSD] Re: [PATCH] KRB5: Adding DNS SRV lookup for krb5 provider

On 01/11/2016 02:03 PM, Pavel Březina wrote: On 01/11/2016 12:43 PM, Petr Cech wrote: Hi, I believe the code belongs to sssm_krb5_auth_init. Right, it is working the same way. I moved DNS SRV Lookup adding into sssm_krb5_auth_init after all other stuff. -- Petr^4 Cech >F

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

On 02/23/2016 03:28 PM, Lukas Slebodnik wrote: On (23/02/16 08:28), Petr Cech wrote: On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: [...] Hello Lukas, thank you for careful code review. I addressed all comments and I found memory leak in original colondb tool. Patch of memory leak

[SSSD] Re: [DESIGN] Invalidate cached sudo rules

On 02/24/2016 04:28 PM, Jakub Hrozek wrote: On Tue, Feb 23, 2016 at 04:08:52PM +0100, Petr Cech wrote: Hello, I've started the design page for Invalidating cached sudo rules here: https://fedorahosted.org/sssd/wiki/DesignDocs/SUDOCachingRulesInvalidate This task consists of two tickets (see

[SSSD] Re: [PATCH] IPA: Use the common if-else coding style

On 02/25/2016 10:54 AM, Pavel Březina wrote: On 02/24/2016 04:43 PM, Jakub Hrozek wrote: This is just a code-style patch, but I got confused by the two if statements, they made me think they were unrelated.. Obvious ack. ___ sssd-devel mailing list

[SSSD] [DESIGN] Invalidate cached sudo rules

Hello, I've started the design page for Invalidating cached sudo rules here: https://fedorahosted.org/sssd/wiki/DesignDocs/SUDOCachingRulesInvalidate This task consists of two tickets (see below). So far, I have worked on the first one. The second one is waiting for SSSD Status Tool. For

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

age. > >Regards >-- >Petr^4 Cech From 2bce55008b3f1a070c224bbb25191408efa42fee Mon Sep 17 00:00:00 2001 >From: Petr Cech<pc...@redhat.com> >Date: Thu, 18 Feb 2016 06:33:53 -0500 >Subject: [PATCH 1/3] COLONDB: Fix memory leak > >man 3 getline says: >ssiz

[SSSD] Re: [PATCH] SDAP_ASYNC: Avoid useless debug message

Petr won't be around for a couple of days and our downstream requested this fix..so I took over (sorry Petr..) and attached is my version of the patch. Thanks. It is the third day after visiting doctor and I feel still the same. Regards -- Petr^4 Cech

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

On 01/29/2016 02:55 PM, Lukas Slebodnik wrote: On (29/01/16 14:15), Lukas Slebodnik wrote: On (06/01/16 13:47), Petr Cech wrote: //snip Lukas, thanks for careful review. There are fixed patches attached. I hope that I check memory leaks in proper way. I am little confused if we need "s

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

On 02/18/2016 01:34 PM, Petr Cech wrote: On 01/29/2016 02:55 PM, Lukas Slebodnik wrote: On (29/01/16 14:15), Lukas Slebodnik wrote: On (06/01/16 13:47), Petr Cech wrote: //snip Lukas, thanks for careful review. There are fixed patches attached. I hope that I check memory leaks in proper way

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I will address some suggestions tomorrow. I am doing tests for sysdb_sudo_rules now. Thanks

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/10/2016 02:36 PM, Pavel Březina wrote: On 03/09/2016 05:49 PM, Petr Cech wrote: On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 04/12/2016 04:24 PM, Petr Cech wrote: On 04/12/2016 01:27 PM, Pavel Březina wrote: On 04/06/2016 04:55 PM, Petr Cech wrote: On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak

[SSSD] Re: [PATCH] REFACTOR: global_talloc_context push/pop remove

On 04/11/2016 08:51 AM, Lukas Slebodnik wrote: On (11/04/16 06:34), Petr Cech wrote: Hello list, push/pop global_talloc_context into check_leaks is redudant. It is done in leak_check_setup() and leak_check_teardown() functions in src/tests/check_leaks. Thanks Pavel Brezina, that showed me

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 04/12/2016 01:27 PM, Pavel Březina wrote: On 04/06/2016 04:55 PM, Petr Cech wrote: On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak and they really test :-) It is possible

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak and they really test :-) It is possible to use compact form of them, maybe more help functions... But I hope that main idea

[SSSD] [PATCH] REFACTOR: global_talloc_context push/pop remove

rom b090aa80e23b33e8f9710412e9453dbcdb6811c5 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 11 Apr 2016 00:26:19 -0400 Subject: [PATCH] REFACTOR: global_talloc_context push/pop remove Push/pop global_talloc_context into check_leaks is redudant. It is done in leak_check_setup() and leak_check

[SSSD] NSS responder should negatively cache local users for a longer time

Hi, I will work on $subject [1] and I have discussed this topic with Jakub a week ago. There are some open questions, so I will be glad if you say your opinion. There could be heavy traffic between SSSD client and server coused by local users. We need longer timeout in negative cache for

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/16/2016 12:37 PM, Pavel Březina wrote: [...] *Patch 2: SYSDB: Add new funtions into sysdb_sudo* +errno_t +sysdb_set_sudo_rule_attr(struct sss_domain_info *domain, + const char *name, + struct sysdb_attrs *attrs, +

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/16/2016 12:37 PM, Pavel Březina wrote: On 03/15/2016 04:40 PM, Petr Cech wrote: On 03/10/2016 02:36 PM, Pavel Březina wrote: [...] There is whole patch set attached. I worked on tests (003 patch) last couple days. I know that there are some test cases missing. My big challenge

[SSSD] Re: Design document - sssctl

On 03/22/2016 12:42 PM, Pavel Reichl wrote: Hello, Pavel Březina and I have prepared the 1st draft of design document. We mostly focused on summing up its future functionality and its interface. Please comment if you miss some essential functionality or if you would prefer some different

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 03:57 PM, Petr Cech wrote: On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: ret = sysdb_search_entry(mem_ctx, domain->sysdb, dn, LDB_SCOPE_SUBTREE, filter, at

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

, Petr Cech wrote: 0001-SYSDB-Add-new-funtions-into-sysdb_sudo.patch ... + +errno_t sysdb_search_sudo_rules(TALLOC_CTX *mem_ctx, +struct sss_domain_info *domain, +const char *sub_filter, +const char

[SSSD] [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

rom 46f42e8e342b9da0a7a61e897eb0e7c119b1f452 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed, 24 Feb 2016 09:12:41 -0500 Subject: [PATCH 1/2] SYSDB: Add new funtions into sysdb_sudo This patch adds two new functions into public API of sysdb_sudo: * sysdb_search_s

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

rom 1657efe255b2bcebfebae9f67d1575d8ad6d2ef1 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 25 Feb 2016 03:28:13 -0500 Subject: [PATCH] TESTS: WIP Test of sysdb_search_sudo_rules This is test of new function sysdb_search_sudo_rules. At the moment, it is not working, there is me

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 01:11 PM, Pavel Březina wrote: Hi, see comments inline. errno_t sysdb_search_sudo_rules(TALLOC_CTX *mem_ctx, struct sss_domain_info *domain, const char *sub_filter, const char **attrs,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/03/2016 02:15 PM, Pavel Březina wrote: On 03/03/2016 02:00 PM, Petr Cech wrote: Hi, I found an interesting thing. I wonder if this is a bug or not. I tried to write a test for sysdb_sudo_store() function: # src/db/sysdb_sudo.h errno_t sysdb_sudo_store (struct * sss_domain_info domain

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

On 03/02/2016 01:10 PM, Lukas Slebodnik wrote: On (02/03/16 13:02), Pavel Reichl wrote: On 03/02/2016 12:53 PM, Lukas Slebodnik wrote: On (02/03/16 12:48), Pavel Březina wrote: On 03/01/2016 03:54 PM, Pavel Reichl wrote: I added one more similar patch. sss_idmap_calculate_range can accept

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/21/2016 03:39 PM, Petr Cech wrote: On 03/16/2016 12:37 PM, Pavel Březina wrote: On 03/15/2016 04:40 PM, Petr Cech wrote: On 03/10/2016 02:36 PM, Pavel Březina wrote: [...] There is whole patch set attached. I worked on tests (003 patch) last couple days. I know that there are some

[SSSD] Re: NSS responder should negatively cache local users for a longer time

On 03/22/2016 08:58 PM, Jakub Hrozek wrote: >On 22 Mar 2016, at 20:35, Simo Sorce<s...@redhat.com> wrote: > >On Sun, 2016-03-20 at 21:28 +0100, Jakub Hrozek wrote: >>>On 16 Mar 2016, at 13:45, Petr Cech<pc...@redhat.com> wrote: >>> >>>H

[SSSD] [PATCH SET] Make the negcache timeout part of nc_ctx

/2317 [2] https://www.mail-archive.com/sssd-devel@lists.fedorahosted.org/msg26506.html Regards -- Petr^4 Čech >From cbb73503b07ef3776a72f90c6f4e2a34c9a3323a Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 22 Apr 2016 04:27:47 -0400 Subject: [PATCH 1/8] NEGCACH

[SSSD] Re: [PATCH] DEBUG: Add `debug` alias for debug_level

On 04/26/2016 05:08 PM, Stephen Gallagher wrote: Our users constantly make the mistake of typing `debug = 9` in the sssd.conf instead of `debug_level = 9` as would be correct. This happens frequently-enough that we should just alias it rather than continue to have people make mistakes.

[SSSD] Re: [PATCH] DEBUG: Add `debug` alias for debug_level

On 04/27/2016 08:47 AM, Petr Cech wrote: On 04/26/2016 05:08 PM, Stephen Gallagher wrote: Our users constantly make the mistake of typing `debug = 9` in the sssd.conf instead of `debug_level = 9` as would be correct. This happens frequently-enough that we should just alias it rather than

[SSSD] [PATCH] RESPONDERS: Fix talloc context for negative cache

Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 26 Apr 2016 03:16:27 -0400 Subject: [PATCH] RESPONDERS: Fix talloc context for negative cache This patch fixes hierarchy of talloc contexts used for initializing negative cache in responders. Resolves: https://fedorahosted

[SSSD] Re: [PATCH] Make sdap_process_group_send() static

On 05/09/2016 09:54 AM, Jakub Hrozek wrote: Hi, a trivial code-hygiene patch is attached. 0001-Make-sdap_process_group_send-static.patch From ac33446aaa78b65c6891f486e9ad462101f88a79 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Tue, 8 Dec 2015 21:10:27 +0100

[SSSD] Re: [PATCH] Make sdap_process_group_send() static

On 05/09/2016 10:01 AM, Petr Cech wrote: On 05/09/2016 09:54 AM, Jakub Hrozek wrote: Hi, a trivial code-hygiene patch is attached. 0001-Make-sdap_process_group_send-static.patch From ac33446aaa78b65c6891f486e9ad462101f88a79 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.

[SSSD] Re: [PATCH] RESPONDERS: Negative caching of local users

On 05/05/2016 05:34 PM, Petr Cech wrote: Hello, this patch resolves [1]. This adds new behaviour of negative caching of locals, so it needs new tests. I will send patch with tests soon, but not today. It is applicable after RESPONDERS: Negcache in resp_ctx [2]. For clarity, there is branch

[SSSD] Re: [PATCH] RESPONDERS: Negative caching of local users

On 05/09/2016 01:15 PM, Petr Cech wrote: On 05/05/2016 05:34 PM, Petr Cech wrote: Hello, this patch resolves [1]. This adds new behaviour of negative caching of locals, so it needs new tests. I will send patch with tests soon, but not today. It is applicable after RESPONDERS: Negcache

[SSSD] [PATCH] AD_PROVIDER: Fix constant char *

Hello, there is simple patch attached. Please, look at commit message. Regards -- Petr^4 Čech >From 67098909520eec35e9f4577813cfe12e4f6c3634 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 12 May 2016 03:04:03 -0400 Subject: [PATCH] AD_PROVIDER: Fix cons

[SSSD] [PATCH] TEST: Removing duplication of mock_rctx

Hello, I noticed a small discrepancy, so I fixed it. There was duplication of mock function in our tests. Simple patch is attached. Regards -- Petr^4 Čech >From 1d678d30330d326c75b6b6ac5fe0d8b652804e0e Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed, 4 May 2016

[SSSD] Re: [PATCH] RESPONDERS: Fix talloc context for negative cache

On 04/28/2016 01:41 PM, Pavel Březina wrote: On 04/26/2016 09:38 AM, Petr Cech wrote: Hi list, this simple patch fixes talloc hierarchy in initializing negative caches in responders. This patch is applicable after [1]. [1] https://www.mail-archive.com/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH SET] Make the negcache timeout part of nc_ctx

On 04/28/2016 01:39 PM, Pavel Březina wrote: On 04/22/2016 03:31 PM, Petr Cech wrote: Hi, attached patch set resolves ticket [1]. It is a refactor of negative cache. I prepared patch set step by step, so reviewer can do review simpler. If you prefer two bigger patches please write me. Notice

[SSSD] Re: [PATCH] TEST: Removing duplication of mock_rctx

On 05/05/2016 10:39 AM, Lukas Slebodnik wrote: Resolves: https://fedorahosted.org/sssd/ticket/2928 It isn't related to this ticket :-) and it does not solve it. I will remove it before pushing the patch CI passed http://sssd-ci.duckdns.org/logs/job/42/85/summary.html ACK LS Hi Lukas,

[SSSD] Re: [PATCH] RESPONDERS: Fix talloc context for negative cache

On 05/02/2016 08:53 AM, Petr Cech wrote: On 04/28/2016 01:41 PM, Pavel Březina wrote: On 04/26/2016 09:38 AM, Petr Cech wrote: Hi list, this simple patch fixes talloc hierarchy in initializing negative caches in responders. This patch is applicable after [1]. [1] https://www.mail

[SSSD] [PATCH 1/6] RESPONDERS: Negcache in resp_ctx

-- Petr^4 Čech >From b71de52198cede4a91744378e9254a8c9b3667ca Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 2 May 2016 09:55:47 -0400 Subject: [PATCH 1/6] RESPONDERS: Negcache in resp_ctx preparing Preparation for initialization of negative cache in common

<    1   2   3   4   >