[SSSD] [sssd PR#127][synchronized] ssh: use cache_req

2017-02-01 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Author: pbrezina Title: #127: ssh: use cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/127/head:pr127 git checkout pr127 From

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-01 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req pbrezina commented: """ It should be fixed. Thanks. """ See the full comment at https://github.com/SSSD/sssd/pull/127#issuecomment-276646417 _

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req pbrezina commented: """ Try now. """ See the full comment at https://github.com/SSSD/sssd/pull/127#issuecomment-277965152 ___ sssd-de

[SSSD] [sssd PR#147][comment] IFP: Update ifp_iface_generated.c

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c pbrezina commented: """ Ack to the patch. """ See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277976661 _

[SSSD] [sssd PR#147][comment] IFP: Update ifp_iface_generated.c

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c pbrezina commented: """ Interesting, we must have some bug in sbus codegen since it doesn't get removed in my tree. I remember a ticket when sbus_codegen seemed to be randomly generated

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case pbrezina commented: """ I don't remember the code now, but does this still obey case sensitivity setting? &q

[SSSD] [sssd PR#147][comment] IFP: Update ifp_iface_generated.c

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c pbrezina commented: """ Please figure out why sbus codegen didn't remove this code instead of removing it manually. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty pbrezina commented: """ @fidencio go with these patches, that is why I created a new ticket for dummy provider @lslebodn with files provider I

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty pbrezina commented: """ In general, I think we should finally create a dummy local provider so we can avoid special casing it all the

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups pbrezina commented: """ Ack from me. Can someone else do review as well since I was helping Fabiano with those patches? """ See the full comment at https:/

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service pbrezina commented: """ Please, stick with sbus code and do not use sdbus. We are at a point where we have internal higher level api to create send and parse dbus messa

[SSSD] [sssd PR#147][comment] IFP: Update ifp_iface_generated.c

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c pbrezina commented: """ When I explicitly touch ifp_iface.xml it gets regenerated correctly... but why wasn't it back at the time? """ See the full comment at https:/

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty pbrezina commented: """ Who knows which version will have local provider removed. Push these patches for now. """

[SSSD] [sssd PR#150][opened] ssh: go to dp first when looking up host

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/150 Author: pbrezina Title: #150: ssh: go to dp first when looking up host Action: opened PR body: """ There were three downstream test failures caused by not updating known_host files properly. Original code went to data provider prior

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case pbrezina commented: """ I wonder if we should warn admin about duplicit value in ldap. But ack to this patch. &q

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty pbrezina commented: """ I mean after changes requested in review are done. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty pbrezina commented: """ Sorry, I didn't push submit button. Darn github. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req pbrezina commented: """ > The code looks good to me now but I found one regression - if you set > default_domain_suffix to the AD domain and try to look up a host, the ssh > responder will qu

[SSSD] [sssd PR#129][comment] Fix for 3283

2017-01-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/129 Title: #129: Fix for 3283 pbrezina commented: """ This is question for @sumit-bose , obviously the filter can now return either user or group. Ack to the patch otherwise. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders pbrezina commented: """ > > if (conn->last_request_time != NULL) { > > time_t *last_request_time = conn->last_request_time; > > >

[SSSD] [sssd PR#130][+Accepted] Fix for 3284

2017-01-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/130 Title: #130: Fix for 3284 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ Yes. Inconsistent sounds good. """ See the full comment at https://github.com/SSSD/sssd/pull/106#issuecomment-275063633 __

[SSSD] [sssd PR#133][synchronized] sbus: use sss_ptr_hash for hash tables

2017-01-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/133/head:pr133 git checkout pr133 From

[SSSD] [sssd PR#133][synchronized] sbus: use sss_ptr_hash for hash tables

2017-01-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/133/head:pr133 git checkout pr133 From

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables pbrezina commented: """ Ok, pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275369657 _

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables pbrezina commented: """ What would you like to see in the commit message? Description of `sss_ptr_hash`? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#134][opened] dp_request_table: remove unused #includes

2017-01-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/134 Author: pbrezina Title: #134: dp_request_table: remove unused #includes Action: opened PR body: """ Trivial patch attached. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch

[SSSD] [sssd PR#160][comment] Fix files provider reallocation logic

2017-02-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/160 Title: #160: Fix files provider reallocation logic pbrezina commented: """ `talloc_realloc` takes number of elements not the total size so ack. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#161][comment] pam_sss: check conversation callback

2017-02-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/161#issuecomment-281643799 ___ s

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-02-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available pbrezina commented: """ Will this fix https://bugzilla.redhat.com/show_bug.cgi?id=1329598 ? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#154][comment] Confront caches first

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/154 Title: #154: Confront caches first pbrezina commented: """ Hi, thank you for the patch. ```c @@ -469,6 +476,8 @@ static void cache_req_input_parsed(struct tevent_req *subreq) return; } +cache_req_setup_search

[SSSD] [sssd PR#155][+Accepted] MONITOR: Don't return an error in case we fail to register a service

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#155][comment] MONITOR: Don't return an error in case we fail to register a service

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service pbrezina commented: """ In case of an error you want to free `mini` context. Ack. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups pbrezina commented: """ Try to describe how PAM responder works with cache and where it differes with other responders in few words. If you have time, do it now before ne

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-24 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations pbrezina commented: """ Typo in last commit message: ``` This functionality is only enabled in case SSSD is configured with with < ``` Otherwise ack. I just wonder

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface pbrezina commented: """ Ack from my side. We can push these patches. I will modify the integration to some extend for `secrets` needs. """

[SSSD] [sssd PR#162][comment] cache_req: use own namespace for UPNs

2017-02-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs pbrezina commented: """ Hi Sumit, I'm afraid that `cache_req` tests fail now. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ > I hope this wouldn't be an issue because the inotify code doesn't call the > callbacks immediately but with a tevent timer (by default immediate tevent &

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface pbrezina commented: """ Thank you. So far I'm reading `secrets` code trying to figure out my needs to comment on `curl` implementation. Here are some comment

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-02-09 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service pbrezina commented: """ My opinion is do not use sync code when use can use async. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-15 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ Ack, thank you. Good job :-) """ See the full comment at https://github.com/SSSD/sssd/pull/106#issuecomment-279976416 __

[SSSD] [sssd PR#133][opened] sbus: use sss_ptr_hash for hash tables

2017-01-24 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: opened PR body: """ This patch reuses `sss_ptr_hash` module introduced in NSS patches in `sbus` code. """ To pull the PR as Git branc

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ Hi, those changes looks good. I have just one comment -- what happens if both groups and passwd are being updated? I see that both will trigger files_account_in

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-17 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface pbrezina commented: """ Hi, I prepared few trivial commits for you to squash if you agree: https://github.com/pbrezina/sssd/commits/curl I tried to push it to you

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-19 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders pbrezina commented: """ ```c if (conn->last_request_time != NULL) { time_t *last_request_time = conn->last_request_time; *last_req

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ @lslebodn Asked me to address my comments in separate patches. I wrote patches for most of the above expect changing the `sf_` prefix and removing logic tha

[SSSD] [sssd PR#121][comment] AUTOFS: Check return of sss_cmd_empty_packet()

2017-01-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/121 Title: #121: AUTOFS: Check return of sss_cmd_empty_packet() pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/121#issuecomment-274058709 _

[SSSD] [sssd PR#121][+Accepted] AUTOFS: Check return of sss_cmd_empty_packet()

2017-01-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/121 Title: #121: AUTOFS: Check return of sss_cmd_empty_packet() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-27 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282709063

[SSSD] [sssd PR#162][+Accepted] cache_req: use own namespace for UPNs

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#159][+Accepted] pam: use authtok from PAM stack if available

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/159#issuecomment-283621166 _

[SSSD] [sssd PR#162][comment] cache_req: use own namespace for UPNs

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/162#issuecomment-283618437 ___ s

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread pbrezina
pbrezina commented on a pull request """ On 09/06/2016 02:21 PM, Jakub Hrozek wrote: > On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > > Thanks for the ack, I would also like to ask @sumit-bose

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread pbrezina
pbrezina commented on a pull request """ On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > Thanks for the ack, I would also like to ask @sumit-bose > <https://github.com/sumit-bose> if he agrees with the change. Btw since clock skew is not fatal anymore, is it possible

[SSSD] [sssd PR#12] failover: proceed normally when no new server is found (opened)

2016-09-02 Thread pbrezina
pbrezina's pull request #12: "failover: proceed normally when no new server is found" was opened PR body: """ https://fedorahosted.org/sssd/ticket/3131 I couldn't reproduce manually so I used the second patch as a by-code reproducer. If you apply the patch then sssd will try to resolve meta

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (+ack)

2016-08-31 Thread pbrezina
jhrozek's pull request #8: "MAN: Document the ldap_user_gid_number option" label *ack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/8 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (comment)

2016-08-30 Thread pbrezina
pbrezina commented on a pull request """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5#issuecomment-243402484 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahos

[SSSD] [sssd PR#20] sss_override fails to export (+Pushed)

2016-09-14 Thread pbrezina
mzidek-rh's pull request #20: "sss_override fails to export" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/20 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#20] sss_override fails to export (-Changes requested)

2016-09-14 Thread pbrezina
mzidek-rh's pull request #20: "sss_override fails to export" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/20 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#24][+Accepted] MAN: Add a manpage for the sssd-secrets responder

2016-09-16 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#21] IFP: expose user and group unique IDs through DBus (+Accepted)

2016-09-09 Thread pbrezina
tequeter's pull request #21: "IFP: expose user and group unique IDs through DBus" label *Accepted* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/21 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#21] IFP: expose user and group unique IDs through DBus (comment)

2016-09-09 Thread pbrezina
pbrezina commented on a pull request """ Hi, thank you for the patch. It looks good and works fine. What do you plan to use it for? """ See the full comment at https://github.com/SSSD/sssd/pull/21#issuecomment-245878446 _

[SSSD] [sssd PR#20] sss_override fails to export (+Accepted)

2016-09-09 Thread pbrezina
mzidek-rh's pull request #20: "sss_override fails to export" label *Accepted* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/20 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-09-30 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins pbrezina commented: """ On 09/30/2016 09:21 AM, Jakub Hrozek wrote: > I'm fine with the approach but I didn't read the code line-by-line. > > We should make sure the code cove

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API pbrezina commented: """ Updated version was pushed. I initialized D-Bus variables in sssctl_systmed_call: ```c static errno_t sssctl_systemd_call(const char *method) { DBusConnecti

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API pbrezina commented: """ Updated version was pushed. I initialized D-Bus variables in sssctl_systmed_call: static errno_t sssctl_systemd_call(const char *method) { DBusConnecti

[SSSD] [sssd PR#30][synchronized] sssctl: use systemd D-Bus API

2016-10-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Author: pbrezina Title: #30: sssctl: use systemd D-Bus API Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/30/head:pr30 git checkout pr30 From

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API pbrezina commented: """ Updated version was pushed. I initialized D-Bus variables in sssctl_systmed_call: ```c static errno_t sssctl_systemd_call(const char *method) { DBusConnecti

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API pbrezina commented: """ Updated version was pushed. I initialized D-Bus variables in `sssctl_systemd_call()`: ```c static errno_t sssctl_systemd_call(const char *method) { DBusConnecti

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-06 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains pbrezina commented: """ The patch that should fix this is: 61913b8f0d1ba54d82640500d7486fac5f72b030 Unfortunately it is written on top of cache_req refactoring in sudo r

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-06 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains pbrezina commented: """ On 10/06/2016 01:42 PM, Jakub Hrozek wrote: > On Thu, Oct 06, 2016 at 03:51:05AM -0700, Pavel Březina wrote: >> T

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains pbrezina commented: """ Not, it is not a bug. The output parameter _name contains a name from the request modified according to rules of the selected domain. I.e. the name

[SSSD] [sssd PR#30][opened] sssctl: use systemd D-Bus API

2016-09-21 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Author: pbrezina Title: #30: sssctl: use systemd D-Bus API Action: opened PR body: """ If systemd is used we leverage it's D-Bus API instead of running systemctl. Resolves: https://fedorahosted.org/sssd/ticket/3056 """

[SSSD] [sssd PR#21][comment] IFP: expose user and group unique IDs through DBus

2016-09-21 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/21 Title: #21: IFP: expose user and group unique IDs through DBus pbrezina commented: """ On 09/21/2016 12:29 PM, Jakub Hrozek wrote: > On Tue, Sep 20, 2016 at 05:24:45AM -0700, sumit-bose wrote: >> > With the SIDs we already

[SSSD] [sssd PR#30][synchronized] sssctl: use systemd D-Bus API

2016-09-21 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Author: pbrezina Title: #30: sssctl: use systemd D-Bus API Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/30/head:pr30 git checkout pr30 From

[SSSD] [sssd PR#29][-Changes requested] tests: Add a regression test for upstream ticket #3131

2016-09-21 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/29 Title: #29: tests: Add a regression test for upstream ticket #3131 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#29][+Changes requested] tests: Add a regression test for upstream ticket #3131

2016-09-21 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/29 Title: #29: tests: Add a regression test for upstream ticket #3131 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#29][comment] tests: Add a regression test for upstream ticket #3131

2016-09-21 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/29 Title: #29: tests: Add a regression test for upstream ticket #3131 pbrezina commented: """ On 09/21/2016 11:02 AM, Jakub Hrozek wrote: > Assigned #29 <https://github.com/SSSD/sssd/pull/29> to @pbrezina > <https://git

[SSSD] [sssd PR#21][comment] IFP: expose user and group unique IDs through DBus

2016-09-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/21 Title: #21: IFP: expose user and group unique IDs through DBus pbrezina commented: """ On 09/19/2016 02:26 PM, tequeter wrote: > Yes, I considered creating a |group_attributes| instead. However it > would have taken more refactoring

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-09-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API pbrezina commented: """ I added debug messages and attached a new patch for /sbin/service. I wonder if we should detect the path with configure? """ See the full comment at htt

[SSSD] [sssd PR#30][synchronized] sssctl: use systemd D-Bus API

2016-09-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Author: pbrezina Title: #30: sssctl: use systemd D-Bus API Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/30/head:pr30 git checkout pr30 From

[SSSD] [sssd PR#34][opened] cache_req: move from switch to plugins

2016-09-27 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/34 Author: pbrezina Title: #34: cache_req: move from switch to plugins Action: opened PR body: """ cache_req grown quite big from the original code and it turned out that using switch statements to branch code for different cases makes

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins pbrezina commented: """ I finished the code and split it into four commits: 1. Implements logic ... it is the same as in responder_cache_req.c but with added support for plugins. 2. Imp

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-10-27 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) pbrezina commented: """ The patch looks good to me. I'd feel better if we somehow managed to backport patch that solves the fully qualified issue in 1.14 though. I'

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) pbrezina commented: """ Ok, I'm fine with this patch due to the indexing issue. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) pbrezina commented: """ So what is the current plan here? """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.14)

2016-10-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.14) pbrezina commented: """ I didn't do a thorough review but we also need to search with lover case values in responder so also names like "admiNISTRATOR" will

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.14)

2016-10-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.14) pbrezina commented: """ I didn't do a thorough review but we also need to search with lover case values in responder so also names like "admiNISTRATOR" will

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.14)

2016-10-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.14) pbrezina commented: """ User that is stored in AD as teST can have multiple login names since case sensitivity is ignored. It can login as test, but also as t

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-17 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins pbrezina commented: """ Updated patch pushed. Diff: ```c diff --git a/src/responder/common/cache_req/cache_req_search.c b/src/responder/common/cache_req/cache_req_search.c index 3

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.14)

2016-10-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.14) pbrezina commented: """ I see why it works now, what I originally meant was to create a whole new attribute, say sudoUserAlias that would contain lowercased values

[SSSD] [sssd PR#89][-Changes requested] nss: rewrite nss responder so it uses cache_req

2016-11-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-11-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Hi, thank you. I fixed those issues. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys

2016-11-28 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys pbrezina commented: """ On 11/24/2016 06:10 PM, Jakub Hrozek wrote: > > > >

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-11-28 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders pbrezina commented: """ Ok, I read those commits and I so far have none code issues. Haven't tried it yet. """ See the full comment at https://github.com/

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-11-29 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders pbrezina commented: """ One thing I don't like about those patches is that we always recreate the idle timer. Can we get around this (maybe also for the client idle timeout)?

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API pbrezina commented: """ No problem. Feel free to push it. """ See the full comment at https://github.com/SSSD/sssd/pull/30#issuecomment-252873755

  1   2   3   4   5   6   7   8   9   10   >