Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-07 Thread Thiago Macieira
On Monday 06 July 2015 22:03:52 Dirk Hohndel wrote: I tried testing on Ubuntu, also in a VM on the same Mac. But I can't seem to figure out which package to install to get the QtBluetooth stuff. Any suggestion on the right package names? This needs to be added to the INSTALL file, too... It

Re: [PATCH] Clean double free in copy_dive_site()

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 07:35:26PM +0200, Salvador Cuñat wrote: This makes subsurface crash by simply clicking a dive in the list. I didn't get that crash (which is surprising, looking at the code), but you are right, good catch. The pointer is freed in the free_taxonomy() call already. /D

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 05:20:22PM +0200, Joakim Bygdell wrote: Didn't manage to quote the patch for some reason... anyway, any chance we could have the disclaimer message once and use a parameter to insert the algorithm? That way the translators only need to do it once as well. It's a

[PATCH] Clean double free in copy_dive_site()

2015-07-07 Thread Salvador Cuñat
This makes subsurface crash by simply clicking a dive in the list. Signed-off-by: Salvador Cuñat salvador.cu...@gmail.com --- divesite.c | 1 - 1 file changed, 1 deletion(-) diff --git a/divesite.c b/divesite.c index 5abab76..5c96bb2 100644 --- a/divesite.c +++ b/divesite.c @@ -171,7 +171,6 @@

Re: [PATCH] Fix tab stop order in planner

2015-07-07 Thread Dirk Hohndel
Jocke get's today's award for most responsive contributor... (and he catapulted himself into the list of the top dozen contributors to Subsurface 4.5) /D On Tue, Jul 07, 2015 at 09:12:33PM +0200, Joakim Bygdell wrote: On 07 Jul 2015, at 20:55, Dirk Hohndel d...@hohndel.org wrote: I do

[PATCH] Fix tab stop order in planner

2015-07-07 Thread Joakim Bygdell
On 07 Jul 2015, at 20:55, Dirk Hohndel d...@hohndel.org wrote:I do notice that the tab order on that screen is completely psychodelic -not necessarily caused by you, but something that will need to beaddressed at some point :)/D 0001-Planner-fix-tab-stop-order.patch Description: Binary data

Re: [PATCH] Clean double free in copy_dive_site()

2015-07-07 Thread Salvador Cuñat
2015-07-07 19:39 GMT+02:00 Dirk Hohndel d...@hohndel.org: On Tue, Jul 07, 2015 at 07:35:26PM +0200, Salvador Cuñat wrote: This makes subsurface crash by simply clicking a dive in the list. I didn't get that crash (which is surprising, looking at the code), I think the free_taxonomy() call

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Joakim Bygdell
On 07 Jul 2015, at 18:12, Dirk Hohndel d...@hohndel.org wrote: 0002, rearranged the GUI to make it visibly easier to see which settings that belong together. 0003, disables GF fields when VPM-B is the selected deco model. Those both seem like great additions. Thank you. What I'm

Re: [PATCH] Fix tab stop order in planner

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 12:28:00PM -0700, Dirk Hohndel wrote: Jocke get's today's award for most responsive contributor... And I get today's award for lack of English grammar :-) :facepalm: /D ___ subsurface mailing list

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 08:32:38PM +0200, Joakim Bygdell wrote: On 07 Jul 2015, at 18:12, Dirk Hohndel d...@hohndel.org wrote: 0002, rearranged the GUI to make it visibly easier to see which settings that belong together. 0003, disables GF fields when VPM-B is the selected deco

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-07 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 10:17:12PM -0700, Dirk Hohndel wrote: My guess is that this is because I'm in a VM. Once I figure out the Ubuntu situation I'll use a different computer that is running Ubuntu directly. I don't consider being able to run inside a VM critical... And I was able to verify

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Rick Walsh
Hi, On 8 July 2015 at 02:12, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 07, 2015 at 05:20:22PM +0200, Joakim Bygdell wrote: Didn't manage to quote the patch for some reason... anyway, any chance we could have the disclaimer message once and use a parameter to insert the

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Dirk Hohndel
Hi Jocke, On Tue, Jul 07, 2015 at 04:41:55PM +0200, Joakim Bygdell wrote: 0001, updates the disclaimer to reflect the deco model that where used to generate the plan. Didn't manage to quote the patch for some reason... anyway, any chance we could have the disclaimer message once and use a

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Joakim Bygdell
On 07 Jul 2015, at 17:10, Dirk Hohndel d...@hohndel.org wrote: Hi Jocke, On Tue, Jul 07, 2015 at 04:41:55PM +0200, Joakim Bygdell wrote: 0001, updates the disclaimer to reflect the deco model that where used to generate the plan. Didn't manage to quote the patch for some reason...

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-07 Thread Miika Turkia
On Tue, Jul 7, 2015 at 9:02 AM, Thiago Macieira thi...@macieira.org wrote: On Monday 06 July 2015 22:03:52 Dirk Hohndel wrote: I tried testing on Ubuntu, also in a VM on the same Mac. But I can't seem to figure out which package to install to get the QtBluetooth stuff. Any suggestion on the

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-07 Thread Rick Walsh
Dirk, Jan, On 5 July 2015 at 23:56, Dirk Hohndel d...@hohndel.org wrote: On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: Hi, Here is another pull request. I hope now it's better. Everything was reorganized from scratch, the final code is almost the same. I like the patches

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 01:49:08PM +0300, Miika Turkia wrote: On Tue, Jul 7, 2015 at 9:02 AM, Thiago Macieira thi...@macieira.org wrote: On Monday 06 July 2015 22:03:52 Dirk Hohndel wrote: I tried testing on Ubuntu, also in a VM on the same Mac. But I can't seem to figure out which package

BT support on Mac

2015-07-07 Thread Dirk Hohndel
Just another data point... it appears on the Mac the test if (!localDevice-isValid()) { fails - even though BT is enable and the dive computer is paired with the Mac. I'm not quite sure how to debug this further... Thanks /D ___ subsurface

Re: [PATCH] update disclaimer.

2015-07-07 Thread Joakim Bygdell
On 07 Jul 2015, at 22:51, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 07, 2015 at 10:18:41PM +0200, Joakim Bygdell wrote: Now the way it should have been the first time. Umm, I was just about to thank you and then I saw this... } else { AHH - my

Re: Linking error with recent libdc

2015-07-07 Thread Gaetan Bisson
[2015-07-07 21:45:49 -0700] Dirk Hohndel: On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: Linking CXX executable subsurface libsubsurface_corelib.a(libdivecomputer.c.o): In function `do_libdivecomputer_import': /build/subsurface-git/src/subsurface/libdivecomputer.c:932:

Re: Linking error with recent libdc

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: Hi, I'm getting errors when compiling a recent subsurface (git snapshot fe8605e) against a recent subsurface-libdc (git snapshot c164cfb, Subsutface-testing banch). Basically all goes well and then: [100%] Building CXX object

Re: [PATCH] small changes to the planner.

2015-07-07 Thread Joakim Bygdell
On 07 Jul 2015, at 23:46, Rick Walsh rickmwa...@gmail.com wrote: Hi, Thank you. Silly question, what was the forth patch in the series (since they are numbered x/4)? :-) The fourth was an idea to spell Bühlmann correctly, Ha. I got flamed big time when I (as a German)

Re: [PATCH] update disclaimer.

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 10:18:41PM +0200, Joakim Bygdell wrote: Now the way it should have been the first time. Umm, I was just about to thank you and then I saw this... } else { AHH - my eyes... they are bleeding!!! /D

Re: Linking error with recent libdc

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 09:45:49PM -0700, Dirk Hohndel wrote: I just force pushed a new libdc/Subsurface-testing that updates to Jef's latest master. Jef has merged almost all of Linus' EON Steele code - basically just the string field related changes are left in our branch, and of course

Re: Linking error with recent libdc

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 07:13:53PM -1000, Gaetan Bisson wrote: [2015-07-07 21:45:49 -0700] Dirk Hohndel: On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: Linking CXX executable subsurface libsubsurface_corelib.a(libdivecomputer.c.o): In function

[PATCH] small changes to the planner.

2015-07-07 Thread Joakim Bygdell
0001, updates the disclaimer to reflect the deco model that where used to generate the plan. 0002, rearranged the GUI to make it visibly easier to see which settings that belong together. 0003, disables GF fields when VPM-B is the selected deco model. 0001-Planner-update-disclamer.patch