[PATCH 2/3] QML UI: add function to get cylinder pressures

Since we only show the first cylinder we can also only edit the first cylinder. Signed-off-by: Joakim Bygdell --- subsurface-core/subsurface-qt/DiveObjectHelper.cpp | 23 ++ subsurface-core/subsurface-qt/DiveObjectHelper.h | 4 2 files changed,

[PATCH 3/3] QML UI: enable edit of cylinder pressures

First cylinder only, show warning if there are more than one cylinder defined. Signed-off-by: Joakim Bygdell --- qt-mobile/qml/DiveDetails.qml | 10 ++ qt-mobile/qml/DiveDetailsEdit.qml | 26 +- qt-mobile/qml/main.qml| 2 ++

[PATCH 1/3] Add helper to parse pressure strings.

Signed-off-by: Joakim Bygdell --- subsurface-core/helpers.h| 1 + subsurface-core/qthelper.cpp | 21 + 2 files changed, 22 insertions(+) diff --git a/subsurface-core/helpers.h b/subsurface-core/helpers.h index b88230c..7537818 100644 ---

Re: [PATCH 2/3] QML UI: add function to get cylinder pressures

On Tue, Feb 09, 2016 at 07:52:03PM +0100, Joakim Bygdell wrote: > > +static QString getPressures(struct dive *dive, bool returnPressures) > +{ > + cylinder_t *cyl = >cylinder[0]; > + QString fmt; > + if (returnPressures == 0) > + fmt = get_pressure_string(cyl->start,

Re: Android build -800

On 9 February 2016 18:35:20 GMT+00:00, Dirk Hohndel wrote: >On Tue, Feb 09, 2016 at 06:06:30PM +, David Tillotson wrote: >> On 9 February 2016 17:48:28 GMT+00:00, Dirk Hohndel > wrote: >> >> The above three combine to open additional screens to the right,

Re: [PATCH 3/3] QML UI: enable edit of cylinder pressures

0003-QML-UI-enable-edit-of-cylinder-pressures.patch Description: Binary data > On 09 Feb 2016, at 19:52, Joakim Bygdell wrote: > > First cylinder only, show warning if there are more than one cylinder defined. > > Signed-off-by: Joakim Bygdell > ---

Re: Android build -800

Just spotted another "gotcha". When adding a dive manually, you can leave the units off all the fields except the time. If you leave the units off, it silently enters "0min" - should it assume minutes? Interestingly, "20:15" is interpreted as "20h:15min", while "00:26:50" is interpreted as

Re: Android build -800

> On 09 Feb 2016, at 20:35, David Tillotson wrote: > > Just spotted another "gotcha". When adding a dive manually, you can leave the > units off all the fields except the time. If you leave the units off, it > silently enters "0min" - should it assume minutes? The users

Re: Android build -800

> On 09 Feb 2016, at 21:10, Dirk Hohndel wrote: > > On Tue, Feb 09, 2016 at 09:02:03PM +0100, Joakim Bygdell wrote: >> >>> On 09 Feb 2016, at 20:35, David Tillotson wrote: >>> >>> Just spotted another "gotcha". When adding a dive manually, you can

Re: [PATCH 1/3] Add helper to parse pressure strings.

On Tue, Feb 09, 2016 at 07:25:50PM +0100, Joakim Bygdell wrote: > > Hmm - that seems wrong. Shouldn't you switch on the pressure units instead > > of on the weight units??? > *facepalm* I blame low blood suger at the time of writing. That's the purpose of sending this to the mailing list. So that

[PATCH] QML UI: Remove unused onClicked event for back button

From: Henrik Brautaset Aronsen I don't know how this got here. Probably having fun with copy and paste. Signed-off-by: Henrik Brautaset Aronsen --- qt-mobile/qml/TopBar.qml | 7 --- 1 file changed, 7 deletions(-) diff --git

Subsurface-mobile first beta will be -802

I submitted this to processing on Google Play. Hopefully in a short while this will be publically available. The opt-in link will be https://play.google.com/apps/testing/org.subsurfacedivelog.mobile I'll announce this on our News section, Facebook, Google Plus and scubaboard in a little while.

[PATCH] QML UI: Fix lingering edit mode

From: Henrik Brautaset Aronsen A dive would linger in edit mode when following these steps: start mobile. show theme info. click on dive in dive list. click edit. click back in topbar, again click back in the topbar. click on dive in dive list, still in edit mode.

Re: [PATCH 2/3] QML UI: add function to get cylinder pressures

> On 09 Feb 2016, at 19:59, Dirk Hohndel wrote: > > On Tue, Feb 09, 2016 at 07:52:03PM +0100, Joakim Bygdell wrote: >> >> +static QString getPressures(struct dive *dive, bool returnPressures) >> +{ >> +cylinder_t *cyl = >cylinder[0]; >> +QString fmt; >> +if

Re: [PATCH 2/3] QML UI: add function to get cylinder pressures

0002-QML-UI-add-function-to-get-cylinder-pressures.patch Description: Binary data > On 09 Feb 2016, at 19:59, Dirk Hohndel wrote: > > On Tue, Feb 09, 2016 at 07:52:03PM +0100, Joakim Bygdell wrote: >> >> +static QString getPressures(struct dive *dive, bool returnPressures)

Re: Android build -800

On Tue, Feb 09, 2016 at 09:02:03PM +0100, Joakim Bygdell wrote: > > > On 09 Feb 2016, at 20:35, David Tillotson wrote: > > > > Just spotted another "gotcha". When adding a dive manually, you can leave > > the units off all the fields except the time. If you leave the

Re: [PATCH 2/3] QML UI: add function to get cylinder pressures

On Tue, Feb 09, 2016 at 08:39:34PM +0100, Joakim Bygdell wrote: > something like this? Yes :-) /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Android build -800

On 9 February 2016 17:48:28 GMT+00:00, Dirk Hohndel wrote: >> After manually adding a dive, the second last dive no longer >displayed a profile until app restarted. I'll try and reproduce this >later (need to delete the manual addition). > >Have you tried going to another dive

Re: Android build -800

On Tue, Feb 09, 2016 at 09:13:28PM +0100, Joakim Bygdell wrote: > > > On 09 Feb 2016, at 21:10, Dirk Hohndel wrote: > > > > On Tue, Feb 09, 2016 at 09:02:03PM +0100, Joakim Bygdell wrote: > >> > >>> On 09 Feb 2016, at 20:35, David Tillotson wrote: > >>>

(final) pre beta test Mobile version -800

List, Concentrated my testing on 2 different aspects. Cloud- and save management, and layout of the DiveEdit screen. Layout DiveEdit screen: I think Dirk finally did it. Scrolled and selected all over the place trough my divelist, and the scaling of the DiveEdit screen is always ok. Tested

Re: Mobile build -786 small test

On February 8, 2016 5:59:38 PM GMT+01:00, Dirk Hohndel wrote: >On Mon, Feb 08, 2016 at 06:44:21PM +0200, Miika Turkia wrote: >> On Mon, Feb 8, 2016 at 6:26 PM, Dirk Hohndel >wrote: >> > On Mon, Feb 08, 2016 at 01:28:05PM +0100, Jan Mulder wrote: >> >> >> >>

[PATCH] Mobile user-manual: Add text that explains action button

[PATCH] Mobile user-manual: Add text that explains action button 4 small images added. Signed-off-by: Willem Ferguson From 43f260e7aa2be9af43c9250f75cad05a141f9d1e Mon Sep 17 00:00:00 2001 From: Willem Ferguson Date: Tue,

Re: (final) pre beta test Mobile version -800

On 09-02-16 10:58, Jan Mulder wrote: List, Concentrated my testing on 2 different aspects. Cloud- and save management, and layout of the DiveEdit screen. Layout DiveEdit screen: I think Dirk finally did it. Scrolled and selected all over the place trough my divelist, and the scaling of the

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tue, Feb 9, 2016 at 11:37 AM, Robert Helling wrote: > > A possible project I could mentor in the summer would be a mobile version > of the planner (if nobody vetos it). That would be a separate app from > subsurface-mobile but of course share a lot of code. > I would love

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On 09 February, 2016 - Dirk Hohndel wrote: > On Tue, Feb 09, 2016 at 12:53:42PM +, JB2Cool wrote: > > On 9 February 2016 at 12:48, Sebastian Kügler wrote: > > > > > > > > A possible project I could mentor in the summer would be a mobile > > > version of > > > > the planner (if

Re: Mobile build -786 small test

On Tue, Feb 9, 2016 at 4:09 PM, Dirk Hohndel wrote: > On Tue, Feb 09, 2016 at 11:46:25AM +0100, Anton Lundin wrote: >> >> >> >> What is the preferred method to clean the git repository? Purge from >> >> server and recreate local one? >> > >> >This is something on my infinite

Re: Mobile build -786 small test

On Tue, Feb 09, 2016 at 11:46:25AM +0100, Anton Lundin wrote: > >> > >> What is the preferred method to clean the git repository? Purge from > >> server and recreate local one? > > > >This is something on my infinite todo list. We have no easy way to do > >that. The best I can think of is: > > >

Re: (final) pre beta test Mobile version -800

On Tue, Feb 09, 2016 at 10:58:46AM +0100, Jan Mulder wrote: > List, > > Concentrated my testing on 2 different aspects. Cloud- and save management, > and layout of the DiveEdit screen. > > Layout DiveEdit screen: I think Dirk finally did it. Scrolled and selected > all over the place trough my

Re: C++ cout within Subsurface

Willem, Also do not include iostream on c code. ;) And do what sebas said, plenty of debug examples on the code. Tomaz Em 9 de fev de 2016 13:00, "Sebastian Kügler" escreveu: > On Tuesday, February 09, 2016 04:57:09 PM Willem Ferguson wrote: > > What do you do? > > Use qDebug().

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tue, Feb 09, 2016 at 12:53:42PM +, JB2Cool wrote: > On 9 February 2016 at 12:48, Sebastian Kügler wrote: > > > > > > A possible project I could mentor in the summer would be a mobile > > version of > > > the planner (if nobody vetos it). That would be a separate app from > >

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tue, Feb 9, 2016 at 2:51 PM, Dirk Hohndel wrote: > On Tue, Feb 09, 2016 at 06:59:48AM +0100, Henrik Brautaset Aronsen wrote: > > Den tirsdag 9. februar 2016 skrev Dirk Hohndel > følgende: > > > > > > > > Finally - what would the projects be this year? Is

Re: C++ cout within Subsurface

On Tuesday, February 09, 2016 04:57:09 PM Willem Ferguson wrote: > What do you do? Use qDebug(). -- sebas http://www.kde.org | http://vizZzion.org ___ subsurface mailing list subsurface@subsurface-divelog.org

Test of build 800

I ran build 800 on my two Android machines. I am delighted that the crash using my dataset has disappeared. Several small issues but two main issues: 1) When hand-entering a dive, the profile does not appear. In other words: I hand-enter information for a new dive, save, go back to the dive

C++ cout within Subsurface

I am printing some intermediate values in the C++ code and I try and use the cout device. But when I compile the machine tells me that does not exist. I suspect it is because of using gcc for handling a mix of c and c++ code??? What do you do? Kind regards, willem

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tue, Feb 09, 2016 at 03:04:50PM +0100, Henrik Brautaset Aronsen wrote: > On Tue, Feb 9, 2016 at 2:51 PM, Dirk Hohndel wrote: > > > On Tue, Feb 09, 2016 at 06:59:48AM +0100, Henrik Brautaset Aronsen wrote: > > > Den tirsdag 9. februar 2016 skrev Dirk Hohndel

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tuesday, February 09, 2016 12:53:42 PM JB2Cool wrote: > On 9 February 2016 at 12:48, Sebastian Kügler wrote: [...] > I'd much rather have something small, stable and high quality than a swiss > army knife that falls apart the moment you look at it. > > There are many areas in

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On 08 February, 2016 - Dirk Hohndel wrote: > Which leads me to the question: > > "do we want to do GSoC 2016?" > > I'm not sure. I thought the last two years were overall good experiences. > > But they have not brought us long term contributors (Gehad was the closest > we got and his last

Re: (final) pre beta test Mobile version -800

On 09-02-16 15:18, Dirk Hohndel wrote: On Tue, Feb 09, 2016 at 10:58:46AM +0100, Jan Mulder wrote: Completely agree. Thanks again for the testing and for the dilligence to keep the issues reported. I really think that we should try harder to use trac for this as it makes it much easier not to

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On 9 February 2016 at 12:48, Sebastian Kügler wrote: > On Tuesday, February 09, 2016 12:17:50 PM Henrik Brautaset Aronsen wrote: > > On Tue, Feb 9, 2016 at 11:37 AM, Robert Helling > wrote: > > > > A possible project I could mentor in the summer would be a

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tuesday, February 09, 2016 12:17:50 PM Henrik Brautaset Aronsen wrote: > On Tue, Feb 9, 2016 at 11:37 AM, Robert Helling wrote: > > A possible project I could mentor in the summer would be a mobile version of > the planner (if nobody vetos it). That would be a separate app

Re: Now Accepting GSoC 2016 Mentor Organization Applications

On Tue, Feb 09, 2016 at 06:59:48AM +0100, Henrik Brautaset Aronsen wrote: > Den tirsdag 9. februar 2016 skrev Dirk Hohndel følgende: > > > > > Finally - what would the projects be this year? Is there anything that > > people > > have in mind that can be done by a student and

Re: (final) pre beta test Mobile version -800

On 09-02-16 12:18, Jan Mulder wrote: Multiple cloud account works with 1 (probably) little thing. Let me elaborate a little. Synced 2 cloud accounts to my phone (my original big logbook, and ssrft...@hohndel.org test account). Switching between them, by just entering new credentials as there

Re: Test of build 800

On Tue, Feb 09, 2016 at 04:29:51PM +0200, Willem Ferguson wrote: > I ran build 800 on my two Android machines. I am delighted that the crash > using my dataset has disappeared. Several small issues but two main issues: > > 1) When hand-entering a dive, the profile does not appear. In other words:

Re: C++ cout within Subsurface

On terça-feira, 9 de fevereiro de 2016 13:04:24 PST Tomaz Canabrava wrote: > Willem, > > Also do not include iostream on c code. ;) > And do what sebas said, plenty of debug examples on the code. qDebug() also requires C++ :-) -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT)

trac

On Tue, Feb 09, 2016 at 03:41:35PM +0100, Jan Mulder wrote: > On 09-02-16 15:18, Dirk Hohndel wrote: > >On Tue, Feb 09, 2016 at 10:58:46AM +0100, Jan Mulder wrote: > >>Completely agree. Thanks again for the testing and for the dilligence to > >>keep the issues reported. I really think that we

[PATCH 1/3] Add helper to parse pressure strings.

Signed-off-by: Joakim Bygdell --- subsurface-core/helpers.h| 1 + subsurface-core/qthelper.cpp | 21 + 2 files changed, 22 insertions(+) diff --git a/subsurface-core/helpers.h b/subsurface-core/helpers.h index b88230c..7537818 100644 ---

[PATCH 3/3] QML UI: enable edit of cylinder pressures

First cylinder only, show warning if there are more than one cylinder defined. Signed-off-by: Joakim Bygdell --- qt-mobile/qml/DiveDetails.qml | 10 ++ qt-mobile/qml/DiveDetailsEdit.qml | 26 +- qt-mobile/qml/main.qml| 2 ++

[PATCH 2/3] QML UI: add function to get cylinder pressures

Since we only show the first cylinder we can also only edit the first cylinder. Signed-off-by: Joakim Bygdell --- subsurface-core/subsurface-qt/DiveObjectHelper.cpp | 23 ++ subsurface-core/subsurface-qt/DiveObjectHelper.h | 4 2 files changed,

Re: Android build -800

I took some time out to test the latest Daily (802) on my "problem child" Note 4 in a (slightly) formal manner. Clean install: Initial setup of cloud credentials - wrong ID or password returns to opening screen, expected to return to credentials entry. Not a real issue, but possibly confusing

Re: Subsurface-planner [was: Now Accepting GSoC 2016 Mentor Organization Applications]

On 10 Feb 2016 05:22, "Henrik Brautaset Aronsen" wrote: > > On Tue, Feb 9, 2016 at 3:05 PM, Dirk Hohndel wrote: >> >> On Tue, Feb 09, 2016 at 12:53:42PM +, JB2Cool wrote: >> > On 9 February 2016 at 12:48, Sebastian Kügler wrote:

Re: Subsurface-planner [was: Now Accepting GSoC 2016 Mentor Organization Applications]

On Wed, Feb 10, 2016 at 08:25:04AM +1100, Rick Walsh wrote: > > A separate Subsurface-planner would be nice as well. Maybe something > > simple, with just table based input and output, utilizing the powerful deco > > planner core that we have. > > I created the basics of a table input/output

[PATCH] QML UI: dive edit, treat numeric input of duration as full minutes

When editing the duration of a dive, if only numbers are entered they are treated as full miuntes. Signed-off-by: Joakim Bygdell --- qt-mobile/qmlmanager.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-mobile/qmlmanager.cpp b/qt-mobile/qmlmanager.cpp index

Re: Android build -800

On Tue, Feb 09, 2016 at 06:06:30PM +, David Tillotson wrote: > On 9 February 2016 17:48:28 GMT+00:00, Dirk Hohndel wrote: > >> The above three combine to open additional screens to the right, > >consuming a press of the back button each. > > > >Wait, now I'm confused. I

[PATCH] QML UI: Back buttons for app log and theme info

From: Henrik Brautaset Aronsen The app log and theme info had context menus with a single close item. No need for that. Signed-off-by: Henrik Brautaset Aronsen --- qt-mobile/qml/GpsList.qml | 12 qt-mobile/qml/Log.qml |

Re: Android build -800

On 9 February 2016 17:48:28 GMT+00:00, Dirk Hohndel wrote: >> The above three combine to open additional screens to the right, >consuming a press of the back button each. > >Wait, now I'm confused. I thought you said the back button was >non-functional. Maybe I should ask "what

Re: [PATCH 1/3] Add helper to parse pressure strings.

On Tue, Feb 09, 2016 at 06:03:23PM +0100, Joakim Bygdell wrote: > Signed-off-by: Joakim Bygdell > --- > subsurface-core/helpers.h| 1 + > subsurface-core/qthelper.cpp | 21 + > 2 files changed, 22 insertions(+) > > diff --git

Subsurface-planner [was: Now Accepting GSoC 2016 Mentor Organization Applications]

On Tue, Feb 9, 2016 at 3:05 PM, Dirk Hohndel wrote: > On Tue, Feb 09, 2016 at 12:53:42PM +, JB2Cool wrote: > > On 9 February 2016 at 12:48, Sebastian Kügler wrote: > > > > > > > > A possible project I could mentor in the summer would be a mobile > > >

Re: [PATCH 2/3] QML UI: add function to get cylinder pressures

On Tue, Feb 09, 2016 at 06:03:24PM +0100, Joakim Bygdell wrote: > Since we only show the first cylinder we can also only edit the first > cylinder. > > Signed-off-by: Joakim Bygdell > --- > subsurface-core/subsurface-qt/DiveObjectHelper.cpp | 23 > ++ >

Re: [PATCH 1/3] Add helper to parse pressure strings.

> On 09 Feb 2016, at 19:21, Dirk Hohndel wrote: > > On Tue, Feb 09, 2016 at 06:03:23PM +0100, Joakim Bygdell wrote: >> Signed-off-by: Joakim Bygdell >> --- >> subsurface-core/helpers.h| 1 + >> subsurface-core/qthelper.cpp | 21 +

Re: [PATCH 2/3] QML UI: add function to get cylinder pressures

> On 09 Feb 2016, at 19:24, Dirk Hohndel wrote: > > On Tue, Feb 09, 2016 at 06:03:24PM +0100, Joakim Bygdell wrote: >> Since we only show the first cylinder we can also only edit the first >> cylinder. >> >> Signed-off-by: Joakim Bygdell >> --- >>

Re: Subsurface-planner [was: Now Accepting GSoC 2016 Mentor Organization Applications]

On 9 February 2016 at 22:51, Dirk Hohndel wrote: > On Wed, Feb 10, 2016 at 08:25:04AM +1100, Rick Walsh wrote: > > > A separate Subsurface-planner would be nice as well. Maybe something > > > simple, with just table based input and output, utilizing the powerful > deco > > >

Re: Now Accepting GSoC 2016 Mentor Organization Applications

9. feb. 2016 15.07 skrev "Dirk Hohndel" : > > On Tue, Feb 09, 2016 at 03:04:50PM +0100, Henrik Brautaset Aronsen wrote: > > > > The only reason the first step was so painful was that noone went for a > > minimum viable product. It blew out of proportion with an too advanced UI >

Re: Android build -800

On Tue, Feb 09, 2016 at 05:08:18PM +, David Tillotson wrote: > I took some time out to test the latest Daily (802) on my "problem child" > Note 4 in a (slightly) formal manner. Thank you for that. > Clean install: > Initial setup of cloud credentials - wrong ID or password returns to