[PATCH 3/3] Hide the dive-related controls when showing trips

2015-06-17 Thread Anton Lundin
Signed-off-by: Anton Lundin gla...@acc.umu.se --- theme/list_lib.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/theme/list_lib.js b/theme/list_lib.js index 0459aad..b698254 100644 --- a/theme/list_lib.js +++ b/theme/list_lib.js @@ -750,14 +750,20 @@ function getDefaultColor(){

[PATCH 1/3] Remove old timing of function

2015-06-17 Thread Anton Lundin
Signed-off-by: Anton Lundin gla...@acc.umu.se --- theme/list_lib.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/theme/list_lib.js b/theme/list_lib.js index afaa77a..17f5206 100644 --- a/theme/list_lib.js +++ b/theme/list_lib.js @@ -134,14 +134,12 @@ function view_pagging(start, end) */

Re: [Patch] Fix planner notes gas change output logic

2015-06-17 Thread Robert C. Helling
Hi everybody, let me first say this: This code is quite convoluted and has some history over which I tried several times to get it right. Too bad, I failed with it so far. Since yesterday, I have already spent several hours on this and still what I have does not satisfy me (one could say: It

Re: [Patch] Fix planner notes gas change output logic

2015-06-17 Thread Rick Walsh
Robert, On 18 June 2015 at 06:53, Robert C. Helling hell...@atdotde.de wrote: Hi everybody, let me first say this: This code is quite convoluted and has some history over which I tried several times to get it right. Too bad, I failed with it so far. Since yesterday, I have already spent

Re: [Patch] Fix planner notes gas change output logic

2015-06-17 Thread Joakim Bygdell
Robert, care to explain the postponed logic? This set is from master. Transition to 30 m in 1:40 min - runtime 1:40 on EAN32 Stay at 30 m for 28:20 min - runtime 30:00 on EAN32 Switch gas to air Stay at 30 m for 30:00 min - runtime 60:00 on air Switch gas to EAN32 Stay at 30 m for 30:00 min -

Re: [Patch] Fix planner notes gas change output logic

2015-06-17 Thread Joakim Bygdell
Transition to 30 m in 1:40 min - runtime 1:40 on EAN32 Stay at 30 m for 28:20 min - runtime 30:00 on EAN32 Switch gas to air Stay at 30 m for 30:00 min - runtime 60:00 on air Switch gas to EAN32 Stay at 30 m for 30:00 min - runtime 90:00 on EAN32 Switch gas to EAN80 Stay at 9.0 m for

Re: Cloud storage and web view

2015-06-17 Thread Dirk Hohndel
On Jun 17, 2015, at 9:19 PM, Gaetan Bisson bis...@archlinux.org wrote: [2015-06-17 19:28:20 -0700] Dirk Hohndel: Anyway, give it a try, let me know what you think. Thanks a lot for all the hard work. I'd like to keep a local copy of my data but use the cloud storage as a backup. In

Re: [Patch] Re-fix silly typo (was Current git no compilee)

2015-06-17 Thread Linus Torvalds
On Jun 17, 2015 02:28, Dirk Hohndel d...@hohndel.org wrote: I should just give up and learn to do flower arrangements. While I'm sure you'd do very well at flower arrangements, I suspect the money in it is not enough to maintain the scuba lifestyle you are accustomed to. Life can be difficult

Re: HTML export - expanding a dive

2015-06-17 Thread Gehad Elrobey
Yes, .target is working here on chromium and yes I meant Expansion I ll refactor that sorry for the wrong spelling. On Wed, Jun 17, 2015 at 7:02 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jun 17, 2015 at 09:59:21AM -0700, Dirk Hohndel wrote: I couldn't reproduce this on Chromium but I

Re: HTML export - expanding a dive

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 07:22:50PM +0200, Gehad Elrobey wrote: Yes, .target is working here on chromium and yes I meant Expansion I ll refactor that sorry for the wrong spelling. No worries. 90+% of us are non-native speakers :-) I have added a small patch to fix the .target issue and was

Re: [Patch] Re-fix silly typo (was Current git no compilee)

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 06:16:18PM +1000, Rick Walsh wrote: Dirk, I compile with debugging. No idea why this didn't get me... The problem seems to be so trivial that I couldn't even see the obviousness of it at first: m_Instance vs m_instance (notice the wrong capitalization).

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Davide DB
On Tue, Jun 16, 2015 at 6:03 PM, Davide DB dbdav...@gmail.com wrote: Did you change the UUID algorithm? Comparing the two files I found same dives with different UUID's Hummm maybe I'm doing something stupid here. dive number='9' rating='3' visibility='2' tags='boat, oc, reef, wreck'

Re: Current git no compilee

2015-06-17 Thread Thiago Macieira
On Tuesday 16 June 2015 20:31:01 Dirk Hohndel wrote: I suspect you compile without debugging, so that the Q_ASSERT_X() goes away. I compile with debugging. No idea why this didn't get me... You may be compiling with debugging but with QT_NO_DEBUG set. The default of QT_DEBUG / QT_NO_DEBUG

[Patch] Re-fix silly typo (was Current git no compilee)

2015-06-17 Thread Rick Walsh
Dirk, On 17 June 2015 at 13:31, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jun 16, 2015 at 05:16:16PM -1000, Linus Torvalds wrote: On Tue, Jun 16, 2015 at 4:27 PM, Dirk Hohndel d...@hohndel.org wrote: Compiled for me... I'm out at dinner. Will look tonight. I suspect you compile

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 02:29:56PM +0200, Davide DB wrote: On Tue, Jun 16, 2015 at 6:03 PM, Davide DB dbdav...@gmail.com wrote: Did you change the UUID algorithm? Comparing the two files I found same dives with different UUID's Hummm maybe I'm doing something stupid here. dive

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Davide DB
On Wed, Jun 17, 2015 at 2:41 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jun 17, 2015 at 02:29:56PM +0200, Davide DB wrote: On Tue, Jun 16, 2015 at 6:03 PM, Davide DB dbdav...@gmail.com wrote: Did you change the UUID algorithm? Comparing the two files I found same dives with

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 03:11:45PM +0200, Davide DB wrote: Last question is about the UUID. Did it change across different builds? I understood that it should be created always the same for the same dive site. Not sure what gave you this impression :-) Here's the actual code while

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Davide DB
On Wed, Jun 17, 2015 at 3:34 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jun 17, 2015 at 03:11:45PM +0200, Davide DB wrote: Last question is about the UUID. Did it change across different builds? I understood that it should be created always the same for the same dive site. Not sure

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 03:52:44PM +0200, Davide DB wrote: Of course. I was just trying to understand the logic behind this. I thought that a dive site should be unique as the real place it represent hence the same (V2 format) dive would generate always the same dive site even across

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-17 Thread Jef Driesen
On 2015-06-15 20:26, Thiago Macieira wrote: On Monday 15 June 2015 06:13:54 Dirk Hohndel wrote: On Mon, Jun 15, 2015 at 03:01:44PM +0200, Jef Driesen wrote: I did already think about this :-) See [1] for some more background info. In a nutshell, the serial layer will be changed from a

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 04:23:01PM +0200, Davide DB wrote: Now an interesting question comes up when we import data from a different source. We have some dives loaded already and we are adding more dives to it. We could conceivably try to see if we have matching dive sites and then

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 04:20:42PM +0200, Jef Driesen wrote: On 2015-06-15 20:26, Thiago Macieira wrote: On Monday 15 June 2015 06:13:54 Dirk Hohndel wrote: On Mon, Jun 15, 2015 at 03:01:44PM +0200, Jef Driesen wrote: I did already think about this :-) See [1] for some more background info.

Re: [Patch] Fix planner notes gas change output logic

2015-06-17 Thread Rick Walsh
Robert, On 16 June 2015 at 22:46, Robert Helling hell...@atdotde.de wrote: No, unfortunately, this is not correct either. I acknowledge the bug that you describe (the gas change to EAN80 should be displayed at 9m depth). But your suggested patch breaks something else (which was the original

Re: GSoC Status - Week 3 (Customizable prints)

2015-06-17 Thread Gehad Elrobey
Hello Lubomir, I have amended the commit I mentioned above, I also added the support to print on many page sizes with different print qualities (This still needs more testing), I have pushed all the commits to my branch. On Sun, Jun 14, 2015 at 6:00 PM, Lubomir I. Ivanov neolit...@gmail.com

Re: HTML export - expanding a dive

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 05:58:43PM +0200, Gehad Elrobey wrote: On Wed, Jun 17, 2015 at 5:13 PM, Dirk Hohndel d...@hohndel.org wrote: Hey Gehad, I know you are focused on this year's GSoC project right now, but I have a question about your previous contribution, the HTML exporter...

Re: HTML export - expanding a dive

2015-06-17 Thread Dirk Hohndel
On Wed, Jun 17, 2015 at 09:59:21AM -0700, Dirk Hohndel wrote: I couldn't reproduce this on Chromium but I still see the malformed Html it seems that Chromium is more tolerant to incorrect tags, I have attached a patch that fixes the tag closing, I hope this will fix the problem. Well, the

HTML export - expanding a dive

2015-06-17 Thread Dirk Hohndel
Hey Gehad, I know you are focused on this year's GSoC project right now, but I have a question about your previous contribution, the HTML exporter... For me (Firefox 38.0.5, Arch Linux) the expansion by clicking on an entry in the dive list doesn't work. I get nothing at all. The Expand All

Re: [Patch] Fix planner notes gas change output logic

2015-06-17 Thread Robert Helling
Rick, On 17.06.2015, at 17:37, Rick Walsh rickmwa...@gmail.com wrote: I think to accomplish this, we need to consider a gaschange-on-the-run as a zero minute segment. I do no think it is correct to have the change on the ascent leg up to the change depth, as that would imply switching gas

Re: HTML export - expanding a dive

2015-06-17 Thread Gehad Elrobey
On Wed, Jun 17, 2015 at 5:13 PM, Dirk Hohndel d...@hohndel.org wrote: Hey Gehad, I know you are focused on this year's GSoC project right now, but I have a question about your previous contribution, the HTML exporter... For me (Firefox 38.0.5, Arch Linux) the expansion by clicking on an

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-17 Thread Robert Helling
Hi, On 17.06.2015, at 16:45, Dirk Hohndel d...@hohndel.org wrote: No one suggested that the application HAS to provide that functionality. What we are suggesting is to make this an OPTION. If the application wants to do this... I did not follow this discussion in all details. But maybe I