Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-06-29 Thread Marco Martin
The branch has been merged in master, the attanched patch to subsurface makes it correctly load with kirigami built in static mode From 2a49e1e5fe7f4525bda6bf26326ea66a4cf3f3eb Mon Sep 17 00:00:00 2001 From: Marco Martin Date: Wed, 22 Jun 2016 18:17:25 +0200 Subject: [PATCH] use kirigami built in

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-06-22 Thread Marco Martin
On Wednesday 22 June 2016, Dirk Hohndel wrote: > Push whatever you want to change into master and I'll see if I can continue > to build an Android package. If that fails as well I'll just stay on the > last Kirigami that worked. I'll test a bit more this patch on android (and see if i can make it

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-06-22 Thread Dirk Hohndel
> On Jun 22, 2016, at 9:34 AM, Marco Martin wrote: > > This is the latest version: > We now added a build time switch in kirigami > to produce a static library (in that case doesn't even need extra-cmake- > modules so no extra deps) > > the build scripts are updated to link to the generated sta

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-06-22 Thread Marco Martin
This is the latest version: We now added a build time switch in kirigami to produce a static library (in that case doesn't even need extra-cmake- modules so no extra deps) the build scripts are updated to link to the generated static library, even tough is pretty ugly cmake, probably it should st

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-30 Thread Marco Martin
On Monday 30 May 2016, Martin Gysel wrote: > > I'm wondering if it would be possible to get Kirigami 'into' qpm [1]. > That way it would be much simpler to use it in any qmake base app. > > I once played around with it and tried to create a .pri file but for > some reasons I failed. so, now if k

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-30 Thread Martin Gysel
Am 30.05.2016 um 14:55 schrieb Marco Martin: > On Monday 30 May 2016, Martin Gysel wrote: >> Am 30.05.2016 um 13:59 schrieb Marco Martin: >>> On Sunday 29 May 2016, Dirk Hohndel wrote: To make matters worse, Tomaz no longer has access to a Mac so he can’t help, either. Which means that ri

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-30 Thread Marco Martin
On Monday 30 May 2016, Martin Gysel wrote: > Am 30.05.2016 um 13:59 schrieb Marco Martin: > > On Sunday 29 May 2016, Dirk Hohndel wrote: > >> To make matters worse, Tomaz no longer has access to a Mac so he can’t > >> help, either. Which means that right now a Kirigami version that > >> requires th

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-30 Thread Martin Gysel
Am 30.05.2016 um 13:59 schrieb Marco Martin: > On Sunday 29 May 2016, Dirk Hohndel wrote: >> To make matters worse, Tomaz no longer has access to a Mac so he can’t >> help, either. Which means that right now a Kirigami version that requires >> the plugin is a non-starter for Subsurface-mobile on iO

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-30 Thread Marco Martin
On Sunday 29 May 2016, Dirk Hohndel wrote: > To make matters worse, Tomaz no longer has access to a Mac so he can’t > help, either. Which means that right now a Kirigami version that requires > the plugin is a non-starter for Subsurface-mobile on iOS. I simply don’t > understand how this is suppose

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-29 Thread Marco Martin
On Sunday 29 May 2016, Dirk Hohndel wrote: > To make matters worse, Tomaz no longer has access to a Mac so he can’t > help, either. Which means that right now a Kirigami version that requires > the plugin is a non-starter for Subsurface-mobile on iOS. I simply don’t > understand how this is suppose

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-29 Thread Dirk Hohndel
I continue to be unable to build the plugin for iOS. Fundamentally it boils down to the fact that I can’t figure out how to get anything that links against Qt to build with cmake when building for iOS. Tomaz actually gave up on that for Subsurface-mobile a while ago and decided to add a whole se

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-26 Thread Marco Martin
Awesome! let me know if you want to give the patch a try and run into hurdles On Wednesday 25 May 2016 14:25:18 Tomaz Canabrava wrote: > Marco, > I don't have the iComputer anymore so I cannot test, but lakademy starts > tomorrow and I'll focus solely on subsurface. > > Tomaz > > Em 25 de mai de

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-25 Thread Dirk Hohndel
On Wed, May 25, 2016 at 07:22:32PM +0200, Marco Martin wrote: > On Thursday 05 May 2016 17:27:08 Marco Martin wrote: > > Hi all, > > at this point it's being a bit of a problem for me not being able to > > add any C++ part in kirigami, since i cannot do a qml plugin (or > > subsurface would break)

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-25 Thread Marco Martin
On Thursday 05 May 2016 17:27:08 Marco Martin wrote: > Hi all, > at this point it's being a bit of a problem for me not being able to > add any C++ part in kirigami, since i cannot do a qml plugin (or > subsurface would break) > We included it as qrc resources in the beginning in order to make > so

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-25 Thread Tomaz Canabrava
Marco, I don't have the iComputer anymore so I cannot test, but lakademy starts tomorrow and I'll focus solely on subsurface. Tomaz Em 25 de mai de 2016 14:22, "Marco Martin" escreveu: > On Thursday 05 May 2016 17:27:08 Marco Martin wrote: > > Hi all, > > at this point it's being a bit of a prob

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-17 Thread Marco Martin
On Tuesday 17 May 2016 18:00:46 Marco Martin wrote: > the patch now uses two cmake options in kirigami that make it not even > search for the optional dependencies, so shouldn't spam with scary > $foo not found messages at configure time anymore another thing that I'll probably change in a future

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-17 Thread Marco Martin
On Thu, May 5, 2016 at 5:27 PM, Marco Martin wrote: > Hi all, > at this point it's being a bit of a problem for me not being able to > add any C++ part in kirigami, since i cannot do a qml plugin (or > subsurface would break) > We included it as qrc resources in the beginning in order to make > so

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-06 Thread Marco Martin
On Friday 06 May 2016 12:45:20 Tomaz Canabrava wrote: > I like ECM, > And we can remove a bit of subsurface cmake magic with it, so keep it. I'm > without computer in the meantime, but as soon as I get one I'll work on > that. it also has some apk packaging plumbing, that could be useful as well

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-06 Thread Tomaz Canabrava
I like ECM, And we can remove a bit of subsurface cmake magic with it, so keep it. I'm without computer in the meantime, but as soon as I get one I'll work on that. Em 6 de mai de 2016 12:29, "Marco Martin" escreveu: > > On Thursday 05 May 2016 11:03:45 Dirk Hohndel wrote: > > >> to move further

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-06 Thread Marco Martin
On Thursday 05 May 2016 11:03:45 Dirk Hohndel wrote: > >> to move further to me is important to know if is easy enough to deploy, > >> as i wouldn't move in a direction that makes things too hard for who is > >> using it> > > I'm sure we can figure this out - I'll make playing with this a priority

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Thomas Pfeiffer
On Donnerstag, 5. Mai 2016 11:35:38 CEST Dirk Hohndel wrote: > This has nothing to do with Linux packaging. > The CMakeLists.txt files simply require certain modules to be present at > build time. Kirigami requires ECM and KF5Plasma > KF5Plasma requires KF5Activities > KF5Activities requires Boost

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Tomaz Canabrava
ECM shouldn't depend on anything as it is just cmake modules. If it depends, it's a bug on the package. Same thing goes for kirigami, as it's just qml files that shouldn't depend on anything else. I'd mark that as packaging bug too. Also kf5 activities shouldn't depend on the whole kf5. We already

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Dirk Hohndel
> On May 5, 2016, at 11:32 AM, Tomaz Canabrava wrote: > > ECM shouldn't depend on anything as it is just cmake modules. If it depends, > it's a bug on the package. Same thing goes for kirigami, as it's just qml > files that shouldn't depend on anything else. I'd mark that as packaging bug > t

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Thomas Pfeiffer
On Donnerstag, 5. Mai 2016 11:03:45 CEST Dirk Hohndel wrote: > So Kirigami requires ECM. and KF5Plasma. and that requires KF5Activities. > Which requires Boost. And KF5. > > I think at this point we need to talk about scope. > > No, it is not reasonable to assume that I want to build all of KDE j

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Dirk Hohndel
> On May 5, 2016, at 10:13 AM, Dirk Hohndel wrote: > > >> On May 5, 2016, at 10:07 AM, Marco Martin wrote: >> >> On Thursday 05 May 2016 09:26:50 Dirk Hohndel wrote: >>> In that context, is there a plugin, yet, with which I could test this? >>> I looked at Kirigami master this morning and did

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Dirk Hohndel
> On May 5, 2016, at 10:07 AM, Marco Martin wrote: > > On Thursday 05 May 2016 09:26:50 Dirk Hohndel wrote: >> In that context, is there a plugin, yet, with which I could test this? >> I looked at Kirigami master this morning and didn't see any sign of >> such a dependency, but maybe you are hol

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Marco Martin
On Thursday 05 May 2016 09:36:41 Dirk Hohndel wrote: > > > > echo org.kde.plasma.kirigami synced from upstream > > So this now copies the icons we need into the Kirigami sources... I assume > that's on the theory that this gets run before Kirigami gets built and > that therefore these icons get

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Marco Martin
On Thursday 05 May 2016 09:26:50 Dirk Hohndel wrote: > In that context, is there a plugin, yet, with which I could test this? > I looked at Kirigami master this morning and didn't see any sign of > such a dependency, but maybe you are holding that back, waiting > for us to get our act together? th

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Dirk Hohndel
On Thu, May 05, 2016 at 05:27:08PM +0200, Marco Martin wrote: > diff --git a/packaging/android/build.sh b/packaging/android/build.sh > index 2213780..8d6f11d 100644 > --- a/packaging/android/build.sh > +++ b/packaging/android/build.sh > @@ -290,6 +290,18 @@ if [ ! -e $PKG_CONFIG_LIBDIR/libdivecompu

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Dirk Hohndel
> On May 5, 2016, at 9:07 AM, Marco Martin wrote: > > On Thursday 05 May 2016 12:39:47 Tomaz Canabrava wrote: >>> on windows/osx shouldn't be an issue as afaik only the desktop version >>> is build there >> >> Nope, >> Mobile is also build, as it's easier and faster to debug some stuff in >> de

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Marco Martin
On Thursday 05 May 2016 12:39:47 Tomaz Canabrava wrote: > > on windows/osx shouldn't be an issue as afaik only the desktop version > > is build there > > Nope, > Mobile is also build, as it's easier and faster to debug some stuff in > desktop mode. > I'm without computer atm so I cannot test. if

Re: [PATCH] WIP: use kirigami plugin instead of embedding in qrc

2016-05-05 Thread Tomaz Canabrava
Em 5 de mai de 2016 12:27, "Marco Martin" escreveu: > > Hi all, > at this point it's being a bit of a problem for me not being able to > add any C++ part in kirigami, since i cannot do a qml plugin (or > subsurface would break) > We included it as qrc resources in the beginning in order to make >