Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread David Chisnall
On 16 Sep 2012, at 10:37, Chris Rees wrote: Actually: for (;;) ; This form will generate a compiler warning, because it looks like a missing loop body. You can silence the warning by this form: for (;;) {} This makes it clear that you have an explicit body containing no

Re: svn commit: r240850 - head/lib/libstand

2012-09-24 Thread David Chisnall
On 23 Sep 2012, at 20:27, Garrett Cooper wrote: +1. free(3) should silently ignore NULL parameters passed into it. Indeed. The C standard's description for free() states that: If ptr is a null pointer, no action occurs. This means that a standards-compilant compiler is entirely at

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread David Chisnall
On 9 Oct 2012, at 17:33, Andrey Chernov wrote: Do you check assembler output for _both_ cases? In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'. IMHO this change should be backed out for srandomdev() and

Re: svn commit: r241931 - in head/sys: conf kern

2012-10-23 Thread David Chisnall
On 23 Oct 2012, at 16:05, Andre Oppermann wrote: For zero copy send we're trying to come up with a sendfile-like approach where the page is simply wired into kernel space. The application then is not allowed to touch it until the socket buffer has released it again. The main issue here is

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread David Chisnall
On 28 May 2012, at 20:33, Dimitry Andric wrote: On the other hand, it's really platform-dependent: I've checked several Linux distributions, and it is fairly unpredictable whether their gcc passes --hash-style to the linker, or if they do, which option they use. Can we make it dependent on

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-30 Thread David Chisnall
On 30 May 2012, at 09:01, Marius Strobl wrote: Ehm, yes, but given that this wouldn't be the first such flag we have is avoiding it really worth the link time and run time overheads in the long term? Given the small overhead of the extra hashes, yes. At some point in the future, we can

Re: svn commit: r236456 - in head/sys: amd64/include i386/include

2012-06-04 Thread David Chisnall
On 4 Jun 2012, at 11:00, Tijl Coosemans wrote: On 02-06-2012 20:10, Konstantin Belousov wrote: Author: kib Date: Sat Jun 2 18:10:16 2012 New Revision: 236456 URL: http://svn.freebsd.org/changeset/base/236456 Log: Use plain store for atomic_store_rel on x86, instead of implicitly

svn commit: r236889 - head/lib/libc/locale

2012-06-11 Thread David Chisnall
Author: theraven Date: Mon Jun 11 14:02:02 2012 New Revision: 236889 URL: http://svn.freebsd.org/changeset/base/236889 Log: Fix a leak when setting the global character locale to C from something else. Reported by: mm Modified: head/lib/libc/locale/setrunelocale.c Modified:

svn commit: r236890 - in head: gnu/lib/libsupc++ lib/libcxxrt

2012-06-11 Thread David Chisnall
Author: theraven Date: Mon Jun 11 15:40:57 2012 New Revision: 236890 URL: http://svn.freebsd.org/changeset/base/236890 Log: Clean up some symbol versions for libsupc++ / libcxxrt. MFC after:1 week Reviewed by: kan Modified: head/gnu/lib/libsupc++/Version.map

Re: svn commit: r237434 - in head/lib/libc: amd64/sys gen i386/sys include sys

2012-06-22 Thread David Chisnall
On 22 Jun 2012, at 08:34, Marius Strobl wrote: I don't know much about x86 CPUs but is my understanding correct that TSCs are not synchronized in any way across CPUs, i.e. reading it on different CPUs may result in time going backwards etc., which is okay for this application though? As long

Re: svn commit: r238118 - head/lib/libc/gen

2012-07-04 Thread David Chisnall
On 4 Jul 2012, at 21:32, Andrey Chernov wrote: 1) /dev/urandom may not exist in jails/sandboxes while sysctls (or old way initialization) always exists. From the perspective of Capsicum sandboxes, a device node is better than a sysctl. The kernel must hard-code policy about which sysctls

svn commit: r238182 - head/lib/libc/locale

2012-07-06 Thread David Chisnall
Author: theraven Date: Fri Jul 6 20:16:22 2012 New Revision: 238182 URL: http://svn.freebsd.org/changeset/base/238182 Log: Restore the __collate_load_error global that was accidentally removed in the xlocale refactoring. MFC after:1 week Modified: head/lib/libc/locale/collate.c

svn commit: r227467 - head/share/monetdef

2011-11-12 Thread David Chisnall
Author: theraven Date: Sat Nov 12 14:39:20 2011 New Revision: 227467 URL: http://svn.freebsd.org/changeset/base/227467 Log: Fix the number of decimal digits used for Swiss Francs (0 - 2). Found by the libc++ test suite. If there is some locale test suite somewhere, it might be worth running

svn commit: r227472 - head/lib/msun/src

2011-11-12 Thread David Chisnall
Author: theraven Date: Sat Nov 12 19:55:48 2011 New Revision: 227472 URL: http://svn.freebsd.org/changeset/base/227472 Log: Expose the unimplemented libm functions in the math.h header. This allows C++'s cmath to work without the compiler complaining that the C++ versions are calling

svn commit: r227474 - head/sys/amd64/include

2011-11-12 Thread David Chisnall
Author: theraven Date: Sat Nov 12 20:16:06 2011 New Revision: 227474 URL: http://svn.freebsd.org/changeset/base/227474 Log: Fix SIGATOMIC_M{IN,AX} on x86-64. These are meant to be the minimum values that are allowed in a sig_atomic_t, but it looks like they were just copied from the x86

svn commit: r227476 - head/include

2011-11-12 Thread David Chisnall
Author: theraven Date: Sat Nov 12 20:45:10 2011 New Revision: 227476 URL: http://svn.freebsd.org/changeset/base/227476 Log: Don't expose the wctype.h macros in C++ mode. They cause problems when people try to invoke the namespaced versions of the functions of the same names. Approved

svn commit: r227487 - head/include

2011-11-13 Thread David Chisnall
Author: theraven Date: Sun Nov 13 16:18:48 2011 New Revision: 227487 URL: http://svn.freebsd.org/changeset/base/227487 Log: The spec says that FILE must be defined in wchar.h, but it wasn't. It is now. Also hide some macros in C++ mode that will break C++ namespaced calls. Approved

svn commit: r227490 - head/include

2011-11-13 Thread David Chisnall
Author: theraven Date: Sun Nov 13 17:07:26 2011 New Revision: 227490 URL: http://svn.freebsd.org/changeset/base/227490 Log: Hide some more macros that will break C++ when compiling in C++ mode. Approved by: dim (mentor) Modified: head/include/ctype.h Modified: head/include/ctype.h

Re: svn commit: r227467 - head/share/monetdef

2011-11-13 Thread David Chisnall
, though. Thanks, Erik Den 12/11/2011 kl. 15.39 skrev David Chisnall: Author: theraven Date: Sat Nov 12 14:39:20 2011 New Revision: 227467 URL: http://svn.freebsd.org/changeset/base/227467 Log: Fix the number of decimal digits used for Swiss Francs (0 - 2). Found by the libc++ test

Re: svn commit: r227487 - head/include

2011-11-14 Thread David Chisnall
On 14 Nov 2011, at 18:02, David Schultz wrote: On Mon, Nov 14, 2011, Dimitry Andric wrote: On 2011-11-14 09:21, Stefan Farfeleder wrote: On Sun, Nov 13, 2011 at 04:18:48PM +, David Chisnall wrote: Author: theraven Date: Sun Nov 13 16:18:48 2011 New Revision: 227487 URL: http

Re: svn commit: r227536 - in head: release share/man/man7

2011-11-17 Thread David Chisnall
On 17 Nov 2011, at 14:31, Alexey Dokuchaev wrote: Kinda gross but FBSD-9.0-RELEASE-amd64-amd64-bootonly.iso? Can't we use one if they are equal? I'd prefer consistency. [...] But it looks so plain stupid! I've had someone ask me what amd64-amd64 meant when I pointed them as the RC

svn commit: r227818 - head/lib/libc/locale

2011-11-22 Thread David Chisnall
Author: theraven Date: Tue Nov 22 14:11:42 2011 New Revision: 227818 URL: http://svn.freebsd.org/changeset/base/227818 Log: Fix a crash when trying to duplicate a locale that contains some implicit C locale components. Reported by: Michael Butler Approved by: dim (mentor) Modified:

Re: svn commit: r227812 - head/lib/libc/string

2011-11-22 Thread David Chisnall
On 22 Nov 2011, at 11:21, Bruce Evans wrote: If this optimization were any good, then the compiler would already do it. In fact, gcc-4.2.1 already does it -- the reverse of it -- it rewrites: if ((i == 0) | (j == 0)) return; test(); into: if (i == 0 || j == 0) return;

Re: svn commit: r227812 - head/lib/libc/string

2011-11-23 Thread David Chisnall
On 22 Nov 2011, at 20:27, David Schultz wrote: Benchmark or not, I think you'll have a very hard time finding a single real program that routinely calls strcasecmp() with identical pointers! I've seen this pattern very often. Often the linker is able to combine constant strings defined in

svn commit: r227983 - in head: . contrib/libc++ contrib/libc++/include contrib/libc++/include/ext contrib/libc++/src contrib/libc++/src/support contrib/libcxxrt etc/mtree lib lib/libc++ lib/libcxxr...

2011-11-25 Thread David Chisnall
Author: theraven Date: Fri Nov 25 20:59:04 2011 New Revision: 227983 URL: http://svn.freebsd.org/changeset/base/227983 Log: Import libc++ / libcxxrt into base. Not build by default yet (use MK_LIBCPLUSPLUS=yes to enable). This is a work-in-progress. It works for me, but is not guaranteed

svn commit: r227999 - head/lib/libc/gen

2011-11-26 Thread David Chisnall
Author: theraven Date: Sat Nov 26 15:57:09 2011 New Revision: 227999 URL: http://svn.freebsd.org/changeset/base/227999 Log: Return not-implemented from pthread_once and pthread_key_create, rather than silently failing and returning success. Without this, code calls pthread_once(),

svn commit: r228002 - head/lib/libc/gen

2011-11-26 Thread David Chisnall
Author: theraven Date: Sat Nov 26 16:49:25 2011 New Revision: 228002 URL: http://svn.freebsd.org/changeset/base/228002 Log: style(9) fix. Approved by: dim (mentor) Modified: head/lib/libc/gen/_pthread_stubs.c Modified: head/lib/libc/gen/_pthread_stubs.c

svn commit: r228004 - in head: contrib/libcxxrt lib/libcxxrt

2011-11-26 Thread David Chisnall
Author: theraven Date: Sat Nov 26 18:46:33 2011 New Revision: 228004 URL: http://svn.freebsd.org/changeset/base/228004 Log: Update libcxxrt to remove the pthread dependency. Also add the license from upstream to contrib. Approved by: dim (mentor) Added:

Re: svn commit: r228004 - in head: contrib/libcxxrt lib/libcxxrt

2011-11-27 Thread David Chisnall
On 27 Nov 2011, at 09:19, Bjoern A. Zeeb wrote: On Sat, 26 Nov 2011, David Schultz wrote: On Sat, Nov 26, 2011, Bjoern A. Zeeb wrote: On Sat, 26 Nov 2011, David Chisnall wrote: Author: theraven Date: Sat Nov 26 18:46:33 2011 New Revision: 228004 URL: http://svn.freebsd.org/changeset

Re: svn commit: r228114 - head/lib/libedit/edit/readline

2011-11-29 Thread David Chisnall
On 29 Nov 2011, at 04:50, Max Khon wrote: All this makes it possible to build and link gdb with -ledit. When I had a quick look a couple of days ago, kadmin and [k]gdb were the only things that linked against readline in base. With them now linking against libedit, can we remove readline

svn commit: r228322 - in head: include lib/libc/stdlib sys/sys

2011-12-07 Thread David Chisnall
file is newly added) +++ head/lib/libc/stdlib/at_quick_exit.3Wed Dec 7 15:25:48 2011 (r228322) @@ -0,0 +1,58 @@ +.\ Copyright (c) 2011 David Chisnall +.\ All rights reserved. +.\ +.\ Redistribution and use in source and binary forms, with or without +.\ modification

svn commit: r228323 - head/lib/libc/stdlib

2011-12-07 Thread David Chisnall
Author: theraven Date: Wed Dec 7 16:12:54 2011 New Revision: 228323 URL: http://svn.freebsd.org/changeset/base/228323 Log: style(9) cleanups. Approved by: brooks (mentor) Modified: head/lib/libc/stdlib/quick_exit.c Modified: head/lib/libc/stdlib/quick_exit.c

svn commit: r228329 - head/lib/libc/stdlib

2011-12-07 Thread David Chisnall
Author: theraven Date: Wed Dec 7 21:02:35 2011 New Revision: 228329 URL: http://svn.freebsd.org/changeset/base/228329 Log: Some fixes to the man pages for [at_]quick_exit(3) Reviewed by:pluknet Approved by:dim (mentor) Modified: head/lib/libc/stdlib/at_quick_exit.3

Re: svn commit: r228322 - in head: include lib/libc/stdlib sys/sys

2011-12-07 Thread David Chisnall
On 7 Dec 2011, at 19:11, David Schultz wrote: Why not use the standard spelling, '_Noreturn'? In pre-C1X modes, _Noreturn is a reserved identifier since it starts with an underscore and capital letter, so it's not considered namespace pollution. Because that would be too obvious... David

svn commit: r228330 - in head: include sys/sys

2011-12-07 Thread David Chisnall
Author: theraven Date: Wed Dec 7 21:17:50 2011 New Revision: 228330 URL: http://svn.freebsd.org/changeset/base/228330 Log: As per das@'s suggestion, s/__noreturn/_Noreturn/, since the latter is an identifier reserved for the implementation in C99 and earlier so there is no sensible reason

Re: svn commit: r228330 - in head: include sys/sys

2011-12-12 Thread David Chisnall
On 11 Dec 2011, at 21:12, Andreas Tobler wrote: As far as I understand, GCC does not support this attribute [[noreturn]] yet. But it defines both, __cplusplus and __cplusplus=201103L. On gcc-4.7 __cplusplus=201103L is the default when we build libstdc++. Advertising C++11 compatibility and

svn commit: r228528 - head/lib/libc/stdlib

2011-12-15 Thread David Chisnall
Author: theraven Date: Thu Dec 15 11:16:41 2011 New Revision: 228528 URL: http://svn.freebsd.org/changeset/base/228528 Log: Small style(9) improvements. Approved by: dim (mentor) Modified: head/lib/libc/stdlib/quick_exit.c Modified: head/lib/libc/stdlib/quick_exit.c

svn commit: r228529 - head/sys/sys

2011-12-15 Thread David Chisnall
Author: theraven Date: Thu Dec 15 11:21:56 2011 New Revision: 228529 URL: http://svn.freebsd.org/changeset/base/228529 Log: Add a pointless and superfluous GNUism that people at a certain large data aggregation and advertising company seem to believe is standard. Approved by: dim

Re: svn commit: r228143 - in head: . share/mk tools/build/options

2011-12-19 Thread David Chisnall
On 19 Dec 2011, at 19:52, Warner Losh wrote: -1. The needs of the many? Please. Let's break a useful feature because some people don't understand it and are impatient? That's lame. How useful is gprof-based profiling these days? Now that we have the DTrace pid provider, don't we have

svn commit: r228859 - head/sys/sys

2011-12-24 Thread David Chisnall
Author: theraven Date: Sat Dec 24 13:28:49 2011 New Revision: 228859 URL: http://svn.freebsd.org/changeset/base/228859 Log: Some GCC-compatibility definitions. Define clang's feature test pseudomacros to always evaluate to 0 if we are using a compiler that doesn't implement them. This

svn commit: r228862 - head/include

2011-12-24 Thread David Chisnall
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/include/stdatomic.hSat Dec 24 15:17:01 2011(r228862) @@ -0,0 +1,296 @@ +/*- + * Copyright (c) 2011 Ed Schouten e...@freebsd.org + *David Chisnall thera...@freebsd.org + * All

svn commit: r228863 - head/include

2011-12-24 Thread David Chisnall
Author: theraven Date: Sat Dec 24 15:31:06 2011 New Revision: 228863 URL: http://svn.freebsd.org/changeset/base/228863 Log: ...and actually install it. Approved by: dim (mentor) Modified: head/include/Makefile Modified: head/include/Makefile

svn commit: r228875 - head/include

2011-12-25 Thread David Chisnall
Author: theraven Date: Sun Dec 25 16:03:54 2011 New Revision: 228875 URL: http://svn.freebsd.org/changeset/base/228875 Log: Restore __is_threaded in C++ mode. Some Google stuff needs it apparently. Reported by: swills Approved by: dim (mentor) Modified: head/include/stdio.h

svn commit: r228918 - head/sys/sys

2011-12-27 Thread David Chisnall
Author: theraven Date: Tue Dec 27 21:36:31 2011 New Revision: 228918 URL: http://svn.freebsd.org/changeset/base/228918 Log: Define NULL to nullptr in C++11 mode (not strictly required, but it makes migrating code to C++11 easier). Approved by: dim (mentor) Modified:

Re: svn commit: r228878 - head/include

2011-12-30 Thread David Chisnall
On 30 Dec 2011, at 16:52, Sean C. Farley wrote: My quick googling didn't show anything at all about the C++ standard and stdbool.h or __bool_true_false_are_defined. It was probably originally set because bool, true, and false are all C++ keywords so certain code that wanted to ifdef on

svn commit: r233235 - in head: contrib/libcxxrt lib/libcxxrt

2012-03-20 Thread David Chisnall
Author: theraven Date: Tue Mar 20 17:58:15 2012 New Revision: 233235 URL: http://svn.freebsd.org/changeset/base/233235 Log: Import new version of libcxxrt. Now works correctly with libobjc2 to implement the unified exception model for Objective-C++. Approved by: dim (mentor) Deleted:

svn commit: r233391 - head/contrib/libstdc++/libsupc++

2012-03-23 Thread David Chisnall
Author: theraven Date: Fri Mar 23 20:10:56 2012 New Revision: 233391 URL: http://svn.freebsd.org/changeset/base/233391 Log: Revert ABI breakage in libsupc++. Unfortunately, the ABI was broken upstream for the 4.2 release, which we imported. We then shipped the broken version for several

svn commit: r233600 - head/include

2012-03-28 Thread David Chisnall
Author: theraven Date: Wed Mar 28 12:11:54 2012 New Revision: 233600 URL: http://svn.freebsd.org/changeset/base/233600 Log: Correctly expose xlocale functions if people include the headers in the wrong order (as some ports apparently do). Approved by: dim (mentor) Modified:

Re: svn commit: r233294 - in head: . contrib/com_err crypto/heimdal crypto/heimdal/admin crypto/heimdal/appl crypto/heimdal/appl/afsutil crypto/heimdal/appl/ftp crypto/heimdal/appl/ftp/common crypto/h

2012-03-29 Thread David Chisnall
On 29 Mar 2012, at 04:36, Doug Barton wrote: All of the stuff that pkgng relies on (including the tool itself) are going to be in the ports collection, where they belong. We should have moved pkg_* there years ago, but this change is at least a step in the right direction. Wait... what? Why

svn commit: r233699 - head/contrib/libstdc++/libsupc++

2012-03-30 Thread David Chisnall
Author: theraven Date: Fri Mar 30 12:48:36 2012 New Revision: 233699 URL: http://svn.freebsd.org/changeset/base/233699 Log: Undo the earlier revert of the ABI change in libsupc++. On further discussion, posting an errata notice with 9.1 is the less painful solution. Approved by: dim

svn commit: r233749 - in head/gnu/lib: libstdc++ libsupc++

2012-03-31 Thread David Chisnall
Author: theraven Date: Sat Mar 31 14:25:12 2012 New Revision: 233749 URL: http://svn.freebsd.org/changeset/base/233749 Log: Make libsupc++ build as a shared library and make libstdc++ a filter library for it. This allows people to swap out libsupc++ for libcxxrt easily, so we can begin

svn commit: r233757 - head/sys/sys

2012-04-01 Thread David Chisnall
Author: theraven Date: Sun Apr 1 09:35:23 2012 New Revision: 233757 URL: http://svn.freebsd.org/changeset/base/233757 Log: Bump __FreeBSD_version for xlocale cleanup, as requested by ports people. Approved by: dim (mentor) Modified: head/sys/sys/param.h Modified: head/sys/sys/param.h

Re: svn commit: r233749 - in head/gnu/lib: libstdc++ libsupc++

2012-04-02 Thread David Chisnall
On 2 Apr 2012, at 02:03, Alexander Kabaev wrote: there are reports of this commit breaking complex C++ binaries such as build as part of KDE4. This is being looked at. Do you have any more information about what is broken? (Run-time failures, linker failures?)

Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-04-07 Thread David Chisnall
On 7 Apr 2012, at 18:10, David Schultz wrote: The biggest hinderance to using extern inline is that gcc and C99 disagree about what it means, unless you use a reasonably recent compiler in C99 mode. I first tried to use extern inline in the tree several years after I backported gcc's C99

svn commit: r234573 - head/include/xlocale

2012-04-22 Thread David Chisnall
Author: theraven Date: Sun Apr 22 16:58:14 2012 New Revision: 234573 URL: http://svn.freebsd.org/changeset/base/234573 Log: Fix a bug caused by some misplaced brackets. Reported by: das Modified: head/include/xlocale/_ctype.h Modified: head/include/xlocale/_ctype.h

svn commit: r234578 - head/lib/libc/locale

2012-04-22 Thread David Chisnall
Author: theraven Date: Sun Apr 22 18:51:38 2012 New Revision: 234578 URL: http://svn.freebsd.org/changeset/base/234578 Log: Fix some incorrect symbol versions. Reported by: das Modified: head/lib/libc/locale/Symbol.map Modified: head/lib/libc/locale/Symbol.map

svn commit: r234732 - head/usr.sbin/wpa/hostapd

2012-04-27 Thread David Chisnall
Author: theraven Date: Fri Apr 27 15:35:09 2012 New Revision: 234732 URL: http://svn.freebsd.org/changeset/base/234732 Log: Add a note to hostapd.conf about an unhelpful error message in the hope that it won't confuse anyone else in the future. MFC after:1 week Modified:

svn commit: r234958 - head/include

2012-05-03 Thread David Chisnall
Author: theraven Date: Thu May 3 15:54:06 2012 New Revision: 234958 URL: http://svn.freebsd.org/changeset/base/234958 Log: Fix stdatomic.h after clang decided to rename all of its builtins to include a c11 prefix to disambiguate them from the one provided by GCC. Note: Clang 3.1 also

svn commit: r234976 - in head/contrib/libc++: include src

2012-05-03 Thread David Chisnall
Author: theraven Date: Thu May 3 17:44:07 2012 New Revision: 234976 URL: http://svn.freebsd.org/changeset/base/234976 Log: Import new version of libc++. Among other improvements, this comes with an atomic header that works with clang 3.1 (and, importantly, the pre-3.1 snapshot currently

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread David Chisnall
On 11 May 2012, at 08:48, Konstantin Belousov wrote: On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: Author: gabor Date: Fri May 11 12:37:16 2012 New Revision: 235267 URL: http://svn.freebsd.org/changeset/base/235267 +bool byte_sort = false; + +static wchar_t **wmonths =

svn commit: r236148 - head/lib/msun/src

2012-05-27 Thread David Chisnall
Author: theraven Date: Sun May 27 12:54:41 2012 New Revision: 236148 URL: http://svn.freebsd.org/changeset/base/236148 Log: Allow inclusion of libc++ cmath to work after including math.h Submitted by: Yamaya Takashi Reviewed by: das MFC after:1 week Modified:

svn commit: r236177 - head/gnu/lib/libsupc++

2012-05-28 Thread David Chisnall
Author: theraven Date: Mon May 28 12:11:00 2012 New Revision: 236177 URL: http://svn.freebsd.org/changeset/base/236177 Log: Correctly export operator new / delete for things linking against libsupc++ but not libstdc++. Unfortunately, it appears that libsupc++ / libstdc++ have a

svn commit: r230225 - head/include

2012-01-16 Thread David Chisnall
Author: theraven Date: Mon Jan 16 18:19:53 2012 New Revision: 230225 URL: http://svn.freebsd.org/changeset/base/230225 Log: Use the signal fence builtin in stdatomic.h when using the clang atomic builtins, rather than the __asm hack. Somehow I missed the existence of this builtin

svn commit: r230267 - head/include

2012-01-17 Thread David Chisnall
Author: theraven Date: Tue Jan 17 15:20:41 2012 New Revision: 230267 URL: http://svn.freebsd.org/changeset/base/230267 Log: Fix clang atomic to use for atomic_is_lock_free(). Reviewed by: ed Approved by: dim (mentor) Modified: head/include/stdatomic.h Modified:

Re: svn commit: r230201 - head/lib/libc/gen

2012-01-19 Thread David Chisnall
On 19 Jan 2012, at 18:09, Ed Schouten wrote: In the very nearby future (after I switch SPARC64 and MIPS to libcompiler_rt), it should be possible to safely use C11's stdatomic.h on all supported architectures. The C11 interface allows any operation to be combined with any type of barrier.

Re: svn commit: r230201 - head/lib/libc/gen

2012-01-20 Thread David Chisnall
On 20 Jan 2012, at 00:46, David Xu wrote: It depends on hardware, if it is a large machine with lots of cpu, a small conflict on dual-core machine can become a large conflict on large machine because it is possible more cpus are now running same code which becomes a bottleneck. On a large

Re: svn commit: r227753 - in head: contrib/gdtoa include lib/libc/gdtoa lib/libc/gen lib/libc/locale lib/libc/regex lib/libc/stdio lib/libc/stdlib lib/libc/stdtime lib/libc/string

2012-01-30 Thread David Chisnall
On 18 Jan 2012, at 19:07, David Schultz wrote: This patch appears to cause a large performance regression. For example, I measured a 78% slowdown for strtol(42, ...). That's definitely worth taking a closer look at. I think we can cache some things in TLS and avoid some

svn commit: r231673 - in head: etc/mtree include include/xlocale lib/libc/locale sys/sys

2012-02-14 Thread David Chisnall
) +++ head/include/xlocale.h Tue Feb 14 12:03:23 2012(r231673) @@ -1,5 +1,5 @@ /*- - * Copyright (c) 2011 The FreeBSD Foundation + * Copyright (c) 2011, 2012 The FreeBSD Foundation * All rights reserved. * * This software was developed by David Chisnall under sponsorship from @@ -8,16

svn commit: r231682 - in head: include lib/libc/locale

2012-02-14 Thread David Chisnall
Author: theraven Date: Tue Feb 14 14:24:37 2012 New Revision: 231682 URL: http://svn.freebsd.org/changeset/base/231682 Log: Fix a misplaced __NO_TLS locations, and change a GNUism to a C11ism for consistency. Approved by: brooks (mentor) Modified: head/include/runetype.h

Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-03-02 Thread David Chisnall
On 2 Mar 2012, at 12:53, Konstantin Belousov wrote: This part of the change breaks KBI. I suggest that for merge to stable/9 you would leave the bread and breadn as functions. Can we not do this for the general case? Provide them as inline extern functions in the header, and implement them

svn commit: r232498 - in head: etc/mtree include include/xlocale lib/libc/locale sys/sys

2012-03-04 Thread David Chisnall
reserved. * * This software was developed by David Chisnall under sponsorship from @@ -8,16 +8,16 @@ * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: - * 1. Redistributions of source code must

svn commit: r232601 - in head/lib/libc: locale regex

2012-03-06 Thread David Chisnall
of this software were developed by David Chisnall * under sponsorship from the FreeBSD Foundation. * - * Copyright (c) 2011 The FreeBSD Foundation - * All rights reserved. - * Portions of this software were developed by David Chisnall - * under sponsorship from the FreeBSD Foundation

Re: svn commit: r232570 - head/sys/boot/i386/boot2

2012-03-08 Thread David Chisnall
On 8 Mar 2012, at 16:05, John Baldwin wrote: On Wednesday, March 07, 2012 5:00:19 pm Jung-uk Kim wrote: On Monday 05 March 2012 02:53 pm, John Baldwin wrote: Author: jhb Date: Mon Mar 5 19:53:17 2012 New Revision: 232570 URL: http://svn.freebsd.org/changeset/base/232570 Log: Fix boot2

svn commit: r232926 - in head: include/xlocale lib/libc/locale

2012-03-13 Thread David Chisnall
Author: theraven Date: Tue Mar 13 14:14:13 2012 New Revision: 232926 URL: http://svn.freebsd.org/changeset/base/232926 Log: More xlocale cleanups. Approved by: dim (mentor) Modified: head/include/xlocale/_ctype.h head/lib/libc/locale/Symbol.map Modified:

svn commit: r232927 - head/include/xlocale

2012-03-13 Thread David Chisnall
Author: theraven Date: Tue Mar 13 15:21:14 2012 New Revision: 232927 URL: http://svn.freebsd.org/changeset/base/232927 Log: Add missing prototypes. Approved by: dim (mentor) Modified: head/include/xlocale/_ctype.h Modified: head/include/xlocale/_ctype.h

svn commit: r232929 - head/include/xlocale

2012-03-13 Thread David Chisnall
Author: theraven Date: Tue Mar 13 17:32:55 2012 New Revision: 232929 URL: http://svn.freebsd.org/changeset/base/232929 Log: Fix the other missing prototypes. Approved by: dim (mentor) Modified: head/include/xlocale/_ctype.h Modified: head/include/xlocale/_ctype.h

svn commit: r232931 - head/include/xlocale

2012-03-13 Thread David Chisnall
Author: theraven Date: Tue Mar 13 18:53:28 2012 New Revision: 232931 URL: http://svn.freebsd.org/changeset/base/232931 Log: And remove the duplicate inlines... Approved by: dim (mentor) Modified: head/include/xlocale/_ctype.h Modified: head/include/xlocale/_ctype.h

svn commit: r232971 - head/include

2012-03-14 Thread David Chisnall
Author: theraven Date: Wed Mar 14 14:39:07 2012 New Revision: 232971 URL: http://svn.freebsd.org/changeset/base/232971 Log: Expose some C11 stuff that is also C++11 stuff in C++11 mode. Approved by: dim (mentor) Modified: head/include/stdlib.h Modified: head/include/stdlib.h

svn commit: r232972 - in head/contrib/libc++: include src

2012-03-14 Thread David Chisnall
Author: theraven Date: Wed Mar 14 14:40:22 2012 New Revision: 232972 URL: http://svn.freebsd.org/changeset/base/232972 Log: Import a slightly newer libc++, with some bugs fixed that were found by running the test suite on FreeBSD. Approved by: dim (mentor) Modified:

svn commit: r233173 - head/lib/libc/locale

2012-03-19 Thread David Chisnall
Author: theraven Date: Mon Mar 19 11:47:37 2012 New Revision: 233173 URL: http://svn.freebsd.org/changeset/base/233173 Log: Make __get_locale() static inline, not just inline, so when compiling libc in debug mode (without optimisations) it doesn't generate a linker failure. Approved by:

svn commit: r233174 - head/lib/libcxxrt

2012-03-19 Thread David Chisnall
Author: theraven Date: Mon Mar 19 11:53:33 2012 New Revision: 233174 URL: http://svn.freebsd.org/changeset/base/233174 Log: Add symbol versioning to libcxxrt. Approved by: dim (mentor) Added: head/lib/libcxxrt/Version.map (contents, props changed) Modified:

Re: svn commit: r250245 - head/lib/libc/locale

2013-05-05 Thread David Chisnall
On 5 May 2013, at 19:31, Andrey Chernov a...@freebsd.org wrote: It is better to fix this function return type to match POSIX standard rather than to document its non-standard behavior. We try to follow POSIX when possible and this is the case. We follow Darwin in this case, which returns 0 on

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread David Chisnall
On 10 May 2013, at 10:01, Eitan Adler ead...@freebsd.org wrote: I thought style(9) disliked the leading (void) but I could be wrong. The cast to (void) tells the compiler that you are ignoring the return result. Without it, you will introduce new warnings and break the build on certain

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread David Chisnall
On 10 May 2013, at 10:12, Eitan Adler ead...@freebsd.org wrote: I don't remember any recent tool which uses that cast to remove errors. clang -Wunused-result gcc -Wunused-result David ___ svn-src-head@freebsd.org mailing list

Re: svn commit: r250986 - head/sys/dev/usb

2013-05-26 Thread David Chisnall
On 26 May 2013, at 03:45, Bruce Evans b...@optusnet.com.au wrote: Hmm, it would be useful to have a compiler flag for initializing all local variables to trap representations on entry to functions. The clang memory sanitizer does this. David ___

svn commit: r251820 - head/gnu/lib/libsupc++

2013-06-16 Thread David Chisnall
Author: theraven Date: Sun Jun 16 21:15:35 2013 New Revision: 251820 URL: http://svnweb.freebsd.org/changeset/base/251820 Log: Fix some missing symbols in the libsupc++ Version.map MFC after:1 week Modified: head/gnu/lib/libsupc++/Version.map Modified:

svn commit: r251856 - head/usr.bin/dtc

2013-06-17 Thread David Chisnall
Author: theraven Date: Mon Jun 17 15:34:22 2013 New Revision: 251856 URL: http://svnweb.freebsd.org/changeset/base/251856 Log: Add a checker to dtc, based on a feature request from rwatson / brooks. This checks that every node that has children specifies their register sizes. This is not

svn commit: r251934 - head/usr.bin/dtc

2013-06-18 Thread David Chisnall
Author: theraven Date: Tue Jun 18 10:26:22 2013 New Revision: 251934 URL: http://svnweb.freebsd.org/changeset/base/251934 Log: Fix bug in destructor for checker manager in DTC that caused segfaults on exit. Modified: head/usr.bin/dtc/checking.cc Modified: head/usr.bin/dtc/checking.cc

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-19 Thread David Chisnall
On 19 Jun 2013, at 16:13, John Baldwin j...@freebsd.org wrote: portsnap does not work for src. (I thought we had already covered that in earlier threads?) portsnap only moves forward. It is a very important feature for our users that whatever tool they use for source updating be

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-20 Thread David Chisnall
On 20 Jun 2013, at 00:10, Warner Losh i...@bsdimp.com wrote: - FreeBSD developers, who are probably okay with installing a port, but would prefer a version that didn't depend on kitchen/sink? - Users, who wish to be able to update the source tree and then either build world, or build some

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-20 Thread David Chisnall
On 20 Jun 2013, at 14:09, Julian Elischer jul...@freebsd.org wrote: Which of the classes of user that I outlined do you think wants to be able to do that? As a FreeBSD user, I never felt the desire to do that, but maybe I was unusual. As a FreeBSD developer, I don't mind installing the svn

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-20 Thread David Chisnall
On 20 Jun 2013, at 20:34, Warner Losh i...@bsdimp.com wrote: People trying new versions of FreeBSD. Some of them install the release, others might install a snapshot, some will do an install world. But if it worked in release 9.3 and broke in 9.4, then to find where they would need to

Re: svn commit: r261283 - in head: contrib/libc++ contrib/libc++/include contrib/libc++/include/experimental contrib/libc++/include/ext contrib/libc++/src etc/mtree lib/libc++ sys/sys tools/build/mk

2014-02-03 Thread David Chisnall
On 3 Feb 2014, at 18:32, Alexander Kabaev kab...@gmail.com wrote: More than likely. It does appear libc++ does not go through same pains to maintain ABI stable as libstdc++ does. The lack of all and any symbol versions in shared library binary strongly suggests that not only they do not

Re: svn commit: r261283 - in head: contrib/libc++ contrib/libc++/include contrib/libc++/include/experimental contrib/libc++/include/ext contrib/libc++/src etc/mtree lib/libc++ sys/sys tools/build/mk

2014-02-04 Thread David Chisnall
On 3 Feb 2014, at 22:00, Alexander Kabaev kab...@gmail.com wrote: At the very least, new library did remove _ZNKSt3__111__libcpp_db12__comparableEPKvS2_ which was public before. This symbol is part of the debugging infrastructure and is used when you build your code with aggressive debug

Re: svn commit: r261801 - head/contrib/libc++/include

2014-02-12 Thread David Chisnall
On 12 Feb 2014, at 18:42, Jung-uk Kim j...@freebsd.org wrote: It seems Apple removed it later. http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131125/094181.html Do you know what they did? They decided to break ABI compatibility with the version of XCode that ships with the

Re: svn commit: r261801 - head/contrib/libc++/include

2014-02-13 Thread David Chisnall
On 13 Feb 2014, at 01:04, Alexander Kabaev kab...@gmail.com wrote: The refusal to use tools that are there precisely to help to help with the binary compatibility in favor of mindless library bumps is just sad. Perhaps you could share with the class. What is the correct way of solving this

Re: svn commit: r261916 - head/sys/dev/xen/console

2014-02-15 Thread David Chisnall
On 15 Feb 2014, at 17:02, Bruce Evans b...@optusnet.com.au wrote: Why? There are hundreds if not thousands of static inline functions in headers, and most of these functions are not always used, so there would be [hundreds if not thousands] * [number of #includes] compiler warnings if

Re: svn commit: r261916 - head/sys/dev/xen/console

2014-02-16 Thread David Chisnall
On 16 Feb 2014, at 04:09, Bruce Evans b...@optusnet.com.au wrote: [a long list of corner cases where the warning may not be correct] Fortunately, the goal of compiler warnings is not to address every possible case, but rather to minimise false positives while still giving useful results. The

svn commit: r262394 - head/usr.bin/dtc

2014-02-23 Thread David Chisnall
Author: theraven Date: Sun Feb 23 21:13:07 2014 New Revision: 262394 URL: http://svnweb.freebsd.org/changeset/base/262394 Log: Fix parsing multiple roots with whitespace between them. Patch by: Patrick Wildt Modified: head/usr.bin/dtc/fdt.cc Modified: head/usr.bin/dtc/fdt.cc

Re: svn commit: r262282 - in head: contrib/dma contrib/dma/debian contrib/dma/debian/migrate contrib/dma/debian/source contrib/dma/test etc/mtree libexec libexec/dma share/mk tools/build/mk tools/buil

2014-02-25 Thread David Chisnall
On 25 Feb 2014, at 07:52, Baptiste Daroussin b...@freebsd.org wrote: On Tue, Feb 25, 2014 at 05:22:22PM +1100, Peter Jeremy wrote: On 2014-Feb-22 13:14:38 +0100, Baptiste Daroussin b...@freebsd.org wrote: On Sat, Feb 22, 2014 at 07:23:50PM +1100, Peter Jeremy wrote: I'd also query the reason

  1   2   3   >