Re: [swift-dev] Testing, validation, and many-core machines

2018-01-17 Thread Michael Gottesman via swift-dev
> On Jan 17, 2018, at 8:23 AM, David Zarzycki via swift-dev > wrote: > > Hello, > > In docs/Testing.md, “long test” is acknowledged but never defined. When > should tests be marked “long_test”? I’m asking because there are arguably a > number of latent long_test tests

Re: [swift-dev] JIRA down

2018-01-08 Thread Michael Gottesman via swift-dev
K Sent from my iPhone > On Jan 8, 2018, at 7:57 AM, Mishal Shah wrote: > > bugs.swift.org is back online. > > Please also email swift-infrastruct...@swift.org in the future. > > Thanks, > Mishal Shah > >> On Jan 7, 2018, at 4:35 PM, Michael Gottesman

[swift-dev] JIRA down

2018-01-08 Thread Michael Gottesman via swift-dev
The JIRA looks like it is down... Michael ___ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2018-01-02 Thread Michael Gottesman via swift-dev
> On Jan 2, 2018, at 7:00 PM, Joe Groff <jgr...@apple.com> wrote: > > > >> On Dec 30, 2017, at 11:23 AM, Michael Gottesman via swift-dev >> <swift-dev@swift.org> wrote: >> >> No. A parameter's convention is ABI. You don't want to change ABI

Re: [swift-dev] Weird dyn_cast code gen / performance problem

2018-01-01 Thread Michael Gottesman via swift-dev
I posted a quick comment there + the llvm ir. It seems like something that could be a simple SimplifyInstructions transformation. Michael > On Jan 1, 2018, at 6:37 PM, David Zarzycki wrote: > > > >> On Jan 1, 2018, at 18:20, John McCall wrote: >> >>> >>>

Re: [swift-dev] Weird dyn_cast code gen / performance problem

2018-01-01 Thread Michael Gottesman via swift-dev
Do you have the llvm-ir handy? > On Jan 1, 2018, at 11:30 AM, David Zarzycki via swift-dev > wrote: > > Hello, > > I noticed recently that the code gen of > CanType::getClassOrBoundGenericClass() could be better and along the way I > found a clang/LLVM bug. Where

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2017-12-31 Thread Michael Gottesman via swift-dev
Felix, on a completely different note. Do you think you could contribute these workloads to the swift benchmark suite. Then we can track it over time. Michael > On Dec 30, 2017, at 10:03 PM, Michael Gottesman via swift-dev > <swift-dev@swift.org> wrote: > > > >>

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2017-12-30 Thread Michael Gottesman via swift-dev
> On Dec 30, 2017, at 9:41 PM, Félix Cloutier wrote: > > >> Le 30 déc. 2017 à 14:22, Michael Gottesman a écrit : >>> That sounds fun. I'll have to check with my manager after the holidays. >> >> Nerd snipe success? = p > > I guess so? 邏 I'm

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2017-12-30 Thread Michael Gottesman via swift-dev
> On Dec 30, 2017, at 1:21 PM, Félix Cloutier wrote: > > >> Le 29 déc. 2017 à 20:50, Michael Gottesman a écrit : >> >> No worries. Happy to help = ). If you are interested, I would be happy to >> help guide you in implementing one of these

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2017-12-29 Thread Michael Gottesman via swift-dev
> On Dec 29, 2017, at 4:58 PM, Félix Cloutier wrote: > > Thanks Michael! Other people might have different opinions, but knowing that > a "definitive" fix is on the way is plenty for me and I'm not looking to make > a fuss. No worries. Happy to help = ). If you are

Re: [swift-dev] "available externally" vs build time

2017-12-29 Thread Michael Gottesman via swift-dev
> On Dec 28, 2017, at 7:32 PM, Chris Lattner via swift-dev > wrote: > > Folks working on the SIL optimizer, particularly those interested in faster > builds: > > If I understand the SIL optimizer correctly, it seems that when the current > program references an

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2017-12-29 Thread Michael Gottesman via swift-dev
> On Dec 28, 2017, at 4:27 PM, Chris Lattner via swift-dev > wrote: > > > > This is a great question, I’m not sure what the answer is: maybe it is a > simple case missed by the arc optimizer? It is a bit more complicated than that. There are codegen aspects and

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

2017-12-29 Thread Michael Gottesman via swift-dev
(FYI I am already writing a longer response, but got interrupted by visiting with my mother ; )). Give me a bit. > On Dec 29, 2017, at 2:03 PM, Robert Widmann wrote: > > Ran into this over the summer. My understanding is that Michael Gottesman > (CC’d) has been

Re: [swift-dev] Protocol Devirtualizer Pass

2017-12-21 Thread Michael Gottesman via swift-dev
Is it possible to merge them? > On Dec 21, 2017, at 11:07 AM, Raj Barik via swift-dev > wrote: > > Hi, > > Thanks. > > > Are you implementing it as a separate pass, or is it part of function > signature specialization? > > > I am currently implementing this as a

Re: [swift-dev] Request for review on Windows CMake changes

2017-12-11 Thread Michael Gottesman via swift-dev
I'll take a look sometime later in the week. If I forget, ping me next Friday. > On Dec 8, 2017, at 5:36 PM, Thomas Roughton via swift-dev > wrote: > > Hi all, > > I've had a PR (https://github.com/apple/swift/pull/13140) that's been open > for about 10 days with a few

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #710

2017-12-01 Thread Michael Gottesman via swift-dev
I wonder if we could emit this during the cmake configure phase. Then this will never happen. > On Dec 1, 2017, at 3:27 AM, Arnold via swift-dev wrote: > > > Oh Rintaro is tryin to fix this issue: > > https://github.com/apple/swift/pull/13203 > > Sent from my iPhone >

Re: [swift-dev] Building a swift release

2017-11-16 Thread Michael Gottesman via swift-dev
> On Nov 16, 2017, at 7:09 AM, Alex Blewitt via swift-dev > wrote: > >> On 16 Nov 2017, at 14:30, Geordie J via swift-dev > > wrote: >> >> Hello, >> >> I recently asked about building a particular Swift release and

Re: [swift-dev] Building a swift release

2017-11-16 Thread Michael Gottesman via swift-dev
> On Nov 16, 2017, at 7:09 AM, Alex Blewitt via swift-dev > wrote: > >> On 16 Nov 2017, at 14:30, Geordie J via swift-dev > > wrote: >> >> Hello, >> >> I recently asked about building a particular Swift release and

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-20 Thread Michael Gottesman via swift-dev
Before you guys decide anything, I would wait for Steve Canon to look at this. +CC Steve Michael > On Oct 20, 2017, at 10:21 AM, Xiaodi Wu via swift-dev > wrote: > > > On Fri, Oct 20, 2017 at 10:10 Matthew Johnson

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #1174

2017-10-17 Thread Michael Gottesman via swift-dev
Is this still an issue? This Foundation test failure is blocking PR testing! This needs to be fixed ASAP or XFAILED. Can you guys fix this now please. Michael > On Oct 17, 2017, at 2:24 PM, Ankit Aggarwal via swift-dev > wrote: > > Test Case

Re: [swift-dev] Reducing array abstraction

2017-10-08 Thread Michael Gottesman via swift-dev
> On Oct 8, 2017, at 11:57 AM, Michael Gottesman via swift-dev > <swift-dev@swift.org> wrote: > >> >> On Oct 6, 2017, at 11:06 PM, Chris Lattner via swift-dev >> <swift-dev@swift.org> wrote: >> >> This question is somewhere between swift-d

Re: [swift-dev] Reducing array abstraction

2017-10-08 Thread Michael Gottesman via swift-dev
> On Oct 6, 2017, at 11:06 PM, Chris Lattner via swift-dev > wrote: > > This question is somewhere between swift-dev and swift-users, not sure where > best to post this. > > I’m working on a project that wants to get very low-abstraction penalty array > operations,

Re: [swift-dev] Exclusivity checker hacking?

2017-10-05 Thread Michael Gottesman via swift-dev
> On Oct 5, 2017, at 1:42 PM, David Zarzycki via swift-dev > wrote: > > Hello, > > As an experiment, I’d like to force the exclusivity checking logic to always > error at compile time, rather than a mix of compile time and run time. Near > as I can tell, there is no

Re: [swift-dev] New to building Swift toolchain

2017-09-26 Thread Michael Gottesman via swift-dev
d then I had vacation = (. > > Michael > >> On Sep 20, 2017, at 10:05 PM, Michael Gottesman via swift-dev >> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >> >> FYI, I haven't forgotten you! I just need to land some code tonight ; ). I >

Re: [swift-dev] New to building Swift toolchain

2017-09-26 Thread Michael Gottesman via swift-dev
Ok. I am looking at this now on my side machine. Sorry for the delay, I had to land code and then I had vacation = (. Michael > On Sep 20, 2017, at 10:05 PM, Michael Gottesman via swift-dev > <swift-dev@swift.org> wrote: > > FYI, I haven't forgotten you! I just need to land

Re: [swift-dev] New to building Swift toolchain

2017-09-20 Thread Michael Gottesman via swift-dev
FYI, I haven't forgotten you! I just need to land some code tonight ; ). I want to try to reproduce exactly what you are doing. Michael > On Sep 20, 2017, at 6:08 AM, Maksym Grebenets wrote: > > I tried few more options. > > I tried switching my shell to bash and giving

Re: [swift-dev] New to building Swift toolchain

2017-09-19 Thread Michael Gottesman via swift-dev
The reason why I know it wasn't clean is that you didn't rebuild LLVM. > On Sep 19, 2017, at 5:11 PM, Maksym Grebenets wrote: > > Hm. But this one was pretty much a clean build. I’ve made sure I removed all > build directories before running it. > > Is there a flag to

Re: [swift-dev] New to building Swift toolchain

2017-09-19 Thread Michael Gottesman via swift-dev
Can you do a new clean build and post the log? > On Sep 19, 2017, at 4:11 PM, Maksym Grebenets wrote: > > Sure, I've put it in a gist here: > https://gist.github.com/mgrebenets/9f50bc07615002cfe6ebb3a9f74cb3de >

Re: [swift-dev] libdispatch switched to CMake

2017-09-18 Thread Michael Gottesman via swift-dev
> On Sep 18, 2017, at 3:28 PM, Saleem Abdulrasool wrote: > > Hello swift-dev, > > This change should be transparent to everyone, but, it still is a pretty big > milestone. > > As of this afternoon, the non-Darwin builds use CMake to build libdispatch. > This work has

Re: [swift-dev] New to building Swift toolchain

2017-09-18 Thread Michael Gottesman via swift-dev
> On Sep 18, 2017, at 8:54 AM, Maksym Grebenets via swift-dev > wrote: > > Hi all > > I guess like many other iOS devs with c/c++ background I really wanted to get > into Swift development one day, at least a tiny bit, at least to understand > how things work. > > So

Re: [swift-dev] [Swift CI] Build Still Failing: OSS - Swift Package - OS X (master) #178

2017-08-31 Thread Michael Gottesman via swift-dev
I don't think it is that. What is actually happening here is that I enabled the ownership verifier on a bunch of SILGen tests. This causes some syntactic changes (i.e. SILArugments must now specify an ownership convention textually. Looks like I missed a spot. I am on it! Michael > On Aug 31,

Re: [swift-dev] Foundation Data Behavior Different (read: crashes) in Swift 3.1 and Swift 3.2

2017-08-24 Thread Michael Gottesman via swift-dev
> On Aug 24, 2017, at 10:47 AM, Ryan Lovelett via swift-dev > wrote: > > I've found what I believe is a bug. Though I'm unclear if the bug is in > Swift 3.1 or Swift 3.2/4.0. All I can say for sure is the behavior is > quite drastically different between the two. > > For

Re: [swift-dev] Is swift.org/contributing/ stale?

2017-08-14 Thread Michael Gottesman via swift-dev
> On Aug 14, 2017, at 10:32 AM, David Zarzycki via swift-dev > wrote: > > Hi Slava, > > Ah. So “GitHub collaborator” status doesn’t imply commit access then? I think that only means that you have a commit in the repository, nothing more. But my memory might be wrong. >

Re: [swift-dev] Debugging on Xcode

2017-08-11 Thread Michael Gottesman via swift-dev
Add to debugging the compiler? Sent from my iPhone > On Aug 11, 2017, at 11:38 AM, Robert Widmann via swift-dev > wrote: > > Full disclaimer: I haven’t looked into this bug, so I’m just going to > describe higher-level workflow tips. > >> On Aug 11, 2017, at 5:02 AM,

Re: [swift-dev] Debugging performance regressions?

2017-08-09 Thread Michael Gottesman via swift-dev
> On Aug 9, 2017, at 11:34 AM, Arnold Schwaighofer via swift-dev > wrote: > > Mark do you have suggestions for Dave? Also, whatever comes from this, can we document in updating the compiler. > >> On Aug 9, 2017, at 11:22 AM, David Zarzycki via swift-dev >>

Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

2017-08-09 Thread Michael Gottesman via swift-dev
I think there are docs on this in the main README or in a CONTRIBUTING file. Mishal (+CC) knows for sure. Michael > On Aug 9, 2017, at 5:41 AM, David Zarzycki via swift-dev > wrote: > > Hi Slava, > > Thanks! I appreciate the suggestion to run tests, but what I’ve tried

Re: [swift-dev] Faster debug builds?

2017-08-06 Thread Michael Gottesman via swift-dev
> On Aug 6, 2017, at 11:11 AM, David Zarzycki via swift-dev > wrote: > > Hello, > > Unless I’m missing a build-script flag, it seems to me that compiling the > Swift stdlib with the unoptimized debug swift compiler takes about 15 minutes > on a fast machine. I am

[swift-dev] Enums with Many Cases/Covered Switches

2017-08-01 Thread Michael Gottesman via swift-dev
I was reading https://github.com/apple/swift/pull/11098 and it brought my mind back to a strawman discussion that Roman and I had some time ago. Namely, in some cases, we want the functionality of a covered switch, but it would be wasteful to write out all of the cases and fatal error due to

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-26 Thread Michael Gottesman via swift-dev
+1! > On Jul 26, 2017, at 8:29 AM, Erik Eckstein via swift-dev > wrote: > > As John said, this is out of scope for swift 4. > I think it’s find to just have it in master. > > Thanks again for your work! > >> On Jul 25, 2017, at 10:00 AM, John McCall via swift-dev >>

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-18 Thread Michael Gottesman via swift-dev
> On Jul 18, 2017, at 9:53 AM, Michael Gottesman via swift-dev > <swift-dev@swift.org> wrote: > >> >> On Jul 18, 2017, at 8:39 AM, Johannes Weiß <johanneswe...@apple.com> wrote: >> >> Hi Erik, >> >>> On 17 Jul 2017, at 10:26 pm, Eri

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-18 Thread Michael Gottesman via swift-dev
> On Jul 18, 2017, at 8:39 AM, Johannes Weiß wrote: > > Hi Erik, > >> On 17 Jul 2017, at 10:26 pm, Erik Eckstein wrote: >> >> Hi Johannes, >> >> great that you want to work on this! > > Thanks for your help, without Michael's and your help I

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-14 Thread Michael Gottesman via swift-dev
> On Jul 12, 2017, at 9:53 AM, Johannes Weiß wrote: > > Hi Michael, > > >> [...] >>> Long story short, I think the RLE actually works for the test case I >>> created. It's even clever enough to see through my invalid function bad() >>> which modified the storage

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-12 Thread Michael Gottesman via swift-dev
> On Jul 11, 2017, at 4:21 PM, Michael Gottesman via swift-dev > <swift-dev@swift.org> wrote: > >> >> On Jul 11, 2017, at 10:16 AM, Johannes Weiß <johanneswe...@apple.com >> <mailto:johanneswe...@apple.com>> wrote: >> >> Hi Michael,

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-11 Thread Michael Gottesman via swift-dev
> On Jul 11, 2017, at 10:16 AM, Johannes Weiß wrote: > > Hi Michael, > >> [...] >>> Now you advise to run the '-debug-only=sil-redundant-load-elim' so I tried >>> >>> sil-opt [...] -debug-only=sil-redundant-load-elim >>> >>> but it doesn't seem happy with that. Did I

[swift-dev] Enabling the ownership verifier on parts of the stdlib

2017-07-10 Thread Michael Gottesman via swift-dev
Hey everyone. Over the weekend I got stdlibCore (and some other parts of the stdlib as well) working with the ownership verifier. I am going to be enabling the verifier by default on stdlibCore sometime this afternoon. If you get hit by any verification issues as you are working, I am adding a

Re: [swift-dev] SR-5403 / Memory Optimization Opportunity (Load/Store forwarding)

2017-07-10 Thread Michael Gottesman via swift-dev
> On Jul 10, 2017, at 10:56 AM, Johannes Weiß wrote: > > Hi Michael, > > Firstly: if swift-dev is not the right place for me to ask silly questions, > please let me know :). > > Thanks very much for all your pointers on the JIRA [1] ticket. I was just > trying to

Re: [swift-dev] State of Semantic ARC?

2017-07-09 Thread Michael Gottesman via swift-dev
> On Jul 8, 2017, at 10:36 AM, Johannes Weiß via swift-dev > wrote: > > Hi swift-dev, > > I haven't heard anything about semantic ARC and couldn't really find much > documentation besides > https://gottesmm.github.io/proposals/high-level-arc-memory-operations.html . >

Re: [swift-dev] External pass pipeline YAML format

2017-06-29 Thread Michael Gottesman via swift-dev
> On Jun 29, 2017, at 12:50 PM, Vasileios Kalintiris wrote: > > I plan on writing a patch for this. Based on which branch should I create the > pull request? Is the swift-3.1-branch frozen? master. > > On Thu, Jun 29, 2017 at 7:27 PM, Michael Gottesman

Re: [swift-dev] External pass pipeline YAML format

2017-06-29 Thread Michael Gottesman via swift-dev
> On Jun 28, 2017, at 10:15 AM, Vasileios Kalintiris via swift-dev > wrote: > > > Have you seen `utils/pass-pipeline/scripts/pipelines_build_script.py`, it > > looks like it might give some hints? > > I've tried generating a pass pipeline with >

Re: [swift-dev] Pathway to becoming an effective contributor

2017-06-22 Thread Michael Gottesman via swift-dev
> On Jun 22, 2017, at 12:32 AM, Jacob Bandes-Storch via swift-dev > wrote: > > Hi, > I’ve thought about this issue in the past too, and would be happy to help > write some content or at least proofread / contribute tidbits to a guide for > new developers. > > As pointed

Re: [swift-dev] Pathway to becoming an effective contributor

2017-06-22 Thread Michael Gottesman via swift-dev
> On Jun 20, 2017, at 12:37 PM, Halen Wooten via swift-dev > wrote: > > Hi, > > I would like to start a discussion about getting started with the > Swift Compiler. The end goal is to see if there are ways we can help > newcomers to the compiler get started and more

Re: [swift-dev] statically initialized arrays

2017-06-14 Thread Michael Gottesman via swift-dev
> On Jun 14, 2017, at 11:24 AM, Erik Eckstein via swift-dev > wrote: > > Hi, > > I’m about implementing statically initialized arrays. It’s about allocating > storage for arrays in the data section rather than on the heap. > > Info: the array storage is a heap object.

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

2017-06-13 Thread Michael Gottesman via swift-dev
So I did a bit more research. Check out how LNT does this: https://github.com/llvm-mirror/lnt I talked with Chris Matthews (+CC) about how LNT uses Mann-Whitney. In the following let n be the number of samples taken. From

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

2017-06-12 Thread Michael Gottesman via swift-dev
> On Jun 12, 2017, at 4:45 PM, Pavol Vaskovic via swift-dev > wrote: > > Hi Andrew, > > On Mon, Jun 12, 2017 at 11:55 PM, Andrew Trick > wrote: >> To partially address this issue (I'm guessing) the last SPEEDUP column >>

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

2017-06-12 Thread Michael Gottesman via swift-dev
> On Jun 12, 2017, at 4:54 PM, Pavol Vaskovic wrote: > > > > On Mon, Jun 12, 2017 at 11:55 PM, Michael Gottesman > wrote: > > The current design assumes that in such cases, the workload will be increased > so that is not an

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

2017-06-12 Thread Michael Gottesman via swift-dev
> On Jun 12, 2017, at 1:45 PM, Pavol Vaskovic via swift-dev > wrote: > > On Tue, May 16, 2017 at 9:10 PM, Dave Abrahams via swift-dev > > wrote: > > on Thu May 11 2017, Pavol Vaskovic wrote: > > I have run Benchmark_O

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Michael Gottesman via swift-dev
> On Apr 26, 2017, at 1:44 PM, John McCall <rjmcc...@apple.com> wrote: > >> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev >> <swift-dev@swift.org> wrote: >> Hey everyone. >> >> I am currently doing some small fixes to SILSuccessor

[swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Michael Gottesman via swift-dev
Hey everyone. I am currently doing some small fixes to SILSuccessor (adding some comments and fixing some issues exposed by LLVM upstream). As I read the code it became pretty apparent that the name is a misnomer... SILSuccessor is not just representing a successor, rather it is representing a

Re: [swift-dev] Emitted SIL does not parse

2017-04-06 Thread Michael Gottesman via swift-dev
> On Apr 6, 2017, at 5:07 PM, Ben Ng wrote: > > It doesn’t look like it: > > swift (LLVM option parsing): Unknown command line argument > '-assume-parsing-unqualified-ownership-sil'. Try: 'swift (LLVM option > parsing) -help' I misunderstood what you said before (I thought

Re: [swift-dev] Using gyb with benchmarks

2017-04-06 Thread Michael Gottesman via swift-dev
> On Apr 6, 2017, at 1:14 PM, Pavol Vaskovic wrote: > > On Thursday, 6 April 2017 at 19:44, Michael Gottesman wrote: >>> On Apr 6, 2017, at 6:16 AM, Pavol Vaskovic via swift-dev >>> wrote: >>> >>> ... >>> How do I make

Re: [swift-dev] Using gyb with benchmarks

2017-04-06 Thread Michael Gottesman via swift-dev
> On Apr 6, 2017, at 6:16 AM, Pavol Vaskovic via swift-dev > wrote: > > Hi! > > I’ve been trying to use gyb to simplify maintenance of some tests in > benchmark/single-source/. > > I have created DropLast.swift.gyb, but it appears this approach is currently > not

Re: [swift-dev] Emitted SIL does not parse

2017-04-04 Thread Michael Gottesman via swift-dev
I think it is an -Xllvm option. > On Apr 4, 2017, at 7:41 PM, Ben Ng wrote: > > Do you mean like: > > $ swiftc -O moof.sil -o moof -Xfrontend > -assume-parsing-unqualified-ownership-sil > > It seems like the `-assume-parsing-unqualified-ownership-sil` argument isn’t >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #1708

2017-03-26 Thread Michael Gottesman via swift-dev
The swiftpm test succeeded the next time. Michael > On Mar 26, 2017, at 7:50 PM, Michael Gottesman via swift-dev > <swift-dev@swift.org> wrote: > > I am taking a look at this. > > Michael > >> On Mar 26, 2017, at 4:00 PM, no-re...@swift.org <

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #1708

2017-03-26 Thread Michael Gottesman via swift-dev
I am taking a look at this. Michael > On Mar 26, 2017, at 4:00 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#1708] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/1708/ >

Re: [swift-dev] Running benchmark in release mode

2017-03-26 Thread Michael Gottesman via swift-dev
> On Mar 25, 2017, at 5:03 AM, Pavol Vaskovic via swift-dev > wrote: > > Hi, > > I’m trying to run the benchmarks for swift-source on my machine. > >> ./swift/utils/build-script --benchmark > > works, but takes ages. So I was trying to run the benchmark in release

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #212

2017-03-19 Thread Michael Gottesman via swift-dev
> On Mar 19, 2017, at 4:59 PM, Greg Parker wrote: > > Michael, one of your changes broke all three ASAN bots. Please fix or revert > ASAP. > > (Could this be related to https://github.com/apple/swift/pull/8169 > ? I didn't confirm

Re: [swift-dev] Profiling ARC

2017-02-20 Thread Michael Gottesman via swift-dev
> On Feb 20, 2017, at 6:31 PM, Jiho Choi wrote: > > I used the older versions (binary-trees #6 & binary-trees #7) which I > downloaded a couple of weeks ago. It seems like they updated binary-trees > benchmarks since then. > > I just profiled the one you linked and got a

Re: [swift-dev] Profiling ARC

2017-02-20 Thread Michael Gottesman via swift-dev
Are you talking about this one (there are two)? http://benchmarksgame.alioth.debian.org/u64q/program.php?test=binarytrees=swift=1 Michael > On Feb 20, 2017, at 2:24 PM, Jiho Choi via swift-dev

Re: [swift-dev] Profiling ARC

2017-02-17 Thread Michael Gottesman via swift-dev
I am familiar with it, just not all of the benchmarks by name. > On Feb 17, 2017, at 3:04 PM, David P Grove wrote: > > Sorry, I shouldn't have assumed that everyone know what the Computer Language > Benchmark Game was. > > There's a set of 10 toy benchmarks written in 30

Re: [swift-dev] Profiling ARC

2017-02-17 Thread Michael Gottesman via swift-dev
> On Feb 17, 2017, at 11:30 AM, David P Grove via swift-dev > wrote: > > swift-dev-boun...@swift.org wrote on 02/16/2017 09:48:28 PM: > > > > I was curious about the overhead of ARC and started profiling some > > benchmarks found in the Computer Language Benchmark Game

Re: [swift-dev] master fails to build

2017-02-13 Thread Michael Gottesman via swift-dev
via swift-dev >>> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >>> >>> I'm not. Is this the part where you tell me I should be? >>> >>> >>> On Feb 12, 2017, 11:53 PM -0500, Michael Gottesman via swift-dev >>> <

Re: [swift-dev] master fails to build

2017-02-12 Thread Michael Gottesman via swift-dev
Just a stab in the dark, but are you using the latest beta SDK? Michael > On Feb 11, 2017, at 5:03 PM, Ben Ng via swift-dev wrote: > > Hi Greg, > > Thanks for the tip. It fails in a different way now: > > FAILED:

Re: [swift-dev] No return functions and program exit

2017-02-07 Thread Michael Gottesman via swift-dev
> On Feb 7, 2017, at 11:56 AM, Andrew Trick <atr...@apple.com> wrote: > >> >> On Feb 6, 2017, at 12:19 PM, Michael Gottesman via swift-dev >> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >> >> >>>

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
eeded. The cleanup for x should be after bar always. > > Erik > >> On Feb 6, 2017, at 12:19 PM, Michael Gottesman via swift-dev >> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >> >>> >>> On Feb 6, 2017, at 11:44 AM, Jordan Ro

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 11:44 AM, Jordan Rose wrote: > > >> On Feb 6, 2017, at 11:25, Joe Groff via swift-dev > > wrote: >> >> >>> On Feb 6, 2017, at 11:22 AM, Michael Gottesman >>

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 10:04 AM, Joe Groff <jgr...@apple.com> wrote: > > >> On Feb 6, 2017, at 9:48 AM, Michael Gottesman via swift-dev >> <swift-dev@swift.org> wrote: >> >> One thing that is an issue that has come up with ownership is that at the

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 10:05 AM, Joe Groff wrote: > > >> On Feb 6, 2017, at 10:02 AM, Jordan Rose via swift-dev >> wrote: >> >> I’ve said this Michael in person, but I’ll put it on the thread for others >> to see: >> >> I don’t think modeling this is

[swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
One thing that is an issue that has come up with ownership is that at the SIL level we do not distinguish in between exceptional noreturn functions and exceptional return functions. This is important since in the non-exceptional case, we would like to clean up all of the values used in the

Re: [swift-dev] Performance issues in automatic reference counting (ARC)?

2017-01-31 Thread Michael Gottesman via swift-dev
al changes, I would like your endorsement before > starting serious work. Send a PR and lets talk about it. [i.e. what Roman said ; )] > > -- Mikio > > > 2016-12-18 5:49 GMT+09:00 Michael Gottesman via swift-dev > <swift-dev@swift.org <mailto:swift-dev@swift.org&g

Re: [swift-dev] Using git-clang-format in the Swift compiler code base.

2017-01-26 Thread Michael Gottesman via swift-dev
Can I make a more radical suggestion. Maybe the thing to do here is to enforce git-clang-format so that everyone uses it. It would be really simple to do. You would require people to put it in a pre commit hook. Then swift-ci would have a job that ran git-clang-format and would require it to

Re: [swift-dev] Including the requirement, but not the SILFunction in default witness tables

2016-12-18 Thread Michael Gottesman via swift-dev
Awesome! Michael > On Dec 18, 2016, at 12:26 AM, Slava Pestov wrote: > > That’s a good idea. Default witness tables are still not 100% done and need > some work. I’ll be sure to revisit the printing part too. > > Slava > >> On Dec 17, 2016, at 9:52 PM, Michael Gottesman

[swift-dev] Including the requirement, but not the SILFunction in default witness tables

2016-12-17 Thread Michael Gottesman via swift-dev
Hey Slava. I just noticed that when we print out the SIL for default witness tables: sil_default_witness_table _CVarArgAligned { no_default no_default } This really does not provide any information. Is it possible to include the requirement, but not the SILFunction. Then we could do this:

Re: [swift-dev] Performance issues in automatic reference counting (ARC)?

2016-12-17 Thread Michael Gottesman via swift-dev
> On Dec 17, 2016, at 11:13 AM, Brian Gesiak via swift-dev > wrote: > > Hello all! > > I really enjoyed Chris Lattner's slides from his talk at IBM >

Re: [swift-dev] Namespacing Compiler-Stdlib Interfaces

2016-12-16 Thread Michael Gottesman via swift-dev
One thing to be careful with here is that sometimes SIL test cases say that are the stdlib but only implement the functionality that they will use (taking advantage of how I believe currently these are checked lazily). If I am correct (which my memory may not be), we will need a flag to be less

Re: [swift-dev] Proposal: SILValue SSA Instructions

2016-12-09 Thread Michael Gottesman via swift-dev
;>>> <mailto:swift-dev@swift.org>> wrote: >>>>> On Dec 5, 2016, at 4:24 PM, Michael Gottesman via swift-dev >>>>> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >>>>> >>>>> Hello everyone! >>&g

Re: [swift-dev] proposed change for master-next merges

2016-12-08 Thread Michael Gottesman via swift-dev
> On Dec 8, 2016, at 7:43 AM, Saleem Abdulrasool via swift-dev > wrote: > > Having been involved in the update process for the next branches, I'm really > excited to see this type of change. > > I think that the "simple" approach is both better to work and collaborate in

Re: [swift-dev] Proposal: SILValue SSA Instructions

2016-12-07 Thread Michael Gottesman via swift-dev
2016, at 10:17 AM, Joe Groff via swift-dev <swift-dev@swift.org >>>>> <mailto:swift-dev@swift.org>> wrote: >>>>>> On Dec 5, 2016, at 4:24 PM, Michael Gottesman via swift-dev >>>>>> <swift-dev@swift.org <mailto:swift-d

[swift-dev] Proposal: SIL Ownership Model + Verifier

2016-12-07 Thread Michael Gottesman via swift-dev
This is a proposal for a new SIL Ownership Model and verifier. An online HTML version of the document is available here: https://gottesmm.github.io/proposals/sil-ownership-model.html and inline below. Michael # Summary

Re: [swift-dev] Proposal: SILValue SSA Instructions

2016-12-06 Thread Michael Gottesman via swift-dev
> On Dec 6, 2016, at 11:29 AM, John McCall <rjmcc...@apple.com> wrote: > >> On Dec 6, 2016, at 10:17 AM, Joe Groff via swift-dev <swift-dev@swift.org> >> wrote: >>> On Dec 5, 2016, at 4:24 PM, Michael Gottesman via swift-dev >>> <

[swift-dev] Proposal: SILValue SSA Instructions

2016-12-05 Thread Michael Gottesman via swift-dev
Hello everyone! This is a proposal for 2 instructions needed to express borrowing via SSA at the SIL level. The need for these were discovered while I was prototyping a SIL ownership verifier. A html version of the proposal:

Re: [swift-dev] Questions about ARC

2016-11-30 Thread Michael Gottesman via swift-dev
> On Nov 30, 2016, at 6:25 PM, Jiho Choi via swift-dev > wrote: > > Thanks for clarifications. I have a couple of follow-up questions. > > 1. Could you please provide more information (e.g. source code location) > about the optimization

Re: [swift-dev] High-level SIL Optimization: How do I get a FuncRef from the stdlib?

2016-11-27 Thread Michael Gottesman via swift-dev
+CC Slava. He has been messing around with this area in the past bit since many of us have looked at this. He is the person you want. Michael > On Nov 25, 2016, at 8:42 PM, Ben Ng wrote: > > Hi everyone, > > I’ve made good progress with the information in this thread but I

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #519

2016-11-16 Thread Michael Gottesman via swift-dev
SGTM! Thanks! > On Nov 16, 2016, at 12:02 PM, ankit_aggar...@apple.com wrote: > > I figured this was a 16.10 issue because PR bot (16.04) passed, however I > wasn't able to reproduce this locally after installing 16.10, I pushed a > commit to pin point the failure line but that integration

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #519

2016-11-16 Thread Michael Gottesman via swift-dev
Question. How did this get through PR testing? Sent from my iPhone > On Nov 16, 2016, at 6:01 AM, Ankit Aggarwal via swift-dev > wrote: > > This is mine, checking. > >> On 16-Nov-2016, at 6:12 PM, no-re...@swift.org wrote: >> >> [FAILURE]

Re: [swift-dev] High-level SIL Optimization: How do I get a FuncRef from the stdlib?

2016-11-15 Thread Michael Gottesman via swift-dev
> On Nov 15, 2016, at 9:02 PM, Ben Ng wrote: > > Hi Michael, > > No, I did not. I don't see swift-dev in the cc line of your email... this > might be an issue with the Inbox for iOS client that I'm using. Ok! This happens sometimes (hit reply instead of reply-all or the

Re: [swift-dev] Casting shadow protocols

2016-11-08 Thread Michael Gottesman via swift-dev
> On Nov 7, 2016, at 11:23 AM, Alexis via swift-dev wrote: > > >> On Nov 4, 2016, at 11:55 PM, Dave Abrahams via swift-dev >> > wrote: >> >> >> on Fri Nov 04 2016, Slava Pestov > > wrote:

Re: [swift-dev] Performance degradation with 3.0.1(String comparison)

2016-11-06 Thread Michael Gottesman via swift-dev
> On Nov 3, 2016, at 11:07 PM, Pushkar N Kulkarni via swift-dev > wrote: > > Hello, > > A colleague of mine who's doing performance testing with some server-side > Swift frameworks like Kitura, Perfect and Zewo found a 15-20% degradation > with a simple "Hello World"

Re: [swift-dev] Stack dump of the compiler?

2016-10-28 Thread Michael Gottesman via swift-dev
Are you talking about the prettyprint stack dump? I think that may have gone away after the recent update to the newer llvm/clang. I think there is a bug to look into what happened here, but no one has had the time to look into it. Michael > On Oct 26, 2016, at 8:53 PM, rintaro ishizaki via

Re: [swift-dev] Purpose of validation-test/Reflection/reflect_*.swift

2016-10-26 Thread Michael Gottesman via swift-dev
> On Oct 26, 2016, at 5:29 PM, Alexis via swift-dev wrote: > > I’m not clear on what the reflection tests are attempting to actually verify. > Just that we don’t change the internal layout of these types accidentally? > We’re churning up the layouts of a lot of the

Re: [swift-dev] PRs not triggering with @swift-ci

2016-10-21 Thread Michael Gottesman via swift-dev
online, I see that the news reports are saying that the issue >> has been resolved. >> >> Mishal/Doug, do you have any insight into this? >> >>> >>> On 21 Oct 2016, at 12:12, Michael Gottesman via swift-dev wrote: >>> >>>> I have bee

  1   2   >